From: "Michal Koutný" <mkoutny@suse.com>
To: cgel.zte@gmail.com
Cc: tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zealci@zte.com.cn, deng.changcheng@zte.com.cn
Subject: Re: [PATCH v2] block: Use div64_ul instead of do_div
Date: Thu, 2 Dec 2021 17:50:20 +0100 [thread overview]
Message-ID: <20211202165020.GC16798@blackbody.suse.cz> (raw)
In-Reply-To: <20211118034033.163550-1-deng.changcheng@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hello.
On Thu, Nov 18, 2021 at 03:40:33AM +0000, cgel.zte@gmail.com wrote:
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Just feedback to the bot or to you -- the same do_div() is in the same
function for writes too. I think the processing shouldn't stop at the
first occurence.
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: cgel.zte-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
zealci-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org,
deng.changcheng-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org
Subject: Re: [PATCH v2] block: Use div64_ul instead of do_div
Date: Thu, 2 Dec 2021 17:50:20 +0100 [thread overview]
Message-ID: <20211202165020.GC16798@blackbody.suse.cz> (raw)
In-Reply-To: <20211118034033.163550-1-deng.changcheng-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
Hello.
On Thu, Nov 18, 2021 at 03:40:33AM +0000, cgel.zte-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> Reported-by: Zeal Robot <zealci-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org>
> Signed-off-by: Changcheng Deng <deng.changcheng-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org>
Just feedback to the bot or to you -- the same do_div() is in the same
function for writes too. I think the processing shouldn't stop at the
first occurence.
Michal
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-12-02 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 1:03 [PATCH] block: Use div64_ul instead of do_div cgel.zte
2021-11-18 3:40 ` [PATCH v2] " cgel.zte
2021-11-18 3:40 ` cgel.zte-Re5JQEeQqe8AvxtiuMwx3w
2021-11-29 18:19 ` Tejun Heo
2021-11-29 18:19 ` Tejun Heo
2021-12-02 16:50 ` Michal Koutný [this message]
2021-12-02 16:50 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202165020.GC16798@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=axboe@kernel.dk \
--cc=cgel.zte@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=deng.changcheng@zte.com.cn \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.