* [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools
@ 2021-12-02 16:06 mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 01/11] multipathd.service: add dependency on systemd-udevd-kernel.socket mwilck
` (12 more replies)
0 siblings, 13 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
Hi Christophe, hi Ben,
here are some last-minute fixes that I'd like to have added to
the currently pending multipath-tools update. None of them touches
any real functionality, except the first one, which I already sent
earlier today. Patch 3,4,5 were already included in my github PR
(which I'm going to rebase to match this submission). Patch 2 supersedes
"multipath-tools: generate abi without version script" from the first
version of the Github PR. The rest is new, tidy-up work for
libmultipath.version.
Regards
Martin
Martin Wilck (11):
multipathd.service: add dependency on systemd-udevd-kernel.socket
multipath-tools: generate abi with dummy version script
multipath-tools: github abi workflow: don't fail on reference branch
multipath-tools: github workflows: rebuild containers for rolling
distros
multipath tools: github workflows: add coverity workflow
multipath-tools: .mailmap: add some more entries
libmultipath: make orphan_paths() static
libmultipath: make update_pathvec_from_dm() static
libmultipath: remove recv_packet_from_client()
libmultipath.version: drop some unused symbols
libmultipath.version: sort symbols
.github/workflows/abi.yaml | 2 +-
.github/workflows/coverity.yaml | 51 +++++++++++++++++
.github/workflows/native.yaml | 62 +++++++++++++++++++-
.mailmap | 7 +++
Makefile.inc | 1 +
libdmmp/Makefile | 2 +-
libmpathcmd/Makefile | 13 ++++-
libmpathpersist/Makefile | 15 ++++-
libmpathvalid/Makefile | 16 +++++-
libmultipath/Makefile | 13 ++++-
libmultipath/libmultipath.version | 95 ++++++++++---------------------
libmultipath/structs_vec.c | 4 +-
libmultipath/structs_vec.h | 4 --
libmultipath/uxsock.c | 5 --
libmultipath/uxsock.h | 6 --
multipathd/multipathd.service | 2 +
16 files changed, 203 insertions(+), 95 deletions(-)
create mode 100644 .github/workflows/coverity.yaml
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 01/11] multipathd.service: add dependency on systemd-udevd-kernel.socket
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 02/11] multipath-tools: generate abi with dummy version script mwilck
` (11 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
Since f42d918 ("multipathd: Remove dependency on
systemd-udev-settle.service"), multipathd has no dependencies on
udev any more. In reality, multipathd depends quite heavily on udev.
multipathd startup succeeds indeed if udevd isn't running. Connecting to the
udev monitor netlink socket works, too, and if udevd is started later on,
multipathd will receive events over this socket. multipathd doesn't connect to
the udev control socket, but it does attempt to trigger uevents using
sysfs. For these events to be processed, the udev kernel socket must be
listening. For that, it's sufficient to depend on systemd-udevd-kernel.socket,
which will start udevd on demand if it isn't running.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
multipathd/multipathd.service | 2 ++
1 file changed, 2 insertions(+)
diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
index 87cb534..1919b38 100644
--- a/multipathd/multipathd.service
+++ b/multipathd/multipathd.service
@@ -2,6 +2,8 @@
Description=Device-Mapper Multipath Device Controller
Before=iscsi.service iscsid.service lvm2-activation-early.service
Before=local-fs-pre.target blk-availability.service shutdown.target
+Wants=systemd-udevd-kernel.socket
+After=systemd-udevd-kernel.socket
After=multipathd.socket systemd-remount-fs.service
DefaultDependencies=no
Conflicts=shutdown.target
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 02/11] multipath-tools: generate abi with dummy version script
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 01/11] multipathd.service: add dependency on systemd-udevd-kernel.socket mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 02/11] multipath-tools: generate abi without " mwilck
` (10 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
The purpose of the "abi" makefile target is to detect ABI changes. If using
the version script the way we do (bumping major or minor versions), abigail
detects a completely different ABI with every bump. This makes it very
difficult to figure out actual changes in the code.
This patch fixes that by using "versionless version scripts" for ABI
generation. These version scripts just list all exported symbols, using
just a single dummy version string. This is better than using no version
script at all, because only exported symbols will be compared, whereas
without a version script we'd be comparing non-exported symbols, too.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
Makefile.inc | 1 +
libdmmp/Makefile | 2 +-
libmpathcmd/Makefile | 13 +++++++++++--
libmpathpersist/Makefile | 15 ++++++++++++---
libmpathvalid/Makefile | 16 +++++++++++++---
libmultipath/Makefile | 13 +++++++++++--
6 files changed, 49 insertions(+), 11 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index 17071ef..b340f2a 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -79,6 +79,7 @@ GZIP = gzip -9 -c
RM = rm -f
LN = ln -sf
INSTALL_PROGRAM = install
+NV_VERSION_SCRIPT = $(VERSION_SCRIPT:%.version=%-nv.version)
# $(call TEST_CC_OPTION,option,fallback)
# Test if the C compiler supports the option.
diff --git a/libdmmp/Makefile b/libdmmp/Makefile
index c91f0c3..de61668 100644
--- a/libdmmp/Makefile
+++ b/libdmmp/Makefile
@@ -58,7 +58,7 @@ uninstall:
$(RM) $(DESTDIR)$(pkgconfdir)/$(PKGFILE)
clean: dep_clean
- $(RM) core *.a *.o *.gz *.so *.so.* *.abi
+ $(RM) core *.a *.o *.gz *.so *.so.* *.abi $(NV_VERSION_SCRIPT)
$(RM) docs/man/*.gz
$(MAKE) -C test clean
diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile
index 5a7a6e9..72cab1e 100644
--- a/libmpathcmd/Makefile
+++ b/libmpathcmd/Makefile
@@ -15,7 +15,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
-Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
$(DEVLIB): $(LIBS)
$(LN) $(LIBS) $@
@@ -33,7 +42,7 @@ uninstall:
$(RM) $(DESTDIR)$(includedir)/mpath_cmd.h
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
index d76918f..1e6399d 100644
--- a/libmpathpersist/Makefile
+++ b/libmpathpersist/Makefile
@@ -3,7 +3,7 @@ include ../Makefile.inc
SONAME = 0
DEVLIB = libmpathpersist.so
LIBS = $(DEVLIB).$(SONAME)
-VERSION_SCRIPT := libmpathpersist.version
+VERSION_SCRIPT:= libmpathpersist.version
CFLAGS += $(LIB_CFLAGS) -I$(multipathdir) -I$(mpathpersistdir) -I$(mpathcmddir)
LDFLAGS += -L$(multipathdir) -L$(mpathcmddir)
@@ -18,7 +18,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
-Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
$(DEVLIB): $(LIBS)
$(LN) $(LIBS) $@
@@ -46,7 +55,7 @@ uninstall:
$(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
diff --git a/libmpathvalid/Makefile b/libmpathvalid/Makefile
index b579535..dce2610 100644
--- a/libmpathvalid/Makefile
+++ b/libmpathvalid/Makefile
@@ -15,10 +15,20 @@ OBJS = mpath_valid.o
all: $(LIBS)
$(LIBS): $(OBJS) $(VERSION_SCRIPT)
- $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) -Wl,--version-script=libmpathvalid.version
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) \
+ -Wl,--version-script=$(VERSION_SCRIPT)
$(LN) $(LIBS) $(DEVLIB)
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
install: $(LIBS)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(syslibdir)
@@ -33,7 +43,7 @@ uninstall:
$(RM) $(DESTDIR)$(includedir)/mpath_valid.h
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index e8fd749..d4af1a5 100644
--- a/libmultipath/Makefile
+++ b/libmultipath/Makefile
@@ -81,7 +81,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(DEVLIB): $(LIBS)
$(LN) $(LIBS) $@
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
../tests/$(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=`basename $@` \
@@ -101,7 +110,7 @@ uninstall:
$(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 02/11] multipath-tools: generate abi without version script
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 01/11] multipathd.service: add dependency on systemd-udevd-kernel.socket mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 02/11] multipath-tools: generate abi with dummy version script mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 17:51 ` Benjamin Marzinski
2021-12-02 16:06 ` [dm-devel] [PATCH 03/11] multipath-tools: github abi workflow: don't fail on reference branch mwilck
` (9 subsequent siblings)
12 siblings, 1 reply; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
The purpose of the "abi" makefile target is to detect ABI changes. If using
the version script the way we do (bumping major or minor versions), abigail
detects a completely different ABI with every bump. This makes it very
difficult to figure out actual changes in the code.
This patch fixes that by using "versionless version scripts" for ABI
generation. These version scripts just list all exported symbols, using
just a single dummy version string. This is better than using no version
script at all, because only exported symbols will be compared, whereas
without a version script we'd be comparing non-exported symbols, too.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
Makefile.inc | 1 +
libdmmp/Makefile | 2 +-
libmpathcmd/Makefile | 13 +++++++++++--
libmpathpersist/Makefile | 15 ++++++++++++---
libmpathvalid/Makefile | 16 +++++++++++++---
libmultipath/Makefile | 13 +++++++++++--
6 files changed, 49 insertions(+), 11 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index 17071ef..b340f2a 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -79,6 +79,7 @@ GZIP = gzip -9 -c
RM = rm -f
LN = ln -sf
INSTALL_PROGRAM = install
+NV_VERSION_SCRIPT = $(VERSION_SCRIPT:%.version=%-nv.version)
# $(call TEST_CC_OPTION,option,fallback)
# Test if the C compiler supports the option.
diff --git a/libdmmp/Makefile b/libdmmp/Makefile
index c91f0c3..de61668 100644
--- a/libdmmp/Makefile
+++ b/libdmmp/Makefile
@@ -58,7 +58,7 @@ uninstall:
$(RM) $(DESTDIR)$(pkgconfdir)/$(PKGFILE)
clean: dep_clean
- $(RM) core *.a *.o *.gz *.so *.so.* *.abi
+ $(RM) core *.a *.o *.gz *.so *.so.* *.abi $(NV_VERSION_SCRIPT)
$(RM) docs/man/*.gz
$(MAKE) -C test clean
diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile
index 5a7a6e9..72cab1e 100644
--- a/libmpathcmd/Makefile
+++ b/libmpathcmd/Makefile
@@ -15,7 +15,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
-Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
$(DEVLIB): $(LIBS)
$(LN) $(LIBS) $@
@@ -33,7 +42,7 @@ uninstall:
$(RM) $(DESTDIR)$(includedir)/mpath_cmd.h
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
index d76918f..1e6399d 100644
--- a/libmpathpersist/Makefile
+++ b/libmpathpersist/Makefile
@@ -3,7 +3,7 @@ include ../Makefile.inc
SONAME = 0
DEVLIB = libmpathpersist.so
LIBS = $(DEVLIB).$(SONAME)
-VERSION_SCRIPT := libmpathpersist.version
+VERSION_SCRIPT:= libmpathpersist.version
CFLAGS += $(LIB_CFLAGS) -I$(multipathdir) -I$(mpathpersistdir) -I$(mpathcmddir)
LDFLAGS += -L$(multipathdir) -L$(mpathcmddir)
@@ -18,7 +18,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
-Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
$(DEVLIB): $(LIBS)
$(LN) $(LIBS) $@
@@ -46,7 +55,7 @@ uninstall:
$(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
diff --git a/libmpathvalid/Makefile b/libmpathvalid/Makefile
index b579535..dce2610 100644
--- a/libmpathvalid/Makefile
+++ b/libmpathvalid/Makefile
@@ -15,10 +15,20 @@ OBJS = mpath_valid.o
all: $(LIBS)
$(LIBS): $(OBJS) $(VERSION_SCRIPT)
- $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) -Wl,--version-script=libmpathvalid.version
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) \
+ -Wl,--version-script=$(VERSION_SCRIPT)
$(LN) $(LIBS) $(DEVLIB)
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
install: $(LIBS)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(syslibdir)
@@ -33,7 +43,7 @@ uninstall:
$(RM) $(DESTDIR)$(includedir)/mpath_valid.h
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index e8fd749..d4af1a5 100644
--- a/libmultipath/Makefile
+++ b/libmultipath/Makefile
@@ -81,7 +81,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(DEVLIB): $(LIBS)
$(LN) $(LIBS) $@
-abi: $(LIBS:%.so.0=%.abi)
+$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
+ @printf 'NOVERSION {\nglobal:\n' >$@
+ @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
+ @printf 'local:\n\t*;\n};\n' >>$@
+
+$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
+ $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
+ -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
+
+abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
../tests/$(LIBS): $(OBJS) $(VERSION_SCRIPT)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=`basename $@` \
@@ -101,7 +110,7 @@ uninstall:
$(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
clean: dep_clean
- $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h
+ $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h $(NV_VERSION_SCRIPT)
include $(wildcard $(OBJS:.o=.d))
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 03/11] multipath-tools: github abi workflow: don't fail on reference branch
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (2 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 02/11] multipath-tools: generate abi without " mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 04/11] multipath-tools: github workflows: rebuild containers for rolling distros mwilck
` (8 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
The download action will always retreive the result of the
last successful workflow on the reference branch. If the
workflow has failed there (because of a difference to the
previous workflow), the results won't be used. Thus don't
fail on the reference branch, even if there are differences.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
.github/workflows/abi.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/abi.yaml b/.github/workflows/abi.yaml
index 53f10d4..0a40104 100644
--- a/.github/workflows/abi.yaml
+++ b/.github/workflows/abi.yaml
@@ -50,5 +50,5 @@ jobs:
name: abi-test
path: abi-test
- name: fail
- if: ${{ steps.compare.outcome == 'failure' }}
+ if: ${{ env.ABI_BRANCH != github.ref_name && steps.compare.outcome == 'failure' }}
run: false
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 04/11] multipath-tools: github workflows: rebuild containers for rolling distros
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (3 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 03/11] multipath-tools: github abi workflow: don't fail on reference branch mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 05/11] multipath tools: github workflows: add coverity workflow mwilck
` (7 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
For Debian "sid" and alpine, using a pre-built container makes
no sense if this container is rebuilt only once every few months.
Rebuild these containers during the test. Also, add Fedora rawhide,
which is likely to ship the latest compilers.
Wrt stable distributions, replace fedora-34 with fedora-35 and add
Debian 11 (bullseye).
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
.github/workflows/native.yaml | 62 +++++++++++++++++++++++++++++++++--
1 file changed, 60 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/native.yaml b/.github/workflows/native.yaml
index 2bb1886..19c9e29 100644
--- a/.github/workflows/native.yaml
+++ b/.github/workflows/native.yaml
@@ -8,15 +8,17 @@ on:
pull_request:
jobs:
- build-and-test:
+ stable:
runs-on: ubuntu-20.04
strategy:
matrix:
- os: [buster, jessie, sid, alpine, fedora-34]
+ os: [buster, jessie, bullseye, fedora-35]
arch: ['', '-i386']
exclude:
- os: fedora-34
arch: '-i386'
+ - os: fedora-35
+ arch: '-i386'
container: mwilck/multipath-build-${{ matrix.os }}${{ matrix.arch }}
steps:
- name: checkout
@@ -30,3 +32,59 @@ jobs:
CC: clang
run: make test
+ rolling:
+ runs-on: ubuntu-20.04
+ strategy:
+ matrix:
+ os: ['debian:sid', 'alpine', 'fedora:rawhide']
+ arch: ['amd64', 'i386']
+ exclude:
+ - os: 'fedora:rawhide'
+ arch: 'i386'
+ container: ${{ matrix.arch }}/${{ matrix.os }}
+ steps:
+ - name: update
+ if: ${{ matrix.os == 'debian:sid' }}
+ run: apt-get update
+ - name: dependencies-debian
+ if: ${{ matrix.os == 'debian:sid' }}
+ run: >
+ apt-get install --yes -o APT::Immediate-Configure=0
+ gcc clang make pkg-config
+ libdevmapper-dev
+ libreadline-dev
+ libaio-dev
+ libudev-dev
+ libjson-c-dev
+ liburcu-dev
+ libcmocka-dev
+ - name: dependencies-alpine
+ if: ${{ matrix.os == 'alpine' }}
+ run: >
+ apk add make gcc clang cmocka
+ musl-dev lvm2-dev libaio-dev readline-dev ncurses-dev eudev-dev
+ userspace-rcu-dev json-c-dev cmocka-dev
+ - name: dependencies-fedora
+ if: ${{ matrix.os == 'fedora:rawhide' }}
+ run: >
+ dnf install -y
+ make clang gcc pkgconfig
+ libaio-devel
+ device-mapper-devel
+ libselinux-devel
+ libsepol-devel
+ readline-devel
+ ncurses-devel
+ userspace-rcu-devel
+ json-c-devel
+ libcmocka-devel
+ - name: checkout
+ uses: actions/checkout@v1
+ - name: build and test
+ run: make test
+ - name: clean
+ run: make clean
+ - name: clang
+ env:
+ CC: clang
+ run: make test
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 05/11] multipath tools: github workflows: add coverity workflow
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (4 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 04/11] multipath-tools: github workflows: rebuild containers for rolling distros mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 06/11] multipath-tools: .mailmap: add some more entries mwilck
` (6 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
Add a workflow that triggers a coverity static analysis scan.
For now, this will only be done on a special branch called "coverity".
Pushing to that branch will trigger the workflow.
For this to work, 3 secrets need to be set in the Github repository:
COVERITY_SCAN_EMAIL: the email address for coverity/synopsis account
COVERITY_SCAN_TOKEN: the coverity / synopsis access token
COVERITY_SCAN_PROJECT: the coverity project, e.g. mwilck/multipath-tools
The workflow succeeds if upload of the coverity results was successful.
The analysis result will be emailed to the given address.
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
.github/workflows/coverity.yaml | 51 +++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 .github/workflows/coverity.yaml
diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml
new file mode 100644
index 0000000..a8b56d4
--- /dev/null
+++ b/.github/workflows/coverity.yaml
@@ -0,0 +1,51 @@
+name: coverity
+on:
+ push:
+ branches:
+ - coverity
+
+jobs:
+ upload-coverity-scan:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: checkout
+ uses: actions/checkout@v2
+ - name: dependencies
+ run: >
+ sudo apt-get install --yes
+ gcc make pkg-config
+ libdevmapper-dev libreadline-dev libaio-dev libsystemd-dev
+ libudev-dev libjson-c-dev liburcu-dev libcmocka-dev
+ - name: download coverity
+ run: >
+ curl -o cov-analysis-linux64.tar.gz
+ --form token="$COV_TOKEN"
+ --form project="$COV_PROJECT"
+ https://scan.coverity.com/download/cxx/linux64
+ env:
+ COV_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }}
+ COV_PROJECT: ${{ secrets.COVERITY_SCAN_PROJECT }}
+ - name: unpack coverity
+ run: |
+ mkdir -p coverity
+ tar xfz cov-analysis-linux64.tar.gz --strip 1 -C coverity
+ - name: build with cov-build
+ run: >
+ PATH="$PWD/coverity/bin:$PATH"
+ cov-build --dir cov-int make -O -j"$(grep -c ^processor /proc/cpuinfo)"
+ - name: pack results
+ run: tar cfz multipath-tools.tgz cov-int
+ - name: submit results
+ run: >
+ curl
+ --form token="$COV_TOKEN"
+ --form email="$COV_EMAIL"
+ --form file="@multipath-tools.tgz"
+ --form version="${{ github.ref_name }}"
+ --form description="$(git describe --tags --match "0.*")"
+ --form project="$COV_PROJECT"
+ https://scan.coverity.com/builds
+ env:
+ COV_TOKEN: ${{ secrets.COVERITY_SCAN_TOKEN }}
+ COV_PROJECT: ${{ secrets.COVERITY_SCAN_PROJECT }}
+ COV_EMAIL: ${{ secrets.COVERITY_SCAN_EMAIL }}
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 06/11] multipath-tools: .mailmap: add some more entries
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (5 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 05/11] multipath tools: github workflows: add coverity workflow mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 07/11] libmultipath: make orphan_paths() static mwilck
` (5 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
.mailmap | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/.mailmap b/.mailmap
index 2c04cb0..14996ab 100644
--- a/.mailmap
+++ b/.mailmap
@@ -9,9 +9,13 @@
#
# Please keep this list dictionary sorted.
#
+Bart Van Assche <bvanassche@acm.org> <bart.vanassche@sandisk.com>
+Bart Van Assche <bvanassche@acm.org> <bart.vanassche@wdc.com>
Benjamin Marzinski <bmarzins@redhat.com> <bmarzin@redhat.com>
Benjamin Marzinski <bmarzins@redhat.com> <bmarzins@sourceware.org>
Benjamin Marzinski <bmarzins@redhat.com> bmarzins@sourceware.org <bmarzins@sourceware.org>
+Chongyun Wu <wucy11@chinatelecom.cn> Wuchongyun <wu.chongyun@h3c.com>
+Chongyun Wu <wucy11@chinatelecom.cn> <wu.chongyun@h3c.com>
Christophe Varoqui <christophe.varoqui@opensvc.com> <christophe.varoqui@free.fr>
Christophe Varoqui <christophe.varoqui@opensvc.com> <cvaroqui@cl039.(none)>
Christophe Varoqui <christophe.varoqui@opensvc.com> <cvaroqui@hera.kernel.org>
@@ -20,5 +24,8 @@ Christophe Varoqui <christophe.varoqui@opensvc.com> root <root@potab.(none)>
Christophe Varoqui <christophe.varoqui@opensvc.com> root <root@xa-s05.(none)>
Christophe Varoqui <christophe.varoqui@opensvc.com> root <root@zezette.localdomain>
Christophe Varoqui <christophe.varoqui@opensvc.com> <root@xa-s05.(none)>
+Hannes Reinecke <hare@suse.de> <hare@acerbis.suse.de>
+Hannes Reinecke <hare@suse.de> <hare@suse.com>
Martin Wilck <mwilck@suse.com> <Martin.Wilck@suse.com>
Martin Wilck <mwilck@suse.com> <mwilck@suse.de>
+wei huang <huang.wei56@zte.com.cn> wei.huang <huang.wei56@zte.com.cn>
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 07/11] libmultipath: make orphan_paths() static
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (6 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 06/11] multipath-tools: .mailmap: add some more entries mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 08/11] libmultipath: make update_pathvec_from_dm() static mwilck
` (4 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
This function is only used in structs_vec.c
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/libmultipath.version | 1 -
libmultipath/structs_vec.c | 2 +-
libmultipath/structs_vec.h | 2 --
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version
index 0c5417d..68db95f 100644
--- a/libmultipath/libmultipath.version
+++ b/libmultipath/libmultipath.version
@@ -129,7 +129,6 @@ global:
need_io_err_check;
normalize_timespec;
orphan_path;
- orphan_paths;
parse_prkey_flags;
pathcount;
path_discovery;
diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c
index 61f8e1b..67d3504 100644
--- a/libmultipath/structs_vec.c
+++ b/libmultipath/structs_vec.c
@@ -300,7 +300,7 @@ void orphan_path(struct path *pp, const char *reason)
uninitialize_path(pp);
}
-void orphan_paths(vector pathvec, struct multipath *mpp, const char *reason)
+static void orphan_paths(vector pathvec, struct multipath *mpp, const char *reason)
{
int i;
struct path * pp;
diff --git a/libmultipath/structs_vec.h b/libmultipath/structs_vec.h
index 2a0cbd1..fb0e3b4 100644
--- a/libmultipath/structs_vec.h
+++ b/libmultipath/structs_vec.h
@@ -15,8 +15,6 @@ void __set_no_path_retry(struct multipath *mpp, bool check_features);
#define set_no_path_retry(mpp) __set_no_path_retry(mpp, true)
int adopt_paths (vector pathvec, struct multipath * mpp);
-void orphan_paths(vector pathvec, struct multipath *mpp,
- const char *reason);
void orphan_path (struct path * pp, const char *reason);
void set_path_removed(struct path *pp);
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 08/11] libmultipath: make update_pathvec_from_dm() static
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (7 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 07/11] libmultipath: make orphan_paths() static mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 09/11] libmultipath: remove recv_packet_from_client() mwilck
` (3 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
This function is called only in structs_vec.c.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/libmultipath.version | 1 -
libmultipath/structs_vec.c | 2 +-
libmultipath/structs_vec.h | 2 --
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version
index 68db95f..a693933 100644
--- a/libmultipath/libmultipath.version
+++ b/libmultipath/libmultipath.version
@@ -197,7 +197,6 @@ global:
update_mpp_paths;
update_multipath_strings;
update_multipath_table;
- update_pathvec_from_dm;
update_queue_mode_add_path;
update_queue_mode_del_path;
ux_socket_listen;
diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c
index 67d3504..cb0ebae 100644
--- a/libmultipath/structs_vec.c
+++ b/libmultipath/structs_vec.c
@@ -99,7 +99,7 @@ static bool guess_mpp_wwid(struct multipath *mpp)
* - may set pp->wwid and / or mpp->wwid
* - calls pathinfo() on existing paths is pathinfo_flags is not 0
*/
-bool update_pathvec_from_dm(vector pathvec, struct multipath *mpp,
+static bool update_pathvec_from_dm(vector pathvec, struct multipath *mpp,
int pathinfo_flags)
{
int i, j;
diff --git a/libmultipath/structs_vec.h b/libmultipath/structs_vec.h
index fb0e3b4..d33fe98 100644
--- a/libmultipath/structs_vec.h
+++ b/libmultipath/structs_vec.h
@@ -19,8 +19,6 @@ void orphan_path (struct path * pp, const char *reason);
void set_path_removed(struct path *pp);
int verify_paths(struct multipath *mpp);
-bool update_pathvec_from_dm(vector pathvec, struct multipath *mpp,
- int pathinfo_flags);
int update_mpp_paths(struct multipath * mpp, vector pathvec);
int update_multipath_strings (struct multipath *mpp, vector pathvec);
void extract_hwe_from_path(struct multipath * mpp);
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 09/11] libmultipath: remove recv_packet_from_client()
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (8 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 08/11] libmultipath: make update_pathvec_from_dm() static mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 10/11] libmultipath.version: drop some unused symbols mwilck
` (2 subsequent siblings)
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
This function became unused after the late uxlsnr patches.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/libmultipath.version | 1 -
libmultipath/uxsock.c | 5 -----
libmultipath/uxsock.h | 6 ------
3 files changed, 12 deletions(-)
diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version
index a693933..941bd8f 100644
--- a/libmultipath/libmultipath.version
+++ b/libmultipath/libmultipath.version
@@ -140,7 +140,6 @@ global:
_print_multipath_topology;
pthread_cond_init_mono;
recv_packet;
- recv_packet_from_client;
reinstate_paths;
remember_wwid;
remove_map;
diff --git a/libmultipath/uxsock.c b/libmultipath/uxsock.c
index 0ccd1fa..2135476 100644
--- a/libmultipath/uxsock.c
+++ b/libmultipath/uxsock.c
@@ -128,8 +128,3 @@ int recv_packet(int fd, char **buf, unsigned int timeout)
{
return _recv_packet(fd, buf, timeout, 0 /* no limit */);
}
-
-int recv_packet_from_client(int fd, char **buf, unsigned int timeout)
-{
- return _recv_packet(fd, buf, timeout, _MAX_CMD_LEN);
-}
diff --git a/libmultipath/uxsock.h b/libmultipath/uxsock.h
index 8e7401d..e3d28cf 100644
--- a/libmultipath/uxsock.h
+++ b/libmultipath/uxsock.h
@@ -5,9 +5,3 @@ int recv_packet(int fd, char **buf, unsigned int timeout);
#define _MAX_CMD_LEN 512
-/*
- * Used for receiving socket command from untrusted socket client where data
- * size is restricted to 512(_MAX_CMD_LEN) at most.
- * Return -EINVAL if data length requested by client exceeded the _MAX_CMD_LEN.
- */
-int recv_packet_from_client(int fd, char **buf, unsigned int timeout);
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 10/11] libmultipath.version: drop some unused symbols
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (9 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 09/11] libmultipath: remove recv_packet_from_client() mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 11/11] libmultipath.version: sort symbols mwilck
2021-12-02 18:35 ` [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools Benjamin Marzinski
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
Remove some symbols that aren't used any more, and move
symbols "only" used by checkers / prioritizers to their respective
places in the file (this helps assessing which symbols are used).
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/libmultipath.version | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version
index 941bd8f..7f845ed 100644
--- a/libmultipath/libmultipath.version
+++ b/libmultipath/libmultipath.version
@@ -48,7 +48,6 @@ global:
checker_clear_message;
checker_disable;
checker_enable;
- checker_is_sync;
checker_message;
checker_name;
checker_state_name;
@@ -209,10 +208,13 @@ global:
verify_paths;
/* checkers */
+ checker_is_sync;
sg_read;
+ start_checker_thread;
/* prioritizers */
get_asymmetric_access_state;
+ get_next_string;
get_prio_timeout;
get_target_port_group;
get_target_port_group_support;
@@ -234,7 +236,6 @@ global:
/* added in 2.1.0 */
libmp_dm_task_run;
- cleanup_mutex;
/* added in 2.2.0 */
libmp_get_multipath_config;
@@ -257,15 +258,10 @@ global:
dm_prereq;
skip_libmp_dm_init;
- /* added in 4.3.0 */
- start_checker_thread;
-
/* added in 4.4.0 */
- get_next_string;
/* added in 4.5.0 */
get_vpd_sgio;
- trigger_partitions_udev_change;
/* added in 7.0.0 */
cleanup_charp;
@@ -276,7 +272,6 @@ global:
append_strbuf_str;
get_strbuf_len;
get_strbuf_str;
- steal_strbuf_str;
fill_strbuf;
print_strbuf;
truncate_strbuf;
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [dm-devel] [PATCH 11/11] libmultipath.version: sort symbols
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (10 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 10/11] libmultipath.version: drop some unused symbols mwilck
@ 2021-12-02 16:06 ` mwilck
2021-12-02 18:35 ` [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools Benjamin Marzinski
12 siblings, 0 replies; 16+ messages in thread
From: mwilck @ 2021-12-02 16:06 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
Give up the habit of indicating in which library version the
symbols were added, which has no real benefit. The only "sections"
that are kept are those listing symbols that are only used by
dlopen'd .so files.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/libmultipath.version | 81 +++++++++++--------------------
1 file changed, 28 insertions(+), 53 deletions(-)
diff --git a/libmultipath/libmultipath.version b/libmultipath/libmultipath.version
index 7f845ed..9c7ffa7 100644
--- a/libmultipath/libmultipath.version
+++ b/libmultipath/libmultipath.version
@@ -43,8 +43,10 @@ global:
alloc_path_layout;
alloc_path_with_pathinfo;
alloc_strvec;
+ append_strbuf_str;
change_foreign;
check_alias_settings;
+ check_daemon;
checker_clear_message;
checker_disable;
checker_enable;
@@ -52,7 +54,9 @@ global:
checker_name;
checker_state_name;
check_foreign;
+ cleanup_charp;
cleanup_lock;
+ cleanup_ucharp;
close_fd;
coalesce_paths;
convert_dev;
@@ -75,6 +79,7 @@ global:
dm_is_mpath;
dm_mapname;
dm_map_present;
+ dm_prereq;
dm_queue_if_no_path;
dm_reassign;
dm_reinstate_path;
@@ -103,16 +108,21 @@ global:
free_pathvec;
free_strvec;
get_monotonic_time;
+ get_multipath_config;
get_multipath_layout;
get_path_layout;
get_pgpolicy_id;
get_refwwid;
get_state;
+ get_strbuf_len;
+ get_strbuf_str;
get_udev_device;
get_uid;
get_used_hwes;
+ get_vpd_sgio;
group_by_prio;
init_checkers;
+ init_config;
init_foreign;
init_prio;
io_err_stat_handle_pathfail;
@@ -120,11 +130,18 @@ global:
is_quote;
libmp_dm_task_create;
libmp_get_version;
+ libmp_get_multipath_config;
+ libmp_dm_task_run;
+ libmp_put_multipath_config;
libmp_udev_set_sync_support;
+ libmp_verbosity;
+ libmultipath_exit;
+ libmultipath_init;
load_config;
log_thread_reset;
log_thread_start;
log_thread_stop;
+ logsink;
need_io_err_check;
normalize_timespec;
orphan_path;
@@ -137,7 +154,9 @@ global:
print_all_paths;
print_foreign_topology;
_print_multipath_topology;
+ print_strbuf;
pthread_cond_init_mono;
+ put_multipath_config;
recv_packet;
reinstate_paths;
remember_wwid;
@@ -147,6 +166,7 @@ global:
remove_wwid;
replace_wwids;
reset_checker_classes;
+ reset_strbuf;
select_all_tg_pt;
select_action;
select_find_multipaths_timeout;
@@ -161,7 +181,9 @@ global:
setup_map;
setup_thread_attr;
should_multipath;
+ skip_libmp_dm_init;
snprint_blacklist_report;
+ __snprint_config;
snprint_config;
snprint_devices;
snprint_foreign_multipaths;
@@ -185,13 +207,17 @@ global:
sysfs_attr_set_value;
sysfs_get_size;
sysfs_is_multipathed;
+ timespeccmp;
timespecsub;
trigger_paths_udev_change;
+ truncate_strbuf;
+ udev;
uevent_dispatch;
uevent_get_dm_str;
uevent_get_env_positive_int;
uevent_is_mpath;
uevent_listen;
+ uninit_config;
update_mpp_paths;
update_multipath_strings;
update_multipath_table;
@@ -213,6 +239,7 @@ global:
start_checker_thread;
/* prioritizers */
+ fill_strbuf;
get_asymmetric_access_state;
get_next_string;
get_prio_timeout;
@@ -223,6 +250,7 @@ global:
libmp_nvme_identify_ns;
log_nvme_errcode;
nvme_id_ctrl_ana;
+ set_wakeup_fn;
snprint_host_wwnn;
snprint_host_wwpn;
snprint_path_serial;
@@ -234,59 +262,6 @@ global:
free_scandir_result;
sysfs_attr_get_value;
- /* added in 2.1.0 */
- libmp_dm_task_run;
-
- /* added in 2.2.0 */
- libmp_get_multipath_config;
- get_multipath_config;
- libmp_put_multipath_config;
- put_multipath_config;
- init_config;
- uninit_config;
-
- /* added in 2.3.0 */
- udev;
- logsink;
- libmultipath_init;
- libmultipath_exit;
-
- /* added in 4.1.0 */
- libmp_verbosity;
-
- /* added in 4.2.0 */
- dm_prereq;
- skip_libmp_dm_init;
-
- /* added in 4.4.0 */
-
- /* added in 4.5.0 */
- get_vpd_sgio;
-
- /* added in 7.0.0 */
- cleanup_charp;
- cleanup_ucharp;
-
- /* added in 8.1.0 */
- reset_strbuf;
- append_strbuf_str;
- get_strbuf_len;
- get_strbuf_str;
- fill_strbuf;
- print_strbuf;
- truncate_strbuf;
-
- /* added in 8.2.0 */
- check_daemon;
-
- /* added in 9.1.0 */
- timespeccmp;
-
- /* added in 10.0.0 */
- set_wakeup_fn;
-
- /* added in 10.1.0 */
- __snprint_config;
local:
*;
};
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [dm-devel] [PATCH 02/11] multipath-tools: generate abi without version script
2021-12-02 16:06 ` [dm-devel] [PATCH 02/11] multipath-tools: generate abi without " mwilck
@ 2021-12-02 17:51 ` Benjamin Marzinski
2021-12-02 18:07 ` Martin Wilck
0 siblings, 1 reply; 16+ messages in thread
From: Benjamin Marzinski @ 2021-12-02 17:51 UTC (permalink / raw)
To: mwilck; +Cc: dm-devel
On Thu, Dec 02, 2021 at 05:06:43PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
I assume that am supposed to ignore this patch, and look at
"multipath-tools: generate abi with dummy version script"
instead, right?
-Ben
> The purpose of the "abi" makefile target is to detect ABI changes. If using
> the version script the way we do (bumping major or minor versions), abigail
> detects a completely different ABI with every bump. This makes it very
> difficult to figure out actual changes in the code.
>
> This patch fixes that by using "versionless version scripts" for ABI
> generation. These version scripts just list all exported symbols, using
> just a single dummy version string. This is better than using no version
> script at all, because only exported symbols will be compared, whereas
> without a version script we'd be comparing non-exported symbols, too.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> Makefile.inc | 1 +
> libdmmp/Makefile | 2 +-
> libmpathcmd/Makefile | 13 +++++++++++--
> libmpathpersist/Makefile | 15 ++++++++++++---
> libmpathvalid/Makefile | 16 +++++++++++++---
> libmultipath/Makefile | 13 +++++++++++--
> 6 files changed, 49 insertions(+), 11 deletions(-)
>
> diff --git a/Makefile.inc b/Makefile.inc
> index 17071ef..b340f2a 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -79,6 +79,7 @@ GZIP = gzip -9 -c
> RM = rm -f
> LN = ln -sf
> INSTALL_PROGRAM = install
> +NV_VERSION_SCRIPT = $(VERSION_SCRIPT:%.version=%-nv.version)
>
> # $(call TEST_CC_OPTION,option,fallback)
> # Test if the C compiler supports the option.
> diff --git a/libdmmp/Makefile b/libdmmp/Makefile
> index c91f0c3..de61668 100644
> --- a/libdmmp/Makefile
> +++ b/libdmmp/Makefile
> @@ -58,7 +58,7 @@ uninstall:
> $(RM) $(DESTDIR)$(pkgconfdir)/$(PKGFILE)
>
> clean: dep_clean
> - $(RM) core *.a *.o *.gz *.so *.so.* *.abi
> + $(RM) core *.a *.o *.gz *.so *.so.* *.abi $(NV_VERSION_SCRIPT)
> $(RM) docs/man/*.gz
> $(MAKE) -C test clean
>
> diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile
> index 5a7a6e9..72cab1e 100644
> --- a/libmpathcmd/Makefile
> +++ b/libmpathcmd/Makefile
> @@ -15,7 +15,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
> $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
> -Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
>
> -abi: $(LIBS:%.so.0=%.abi)
> +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
> + @printf 'NOVERSION {\nglobal:\n' >$@
> + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
> + @printf 'local:\n\t*;\n};\n' >>$@
> +
> +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
> + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
> + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
> +
> +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
>
> $(DEVLIB): $(LIBS)
> $(LN) $(LIBS) $@
> @@ -33,7 +42,7 @@ uninstall:
> $(RM) $(DESTDIR)$(includedir)/mpath_cmd.h
>
> clean: dep_clean
> - $(RM) core *.a *.o *.so *.so.* *.gz *.abi
> + $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
>
> include $(wildcard $(OBJS:.o=.d))
>
> diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
> index d76918f..1e6399d 100644
> --- a/libmpathpersist/Makefile
> +++ b/libmpathpersist/Makefile
> @@ -3,7 +3,7 @@ include ../Makefile.inc
> SONAME = 0
> DEVLIB = libmpathpersist.so
> LIBS = $(DEVLIB).$(SONAME)
> -VERSION_SCRIPT := libmpathpersist.version
> +VERSION_SCRIPT:= libmpathpersist.version
>
> CFLAGS += $(LIB_CFLAGS) -I$(multipathdir) -I$(mpathpersistdir) -I$(mpathcmddir)
> LDFLAGS += -L$(multipathdir) -L$(mpathcmddir)
> @@ -18,7 +18,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
> $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
> -Wl,--version-script=$(VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
>
> -abi: $(LIBS:%.so.0=%.abi)
> +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
> + @printf 'NOVERSION {\nglobal:\n' >$@
> + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
> + @printf 'local:\n\t*;\n};\n' >>$@
> +
> +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
> + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
> + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
> +
> +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
>
> $(DEVLIB): $(LIBS)
> $(LN) $(LIBS) $@
> @@ -46,7 +55,7 @@ uninstall:
> $(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
>
> clean: dep_clean
> - $(RM) core *.a *.o *.so *.so.* *.gz *.abi
> + $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
>
> include $(wildcard $(OBJS:.o=.d))
>
> diff --git a/libmpathvalid/Makefile b/libmpathvalid/Makefile
> index b579535..dce2610 100644
> --- a/libmpathvalid/Makefile
> +++ b/libmpathvalid/Makefile
> @@ -15,10 +15,20 @@ OBJS = mpath_valid.o
> all: $(LIBS)
>
> $(LIBS): $(OBJS) $(VERSION_SCRIPT)
> - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) -Wl,--version-script=libmpathvalid.version
> + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) \
> + -Wl,--version-script=$(VERSION_SCRIPT)
> $(LN) $(LIBS) $(DEVLIB)
>
> -abi: $(LIBS:%.so.0=%.abi)
> +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
> + @printf 'NOVERSION {\nglobal:\n' >$@
> + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
> + @printf 'local:\n\t*;\n};\n' >>$@
> +
> +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
> + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
> + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
> +
> +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
>
> install: $(LIBS)
> $(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(syslibdir)
> @@ -33,7 +43,7 @@ uninstall:
> $(RM) $(DESTDIR)$(includedir)/mpath_valid.h
>
> clean: dep_clean
> - $(RM) core *.a *.o *.so *.so.* *.gz *.abi
> + $(RM) core *.a *.o *.so *.so.* *.gz *.abi $(NV_VERSION_SCRIPT)
>
> include $(wildcard $(OBJS:.o=.d))
>
> diff --git a/libmultipath/Makefile b/libmultipath/Makefile
> index e8fd749..d4af1a5 100644
> --- a/libmultipath/Makefile
> +++ b/libmultipath/Makefile
> @@ -81,7 +81,16 @@ $(LIBS): $(OBJS) $(VERSION_SCRIPT)
> $(DEVLIB): $(LIBS)
> $(LN) $(LIBS) $@
>
> -abi: $(LIBS:%.so.0=%.abi)
> +$(NV_VERSION_SCRIPT): $(VERSION_SCRIPT)
> + @printf 'NOVERSION {\nglobal:\n' >$@
> + @grep -P '^[ \t]+[a-zA-Z_][a-zA-Z0-9_]*;' $< >>$@
> + @printf 'local:\n\t*;\n};\n' >>$@
> +
> +$(LIBS:%.so.$(SONAME)=%-nv.so): $(OBJS) $(NV_VERSION_SCRIPT)
> + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ \
> + -Wl,--version-script=$(NV_VERSION_SCRIPT) -o $@ $(OBJS) $(LIBDEPS)
> +
> +abi: $(LIBS:%.so.$(SONAME)=%-nv.abi)
>
> ../tests/$(LIBS): $(OBJS) $(VERSION_SCRIPT)
> $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=`basename $@` \
> @@ -101,7 +110,7 @@ uninstall:
> $(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
>
> clean: dep_clean
> - $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h
> + $(RM) core *.a *.o *.so *.so.* *.gz *.abi nvme-ioctl.c nvme-ioctl.h $(NV_VERSION_SCRIPT)
>
> include $(wildcard $(OBJS:.o=.d))
>
> --
> 2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dm-devel] [PATCH 02/11] multipath-tools: generate abi without version script
2021-12-02 17:51 ` Benjamin Marzinski
@ 2021-12-02 18:07 ` Martin Wilck
0 siblings, 0 replies; 16+ messages in thread
From: Martin Wilck @ 2021-12-02 18:07 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: dm-devel
On Thu, 2021-12-02 at 11:51 -0600, Benjamin Marzinski wrote:
> On Thu, Dec 02, 2021 at 05:06:43PM +0100, mwilck@suse.com wrote:
> > From: Martin Wilck <mwilck@suse.com>
> >
>
> I assume that am supposed to ignore this patch, and look at
>
> "multipath-tools: generate abi with dummy version script"
>
> instead, right?
>
Yes. I'm sorry. This one can be ignored.
Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
` (11 preceding siblings ...)
2021-12-02 16:06 ` [dm-devel] [PATCH 11/11] libmultipath.version: sort symbols mwilck
@ 2021-12-02 18:35 ` Benjamin Marzinski
12 siblings, 0 replies; 16+ messages in thread
From: Benjamin Marzinski @ 2021-12-02 18:35 UTC (permalink / raw)
To: mwilck; +Cc: dm-devel
On Thu, Dec 02, 2021 at 05:06:40PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> Hi Christophe, hi Ben,
>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> here are some last-minute fixes that I'd like to have added to
> the currently pending multipath-tools update. None of them touches
> any real functionality, except the first one, which I already sent
> earlier today. Patch 3,4,5 were already included in my github PR
> (which I'm going to rebase to match this submission). Patch 2 supersedes
> "multipath-tools: generate abi without version script" from the first
> version of the Github PR. The rest is new, tidy-up work for
> libmultipath.version.
>
> Regards
> Martin
>
> Martin Wilck (11):
> multipathd.service: add dependency on systemd-udevd-kernel.socket
> multipath-tools: generate abi with dummy version script
> multipath-tools: github abi workflow: don't fail on reference branch
> multipath-tools: github workflows: rebuild containers for rolling
> distros
> multipath tools: github workflows: add coverity workflow
> multipath-tools: .mailmap: add some more entries
> libmultipath: make orphan_paths() static
> libmultipath: make update_pathvec_from_dm() static
> libmultipath: remove recv_packet_from_client()
> libmultipath.version: drop some unused symbols
> libmultipath.version: sort symbols
>
> .github/workflows/abi.yaml | 2 +-
> .github/workflows/coverity.yaml | 51 +++++++++++++++++
> .github/workflows/native.yaml | 62 +++++++++++++++++++-
> .mailmap | 7 +++
> Makefile.inc | 1 +
> libdmmp/Makefile | 2 +-
> libmpathcmd/Makefile | 13 ++++-
> libmpathpersist/Makefile | 15 ++++-
> libmpathvalid/Makefile | 16 +++++-
> libmultipath/Makefile | 13 ++++-
> libmultipath/libmultipath.version | 95 ++++++++++---------------------
> libmultipath/structs_vec.c | 4 +-
> libmultipath/structs_vec.h | 4 --
> libmultipath/uxsock.c | 5 --
> libmultipath/uxsock.h | 6 --
> multipathd/multipathd.service | 2 +
> 16 files changed, 203 insertions(+), 95 deletions(-)
> create mode 100644 .github/workflows/coverity.yaml
>
> --
> 2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-12-02 18:38 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 16:06 [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 01/11] multipathd.service: add dependency on systemd-udevd-kernel.socket mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 02/11] multipath-tools: generate abi with dummy version script mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 02/11] multipath-tools: generate abi without " mwilck
2021-12-02 17:51 ` Benjamin Marzinski
2021-12-02 18:07 ` Martin Wilck
2021-12-02 16:06 ` [dm-devel] [PATCH 03/11] multipath-tools: github abi workflow: don't fail on reference branch mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 04/11] multipath-tools: github workflows: rebuild containers for rolling distros mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 05/11] multipath tools: github workflows: add coverity workflow mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 06/11] multipath-tools: .mailmap: add some more entries mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 07/11] libmultipath: make orphan_paths() static mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 08/11] libmultipath: make update_pathvec_from_dm() static mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 09/11] libmultipath: remove recv_packet_from_client() mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 10/11] libmultipath.version: drop some unused symbols mwilck
2021-12-02 16:06 ` [dm-devel] [PATCH 11/11] libmultipath.version: sort symbols mwilck
2021-12-02 18:35 ` [dm-devel] [PATCH 00/11] Last-minute patches for multipath-tools Benjamin Marzinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.