* [PATCH] erofs-utils: loosen hash_64 compile restriction
@ 2021-12-02 19:09 Daeho Jeong
2021-12-03 1:07 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Daeho Jeong @ 2021-12-02 19:09 UTC (permalink / raw)
To: linux-erofs; +Cc: jaegeuk, Daeho Jeong
From: Daeho Jeong <daehojeong@google.com>
We've got the below "unused function" warning for 32bit compilation. So,
fixed it.
error: unused function 'hash_64' [-Werror,-Wunused-function]
Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
include/erofs/hashtable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/erofs/hashtable.h b/include/erofs/hashtable.h
index 90eb84e..d425f0c 100644
--- a/include/erofs/hashtable.h
+++ b/include/erofs/hashtable.h
@@ -251,7 +251,7 @@ static inline u32 hash_32(u32 val, unsigned int bits)
return __hash_32(val) >> (32 - bits);
}
-static __always_inline u32 hash_64(u64 val, unsigned int bits)
+static inline u32 hash_64(u64 val, unsigned int bits)
{
#if BITS_PER_LONG == 64
/* 64x64-bit multiply is efficient on all 64-bit processors */
--
2.34.0.384.gca35af8252-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] erofs-utils: loosen hash_64 compile restriction
2021-12-02 19:09 [PATCH] erofs-utils: loosen hash_64 compile restriction Daeho Jeong
@ 2021-12-03 1:07 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2021-12-03 1:07 UTC (permalink / raw)
To: Daeho Jeong; +Cc: linux-erofs, Daeho Jeong, jaegeuk
On Thu, Dec 02, 2021 at 11:09:23AM -0800, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> We've got the below "unused function" warning for 32bit compilation. So,
> fixed it.
>
> error: unused function 'hash_64' [-Werror,-Wunused-function]
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 1:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 19:09 [PATCH] erofs-utils: loosen hash_64 compile restriction Daeho Jeong
2021-12-03 1:07 ` Gao Xiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.