From: kernel test robot <lkp@intel.com> To: Mel Gorman <mgorman@suse.de>, Andrew Morton <akpm@linux-foundation.org> Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>, Alexey Avramov <hakavlad@inbox.lv>, Rik van Riel <riel@surriel.com>, Mike Galbraith <efault@gmx.de>, Darrick Wong <djwong@kernel.org>, regressions@lists.linux.dev, Linux-fsdevel <linux-fsdevel@vger.kernel.org> Subject: Re: [PATCH 1/1] mm: vmscan: Reduce throttling due to a failure to make progress Date: Fri, 3 Dec 2021 00:02:49 +0800 [thread overview] Message-ID: <202112030001.HUiErCyK-lkp@intel.com> (raw) In-Reply-To: <20211202131842.9217-1-mgorman@techsingularity.net> Hi Mel, I love your patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004 base: https://github.com/hnaz/linux-mm master config: x86_64-buildonly-randconfig-r001-20211202 (https://download.01.org/0day-ci/archive/20211203/202112030001.HUiErCyK-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b553297ef3ee4dc2119d5429adf3072e90fac38) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/01dada07590ae9c69a9415ba9af96d5ae184d861 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004 git checkout 01dada07590ae9c69a9415ba9af96d5ae184d861 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> mm/vmscan.c:1024:6: warning: no previous prototype for function 'skip_throttle_noprogress' [-Wmissing-prototypes] bool skip_throttle_noprogress(pg_data_t *pgdat) ^ mm/vmscan.c:1024:1: note: declare 'static' if the function is not intended to be used outside of this translation unit bool skip_throttle_noprogress(pg_data_t *pgdat) ^ static 1 warning generated. vim +/skip_throttle_noprogress +1024 mm/vmscan.c 1023 > 1024 bool skip_throttle_noprogress(pg_data_t *pgdat) 1025 { 1026 int reclaimable = 0, write_pending = 0; 1027 int i; 1028 1029 /* 1030 * If kswapd is disabled, reschedule if necessary but do not 1031 * throttle as the system is likely near OOM. 1032 */ 1033 if (pgdat->kswapd_failures >= MAX_RECLAIM_RETRIES) 1034 return true; 1035 1036 /* 1037 * If there are a lot of dirty/writeback pages then do not 1038 * throttle as throttling will occur when the pages cycle 1039 * towards the end of the LRU if still under writeback. 1040 */ 1041 for (i = 0; i < MAX_NR_ZONES; i++) { 1042 struct zone *zone = pgdat->node_zones + i; 1043 1044 if (!populated_zone(zone)) 1045 continue; 1046 1047 reclaimable += zone_reclaimable_pages(zone); 1048 write_pending += zone_page_state_snapshot(zone, 1049 NR_ZONE_WRITE_PENDING); 1050 } 1051 if (2 * write_pending <= reclaimable) 1052 return true; 1053 1054 return false; 1055 } 1056 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 1/1] mm: vmscan: Reduce throttling due to a failure to make progress Date: Fri, 03 Dec 2021 00:02:49 +0800 [thread overview] Message-ID: <202112030001.HUiErCyK-lkp@intel.com> (raw) In-Reply-To: <20211202131842.9217-1-mgorman@techsingularity.net> [-- Attachment #1: Type: text/plain, Size: 3083 bytes --] Hi Mel, I love your patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004 base: https://github.com/hnaz/linux-mm master config: x86_64-buildonly-randconfig-r001-20211202 (https://download.01.org/0day-ci/archive/20211203/202112030001.HUiErCyK-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b553297ef3ee4dc2119d5429adf3072e90fac38) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/01dada07590ae9c69a9415ba9af96d5ae184d861 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004 git checkout 01dada07590ae9c69a9415ba9af96d5ae184d861 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> mm/vmscan.c:1024:6: warning: no previous prototype for function 'skip_throttle_noprogress' [-Wmissing-prototypes] bool skip_throttle_noprogress(pg_data_t *pgdat) ^ mm/vmscan.c:1024:1: note: declare 'static' if the function is not intended to be used outside of this translation unit bool skip_throttle_noprogress(pg_data_t *pgdat) ^ static 1 warning generated. vim +/skip_throttle_noprogress +1024 mm/vmscan.c 1023 > 1024 bool skip_throttle_noprogress(pg_data_t *pgdat) 1025 { 1026 int reclaimable = 0, write_pending = 0; 1027 int i; 1028 1029 /* 1030 * If kswapd is disabled, reschedule if necessary but do not 1031 * throttle as the system is likely near OOM. 1032 */ 1033 if (pgdat->kswapd_failures >= MAX_RECLAIM_RETRIES) 1034 return true; 1035 1036 /* 1037 * If there are a lot of dirty/writeback pages then do not 1038 * throttle as throttling will occur when the pages cycle 1039 * towards the end of the LRU if still under writeback. 1040 */ 1041 for (i = 0; i < MAX_NR_ZONES; i++) { 1042 struct zone *zone = pgdat->node_zones + i; 1043 1044 if (!populated_zone(zone)) 1045 continue; 1046 1047 reclaimable += zone_reclaimable_pages(zone); 1048 write_pending += zone_page_state_snapshot(zone, 1049 NR_ZONE_WRITE_PENDING); 1050 } 1051 if (2 * write_pending <= reclaimable) 1052 return true; 1053 1054 return false; 1055 } 1056 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-12-02 16:03 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-02 13:18 [PATCH 1/1] mm: vmscan: Reduce throttling due to a failure to make progress Mel Gorman 2021-12-02 14:51 ` kernel test robot 2021-12-02 14:51 ` kernel test robot 2021-12-02 16:02 ` kernel test robot [this message] 2021-12-02 16:02 ` kernel test robot -- strict thread matches above, loose matches on Subject: below -- 2021-11-25 15:18 Mel Gorman 2021-11-26 10:14 ` Vlastimil Babka 2021-11-26 10:26 ` Mike Galbraith 2021-11-26 16:12 ` Alexey Avramov 2021-11-26 16:52 ` Mel Gorman 2021-11-27 19:26 ` Alexey Avramov 2021-11-28 10:00 ` Mike Galbraith 2021-11-28 11:39 ` Mike Galbraith 2021-11-28 12:35 ` Mike Galbraith 2021-11-28 18:38 ` Mike Galbraith 2021-11-28 11:58 ` Alexey Avramov 2021-11-29 8:26 ` Mel Gorman 2021-11-29 15:01 ` Mel Gorman 2021-11-30 10:14 ` Mike Galbraith 2021-11-30 11:22 ` Mel Gorman 2021-11-30 12:00 ` Mike Galbraith 2021-11-30 12:51 ` Mike Galbraith 2021-11-30 13:09 ` Mel Gorman 2021-12-01 4:32 ` Mike Galbraith 2021-11-30 16:03 ` Alexey Avramov 2021-11-30 17:27 ` Mel Gorman 2021-11-30 17:59 ` Mike Galbraith 2021-12-01 13:01 ` Mel Gorman 2021-12-01 13:52 ` Mike Galbraith 2021-12-01 15:06 ` Mel Gorman 2021-11-30 18:38 ` Alexey Avramov 2021-12-01 14:00 ` Mel Gorman 2021-12-01 17:29 ` Darrick J. Wong 2021-12-02 9:43 ` Mel Gorman 2021-12-02 16:09 ` Darrick J. Wong 2021-12-02 3:11 ` Mike Galbraith 2021-12-02 10:13 ` Mel Gorman 2021-12-02 10:51 ` Mike Galbraith 2021-12-02 11:42 ` Alexey Avramov 2021-12-02 12:14 ` Alexey Avramov 2021-12-02 12:15 ` Mel Gorman 2021-12-02 12:22 ` Alexey Avramov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202112030001.HUiErCyK-lkp@intel.com \ --to=lkp@intel.com \ --cc=akpm@linux-foundation.org \ --cc=djwong@kernel.org \ --cc=efault@gmx.de \ --cc=hakavlad@inbox.lv \ --cc=kbuild-all@lists.01.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=llvm@lists.linux.dev \ --cc=mgorman@suse.de \ --cc=mhocko@suse.com \ --cc=regressions@lists.linux.dev \ --cc=riel@surriel.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.