* [Intel-gfx] [v3 0/3] Introduce Raptor Lake S
@ 2021-12-03 6:35 ` Anusha Srivatsa
0 siblings, 0 replies; 23+ messages in thread
From: Anusha Srivatsa @ 2021-12-03 6:35 UTC (permalink / raw)
To: intel-gfx
Cc: Jani Nikula, x86, dri-devel, Dave Hansen, Ingo Molnar, Borislav Petkov
Raptor Lake S(RPL-S) is a version 12
Display, Media and Render. For all i915
purposes it is the same as Alder Lake S (ADL-S).
The series introduces it as a subplatform
of ADL-S. The one difference is the GuC
submission which is default on RPL-S but
was not the case with ADL-S.
All patches are reviewed. Jani has acked the series.
Looking for other acks in order to merge these to
respective branches.
Cc: x86@kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Anusha Srivatsa (3):
drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
drm/i915/rpl-s: Add PCH Support for Raptor Lake S
drm/i915/rpl-s: Enable guc submission by default
arch/x86/kernel/early-quirks.c | 1 +
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/i915_pci.c | 1 +
drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
drivers/gpu/drm/i915/intel_device_info.h | 3 +++
drivers/gpu/drm/i915/intel_pch.c | 1 +
drivers/gpu/drm/i915/intel_pch.h | 1 +
include/drm/i915_pciids.h | 9 +++++++++
9 files changed, 26 insertions(+), 1 deletion(-)
--
2.25.1
^ permalink raw reply [flat|nested] 23+ messages in thread
* [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
@ 2021-12-03 6:35 ` Anusha Srivatsa
-1 siblings, 0 replies; 23+ messages in thread
From: Anusha Srivatsa @ 2021-12-03 6:35 UTC (permalink / raw)
To: intel-gfx
Cc: Tvrtko Ursulin, Anusha Srivatsa, José Roberto de Souza, x86,
dri-devel, Dave Hansen, Ingo Molnar, Borislav Petkov
Raptor Lake S(RPL-S) is a version 12
Display, Media and Render. For all i915
purposes it is the same as Alder Lake S (ADL-S).
Introduce RPL-S as a subplatform
of ADL-S. This patch adds PCI ids for RPL-S.
v2: Update PCI IDs.
- Add more description to commit message (Jani)
v3: s/IS_RAPTORLAKE/IS_ADLS_RPLS (Jani)
- Fix comment (Tvrtko)
BSpec: 53655
Cc: x86@kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
arch/x86/kernel/early-quirks.c | 1 +
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/i915_pci.c | 1 +
drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
drivers/gpu/drm/i915/intel_device_info.h | 3 +++
include/drm/i915_pciids.h | 9 +++++++++
6 files changed, 23 insertions(+)
diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 391a4e2b8604..fd2d3ab38ebb 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
INTEL_RKL_IDS(&gen11_early_ops),
INTEL_ADLS_IDS(&gen11_early_ops),
INTEL_ADLP_IDS(&gen11_early_ops),
+ INTEL_RPLS_IDS(&gen11_early_ops),
};
struct resource intel_graphics_stolen_res __ro_after_init = DEFINE_RES_MEM(0, 0);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 7e1192aeef90..fe36d0f5da67 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1469,6 +1469,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G10)
#define IS_DG2_G11(dev_priv) \
IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
+#define IS_ADLS_RPLS(dev_priv) \
+ IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
#define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
(INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
#define IS_BDW_ULT(dev_priv) \
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index f01cba4ec283..061b2e076373 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -1131,6 +1131,7 @@ static const struct pci_device_id pciidlist[] = {
INTEL_ADLS_IDS(&adl_s_info),
INTEL_ADLP_IDS(&adl_p_info),
INTEL_DG1_IDS(&dg1_info),
+ INTEL_RPLS_IDS(&adl_s_info),
{0, 0, 0}
};
MODULE_DEVICE_TABLE(pci, pciidlist);
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index e6605b5181a5..a3446a2abcb2 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
INTEL_ICL_PORT_F_IDS(0),
};
+static const u16 subplatform_rpls_ids[] = {
+ INTEL_RPLS_IDS(0),
+};
+
static bool find_devid(u16 id, const u16 *p, unsigned int num)
{
for (; num; num--, p++) {
@@ -206,6 +210,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
} else if (find_devid(devid, subplatform_portf_ids,
ARRAY_SIZE(subplatform_portf_ids))) {
mask = BIT(INTEL_SUBPLATFORM_PORTF);
+ } else if (find_devid(devid, subplatform_rpls_ids,
+ ARRAY_SIZE(subplatform_rpls_ids))) {
+ mask = BIT(INTEL_SUBPLATFORM_RPL_S);
}
if (IS_TIGERLAKE(i915)) {
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 669f0d26c3c3..2bedf73e0a7d 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -110,6 +110,9 @@ enum intel_platform {
#define INTEL_SUBPLATFORM_G10 0
#define INTEL_SUBPLATFORM_G11 1
+/* ADL-S */
+#define INTEL_SUBPLATFORM_RPL_S 0
+
enum intel_ppgtt_type {
INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index c00ac54692d7..baf3d1d3d566 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -666,4 +666,13 @@
INTEL_VGA_DEVICE(0x46C2, info), \
INTEL_VGA_DEVICE(0x46C3, info)
+/* RPL-S */
+#define INTEL_RPLS_IDS(info) \
+ INTEL_VGA_DEVICE(0xA780, info), \
+ INTEL_VGA_DEVICE(0xA781, info), \
+ INTEL_VGA_DEVICE(0xA782, info), \
+ INTEL_VGA_DEVICE(0xA783, info), \
+ INTEL_VGA_DEVICE(0xA788, info), \
+ INTEL_VGA_DEVICE(0xA789, info)
+
#endif /* _I915_PCIIDS_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Intel-gfx] [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
@ 2021-12-03 6:35 ` Anusha Srivatsa
0 siblings, 0 replies; 23+ messages in thread
From: Anusha Srivatsa @ 2021-12-03 6:35 UTC (permalink / raw)
To: intel-gfx; +Cc: x86, dri-devel, Dave Hansen, Ingo Molnar, Borislav Petkov
Raptor Lake S(RPL-S) is a version 12
Display, Media and Render. For all i915
purposes it is the same as Alder Lake S (ADL-S).
Introduce RPL-S as a subplatform
of ADL-S. This patch adds PCI ids for RPL-S.
v2: Update PCI IDs.
- Add more description to commit message (Jani)
v3: s/IS_RAPTORLAKE/IS_ADLS_RPLS (Jani)
- Fix comment (Tvrtko)
BSpec: 53655
Cc: x86@kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
arch/x86/kernel/early-quirks.c | 1 +
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/i915_pci.c | 1 +
drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
drivers/gpu/drm/i915/intel_device_info.h | 3 +++
include/drm/i915_pciids.h | 9 +++++++++
6 files changed, 23 insertions(+)
diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 391a4e2b8604..fd2d3ab38ebb 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
INTEL_RKL_IDS(&gen11_early_ops),
INTEL_ADLS_IDS(&gen11_early_ops),
INTEL_ADLP_IDS(&gen11_early_ops),
+ INTEL_RPLS_IDS(&gen11_early_ops),
};
struct resource intel_graphics_stolen_res __ro_after_init = DEFINE_RES_MEM(0, 0);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 7e1192aeef90..fe36d0f5da67 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1469,6 +1469,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G10)
#define IS_DG2_G11(dev_priv) \
IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)
+#define IS_ADLS_RPLS(dev_priv) \
+ IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL_S)
#define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
(INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
#define IS_BDW_ULT(dev_priv) \
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index f01cba4ec283..061b2e076373 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -1131,6 +1131,7 @@ static const struct pci_device_id pciidlist[] = {
INTEL_ADLS_IDS(&adl_s_info),
INTEL_ADLP_IDS(&adl_p_info),
INTEL_DG1_IDS(&dg1_info),
+ INTEL_RPLS_IDS(&adl_s_info),
{0, 0, 0}
};
MODULE_DEVICE_TABLE(pci, pciidlist);
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index e6605b5181a5..a3446a2abcb2 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -170,6 +170,10 @@ static const u16 subplatform_portf_ids[] = {
INTEL_ICL_PORT_F_IDS(0),
};
+static const u16 subplatform_rpls_ids[] = {
+ INTEL_RPLS_IDS(0),
+};
+
static bool find_devid(u16 id, const u16 *p, unsigned int num)
{
for (; num; num--, p++) {
@@ -206,6 +210,9 @@ void intel_device_info_subplatform_init(struct drm_i915_private *i915)
} else if (find_devid(devid, subplatform_portf_ids,
ARRAY_SIZE(subplatform_portf_ids))) {
mask = BIT(INTEL_SUBPLATFORM_PORTF);
+ } else if (find_devid(devid, subplatform_rpls_ids,
+ ARRAY_SIZE(subplatform_rpls_ids))) {
+ mask = BIT(INTEL_SUBPLATFORM_RPL_S);
}
if (IS_TIGERLAKE(i915)) {
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 669f0d26c3c3..2bedf73e0a7d 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -110,6 +110,9 @@ enum intel_platform {
#define INTEL_SUBPLATFORM_G10 0
#define INTEL_SUBPLATFORM_G11 1
+/* ADL-S */
+#define INTEL_SUBPLATFORM_RPL_S 0
+
enum intel_ppgtt_type {
INTEL_PPGTT_NONE = I915_GEM_PPGTT_NONE,
INTEL_PPGTT_ALIASING = I915_GEM_PPGTT_ALIASING,
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index c00ac54692d7..baf3d1d3d566 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -666,4 +666,13 @@
INTEL_VGA_DEVICE(0x46C2, info), \
INTEL_VGA_DEVICE(0x46C3, info)
+/* RPL-S */
+#define INTEL_RPLS_IDS(info) \
+ INTEL_VGA_DEVICE(0xA780, info), \
+ INTEL_VGA_DEVICE(0xA781, info), \
+ INTEL_VGA_DEVICE(0xA782, info), \
+ INTEL_VGA_DEVICE(0xA783, info), \
+ INTEL_VGA_DEVICE(0xA788, info), \
+ INTEL_VGA_DEVICE(0xA789, info)
+
#endif /* _I915_PCIIDS_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
@ 2021-12-08 20:56 ` Dave Hansen
-1 siblings, 0 replies; 23+ messages in thread
From: Dave Hansen @ 2021-12-08 20:56 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx
Cc: Tvrtko Ursulin, Dave Hansen, x86, dri-devel, Ingo Molnar,
Borislav Petkov, José Roberto de Souza
On 12/2/21 10:35 PM, Anusha Srivatsa wrote:
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 391a4e2b8604..fd2d3ab38ebb 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_RKL_IDS(&gen11_early_ops),
> INTEL_ADLS_IDS(&gen11_early_ops),
> INTEL_ADLP_IDS(&gen11_early_ops),
> + INTEL_RPLS_IDS(&gen11_early_ops),
> };
For arch/x86 purposes:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
@ 2021-12-08 20:56 ` Dave Hansen
0 siblings, 0 replies; 23+ messages in thread
From: Dave Hansen @ 2021-12-08 20:56 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx
Cc: Dave Hansen, x86, dri-devel, Ingo Molnar, Borislav Petkov
On 12/2/21 10:35 PM, Anusha Srivatsa wrote:
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 391a4e2b8604..fd2d3ab38ebb 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_RKL_IDS(&gen11_early_ops),
> INTEL_ADLS_IDS(&gen11_early_ops),
> INTEL_ADLP_IDS(&gen11_early_ops),
> + INTEL_RPLS_IDS(&gen11_early_ops),
> };
For arch/x86 purposes:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
2021-12-08 20:56 ` [Intel-gfx] " Dave Hansen
@ 2021-12-09 10:14 ` Srivatsa, Anusha
-1 siblings, 0 replies; 23+ messages in thread
From: Srivatsa, Anusha @ 2021-12-09 10:14 UTC (permalink / raw)
To: Hansen, Dave, intel-gfx
Cc: Dave Hansen, x86, dri-devel, Ingo Molnar, Borislav Petkov
> -----Original Message-----
> From: Hansen, Dave <dave.hansen@intel.com>
> Sent: Thursday, December 9, 2021 2:27 AM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Tvrtko Ursulin
> <tvrtko.ursulin@linux.intel.com>; Roper, Matthew D
> <matthew.d.roper@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>;
> Souza, Jose <jose.souza@intel.com>
> Subject: Re: [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
>
> On 12/2/21 10:35 PM, Anusha Srivatsa wrote:
> > diff --git a/arch/x86/kernel/early-quirks.c
> > b/arch/x86/kernel/early-quirks.c index 391a4e2b8604..fd2d3ab38ebb
> > 100644
> > --- a/arch/x86/kernel/early-quirks.c
> > +++ b/arch/x86/kernel/early-quirks.c
> > @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[]
> __initconst = {
> > INTEL_RKL_IDS(&gen11_early_ops),
> > INTEL_ADLS_IDS(&gen11_early_ops),
> > INTEL_ADLP_IDS(&gen11_early_ops),
> > + INTEL_RPLS_IDS(&gen11_early_ops),
> > };
>
> For arch/x86 purposes:
>
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Thanks for the ack!
Anusha
^ permalink raw reply [flat|nested] 23+ messages in thread* RE: [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
@ 2021-12-09 10:14 ` Srivatsa, Anusha
0 siblings, 0 replies; 23+ messages in thread
From: Srivatsa, Anusha @ 2021-12-09 10:14 UTC (permalink / raw)
To: Hansen, Dave, intel-gfx
Cc: Tvrtko Ursulin, Dave Hansen, x86, dri-devel, Ingo Molnar,
Borislav Petkov, Souza, Jose
> -----Original Message-----
> From: Hansen, Dave <dave.hansen@intel.com>
> Sent: Thursday, December 9, 2021 2:27 AM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Tvrtko Ursulin
> <tvrtko.ursulin@linux.intel.com>; Roper, Matthew D
> <matthew.d.roper@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>;
> Souza, Jose <jose.souza@intel.com>
> Subject: Re: [v3 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
>
> On 12/2/21 10:35 PM, Anusha Srivatsa wrote:
> > diff --git a/arch/x86/kernel/early-quirks.c
> > b/arch/x86/kernel/early-quirks.c index 391a4e2b8604..fd2d3ab38ebb
> > 100644
> > --- a/arch/x86/kernel/early-quirks.c
> > +++ b/arch/x86/kernel/early-quirks.c
> > @@ -554,6 +554,7 @@ static const struct pci_device_id intel_early_ids[]
> __initconst = {
> > INTEL_RKL_IDS(&gen11_early_ops),
> > INTEL_ADLS_IDS(&gen11_early_ops),
> > INTEL_ADLP_IDS(&gen11_early_ops),
> > + INTEL_RPLS_IDS(&gen11_early_ops),
> > };
>
> For arch/x86 purposes:
>
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Thanks for the ack!
Anusha
^ permalink raw reply [flat|nested] 23+ messages in thread
* [v3 2/3] drm/i915/rpl-s: Add PCH Support for Raptor Lake S
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
@ 2021-12-03 6:35 ` Anusha Srivatsa
-1 siblings, 0 replies; 23+ messages in thread
From: Anusha Srivatsa @ 2021-12-03 6:35 UTC (permalink / raw)
To: intel-gfx
Cc: Tvrtko Ursulin, Anusha Srivatsa, dri-devel, José Roberto de Souza
Add the PCH ID for RPL-S.
v2: Self contained commit message (Jani)
Cc: dri-devel@lists.freedesktop.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/intel_pch.c | 1 +
drivers/gpu/drm/i915/intel_pch.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
index d1d4b97b86f5..da8f82c2342f 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -129,6 +129,7 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
return PCH_JSP;
case INTEL_PCH_ADP_DEVICE_ID_TYPE:
case INTEL_PCH_ADP2_DEVICE_ID_TYPE:
+ case INTEL_PCH_ADP3_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found Alder Lake PCH\n");
drm_WARN_ON(&dev_priv->drm, !IS_ALDERLAKE_S(dev_priv) &&
!IS_ALDERLAKE_P(dev_priv));
diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
index 7c0d83d292dc..6bff77521094 100644
--- a/drivers/gpu/drm/i915/intel_pch.h
+++ b/drivers/gpu/drm/i915/intel_pch.h
@@ -57,6 +57,7 @@ enum intel_pch {
#define INTEL_PCH_JSP2_DEVICE_ID_TYPE 0x3880
#define INTEL_PCH_ADP_DEVICE_ID_TYPE 0x7A80
#define INTEL_PCH_ADP2_DEVICE_ID_TYPE 0x5180
+#define INTEL_PCH_ADP3_DEVICE_ID_TYPE 0x7A00
#define INTEL_PCH_P2X_DEVICE_ID_TYPE 0x7100
#define INTEL_PCH_P3X_DEVICE_ID_TYPE 0x7000
#define INTEL_PCH_QEMU_DEVICE_ID_TYPE 0x2900 /* qemu q35 has 2918 */
--
2.25.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Intel-gfx] [v3 2/3] drm/i915/rpl-s: Add PCH Support for Raptor Lake S
@ 2021-12-03 6:35 ` Anusha Srivatsa
0 siblings, 0 replies; 23+ messages in thread
From: Anusha Srivatsa @ 2021-12-03 6:35 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Add the PCH ID for RPL-S.
v2: Self contained commit message (Jani)
Cc: dri-devel@lists.freedesktop.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/intel_pch.c | 1 +
drivers/gpu/drm/i915/intel_pch.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
index d1d4b97b86f5..da8f82c2342f 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -129,6 +129,7 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
return PCH_JSP;
case INTEL_PCH_ADP_DEVICE_ID_TYPE:
case INTEL_PCH_ADP2_DEVICE_ID_TYPE:
+ case INTEL_PCH_ADP3_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found Alder Lake PCH\n");
drm_WARN_ON(&dev_priv->drm, !IS_ALDERLAKE_S(dev_priv) &&
!IS_ALDERLAKE_P(dev_priv));
diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
index 7c0d83d292dc..6bff77521094 100644
--- a/drivers/gpu/drm/i915/intel_pch.h
+++ b/drivers/gpu/drm/i915/intel_pch.h
@@ -57,6 +57,7 @@ enum intel_pch {
#define INTEL_PCH_JSP2_DEVICE_ID_TYPE 0x3880
#define INTEL_PCH_ADP_DEVICE_ID_TYPE 0x7A80
#define INTEL_PCH_ADP2_DEVICE_ID_TYPE 0x5180
+#define INTEL_PCH_ADP3_DEVICE_ID_TYPE 0x7A00
#define INTEL_PCH_P2X_DEVICE_ID_TYPE 0x7100
#define INTEL_PCH_P3X_DEVICE_ID_TYPE 0x7000
#define INTEL_PCH_QEMU_DEVICE_ID_TYPE 0x2900 /* qemu q35 has 2918 */
--
2.25.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [v3 3/3] drm/i915/rpl-s: Enable guc submission by default
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
@ 2021-12-03 6:35 ` Anusha Srivatsa
-1 siblings, 0 replies; 23+ messages in thread
From: Anusha Srivatsa @ 2021-12-03 6:35 UTC (permalink / raw)
To: intel-gfx
Cc: Tvrtko Ursulin, Anusha Srivatsa, dri-devel, José Roberto de Souza
Though, RPL-S is defined as subplatform of ADL-S, unlike
ADL-S, it has GuC submission by default.
v2: Remove extra parenthesis (Jani)
v3: s/IS_RAPTORLAKE/IS_ADLS_RPLS (Jani)
Cc: dri-devel@lists.freedesktop.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 2fef3b0bbe95..8f17005ce85f 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -35,7 +35,7 @@ static void uc_expand_default_options(struct intel_uc *uc)
}
/* Intermediate platforms are HuC authentication only */
- if (IS_ALDERLAKE_S(i915)) {
+ if (IS_ALDERLAKE_S(i915) && !IS_ADLS_RPLS(i915)) {
i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
return;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Intel-gfx] [v3 3/3] drm/i915/rpl-s: Enable guc submission by default
@ 2021-12-03 6:35 ` Anusha Srivatsa
0 siblings, 0 replies; 23+ messages in thread
From: Anusha Srivatsa @ 2021-12-03 6:35 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Though, RPL-S is defined as subplatform of ADL-S, unlike
ADL-S, it has GuC submission by default.
v2: Remove extra parenthesis (Jani)
v3: s/IS_RAPTORLAKE/IS_ADLS_RPLS (Jani)
Cc: dri-devel@lists.freedesktop.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 2fef3b0bbe95..8f17005ce85f 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -35,7 +35,7 @@ static void uc_expand_default_options(struct intel_uc *uc)
}
/* Intermediate platforms are HuC authentication only */
- if (IS_ALDERLAKE_S(i915)) {
+ if (IS_ALDERLAKE_S(i915) && !IS_ADLS_RPLS(i915)) {
i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
return;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce Raptor Lake S (rev5)
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
` (3 preceding siblings ...)
(?)
@ 2021-12-03 8:25 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2021-12-03 8:25 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: Introduce Raptor Lake S (rev5)
URL : https://patchwork.freedesktop.org/series/96869/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
42dde2f80fd1 drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
-:121: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#121: FILE: include/drm/i915_pciids.h:670:
+#define INTEL_RPLS_IDS(info) \
+ INTEL_VGA_DEVICE(0xA780, info), \
+ INTEL_VGA_DEVICE(0xA781, info), \
+ INTEL_VGA_DEVICE(0xA782, info), \
+ INTEL_VGA_DEVICE(0xA783, info), \
+ INTEL_VGA_DEVICE(0xA788, info), \
+ INTEL_VGA_DEVICE(0xA789, info)
-:121: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#121: FILE: include/drm/i915_pciids.h:670:
+#define INTEL_RPLS_IDS(info) \
+ INTEL_VGA_DEVICE(0xA780, info), \
+ INTEL_VGA_DEVICE(0xA781, info), \
+ INTEL_VGA_DEVICE(0xA782, info), \
+ INTEL_VGA_DEVICE(0xA783, info), \
+ INTEL_VGA_DEVICE(0xA788, info), \
+ INTEL_VGA_DEVICE(0xA789, info)
total: 1 errors, 0 warnings, 1 checks, 63 lines checked
27dc80d16a61 drm/i915/rpl-s: Add PCH Support for Raptor Lake S
1bc48ab1e321 drm/i915/rpl-s: Enable guc submission by default
^ permalink raw reply [flat|nested] 23+ messages in thread* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce Raptor Lake S (rev5)
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
` (4 preceding siblings ...)
(?)
@ 2021-12-03 8:27 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2021-12-03 8:27 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: Introduce Raptor Lake S (rev5)
URL : https://patchwork.freedesktop.org/series/96869/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 23+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce Raptor Lake S (rev5)
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
` (5 preceding siblings ...)
(?)
@ 2021-12-03 8:53 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2021-12-03 8:53 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5548 bytes --]
== Series Details ==
Series: Introduce Raptor Lake S (rev5)
URL : https://patchwork.freedesktop.org/series/96869/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10958 -> Patchwork_21738
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21738 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21738, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/index.html
Participating hosts (39 -> 32)
------------------------------
Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-pnv-d510 bat-jsl-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21738:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/fi-bxt-dsi/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-bxt-dsi/igt@i915_selftest@live@execlists.html
Known issues
------------
Here are the changes found in Patchwork_21738 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
* igt@gem_exec_suspend@basic-s3:
- fi-skl-6600u: [PASS][5] -> [INCOMPLETE][6] ([i915#4547])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-skl-6600u/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@gt_contexts:
- fi-snb-2520m: [PASS][7] -> [DMESG-FAIL][8] ([i915#4610])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-snb-2520m/igt@i915_selftest@live@gt_contexts.html
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-n3050: [PASS][9] -> [DMESG-FAIL][10] ([i915#2927] / [i915#3428])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10958/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][11] ([i915#2722] / [i915#3363] / [i915#4312])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-skl-6600u/igt@runner@aborted.html
- fi-snb-2520m: NOTRUN -> [FAIL][12] ([i915#2426] / [i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-snb-2520m/igt@runner@aborted.html
- fi-bxt-dsi: NOTRUN -> [FAIL][13] ([i915#2722] / [i915#3363] / [i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-bxt-dsi/igt@runner@aborted.html
- fi-bsw-n3050: NOTRUN -> [FAIL][14] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/fi-bsw-n3050/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4610]: https://gitlab.freedesktop.org/drm/intel/issues/4610
Build changes
-------------
* Linux: CI_DRM_10958 -> Patchwork_21738
CI-20190529: 20190529
CI_DRM_10958: df70f2f759f511a174efaf65212bf005fc259be9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6299: 0933b7ccdb2bb054b6a8154171e35315d84299b7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21738: 1bc48ab1e3213c92ee29d1bea8ca0911249a465e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1bc48ab1e321 drm/i915/rpl-s: Enable guc submission by default
27dc80d16a61 drm/i915/rpl-s: Add PCH Support for Raptor Lake S
42dde2f80fd1 drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21738/index.html
[-- Attachment #2: Type: text/html, Size: 6474 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [v3 0/3] Introduce Raptor Lake S
2021-12-03 6:35 ` [Intel-gfx] " Anusha Srivatsa
@ 2021-12-03 9:27 ` Tvrtko Ursulin
-1 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2021-12-03 9:27 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx
Cc: Dave Hansen, Jani Nikula, x86, dri-devel, Ingo Molnar, Borislav Petkov
On 03/12/2021 06:35, Anusha Srivatsa wrote:
> Raptor Lake S(RPL-S) is a version 12
> Display, Media and Render. For all i915
> purposes it is the same as Alder Lake S (ADL-S).
>
> The series introduces it as a subplatform
> of ADL-S. The one difference is the GuC
> submission which is default on RPL-S but
> was not the case with ADL-S.
As a side note, not a blocker of any kind, I am slightly disheartened
but the confusion of ADL_P and ADL_S being separate platforms, but then
RPL_S is subplatform of ADL_S. Maybe it is just me not being able to
keep track of things.
> All patches are reviewed. Jani has acked the series.
> Looking for other acks in order to merge these to
> respective branches.
Which branches would that be for this series? First two to
drm-intel-next and last one to drm-intel-gt-next? Is that complication
needed and/or worth the effort?
Regards,
Tvrtko
> Cc: x86@kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> Anusha Srivatsa (3):
> drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> drm/i915/rpl-s: Enable guc submission by default
>
> arch/x86/kernel/early-quirks.c | 1 +
> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> drivers/gpu/drm/i915/intel_pch.c | 1 +
> drivers/gpu/drm/i915/intel_pch.h | 1 +
> include/drm/i915_pciids.h | 9 +++++++++
> 9 files changed, 26 insertions(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S
@ 2021-12-03 9:27 ` Tvrtko Ursulin
0 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2021-12-03 9:27 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx
Cc: Dave Hansen, Jani Nikula, x86, dri-devel, Ingo Molnar, Borislav Petkov
On 03/12/2021 06:35, Anusha Srivatsa wrote:
> Raptor Lake S(RPL-S) is a version 12
> Display, Media and Render. For all i915
> purposes it is the same as Alder Lake S (ADL-S).
>
> The series introduces it as a subplatform
> of ADL-S. The one difference is the GuC
> submission which is default on RPL-S but
> was not the case with ADL-S.
As a side note, not a blocker of any kind, I am slightly disheartened
but the confusion of ADL_P and ADL_S being separate platforms, but then
RPL_S is subplatform of ADL_S. Maybe it is just me not being able to
keep track of things.
> All patches are reviewed. Jani has acked the series.
> Looking for other acks in order to merge these to
> respective branches.
Which branches would that be for this series? First two to
drm-intel-next and last one to drm-intel-gt-next? Is that complication
needed and/or worth the effort?
Regards,
Tvrtko
> Cc: x86@kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> Anusha Srivatsa (3):
> drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> drm/i915/rpl-s: Enable guc submission by default
>
> arch/x86/kernel/early-quirks.c | 1 +
> drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> drivers/gpu/drm/i915/intel_pch.c | 1 +
> drivers/gpu/drm/i915/intel_pch.h | 1 +
> include/drm/i915_pciids.h | 9 +++++++++
> 9 files changed, 26 insertions(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [v3 0/3] Introduce Raptor Lake S
2021-12-03 9:27 ` [Intel-gfx] " Tvrtko Ursulin
@ 2021-12-06 4:29 ` Srivatsa, Anusha
-1 siblings, 0 replies; 23+ messages in thread
From: Srivatsa, Anusha @ 2021-12-06 4:29 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
Cc: Dave Hansen, Nikula, Jani, x86, dri-devel, Ingo Molnar, Borislav Petkov
> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: Friday, December 3, 2021 2:57 PM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: Re: [v3 0/3] Introduce Raptor Lake S
>
>
> On 03/12/2021 06:35, Anusha Srivatsa wrote:
> > Raptor Lake S(RPL-S) is a version 12
> > Display, Media and Render. For all i915 purposes it is the same as
> > Alder Lake S (ADL-S).
> >
> > The series introduces it as a subplatform of ADL-S. The one difference
> > is the GuC submission which is default on RPL-S but was not the case
> > with ADL-S.
>
> As a side note, not a blocker of any kind, I am slightly disheartened but the
> confusion of ADL_P and ADL_S being separate platforms, but then RPL_S is
> subplatform of ADL_S. Maybe it is just me not being able to keep track of
> things.
>
> > All patches are reviewed. Jani has acked the series.
> > Looking for other acks in order to merge these to respective branches.
>
> Which branches would that be for this series? First two to drm-intel-next and
> last one to drm-intel-gt-next? Is that complication needed and/or worth the
> effort?
Tvrtko,
All three have to land to drm-intel-next. The last one has dependency on the first patch and is a trivial change.
Anusha
> Regards,
>
> Tvrtko
>
> > Cc: x86@kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Anusha Srivatsa (3):
> > drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> > drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> > drm/i915/rpl-s: Enable guc submission by default
> >
> > arch/x86/kernel/early-quirks.c | 1 +
> > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > drivers/gpu/drm/i915/i915_pci.c | 1 +
> > drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > drivers/gpu/drm/i915/intel_pch.c | 1 +
> > drivers/gpu/drm/i915/intel_pch.h | 1 +
> > include/drm/i915_pciids.h | 9 +++++++++
> > 9 files changed, 26 insertions(+), 1 deletion(-)
> >
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S
@ 2021-12-06 4:29 ` Srivatsa, Anusha
0 siblings, 0 replies; 23+ messages in thread
From: Srivatsa, Anusha @ 2021-12-06 4:29 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
Cc: Dave Hansen, Nikula, Jani, x86, dri-devel, Ingo Molnar, Borislav Petkov
> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: Friday, December 3, 2021 2:57 PM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: Re: [v3 0/3] Introduce Raptor Lake S
>
>
> On 03/12/2021 06:35, Anusha Srivatsa wrote:
> > Raptor Lake S(RPL-S) is a version 12
> > Display, Media and Render. For all i915 purposes it is the same as
> > Alder Lake S (ADL-S).
> >
> > The series introduces it as a subplatform of ADL-S. The one difference
> > is the GuC submission which is default on RPL-S but was not the case
> > with ADL-S.
>
> As a side note, not a blocker of any kind, I am slightly disheartened but the
> confusion of ADL_P and ADL_S being separate platforms, but then RPL_S is
> subplatform of ADL_S. Maybe it is just me not being able to keep track of
> things.
>
> > All patches are reviewed. Jani has acked the series.
> > Looking for other acks in order to merge these to respective branches.
>
> Which branches would that be for this series? First two to drm-intel-next and
> last one to drm-intel-gt-next? Is that complication needed and/or worth the
> effort?
Tvrtko,
All three have to land to drm-intel-next. The last one has dependency on the first patch and is a trivial change.
Anusha
> Regards,
>
> Tvrtko
>
> > Cc: x86@kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Anusha Srivatsa (3):
> > drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> > drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> > drm/i915/rpl-s: Enable guc submission by default
> >
> > arch/x86/kernel/early-quirks.c | 1 +
> > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > drivers/gpu/drm/i915/i915_pci.c | 1 +
> > drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > drivers/gpu/drm/i915/intel_pch.c | 1 +
> > drivers/gpu/drm/i915/intel_pch.h | 1 +
> > include/drm/i915_pciids.h | 9 +++++++++
> > 9 files changed, 26 insertions(+), 1 deletion(-)
> >
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [v3 0/3] Introduce Raptor Lake S
2021-12-06 4:29 ` [Intel-gfx] " Srivatsa, Anusha
@ 2021-12-07 9:53 ` Srivatsa, Anusha
-1 siblings, 0 replies; 23+ messages in thread
From: Srivatsa, Anusha @ 2021-12-07 9:53 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx, Joonas Lahtinen, Ursulin, Tvrtko
Cc: x86, Nikula, Jani, Dave Hansen, dri-devel, Ingo Molnar, Borislav Petkov
> -----Original Message-----
> From: Srivatsa, Anusha
> Sent: Monday, December 6, 2021 9:59 AM
> To: 'Tvrtko Ursulin' <tvrtko.ursulin@linux.intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [v3 0/3] Introduce Raptor Lake S
>
>
>
> > -----Original Message-----
> > From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Sent: Friday, December 3, 2021 2:57 PM
> > To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> > <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> > <dave.hansen@linux.intel.com>; Joonas Lahtinen
> > <joonas.lahtinen@linux.intel.com>; Nikula, Jani
> > <jani.nikula@intel.com>
> > Subject: Re: [v3 0/3] Introduce Raptor Lake S
> >
> >
> > On 03/12/2021 06:35, Anusha Srivatsa wrote:
> > > Raptor Lake S(RPL-S) is a version 12 Display, Media and Render. For
> > > all i915 purposes it is the same as Alder Lake S (ADL-S).
> > >
> > > The series introduces it as a subplatform of ADL-S. The one
> > > difference is the GuC submission which is default on RPL-S but was
> > > not the case with ADL-S.
> >
> > As a side note, not a blocker of any kind, I am slightly disheartened
> > but the confusion of ADL_P and ADL_S being separate platforms, but
> > then RPL_S is subplatform of ADL_S. Maybe it is just me not being able
> > to keep track of things.
> >
> > > All patches are reviewed. Jani has acked the series.
> > > Looking for other acks in order to merge these to respective branches.
> >
> > Which branches would that be for this series? First two to
> > drm-intel-next and last one to drm-intel-gt-next? Is that complication
> > needed and/or worth the effort?
>
> Tvrtko,
> All three have to land to drm-intel-next. The last one has dependency on the
> first patch and is a trivial change.
@Ursulin, Tvrtko @Joonas Lahtinen can I get an ack to merge these into drm-intel-next branch?
Anusha
> Anusha
> > Regards,
> >
> > Tvrtko
> >
> > > Cc: x86@kernel.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Ingo Molnar <mingo@redhat.com>
> > > Cc: Borislav Petkov <bp@alien8.de>
> > > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > >
> > > Anusha Srivatsa (3):
> > > drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> > > drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> > > drm/i915/rpl-s: Enable guc submission by default
> > >
> > > arch/x86/kernel/early-quirks.c | 1 +
> > > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> > > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > > drivers/gpu/drm/i915/i915_pci.c | 1 +
> > > drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > > drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > > drivers/gpu/drm/i915/intel_pch.c | 1 +
> > > drivers/gpu/drm/i915/intel_pch.h | 1 +
> > > include/drm/i915_pciids.h | 9 +++++++++
> > > 9 files changed, 26 insertions(+), 1 deletion(-)
> > >
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S
@ 2021-12-07 9:53 ` Srivatsa, Anusha
0 siblings, 0 replies; 23+ messages in thread
From: Srivatsa, Anusha @ 2021-12-07 9:53 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx, Joonas Lahtinen, Ursulin, Tvrtko
Cc: x86, Nikula, Jani, Dave Hansen, dri-devel, Ingo Molnar, Borislav Petkov
> -----Original Message-----
> From: Srivatsa, Anusha
> Sent: Monday, December 6, 2021 9:59 AM
> To: 'Tvrtko Ursulin' <tvrtko.ursulin@linux.intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [v3 0/3] Introduce Raptor Lake S
>
>
>
> > -----Original Message-----
> > From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Sent: Friday, December 3, 2021 2:57 PM
> > To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> > <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> > <dave.hansen@linux.intel.com>; Joonas Lahtinen
> > <joonas.lahtinen@linux.intel.com>; Nikula, Jani
> > <jani.nikula@intel.com>
> > Subject: Re: [v3 0/3] Introduce Raptor Lake S
> >
> >
> > On 03/12/2021 06:35, Anusha Srivatsa wrote:
> > > Raptor Lake S(RPL-S) is a version 12 Display, Media and Render. For
> > > all i915 purposes it is the same as Alder Lake S (ADL-S).
> > >
> > > The series introduces it as a subplatform of ADL-S. The one
> > > difference is the GuC submission which is default on RPL-S but was
> > > not the case with ADL-S.
> >
> > As a side note, not a blocker of any kind, I am slightly disheartened
> > but the confusion of ADL_P and ADL_S being separate platforms, but
> > then RPL_S is subplatform of ADL_S. Maybe it is just me not being able
> > to keep track of things.
> >
> > > All patches are reviewed. Jani has acked the series.
> > > Looking for other acks in order to merge these to respective branches.
> >
> > Which branches would that be for this series? First two to
> > drm-intel-next and last one to drm-intel-gt-next? Is that complication
> > needed and/or worth the effort?
>
> Tvrtko,
> All three have to land to drm-intel-next. The last one has dependency on the
> first patch and is a trivial change.
@Ursulin, Tvrtko @Joonas Lahtinen can I get an ack to merge these into drm-intel-next branch?
Anusha
> Anusha
> > Regards,
> >
> > Tvrtko
> >
> > > Cc: x86@kernel.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Ingo Molnar <mingo@redhat.com>
> > > Cc: Borislav Petkov <bp@alien8.de>
> > > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > >
> > > Anusha Srivatsa (3):
> > > drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> > > drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> > > drm/i915/rpl-s: Enable guc submission by default
> > >
> > > arch/x86/kernel/early-quirks.c | 1 +
> > > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
> > > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > > drivers/gpu/drm/i915/i915_pci.c | 1 +
> > > drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > > drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > > drivers/gpu/drm/i915/intel_pch.c | 1 +
> > > drivers/gpu/drm/i915/intel_pch.h | 1 +
> > > include/drm/i915_pciids.h | 9 +++++++++
> > > 9 files changed, 26 insertions(+), 1 deletion(-)
> > >
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [v3 0/3] Introduce Raptor Lake S
2021-12-06 4:29 ` [Intel-gfx] " Srivatsa, Anusha
@ 2021-12-08 9:52 ` Tvrtko Ursulin
-1 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2021-12-08 9:52 UTC (permalink / raw)
To: Srivatsa, Anusha, intel-gfx
Cc: Dave Hansen, Nikula, Jani, x86, dri-devel, Ingo Molnar, Borislav Petkov
On 06/12/2021 04:29, Srivatsa, Anusha wrote:
>> -----Original Message-----
>> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Sent: Friday, December 3, 2021 2:57 PM
>> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
>> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
>> <dave.hansen@linux.intel.com>; Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
>> Subject: Re: [v3 0/3] Introduce Raptor Lake S
>>
>>
>> On 03/12/2021 06:35, Anusha Srivatsa wrote:
>>> Raptor Lake S(RPL-S) is a version 12
>>> Display, Media and Render. For all i915 purposes it is the same as
>>> Alder Lake S (ADL-S).
>>>
>>> The series introduces it as a subplatform of ADL-S. The one difference
>>> is the GuC submission which is default on RPL-S but was not the case
>>> with ADL-S.
>>
>> As a side note, not a blocker of any kind, I am slightly disheartened but the
>> confusion of ADL_P and ADL_S being separate platforms, but then RPL_S is
>> subplatform of ADL_S. Maybe it is just me not being able to keep track of
>> things.
>>
>>> All patches are reviewed. Jani has acked the series.
>>> Looking for other acks in order to merge these to respective branches.
>>
>> Which branches would that be for this series? First two to drm-intel-next and
>> last one to drm-intel-gt-next? Is that complication needed and/or worth the
>> effort?
>
> Tvrtko,
> All three have to land to drm-intel-next. The last one has dependency on the first patch and is a trivial change.
One more ack for a good measure:
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S
@ 2021-12-08 9:52 ` Tvrtko Ursulin
0 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2021-12-08 9:52 UTC (permalink / raw)
To: Srivatsa, Anusha, intel-gfx
Cc: Dave Hansen, Nikula, Jani, x86, dri-devel, Ingo Molnar, Borislav Petkov
On 06/12/2021 04:29, Srivatsa, Anusha wrote:
>> -----Original Message-----
>> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Sent: Friday, December 3, 2021 2:57 PM
>> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
>> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
>> <dave.hansen@linux.intel.com>; Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
>> Subject: Re: [v3 0/3] Introduce Raptor Lake S
>>
>>
>> On 03/12/2021 06:35, Anusha Srivatsa wrote:
>>> Raptor Lake S(RPL-S) is a version 12
>>> Display, Media and Render. For all i915 purposes it is the same as
>>> Alder Lake S (ADL-S).
>>>
>>> The series introduces it as a subplatform of ADL-S. The one difference
>>> is the GuC submission which is default on RPL-S but was not the case
>>> with ADL-S.
>>
>> As a side note, not a blocker of any kind, I am slightly disheartened but the
>> confusion of ADL_P and ADL_S being separate platforms, but then RPL_S is
>> subplatform of ADL_S. Maybe it is just me not being able to keep track of
>> things.
>>
>>> All patches are reviewed. Jani has acked the series.
>>> Looking for other acks in order to merge these to respective branches.
>>
>> Which branches would that be for this series? First two to drm-intel-next and
>> last one to drm-intel-gt-next? Is that complication needed and/or worth the
>> effort?
>
> Tvrtko,
> All three have to land to drm-intel-next. The last one has dependency on the first patch and is a trivial change.
One more ack for a good measure:
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 23+ messages in thread