From: kernel test robot <lkp@intel.com>
To: Moudy Ho <moudy.ho@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Jernej Skrabec <jernej.skrabec@siol.net>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Landley <rob@landley.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v10 3/3] media: platform: mtk-mdp3: add Mediatek MDP3 driver
Date: Fri, 3 Dec 2021 08:11:12 +0800 [thread overview]
Message-ID: <202112030854.bLiR84B2-lkp@intel.com> (raw)
In-Reply-To: <20211202062733.20338-4-moudy.ho@mediatek.com>
Hi Moudy,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on media-tree/master]
[also build test ERROR on robh/for-next v5.16-rc3 next-20211202]
[cannot apply to mbgg-mediatek/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Moudy-Ho/media-mediatek-support-mdp3-on-mt8183-platform/20211202-142942
base: git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20211203/202112030854.bLiR84B2-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2cff549997593f4c843e2b867b06992ae409ea86
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Moudy-Ho/media-mediatek-support-mdp3-on-mt8183-platform/20211202-142942
git checkout 2cff549997593f4c843e2b867b06992ae409ea86
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:14,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c:15:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c:15:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function); did you mean 'SCP_IPI_MAX'?
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
| SCP_IPI_MAX
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c: In function 'mdp_probe':
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c:192:37: error: implicit declaration of function 'mtk_mutex_mdp_get'; did you mean 'mtk_mutex_get'? [-Werror=implicit-function-declaration]
192 | mdp->mdp_mutex[i] = mtk_mutex_mdp_get(&mm_pdev->dev, i);
| ^~~~~~~~~~~~~~~~~
| mtk_mutex_get
cc1: some warnings being treated as errors
--
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:14,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c:10:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c:10:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function); did you mean 'SCP_IPI_MAX'?
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
| SCP_IPI_MAX
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
--
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:14,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c:10:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c:10:
drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function)
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
--
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:12:
drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function)
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'get_comp_flag':
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:35:38: error: 'MDP_COMP_RDMA0' undeclared (first use in this function)
35 | if (ctx->comp->id == MDP_COMP_RDMA0)
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:35:38: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/linux/bits.h:6,
from include/linux/bitops.h:6,
from include/linux/kernel.h:13,
from include/linux/clk.h:13,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:7:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:36:58: error: 'MDP_COMP_RSZ1' undeclared (first use in this function)
36 | return BIT(MDP_COMP_RDMA0) | BIT(MDP_COMP_RSZ1);
| ^~~~~~~~~~~~~
include/vdso/bits.h:7:44: note: in definition of macro 'BIT'
7 | #define BIT(nr) (UL(1) << (nr))
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: At top level:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:41:55: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
41 | static int init_rdma(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd)
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'init_rdma':
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:48:66: error: 'MDP_COMP_RSZ1' undeclared (first use in this function)
48 | struct mdp_comp *prz1 = ctx->comp->mdp_dev->comp[MDP_COMP_RSZ1];
| ^~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:51:38: error: 'MDP_COMP_RDMA0' undeclared (first use in this function)
51 | if (ctx->comp->id == MDP_COMP_RDMA0 && prz1)
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:52:25: note: in expansion of macro 'MM_REG_WRITE'
52 | MM_REG_WRITE(cmd, subsys_id, prz1->reg_base, PRZ_ENABLE,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:57:9: note: in expansion of macro 'MM_REG_WRITE'
57 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_RESET, BIT(0), BIT(0));
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:34:33: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
34 | cmdq_pkt_poll_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:37:9: note: in expansion of macro 'MM_REG_POLL_MASK'
37 | MM_REG_POLL_MASK((cmd), id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:58:9: note: in expansion of macro 'MM_REG_POLL'
58 | MM_REG_POLL(cmd, subsys_id, base, MDP_RDMA_MON_STA_1, BIT(8), BIT(8));
| ^~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:59:9: note: in expansion of macro 'MM_REG_WRITE'
59 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_RESET, 0x0, BIT(0));
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: At top level:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:64:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
64 | struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'config_rdma_frame':
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:77:25: note: in expansion of macro 'MM_REG_WRITE'
77 | MM_REG_WRITE(cmd, subsys_id, base,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:80:25: note: in expansion of macro 'MM_REG_WRITE'
80 | MM_REG_WRITE(cmd, subsys_id, base,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:85:9: note: in expansion of macro 'MM_REG_WRITE'
85 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_GMCIF_CON,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:91:9: note: in expansion of macro 'MM_REG_WRITE'
91 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_CON, rdma->src_ctrl,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:97:25: note: in expansion of macro 'MM_REG_WRITE'
97 | MM_REG_WRITE(cmd, subsys_id,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:100:25: note: in expansion of macro 'MM_REG_WRITE'
100 | MM_REG_WRITE(cmd, subsys_id,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:105:33: note: in expansion of macro 'MM_REG_WRITE'
105 | MM_REG_WRITE(cmd, subsys_id,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:110:9: note: in expansion of macro 'MM_REG_WRITE'
110 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_CON, rdma->control,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:113:9: note: in expansion of macro 'MM_REG_WRITE'
113 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_BASE_0, rdma->iova[0],
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:115:9: note: in expansion of macro 'MM_REG_WRITE'
115 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_BASE_1, rdma->iova[1],
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:117:9: note: in expansion of macro 'MM_REG_WRITE'
117 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_BASE_2, rdma->iova[2],
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:120:9: note: in expansion of macro 'MM_REG_WRITE'
120 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_END_0,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:122:9: note: in expansion of macro 'MM_REG_WRITE'
122 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_END_1,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:124:9: note: in expansion of macro 'MM_REG_WRITE'
124 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_END_2,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:127:9: note: in expansion of macro 'MM_REG_WRITE'
127 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_MF_BKGD_SIZE_IN_BYTE,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:129:9: note: in expansion of macro 'MM_REG_WRITE'
129 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SF_BKGD_SIZE_IN_BYTE,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:132:9: note: in expansion of macro 'MM_REG_WRITE'
132 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_TRANSFORM_0,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: At top level:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:139:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
139 | struct mmsys_cmdq_cmd *cmd, u32 index)
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'config_rdma_subfrm':
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:151:9: note: in expansion of macro 'MM_REG_WRITE'
151 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_EN, BIT(0), BIT(0));
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:154:9: note: in expansion of macro 'MM_REG_WRITE'
154 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_OFFSET_0,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:160:25: note: in expansion of macro 'MM_REG_WRITE'
160 | MM_REG_WRITE(cmd, subsys_id, base,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
..
vim +/id +109 drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h
12
13 #define MM_REG_WRITE_MASK(cmd, id, base, ofst, val, mask, ...) \
> 14 cmdq_pkt_write_mask((cmd)->pkt, id, \
15 (base) + (ofst), (val), (mask), ##__VA_ARGS__)
16 #define MM_REG_WRITE(cmd, id, base, ofst, val, mask, ...) \
17 MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
18 (((mask) & (ofst##_MASK)) == (ofst##_MASK)) ? \
19 (0xffffffff) : (mask), ##__VA_ARGS__)
20
21 #define MM_REG_WAIT(cmd, evt) \
22 cmdq_pkt_wfe((cmd)->pkt, (cmd)->event[(evt)], true)
23
24 #define MM_REG_WAIT_NO_CLEAR(cmd, evt) \
25 cmdq_pkt_wfe((cmd)->pkt, (cmd)->event[(evt)], false)
26
27 #define MM_REG_CLEAR(cmd, evt) \
28 cmdq_pkt_clear_event((cmd)->pkt, (cmd)->event[(evt)])
29
30 #define MM_REG_SET_EVENT(cmd, evt) \
31 cmdq_pkt_set_event((cmd)->pkt, (cmd)->event[(evt)])
32
33 #define MM_REG_POLL_MASK(cmd, id, base, ofst, val, mask, ...) \
34 cmdq_pkt_poll_mask((cmd)->pkt, id, \
35 (base) + (ofst), (val), (mask), ##__VA_ARGS__)
36 #define MM_REG_POLL(cmd, id, base, ofst, val, mask, ...) \
37 MM_REG_POLL_MASK((cmd), id, base, ofst, val, \
38 (((mask) & (ofst##_MASK)) == (ofst##_MASK)) ? \
39 (0xffffffff) : (mask), ##__VA_ARGS__)
40
41 enum mdp_comp_type {
42 MDP_COMP_TYPE_INVALID = 0,
43
44 MDP_COMP_TYPE_RDMA,
45 MDP_COMP_TYPE_RSZ,
46 MDP_COMP_TYPE_WROT,
47 MDP_COMP_TYPE_WDMA,
48 MDP_COMP_TYPE_PATH1,
49 MDP_COMP_TYPE_PATH2,
50
51 MDP_COMP_TYPE_TDSHP,
52 MDP_COMP_TYPE_COLOR,
53 MDP_COMP_TYPE_DRE,
54 MDP_COMP_TYPE_CCORR,
55 MDP_COMP_TYPE_HDR,
56
57 MDP_COMP_TYPE_IMGI,
58 MDP_COMP_TYPE_WPEI,
59 MDP_COMP_TYPE_EXTO, /* External path */
60 MDP_COMP_TYPE_DL_PATH1, /* Direct-link path1 */
61 MDP_COMP_TYPE_DL_PATH2, /* Direct-link path2 */
62
63 MDP_COMP_TYPE_COUNT /* ALWAYS keep at the end */
64 };
65
66 enum mdp_comp_event {
67 RDMA0_SOF,
68 RDMA0_DONE,
69 RSZ0_SOF,
70 RSZ1_SOF,
71 TDSHP0_SOF,
72 WROT0_SOF,
73 WROT0_DONE,
74 WDMA0_SOF,
75 WDMA0_DONE,
76
77 ISP_P2_0_DONE,
78 ISP_P2_1_DONE,
79 ISP_P2_2_DONE,
80 ISP_P2_3_DONE,
81 ISP_P2_4_DONE,
82 ISP_P2_5_DONE,
83 ISP_P2_6_DONE,
84 ISP_P2_7_DONE,
85 ISP_P2_8_DONE,
86 ISP_P2_9_DONE,
87 ISP_P2_10_DONE,
88 ISP_P2_11_DONE,
89 ISP_P2_12_DONE,
90 ISP_P2_13_DONE,
91 ISP_P2_14_DONE,
92
93 WPE_DONE,
94 WPE_B_DONE,
95
96 MDP_MAX_EVENT_COUNT /* ALWAYS keep at the end */
97 };
98
99 struct mdp_comp_ops;
100
101 struct mdp_comp {
102 struct mdp_dev *mdp_dev;
103 void __iomem *regs;
104 phys_addr_t reg_base;
105 u8 subsys_id;
106 struct clk *clks[6];
107 struct device *comp_dev;
108 enum mdp_comp_type type;
> 109 enum mtk_mdp_comp_id id;
110 u32 alias_id;
111 const struct mdp_comp_ops *ops;
112 };
113
114 struct mdp_comp_ctx {
115 struct mdp_comp *comp;
116 const struct img_compparam *param;
117 const struct img_input *input;
118 const struct img_output *outputs[IMG_MAX_HW_OUTPUTS];
119 };
120
121 struct mdp_comp_ops {
122 s64 (*get_comp_flag)(const struct mdp_comp_ctx *ctx);
> 123 int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
124 int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
125 const struct v4l2_rect *compose);
126 int (*config_subfrm)(struct mdp_comp_ctx *ctx,
127 struct mmsys_cmdq_cmd *cmd, u32 index);
128 int (*wait_comp_event)(struct mdp_comp_ctx *ctx,
129 struct mmsys_cmdq_cmd *cmd);
130 int (*advance_subfrm)(struct mdp_comp_ctx *ctx,
131 struct mmsys_cmdq_cmd *cmd, u32 index);
132 int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
133 };
134
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v10 3/3] media: platform: mtk-mdp3: add Mediatek MDP3 driver
Date: Fri, 03 Dec 2021 08:11:12 +0800 [thread overview]
Message-ID: <202112030854.bLiR84B2-lkp@intel.com> (raw)
In-Reply-To: <20211202062733.20338-4-moudy.ho@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 39198 bytes --]
Hi Moudy,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on media-tree/master]
[also build test ERROR on robh/for-next v5.16-rc3 next-20211202]
[cannot apply to mbgg-mediatek/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Moudy-Ho/media-mediatek-support-mdp3-on-mt8183-platform/20211202-142942
base: git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20211203/202112030854.bLiR84B2-lkp(a)intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2cff549997593f4c843e2b867b06992ae409ea86
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Moudy-Ho/media-mediatek-support-mdp3-on-mt8183-platform/20211202-142942
git checkout 2cff549997593f4c843e2b867b06992ae409ea86
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:14,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c:15:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c:15:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function); did you mean 'SCP_IPI_MAX'?
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
| SCP_IPI_MAX
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c: In function 'mdp_probe':
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c:192:37: error: implicit declaration of function 'mtk_mutex_mdp_get'; did you mean 'mtk_mutex_get'? [-Werror=implicit-function-declaration]
192 | mdp->mdp_mutex[i] = mtk_mutex_mdp_get(&mm_pdev->dev, i);
| ^~~~~~~~~~~~~~~~~
| mtk_mutex_get
cc1: some warnings being treated as errors
--
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:14,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c:10:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c:10:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function); did you mean 'SCP_IPI_MAX'?
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
| SCP_IPI_MAX
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
--
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:14,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c:10:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-regs.c:10:
drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function)
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
--
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:109:41: error: field 'id' has incomplete type
109 | enum mtk_mdp_comp_id id;
| ^~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:123:59: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
123 | int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:124:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
124 | int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:127:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
127 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:129:39: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
129 | struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:131:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
131 | struct mmsys_cmdq_cmd *cmd, u32 index);
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:132:62: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
132 | int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:12:
drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:43:60: error: 'MDP_PIPE_MAX' undeclared here (not in a function)
43 | struct mtk_mutex *mdp_mutex[MDP_PIPE_MAX];
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.h:44:55: error: 'MDP_MAX_COMP_COUNT' undeclared here (not in a function); did you mean 'MDP_MAX_EVENT_COUNT'?
44 | struct mdp_comp *comp[MDP_MAX_COMP_COUNT];
| ^~~~~~~~~~~~~~~~~~
| MDP_MAX_EVENT_COUNT
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'get_comp_flag':
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:35:38: error: 'MDP_COMP_RDMA0' undeclared (first use in this function)
35 | if (ctx->comp->id == MDP_COMP_RDMA0)
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:35:38: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/linux/bits.h:6,
from include/linux/bitops.h:6,
from include/linux/kernel.h:13,
from include/linux/clk.h:13,
from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:7:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:36:58: error: 'MDP_COMP_RSZ1' undeclared (first use in this function)
36 | return BIT(MDP_COMP_RDMA0) | BIT(MDP_COMP_RSZ1);
| ^~~~~~~~~~~~~
include/vdso/bits.h:7:44: note: in definition of macro 'BIT'
7 | #define BIT(nr) (UL(1) << (nr))
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: At top level:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:41:55: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
41 | static int init_rdma(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd)
| ^~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'init_rdma':
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:48:66: error: 'MDP_COMP_RSZ1' undeclared (first use in this function)
48 | struct mdp_comp *prz1 = ctx->comp->mdp_dev->comp[MDP_COMP_RSZ1];
| ^~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:51:38: error: 'MDP_COMP_RDMA0' undeclared (first use in this function)
51 | if (ctx->comp->id == MDP_COMP_RDMA0 && prz1)
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:52:25: note: in expansion of macro 'MM_REG_WRITE'
52 | MM_REG_WRITE(cmd, subsys_id, prz1->reg_base, PRZ_ENABLE,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:57:9: note: in expansion of macro 'MM_REG_WRITE'
57 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_RESET, BIT(0), BIT(0));
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:34:33: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
34 | cmdq_pkt_poll_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:37:9: note: in expansion of macro 'MM_REG_POLL_MASK'
37 | MM_REG_POLL_MASK((cmd), id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:58:9: note: in expansion of macro 'MM_REG_POLL'
58 | MM_REG_POLL(cmd, subsys_id, base, MDP_RDMA_MON_STA_1, BIT(8), BIT(8));
| ^~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:59:9: note: in expansion of macro 'MM_REG_WRITE'
59 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_RESET, 0x0, BIT(0));
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: At top level:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:64:37: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
64 | struct mmsys_cmdq_cmd *cmd,
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'config_rdma_frame':
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:77:25: note: in expansion of macro 'MM_REG_WRITE'
77 | MM_REG_WRITE(cmd, subsys_id, base,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:80:25: note: in expansion of macro 'MM_REG_WRITE'
80 | MM_REG_WRITE(cmd, subsys_id, base,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:85:9: note: in expansion of macro 'MM_REG_WRITE'
85 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_GMCIF_CON,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:91:9: note: in expansion of macro 'MM_REG_WRITE'
91 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_CON, rdma->src_ctrl,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:97:25: note: in expansion of macro 'MM_REG_WRITE'
97 | MM_REG_WRITE(cmd, subsys_id,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:100:25: note: in expansion of macro 'MM_REG_WRITE'
100 | MM_REG_WRITE(cmd, subsys_id,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:105:33: note: in expansion of macro 'MM_REG_WRITE'
105 | MM_REG_WRITE(cmd, subsys_id,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:110:9: note: in expansion of macro 'MM_REG_WRITE'
110 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_CON, rdma->control,
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:113:9: note: in expansion of macro 'MM_REG_WRITE'
113 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_BASE_0, rdma->iova[0],
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:115:9: note: in expansion of macro 'MM_REG_WRITE'
115 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_BASE_1, rdma->iova[1],
| ^~~~~~~~~~~~
>> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:117:9: note: in expansion of macro 'MM_REG_WRITE'
117 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_BASE_2, rdma->iova[2],
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:120:9: note: in expansion of macro 'MM_REG_WRITE'
120 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_END_0,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:122:9: note: in expansion of macro 'MM_REG_WRITE'
122 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_END_1,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:124:9: note: in expansion of macro 'MM_REG_WRITE'
124 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_END_2,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:127:9: note: in expansion of macro 'MM_REG_WRITE'
127 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_MF_BKGD_SIZE_IN_BYTE,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:129:9: note: in expansion of macro 'MM_REG_WRITE'
129 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SF_BKGD_SIZE_IN_BYTE,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:132:9: note: in expansion of macro 'MM_REG_WRITE'
132 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_TRANSFORM_0,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: At top level:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:139:38: warning: 'struct mmsys_cmdq_cmd' declared inside parameter list will not be visible outside of this definition or declaration
139 | struct mmsys_cmdq_cmd *cmd, u32 index)
| ^~~~~~~~~~~~~~
In file included from drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:11:
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'config_rdma_subfrm':
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:151:9: note: in expansion of macro 'MM_REG_WRITE'
151 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_EN, BIT(0), BIT(0));
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:154:9: note: in expansion of macro 'MM_REG_WRITE'
154 | MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_SRC_OFFSET_0,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
| ^~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:160:25: note: in expansion of macro 'MM_REG_WRITE'
160 | MM_REG_WRITE(cmd, subsys_id, base,
| ^~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:14:34: error: invalid use of undefined type 'struct mmsys_cmdq_cmd'
14 | cmdq_pkt_write_mask((cmd)->pkt, id, \
| ^~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h:17:9: note: in expansion of macro 'MM_REG_WRITE_MASK'
17 | MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
..
vim +/id +109 drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.h
12
13 #define MM_REG_WRITE_MASK(cmd, id, base, ofst, val, mask, ...) \
> 14 cmdq_pkt_write_mask((cmd)->pkt, id, \
15 (base) + (ofst), (val), (mask), ##__VA_ARGS__)
16 #define MM_REG_WRITE(cmd, id, base, ofst, val, mask, ...) \
17 MM_REG_WRITE_MASK(cmd, id, base, ofst, val, \
18 (((mask) & (ofst##_MASK)) == (ofst##_MASK)) ? \
19 (0xffffffff) : (mask), ##__VA_ARGS__)
20
21 #define MM_REG_WAIT(cmd, evt) \
22 cmdq_pkt_wfe((cmd)->pkt, (cmd)->event[(evt)], true)
23
24 #define MM_REG_WAIT_NO_CLEAR(cmd, evt) \
25 cmdq_pkt_wfe((cmd)->pkt, (cmd)->event[(evt)], false)
26
27 #define MM_REG_CLEAR(cmd, evt) \
28 cmdq_pkt_clear_event((cmd)->pkt, (cmd)->event[(evt)])
29
30 #define MM_REG_SET_EVENT(cmd, evt) \
31 cmdq_pkt_set_event((cmd)->pkt, (cmd)->event[(evt)])
32
33 #define MM_REG_POLL_MASK(cmd, id, base, ofst, val, mask, ...) \
34 cmdq_pkt_poll_mask((cmd)->pkt, id, \
35 (base) + (ofst), (val), (mask), ##__VA_ARGS__)
36 #define MM_REG_POLL(cmd, id, base, ofst, val, mask, ...) \
37 MM_REG_POLL_MASK((cmd), id, base, ofst, val, \
38 (((mask) & (ofst##_MASK)) == (ofst##_MASK)) ? \
39 (0xffffffff) : (mask), ##__VA_ARGS__)
40
41 enum mdp_comp_type {
42 MDP_COMP_TYPE_INVALID = 0,
43
44 MDP_COMP_TYPE_RDMA,
45 MDP_COMP_TYPE_RSZ,
46 MDP_COMP_TYPE_WROT,
47 MDP_COMP_TYPE_WDMA,
48 MDP_COMP_TYPE_PATH1,
49 MDP_COMP_TYPE_PATH2,
50
51 MDP_COMP_TYPE_TDSHP,
52 MDP_COMP_TYPE_COLOR,
53 MDP_COMP_TYPE_DRE,
54 MDP_COMP_TYPE_CCORR,
55 MDP_COMP_TYPE_HDR,
56
57 MDP_COMP_TYPE_IMGI,
58 MDP_COMP_TYPE_WPEI,
59 MDP_COMP_TYPE_EXTO, /* External path */
60 MDP_COMP_TYPE_DL_PATH1, /* Direct-link path1 */
61 MDP_COMP_TYPE_DL_PATH2, /* Direct-link path2 */
62
63 MDP_COMP_TYPE_COUNT /* ALWAYS keep at the end */
64 };
65
66 enum mdp_comp_event {
67 RDMA0_SOF,
68 RDMA0_DONE,
69 RSZ0_SOF,
70 RSZ1_SOF,
71 TDSHP0_SOF,
72 WROT0_SOF,
73 WROT0_DONE,
74 WDMA0_SOF,
75 WDMA0_DONE,
76
77 ISP_P2_0_DONE,
78 ISP_P2_1_DONE,
79 ISP_P2_2_DONE,
80 ISP_P2_3_DONE,
81 ISP_P2_4_DONE,
82 ISP_P2_5_DONE,
83 ISP_P2_6_DONE,
84 ISP_P2_7_DONE,
85 ISP_P2_8_DONE,
86 ISP_P2_9_DONE,
87 ISP_P2_10_DONE,
88 ISP_P2_11_DONE,
89 ISP_P2_12_DONE,
90 ISP_P2_13_DONE,
91 ISP_P2_14_DONE,
92
93 WPE_DONE,
94 WPE_B_DONE,
95
96 MDP_MAX_EVENT_COUNT /* ALWAYS keep at the end */
97 };
98
99 struct mdp_comp_ops;
100
101 struct mdp_comp {
102 struct mdp_dev *mdp_dev;
103 void __iomem *regs;
104 phys_addr_t reg_base;
105 u8 subsys_id;
106 struct clk *clks[6];
107 struct device *comp_dev;
108 enum mdp_comp_type type;
> 109 enum mtk_mdp_comp_id id;
110 u32 alias_id;
111 const struct mdp_comp_ops *ops;
112 };
113
114 struct mdp_comp_ctx {
115 struct mdp_comp *comp;
116 const struct img_compparam *param;
117 const struct img_input *input;
118 const struct img_output *outputs[IMG_MAX_HW_OUTPUTS];
119 };
120
121 struct mdp_comp_ops {
122 s64 (*get_comp_flag)(const struct mdp_comp_ctx *ctx);
> 123 int (*init_comp)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
124 int (*config_frame)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd,
125 const struct v4l2_rect *compose);
126 int (*config_subfrm)(struct mdp_comp_ctx *ctx,
127 struct mmsys_cmdq_cmd *cmd, u32 index);
128 int (*wait_comp_event)(struct mdp_comp_ctx *ctx,
129 struct mmsys_cmdq_cmd *cmd);
130 int (*advance_subfrm)(struct mdp_comp_ctx *ctx,
131 struct mmsys_cmdq_cmd *cmd, u32 index);
132 int (*post_process)(struct mdp_comp_ctx *ctx, struct mmsys_cmdq_cmd *cmd);
133 };
134
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-03 0:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 6:27 [PATCH v10 0/3] media: mediatek: support mdp3 on mt8183 platform Moudy Ho
2021-12-02 6:27 ` Moudy Ho
2021-12-02 6:27 ` Moudy Ho
2021-12-02 6:27 ` [PATCH v10 1/3] dt-binding: mt8183: add Mediatek MDP3 dt-bindings Moudy Ho
2021-12-02 6:27 ` Moudy Ho
2021-12-02 6:27 ` Moudy Ho
2021-12-10 18:17 ` Rob Herring
2021-12-10 18:17 ` Rob Herring
2021-12-10 18:17 ` Rob Herring
2021-12-27 8:26 ` moudy ho
2021-12-27 8:26 ` moudy ho
2021-12-02 6:27 ` [PATCH v10 2/3] dts: arm64: mt8183: add Mediatek MDP3 nodes Moudy Ho
2021-12-02 6:27 ` Moudy Ho
2021-12-02 6:27 ` Moudy Ho
2021-12-15 10:15 ` AngeloGioacchino Del Regno
2021-12-15 10:15 ` AngeloGioacchino Del Regno
2021-12-15 10:15 ` AngeloGioacchino Del Regno
2021-12-02 6:27 ` [PATCH v10 3/3] media: platform: mtk-mdp3: add Mediatek MDP3 driver Moudy Ho
2021-12-02 6:27 ` Moudy Ho
2021-12-02 6:54 ` moudy ho
2021-12-02 6:54 ` moudy ho
2021-12-03 0:11 ` kernel test robot [this message]
2021-12-03 0:11 ` kernel test robot
2021-12-07 14:20 ` Hans Verkuil
2021-12-07 14:20 ` Hans Verkuil
2021-12-07 14:20 ` Hans Verkuil
2021-12-07 14:33 ` Geert Uytterhoeven
2021-12-07 14:33 ` Geert Uytterhoeven
2021-12-07 14:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112030854.bLiR84B2-lkp@intel.com \
--to=lkp@intel.com \
--cc=chunkuang.hu@kernel.org \
--cc=geert+renesas@glider.be \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=kbuild-all@lists.01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.