From: Amit Daniel Kachhap <amit.kachhap@arm.com> To: linux-kernel@vger.kernel.org Cc: Christoph Hellwig <hch@lst.de>, Vincenzo Frascino <Vincenzo.Frascino@arm.com>, Kevin Brodsky <kevin.brodsky@arm.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, kexec <kexec@lists.infradead.org>, Amit Daniel Kachhap <amit.kachhap@arm.com> Subject: [RFC PATCH 00/14] fs/proc/vmcore: Remove unnecessary user pointer conversions Date: Fri, 3 Dec 2021 16:12:17 +0530 [thread overview] Message-ID: <20211203104231.17597-1-amit.kachhap@arm.com> (raw) Hi, This series aims to restructure the external interfaces as well internal code used in fs/proc/vmcore.c by removing the interchangeable use of user and kernel pointers. This unnecessary conversion may obstruct the tools such as sparse in generating meaningful results. This also simplifies the things by keeping the user and kernel pointers separate during propagation. The external interfaces such as copy_oldmem_page, copy_oldmem_page_encrypted and read_from_oldmem are used across different architectures. The goal here is to update one architecture at a time and hence there is an extra cleanup done in the end to remove the intermediaries. In this series, an extra user pointer is added as a parameter to all the above functions instead of an union as there were disagreement in earlier ideas of using universal pointer [1,2]. This series is posted as RFC so as to find out an acceptable way of handling this use case. This series is based on v5.16-rc3 and is compile tested for modified architectures and boot tested in qemu for all architectures except ia64. Note: This patch series breaks the crash dump functionality after patch 3 and is restored after each arch implements its own copy_oldmem_page_buf() interface. Thanks, Amit Daniel [1]: https://lore.kernel.org/lkml/20200624162901.1814136-2-hch@lst.de/ [2]: https://lore.kernel.org/lkml/CAHk-=wit9enePELG=-HnLsr0nY5bucFNjqAqWoFTuYDGR1P4KA@mail.gmail.com/ Amit Daniel Kachhap (14): fs/proc/vmcore: Update read_from_oldmem() for user pointer fs/proc/vmcore: Update copy_oldmem_page_encrypted() for user buffer fs/proc/vmcore: Update copy_oldmem_page() for user buffer x86/crash_dump_64: Use the new interface copy_oldmem_page_buf x86/crash_dump_32: Use the new interface copy_oldmem_page_buf arm64/crash_dump: Use the new interface copy_oldmem_page_buf arm/crash_dump: Use the new interface copy_oldmem_page_buf mips/crash_dump: Use the new interface copy_oldmem_page_buf sh/crash_dump: Use the new interface copy_oldmem_page_buf riscv/crash_dump: Use the new interface copy_oldmem_page_buf powerpc/crash_dump: Use the new interface copy_oldmem_page_buf ia64/crash_dump: Use the new interface copy_oldmem_page_buf s390/crash_dump: Use the new interface copy_oldmem_page_buf fs/proc/vmcore: Remove the unused old interface copy_oldmem_page arch/arm/kernel/crash_dump.c | 21 ++++---- arch/arm64/kernel/crash_dump.c | 21 ++++---- arch/ia64/kernel/crash_dump.c | 25 +++++----- arch/mips/kernel/crash_dump.c | 24 ++++----- arch/powerpc/kernel/crash_dump.c | 33 +++++++------ arch/riscv/kernel/crash_dump.c | 25 +++++----- arch/s390/kernel/crash_dump.c | 12 ++--- arch/sh/kernel/crash_dump.c | 25 +++++----- arch/x86/kernel/crash_dump_32.c | 24 ++++----- arch/x86/kernel/crash_dump_64.c | 48 +++++++++--------- fs/proc/vmcore.c | 85 +++++++++++++++++--------------- include/linux/crash_dump.h | 23 +++++---- 12 files changed, 189 insertions(+), 177 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Amit Daniel Kachhap <amit.kachhap@arm.com> To: linux-kernel@vger.kernel.org Cc: Christoph Hellwig <hch@lst.de>, Vincenzo Frascino <Vincenzo.Frascino@arm.com>, Kevin Brodsky <kevin.brodsky@arm.com>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, kexec <kexec@lists.infradead.org>, Amit Daniel Kachhap <amit.kachhap@arm.com> Subject: [RFC PATCH 00/14] fs/proc/vmcore: Remove unnecessary user pointer conversions Date: Fri, 3 Dec 2021 16:12:17 +0530 [thread overview] Message-ID: <20211203104231.17597-1-amit.kachhap@arm.com> (raw) Hi, This series aims to restructure the external interfaces as well internal code used in fs/proc/vmcore.c by removing the interchangeable use of user and kernel pointers. This unnecessary conversion may obstruct the tools such as sparse in generating meaningful results. This also simplifies the things by keeping the user and kernel pointers separate during propagation. The external interfaces such as copy_oldmem_page, copy_oldmem_page_encrypted and read_from_oldmem are used across different architectures. The goal here is to update one architecture at a time and hence there is an extra cleanup done in the end to remove the intermediaries. In this series, an extra user pointer is added as a parameter to all the above functions instead of an union as there were disagreement in earlier ideas of using universal pointer [1,2]. This series is posted as RFC so as to find out an acceptable way of handling this use case. This series is based on v5.16-rc3 and is compile tested for modified architectures and boot tested in qemu for all architectures except ia64. Note: This patch series breaks the crash dump functionality after patch 3 and is restored after each arch implements its own copy_oldmem_page_buf() interface. Thanks, Amit Daniel [1]: https://lore.kernel.org/lkml/20200624162901.1814136-2-hch@lst.de/ [2]: https://lore.kernel.org/lkml/CAHk-=wit9enePELG=-HnLsr0nY5bucFNjqAqWoFTuYDGR1P4KA@mail.gmail.com/ Amit Daniel Kachhap (14): fs/proc/vmcore: Update read_from_oldmem() for user pointer fs/proc/vmcore: Update copy_oldmem_page_encrypted() for user buffer fs/proc/vmcore: Update copy_oldmem_page() for user buffer x86/crash_dump_64: Use the new interface copy_oldmem_page_buf x86/crash_dump_32: Use the new interface copy_oldmem_page_buf arm64/crash_dump: Use the new interface copy_oldmem_page_buf arm/crash_dump: Use the new interface copy_oldmem_page_buf mips/crash_dump: Use the new interface copy_oldmem_page_buf sh/crash_dump: Use the new interface copy_oldmem_page_buf riscv/crash_dump: Use the new interface copy_oldmem_page_buf powerpc/crash_dump: Use the new interface copy_oldmem_page_buf ia64/crash_dump: Use the new interface copy_oldmem_page_buf s390/crash_dump: Use the new interface copy_oldmem_page_buf fs/proc/vmcore: Remove the unused old interface copy_oldmem_page arch/arm/kernel/crash_dump.c | 21 ++++---- arch/arm64/kernel/crash_dump.c | 21 ++++---- arch/ia64/kernel/crash_dump.c | 25 +++++----- arch/mips/kernel/crash_dump.c | 24 ++++----- arch/powerpc/kernel/crash_dump.c | 33 +++++++------ arch/riscv/kernel/crash_dump.c | 25 +++++----- arch/s390/kernel/crash_dump.c | 12 ++--- arch/sh/kernel/crash_dump.c | 25 +++++----- arch/x86/kernel/crash_dump_32.c | 24 ++++----- arch/x86/kernel/crash_dump_64.c | 48 +++++++++--------- fs/proc/vmcore.c | 85 +++++++++++++++++--------------- include/linux/crash_dump.h | 23 +++++---- 12 files changed, 189 insertions(+), 177 deletions(-) -- 2.17.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2021-12-03 10:42 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-03 10:42 Amit Daniel Kachhap [this message] 2021-12-03 10:42 ` [RFC PATCH 00/14] fs/proc/vmcore: Remove unnecessary user pointer conversions Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 01/14] fs/proc/vmcore: Update read_from_oldmem() for user pointer Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-06 14:04 ` Christoph Hellwig 2021-12-06 14:04 ` Christoph Hellwig 2021-12-06 14:17 ` Matthew Wilcox 2021-12-06 14:17 ` Matthew Wilcox 2021-12-06 14:54 ` Christoph Hellwig 2021-12-06 14:54 ` Christoph Hellwig 2021-12-06 15:07 ` Matthew Wilcox 2021-12-06 15:07 ` Matthew Wilcox 2021-12-07 11:15 ` Christoph Hellwig 2021-12-07 11:15 ` Christoph Hellwig 2021-12-07 7:11 ` Amit Kachhap 2021-12-07 7:11 ` Amit Kachhap 2021-12-03 10:42 ` [RFC PATCH 02/14] fs/proc/vmcore: Update copy_oldmem_page_encrypted() for user buffer Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 03/14] fs/proc/vmcore: Update copy_oldmem_page() " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 04/14] x86/crash_dump_64: Use the new interface copy_oldmem_page_buf Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 05/14] x86/crash_dump_32: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 06/14] arm64/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 07/14] arm/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 08/14] mips/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 09/14] sh/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 10/14] riscv/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 11/14] powerpc/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 12/14] ia64/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:54 ` Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 13/14] s390/crash_dump: " Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap 2021-12-03 10:42 ` [RFC PATCH 14/14] fs/proc/vmcore: Remove the unused old interface copy_oldmem_page Amit Daniel Kachhap 2021-12-03 10:42 ` Amit Daniel Kachhap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211203104231.17597-1-amit.kachhap@arm.com \ --to=amit.kachhap@arm.com \ --cc=Vincenzo.Frascino@arm.com \ --cc=hch@lst.de \ --cc=kevin.brodsky@arm.com \ --cc=kexec@lists.infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.