[u-boot-test-hooks PATCH v2] travis-ci: Add tests for booting from coreboot

[u-boot-test-hooks PATCH v2] travis-ci: Add tests for booting from coreboot

[Simon Glass]

Add a means of testing a coreboot + U-Boot build using qemu.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
As to what to do with people's labs, I think applying these patches does
encourage them and provide people with examples. Having 'no mainline' for
these is going to be an impediment I think.

Changes in v2:
- Drop the ellesmere symlink

 bin/travis-ci/conf.coreboot_qemu | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 bin/travis-ci/conf.coreboot_qemu

diff --git a/bin/travis-ci/conf.coreboot_qemu b/bin/travis-ci/conf.coreboot_qemu
new file mode 100644
index 0000000..76d6927
--- /dev/null
+++ b/bin/travis-ci/conf.coreboot_qemu
@@ -0,0 +1,28 @@
+# Copyright (c) 2016 Konsulko Group. All rights reserved.
+# Copyright 2021 Google LLC
+#
+# Permission is hereby granted, free of charge, to any person obtaining a
+# copy of this software and associated documentation files (the "Software"),
+# to deal in the Software without restriction, including without limitation
+# the rights to use, copy, modify, merge, publish, distribute, sublicense,
+# and/or sell copies of the Software, and to permit persons to whom the
+# Software is furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+# DEALINGS IN THE SOFTWARE.
+
+console_impl=qemu
+qemu_machine="pc"
+qemu_binary="qemu-system-i386"
+qemu_extra_args="-nographic -cpu qemu32 -netdev user,id=net0,tftp=${UBOOT_TRAVIS_BUILD_DIR} -device e1000,netdev=net0"
+qemu_kernel_args="-bios ${U_BOOT_BUILD_DIR}/coreboot.rom"
+reset_impl=none
+flash_impl=none
-- 
2.34.0.384.gca35af8252-goog

Re: [u-boot-test-hooks PATCH v2] travis-ci: Add tests for booting from coreboot

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Fri, Dec 03, 2021 at 08:52:38AM -0700, Simon Glass wrote:

> Add a means of testing a coreboot + U-Boot build using qemu.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> As to what to do with people's labs, I think applying these patches does
> encourage them and provide people with examples. Having 'no mainline' for
> these is going to be an impediment I think.
> 
> Changes in v2:
> - Drop the ellesmere symlink
> 
>  bin/travis-ci/conf.coreboot_qemu | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 bin/travis-ci/conf.coreboot_qemu

So, now we have the conf, for something 100% virtual, in bin/travis-ci
(which yes, ugh, bad name).  If we had a top-level README.rst how would
it be unclear that this is a functional example?  In fact, maybe we
should clear something up.  How does the network test work for you?  I
have to modify them to pass -tftp=/tftpboot so that I can then give it
things like helloworld.efi and appropriate grub.efi.  Are you using some
wrapper to make things look more like what CI does?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [u-boot-test-hooks PATCH v2] travis-ci: Add tests for booting from coreboot

[Simon Glass]

Hi Tom,

On Fri, 3 Dec 2021 at 09:02, Tom Rini <trini@konsulko.com> wrote:
>
> On Fri, Dec 03, 2021 at 08:52:38AM -0700, Simon Glass wrote:
>
> > Add a means of testing a coreboot + U-Boot build using qemu.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> > As to what to do with people's labs, I think applying these patches does
> > encourage them and provide people with examples. Having 'no mainline' for
> > these is going to be an impediment I think.
> >
> > Changes in v2:
> > - Drop the ellesmere symlink
> >
> >  bin/travis-ci/conf.coreboot_qemu | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >  create mode 100644 bin/travis-ci/conf.coreboot_qemu
>
> So, now we have the conf, for something 100% virtual, in bin/travis-ci
> (which yes, ugh, bad name).  If we had a top-level README.rst how would
> it be unclear that this is a functional example?  In fact, maybe we
> should clear something up.  How does the network test work for you?  I
> have to modify them to pass -tftp=/tftpboot so that I can then give it
> things like helloworld.efi and appropriate grub.efi.  Are you using some
> wrapper to make things look more like what CI does?

I haven't tried the network tests, actually. Mostly I run individual
tests or just boot to a prompt and try things out. One day I would
like to get labman closer to making this automatic.

Regards,
Simon

Re: [u-boot-test-hooks PATCH v2] travis-ci: Add tests for booting from coreboot

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]

On Fri, Dec 03, 2021 at 09:17:20AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Fri, 3 Dec 2021 at 09:02, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Dec 03, 2021 at 08:52:38AM -0700, Simon Glass wrote:
> >
> > > Add a means of testing a coreboot + U-Boot build using qemu.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > > As to what to do with people's labs, I think applying these patches does
> > > encourage them and provide people with examples. Having 'no mainline' for
> > > these is going to be an impediment I think.
> > >
> > > Changes in v2:
> > > - Drop the ellesmere symlink
> > >
> > >  bin/travis-ci/conf.coreboot_qemu | 28 ++++++++++++++++++++++++++++
> > >  1 file changed, 28 insertions(+)
> > >  create mode 100644 bin/travis-ci/conf.coreboot_qemu
> >
> > So, now we have the conf, for something 100% virtual, in bin/travis-ci
> > (which yes, ugh, bad name).  If we had a top-level README.rst how would
> > it be unclear that this is a functional example?  In fact, maybe we
> > should clear something up.  How does the network test work for you?  I
> > have to modify them to pass -tftp=/tftpboot so that I can then give it
> > things like helloworld.efi and appropriate grub.efi.  Are you using some
> > wrapper to make things look more like what CI does?
> 
> I haven't tried the network tests, actually. Mostly I run individual
> tests or just boot to a prompt and try things out. One day I would
> like to get labman closer to making this automatic.

Ah.  I have a wrapper to activate a virtualenv for the pytest stuff,
then set PYTHONPATH / UBOOT_TRAVIS_BUILD_DIR and it all just works.
Except since I want to test the network a bit more heavily, I pass in my
own tftpboot dir, with a larger test file.  I could possibly change
things to wrap up and look more like CI does, and require less tweaking.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [u-boot-test-hooks PATCH v2] travis-ci: Add tests for booting from coreboot

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

On Fri, Dec 03, 2021 at 08:52:38AM -0700, Simon Glass wrote:

> Add a means of testing a coreboot + U-Boot build using qemu.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-test-hooks/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]