[ulogd2 PATCH] build: bump libnetfilter_log dependency

[ulogd2 PATCH] build: bump libnetfilter_log dependency

[Jeremy Sowden]

Recent changes to add conntrack info to the NFLOG output plug-in rely on
symbols only present in the headers provided by libnetfilter-log v1.0.2:

    CC       ulogd_inppkt_NFLOG.lo
  ulogd_inppkt_NFLOG.c: In function 'build_ct':
  ulogd_inppkt_NFLOG.c:346:34: error: 'NFULA_CT' undeclared (first use in this function); did you mean 'NFULA_GID'?
     if (mnl_attr_get_type(attr) == NFULA_CT) {
                                    ^~~~~~~~
                                    NFULA_GID
  ulogd_inppkt_NFLOG.c:346:34: note: each undeclared identifier is reported only once for each function it appears in
  ulogd_inppkt_NFLOG.c: In function 'start':
  ulogd_inppkt_NFLOG.c:669:12: error: 'NFULNL_CFG_F_CONNTRACK' undeclared (first use in this function); did you mean 'NFULNL_CFG_F_SEQ'?
     flags |= NFULNL_CFG_F_CONNTRACK;
              ^~~~~~~~~~~~~~~~~~~~~~
              NFULNL_CFG_F_SEQ

Bump the pkg-config version accordingly.

Fixes: f6a615587a10 ("NFLOG: attach struct nf_conntrack")
Fixes: e513a04cd925 ("NFLOG: add NFULNL_CFG_F_CONNTRACK flag")
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 895d58439ef7..b3e1c8f6b926 100644
--- a/configure.ac
+++ b/configure.ac
@@ -52,7 +52,7 @@ AC_ARG_ENABLE([nflog],
               [enable_nflog=$enableval],
               [enable_nflog=yes])
 AS_IF([test "x$enable_nflog" = "xyes"],
-      [PKG_CHECK_MODULES([LIBNETFILTER_LOG], [libnetfilter_log >= 1.0.0])
+      [PKG_CHECK_MODULES([LIBNETFILTER_LOG], [libnetfilter_log >= 1.0.2])
        AC_DEFINE([BUILD_NFLOG], [1], [Building nflog module])],
       [enable_nflog=no])
 AM_CONDITIONAL([BUILD_NFLOG], [test "x$enable_nflog" = "xyes"])
-- 
2.33.0

Re: [ulogd2 PATCH] build: bump libnetfilter_log dependency

[Pablo Neira Ayuso]

On Sat, Dec 04, 2021 at 08:56:00PM +0000, Jeremy Sowden wrote:
> Recent changes to add conntrack info to the NFLOG output plug-in rely on
> symbols only present in the headers provided by libnetfilter-log v1.0.2:
> 
>     CC       ulogd_inppkt_NFLOG.lo
>   ulogd_inppkt_NFLOG.c: In function 'build_ct':
>   ulogd_inppkt_NFLOG.c:346:34: error: 'NFULA_CT' undeclared (first use in this function); did you mean 'NFULA_GID'?
>      if (mnl_attr_get_type(attr) == NFULA_CT) {
>                                     ^~~~~~~~
>                                     NFULA_GID
>   ulogd_inppkt_NFLOG.c:346:34: note: each undeclared identifier is reported only once for each function it appears in
>   ulogd_inppkt_NFLOG.c: In function 'start':
>   ulogd_inppkt_NFLOG.c:669:12: error: 'NFULNL_CFG_F_CONNTRACK' undeclared (first use in this function); did you mean 'NFULNL_CFG_F_SEQ'?
>      flags |= NFULNL_CFG_F_CONNTRACK;
>               ^~~~~~~~~~~~~~~~~~~~~~
>               NFULNL_CFG_F_SEQ
> 
> Bump the pkg-config version accordingly.

Applied, thanks