[OE-core][PATCH] tune-cortexa72: Add new tune for crc and crypto

[OE-core][PATCH] tune-cortexa72: Add new tune for crc and crypto

[Jagadeesh Krishnanjanappa]

The newly added cortexa72-crypto tune builds programs for armv8a
with crc+crypto. Whereas default tune cortexa72 builds programs
with armv8a only.

[YOCTO #14641]

Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
---
 .../conf/machine/include/arm/armv8a/tune-cortexa72.inc | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
index 2a510bd45b..8c32286c84 100644
--- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
+++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
@@ -6,8 +6,12 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa72', ' -mcpu=corte
 require conf/machine/include/arm/arch-armv8a.inc
 
 # Little Endian base configs
-AVAILTUNES += "cortexa72"
+AVAILTUNES += "cortexa72 cortexa72-crypto"
 ARMPKGARCH:tune-cortexa72             = "cortexa72"
-TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a-crc-crypto} cortexa72"
-PACKAGE_EXTRA_ARCHS:tune-cortexa72    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72"
+ARMPKGARCH:tune-cortexa72-crypto      = "cortexa72"
+TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a} cortexa72"
+TUNE_FEATURES:tune-cortexa72-crypto   = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72    = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
+PACKAGE_EXTRA_ARCHS:tune-cortexa72-crypto    = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crypto"
 BASE_LIB:tune-cortexa72               = "lib64"
+BASE_LIB:tune-cortexa72-crypto        = "lib64"
-- 
2.17.1

Re: [OE-core][PATCH] tune-cortexa72: Add new tune for crc and crypto

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2757 bytes --]

On Sun, Dec 5, 2021 at 3:36 AM Jagadeesh Krishnanjanappa <
workjagadeesh@gmail.com> wrote:

> The newly added cortexa72-crypto tune builds programs for armv8a
> with crc+crypto. Whereas default tune cortexa72 builds programs
> with armv8a only.


There is another patch I sent to add converse infact to support nocrypto
instead because this change you propose will regress existing cortexa72
tunes for machines which have crypto aes implemented in hardware and it
will be not backward compatible since many bsps try to support multiple
releases
So far only rpi4 cortexa72 SOCs are one which don’t have crypto are you
aware of some others ?

>
>
> [YOCTO #14641]
>
> Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
> ---
>  .../conf/machine/include/arm/armv8a/tune-cortexa72.inc | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> index 2a510bd45b..8c32286c84 100644
> --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> @@ -6,8 +6,12 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES',
> 'cortexa72', ' -mcpu=corte
>  require conf/machine/include/arm/arch-armv8a.inc
>
>  # Little Endian base configs
> -AVAILTUNES += "cortexa72"
> +AVAILTUNES += "cortexa72 cortexa72-crypto"
>  ARMPKGARCH:tune-cortexa72             = "cortexa72"
> -TUNE_FEATURES:tune-cortexa72          =
> "${TUNE_FEATURES:tune-armv8a-crc-crypto} cortexa72"
> -PACKAGE_EXTRA_ARCHS:tune-cortexa72    =
> "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72"
> +ARMPKGARCH:tune-cortexa72-crypto      = "cortexa72"
> +TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a}
> cortexa72"
> +TUNE_FEATURES:tune-cortexa72-crypto   = "${TUNE_FEATURES:tune-cortexa72}
> crc crypto"
> +PACKAGE_EXTRA_ARCHS:tune-cortexa72    =
> "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
> +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crypto    =
> "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crypto"
>  BASE_LIB:tune-cortexa72               = "lib64"
> +BASE_LIB:tune-cortexa72-crypto        = "lib64"
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159190):
> https://lists.openembedded.org/g/openembedded-core/message/159190
> Mute This Topic: https://lists.openembedded.org/mt/87515896/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3981 bytes --]

Re: [OE-core][PATCH] tune-cortexa72: Add new tune for crc and crypto

[Jagadeesh Krishnanjanappa]

[-- Attachment #1: Type: text/plain, Size: 3243 bytes --]

So far only rpi4 cortexa72 SOCs are one which don’t have crypto are you
aware of some others ?
JK: I do not know other SoCs which do not have crypto. The change is
similar to other
meta/conf/machine/include/arm/armv8a/tune-cortexa*.inc files where crypto
has been added as
separate DEFAULTTUNE.

Regards,
Jagadeesh


On Sun, Dec 5, 2021 at 10:54 PM Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On Sun, Dec 5, 2021 at 3:36 AM Jagadeesh Krishnanjanappa <
> workjagadeesh@gmail.com> wrote:
>
>> The newly added cortexa72-crypto tune builds programs for armv8a
>> with crc+crypto. Whereas default tune cortexa72 builds programs
>> with armv8a only.
>
>
> There is another patch I sent to add converse infact to support nocrypto
> instead because this change you propose will regress existing cortexa72
> tunes for machines which have crypto aes implemented in hardware and it
> will be not backward compatible since many bsps try to support multiple
> releases
> So far only rpi4 cortexa72 SOCs are one which don’t have crypto are you
> aware of some others ?
>
>>
>>
>> [YOCTO #14641]
>>
>> Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
>> ---
>>  .../conf/machine/include/arm/armv8a/tune-cortexa72.inc | 10 +++++++---
>>  1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
>> b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
>> index 2a510bd45b..8c32286c84 100644
>> --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
>> +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
>> @@ -6,8 +6,12 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES',
>> 'cortexa72', ' -mcpu=corte
>>  require conf/machine/include/arm/arch-armv8a.inc
>>
>>  # Little Endian base configs
>> -AVAILTUNES += "cortexa72"
>> +AVAILTUNES += "cortexa72 cortexa72-crypto"
>>  ARMPKGARCH:tune-cortexa72             = "cortexa72"
>> -TUNE_FEATURES:tune-cortexa72          =
>> "${TUNE_FEATURES:tune-armv8a-crc-crypto} cortexa72"
>> -PACKAGE_EXTRA_ARCHS:tune-cortexa72    =
>> "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72"
>> +ARMPKGARCH:tune-cortexa72-crypto      = "cortexa72"
>> +TUNE_FEATURES:tune-cortexa72          = "${TUNE_FEATURES:tune-armv8a}
>> cortexa72"
>> +TUNE_FEATURES:tune-cortexa72-crypto   = "${TUNE_FEATURES:tune-cortexa72}
>> crc crypto"
>> +PACKAGE_EXTRA_ARCHS:tune-cortexa72    =
>> "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
>> +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crypto    =
>> "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crypto"
>>  BASE_LIB:tune-cortexa72               = "lib64"
>> +BASE_LIB:tune-cortexa72-crypto        = "lib64"
>> --
>> 2.17.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#159190):
>> https://lists.openembedded.org/g/openembedded-core/message/159190
>> Mute This Topic: https://lists.openembedded.org/mt/87515896/1997914
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
>> raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>>

[-- Attachment #2: Type: text/html, Size: 4915 bytes --]