All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <p.yadav@ti.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: macromorgan@hotmail.com, vigneshr@ti.com, jaimeliao@mxic.com.tw,
	richard@nod.at, esben@geanix.com, linux@rasmusvillemoes.dk,
	knaerzche@gmail.com, nicolas.ferre@microchip.com,
	michael@walle.cc, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, code@reto-schneider.ch,
	miquel.raynal@bootlin.com, heiko.thiery@gmail.com, sr@denx.de,
	mail@david-bauer.net, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v5 01/14] mtd: spi-nor: Fix mtd size for s3an flashes
Date: Mon, 6 Dec 2021 17:24:36 +0530	[thread overview]
Message-ID: <20211206115434.t5yv53vfiapnribq@ti.com> (raw)
In-Reply-To: <20211203142256.47370-2-tudor.ambarus@microchip.com>

On 03/12/21 04:22PM, Tudor Ambarus wrote:
> As it was before the blamed commit, s3an_nor_scan() was called
> after mtd size was set with params->size, and it overwrote the mtd
> size value with '8 * nor->page_size * nor->info->n_sectors' when
> XSR_PAGESIZE was set. With the introduction of
> s3an_post_sfdp_fixups(), we missed to update the mtd size for the
> s3an flashes. Fix the mtd size by updating both nor->params->size,
> (which will update the mtd_info size later on) and nor->mtd.size
> (which is used in spi_nor_set_addr_width()).
> 
> Fixes: 641edddb4f43 ("mtd: spi-nor: Add s3an_post_sfdp_fixups()")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>  drivers/mtd/spi-nor/xilinx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/xilinx.c b/drivers/mtd/spi-nor/xilinx.c
> index 7e970ccf7903..03d3b006a039 100644
> --- a/drivers/mtd/spi-nor/xilinx.c
> +++ b/drivers/mtd/spi-nor/xilinx.c
> @@ -69,7 +69,8 @@ static int xilinx_nor_setup(struct spi_nor *nor,
>  		page_size = (nor->params->page_size == 264) ? 256 : 512;
>  		nor->params->page_size = page_size;
>  		nor->mtd.writebufsize = page_size;
> -		nor->mtd.size = 8 * page_size * nor->info->n_sectors;
> +		nor->params->size = 8 * page_size * nor->info->n_sectors;
> +		nor->mtd.size = nor->params->size;

I supposed you could just have done this in patch 2 directly, but this 
is fine too.

Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: macromorgan@hotmail.com, vigneshr@ti.com, jaimeliao@mxic.com.tw,
	richard@nod.at, esben@geanix.com, linux@rasmusvillemoes.dk,
	knaerzche@gmail.com, michael@walle.cc,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, code@reto-schneider.ch,
	miquel.raynal@bootlin.com, heiko.thiery@gmail.com, sr@denx.de,
	figgyc@figgyc.uk, mail@david-bauer.net, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v5 01/14] mtd: spi-nor: Fix mtd size for s3an flashes
Date: Mon, 6 Dec 2021 17:24:36 +0530	[thread overview]
Message-ID: <20211206115434.t5yv53vfiapnribq@ti.com> (raw)
In-Reply-To: <20211203142256.47370-2-tudor.ambarus@microchip.com>

On 03/12/21 04:22PM, Tudor Ambarus wrote:
> As it was before the blamed commit, s3an_nor_scan() was called
> after mtd size was set with params->size, and it overwrote the mtd
> size value with '8 * nor->page_size * nor->info->n_sectors' when
> XSR_PAGESIZE was set. With the introduction of
> s3an_post_sfdp_fixups(), we missed to update the mtd size for the
> s3an flashes. Fix the mtd size by updating both nor->params->size,
> (which will update the mtd_info size later on) and nor->mtd.size
> (which is used in spi_nor_set_addr_width()).
> 
> Fixes: 641edddb4f43 ("mtd: spi-nor: Add s3an_post_sfdp_fixups()")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>  drivers/mtd/spi-nor/xilinx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/xilinx.c b/drivers/mtd/spi-nor/xilinx.c
> index 7e970ccf7903..03d3b006a039 100644
> --- a/drivers/mtd/spi-nor/xilinx.c
> +++ b/drivers/mtd/spi-nor/xilinx.c
> @@ -69,7 +69,8 @@ static int xilinx_nor_setup(struct spi_nor *nor,
>  		page_size = (nor->params->page_size == 264) ? 256 : 512;
>  		nor->params->page_size = page_size;
>  		nor->mtd.writebufsize = page_size;
> -		nor->mtd.size = 8 * page_size * nor->info->n_sectors;
> +		nor->params->size = 8 * page_size * nor->info->n_sectors;
> +		nor->mtd.size = nor->params->size;

I supposed you could just have done this in patch 2 directly, but this 
is fine too.

Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-06 11:56 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 14:22 [PATCH v5 00/14] mtd: spi-nor: Clean params init Tudor Ambarus
2021-12-03 14:22 ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 01/14] mtd: spi-nor: Fix mtd size for s3an flashes Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-06 11:54   ` Pratyush Yadav [this message]
2021-12-06 11:54     ` Pratyush Yadav
2021-12-06 14:40     ` Tudor.Ambarus
2021-12-06 14:40       ` Tudor.Ambarus
2021-12-03 14:22 ` [PATCH v5 02/14] mtd: spi-nor: core: Don't use mtd_info in the NOR's probe sequence of calls Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-06 11:55   ` Pratyush Yadav
2021-12-06 11:55     ` Pratyush Yadav
2021-12-03 14:22 ` [PATCH v5 03/14] mtd: spi-nor: Introduce spi_nor_set_mtd_info() Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 04/14] mtd: spi-nor: core: Call spi_nor_post_sfdp_fixups() only when SFDP is defined Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 05/14] mtd: spi-nor: core: Introduce flash_info mfr_flags Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 06/14] mtd: spi-nor: Rework the flash_info flags Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 07/14] mtd: spi-nor: Introduce spi_nor_init_flags() Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 08/14] mtd: spi-nor: Introduce spi_nor_init_fixup_flags() Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 09/14] mtd: spi-nor: core: Init all flash parameters based on SFDP where possible Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-06 12:22   ` Pratyush Yadav
2021-12-06 12:22     ` Pratyush Yadav
2021-12-06 13:52     ` Tudor.Ambarus
2021-12-06 13:52       ` Tudor.Ambarus
2021-12-06 15:04       ` Pratyush Yadav
2021-12-06 15:04         ` Pratyush Yadav
2021-12-06 18:12         ` Tudor.Ambarus
2021-12-06 18:12           ` Tudor.Ambarus
2021-12-03 14:22 ` [PATCH v5 10/14] mtd: spi-nor: core: Move spi_nor_set_addr_width() in spi_nor_setup() Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 11/14] mtd: spi-nor: winbond: w25q256jvm: Init flash based on SFDP Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 12/14] mtd: spi-nor: spansion: s25fl256s0: Skip SFDP parsing Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 13/14] mtd: spi-nor: gigadevice: gd25q256: Init flash based on SFDP Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-03 14:22 ` [PATCH v5 14/14] mtd: spi-nor: issi: is25lp256: " Tudor Ambarus
2021-12-03 14:22   ` Tudor Ambarus
2021-12-06 12:25 ` [PATCH v5 00/14] mtd: spi-nor: Clean params init Pratyush Yadav
2021-12-06 12:25   ` Pratyush Yadav
2021-12-06 13:53   ` Tudor.Ambarus
2021-12-06 13:53     ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211206115434.t5yv53vfiapnribq@ti.com \
    --to=p.yadav@ti.com \
    --cc=code@reto-schneider.ch \
    --cc=esben@geanix.com \
    --cc=heiko.thiery@gmail.com \
    --cc=jaimeliao@mxic.com.tw \
    --cc=knaerzche@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=macromorgan@hotmail.com \
    --cc=mail@david-bauer.net \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=richard@nod.at \
    --cc=sr@denx.de \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.