All of lore.kernel.org
 help / color / mirror / Atom feed
* + fs-move-dcache-sysctls-to-its-own-file-fix-2.patch added to -mm tree
@ 2021-12-03 20:14 akpm
  2021-12-06  7:39 ` Stephen Rothwell
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2021-12-03 20:14 UTC (permalink / raw)
  To: arnd, mcgrof, mm-commits, sfr


The patch titled
     Subject: fs/dcache: avoid unused-function warning
has been added to the -mm tree.  Its filename is
     fs-move-dcache-sysctls-to-its-own-file-fix-2.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/fs-move-dcache-sysctls-to-its-own-file-fix-2.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/fs-move-dcache-sysctls-to-its-own-file-fix-2.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Arnd Bergmann <arnd@arndb.de>
Subject: fs/dcache: avoid unused-function warning

Now that 'dentry_stat' is marked 'static', we can run into this warning:

fs/dcache.c:128:29: error: 'dentry_stat' defined but not used [-Werror=unused-variable]
  128 | static struct dentry_stat_t dentry_stat = {

Hide it in the same #ifdef as its only references.

Link: https://lkml.kernel.org/r/20211203190123.874239-2-arnd@kernel.org
Fixes: f0eea17ca8da ("fs: move dcache sysctls to its own file")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/dcache.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

--- a/fs/dcache.c~fs-move-dcache-sysctls-to-its-own-file-fix-2
+++ a/fs/dcache.c
@@ -124,16 +124,15 @@ struct dentry_stat_t {
 	long dummy;		/* Reserved for future use */
 };
 
-/* Statistics gathering. */
-static struct dentry_stat_t dentry_stat = {
-	.age_limit = 45,
-};
-
 static DEFINE_PER_CPU(long, nr_dentry);
 static DEFINE_PER_CPU(long, nr_dentry_unused);
 static DEFINE_PER_CPU(long, nr_dentry_negative);
 
 #if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS)
+/* Statistics gathering. */
+static struct dentry_stat_t dentry_stat = {
+	.age_limit = 45,
+};
 
 /*
  * Here we resort to our own counters instead of using generic per-cpu counters
_

Patches currently in -mm which might be from arnd@arndb.de are

fs-move-inode-sysctls-to-its-own-file-fix.patch
fs-move-dcache-sysctls-to-its-own-file-fix-2.patch


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: + fs-move-dcache-sysctls-to-its-own-file-fix-2.patch added to -mm tree
  2021-12-03 20:14 + fs-move-dcache-sysctls-to-its-own-file-fix-2.patch added to -mm tree akpm
@ 2021-12-06  7:39 ` Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2021-12-06  7:39 UTC (permalink / raw)
  To: akpm; +Cc: arnd, mcgrof, mm-commits

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Hi all,

On Fri, 03 Dec 2021 12:14:31 -0800 akpm@linux-foundation.org wrote:
>
> The patch titled
>      Subject: fs/dcache: avoid unused-function warning
> has been added to the -mm tree.  Its filename is
>      fs-move-dcache-sysctls-to-its-own-file-fix-2.patch

Added to linux-next today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-06  7:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-03 20:14 + fs-move-dcache-sysctls-to-its-own-file-fix-2.patch added to -mm tree akpm
2021-12-06  7:39 ` Stephen Rothwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.