From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Jiri Slaby <jslaby@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
ardb@kernel.org, broonie@kernel.org, catalin.marinas@arm.com,
dave.hansen@linux.intel.com,
linux-arm-kernel@lists.infradead.org, maz@kernel.org,
mingo@redhat.com, tabba@google.com, tglx@linutronix.de,
will@kernel.org
Subject: Re: [RFC PATCH 0/6] linkage: better symbol aliasing
Date: Mon, 6 Dec 2021 21:23:04 -0800 [thread overview]
Message-ID: <20211207052304.pb76ofjymf7o2yyb@treble> (raw)
In-Reply-To: <20211206124715.4101571-1-mark.rutland@arm.com>
On Mon, Dec 06, 2021 at 12:47:09PM +0000, Mark Rutland wrote:
> This avoids repetition and hopefully make it easier to ensure
> consistency (e.g. so each function has a single canonical name and
> associated metadata).
>
> I'm sending this as an RFC since I want to check:
>
> a) People are happy with the idea in principle.
>
> b) People are happy with the implementation within <linux/linkage.h>.
>
> ... and I haven't yet converted the headers under tools/, which is
> largely a copy+paste job.
Looks like a definite improvement to me.
The only suggestion I'd have would be to fix a minor naming
inconsistency: change "SYM_FUNC_LOCAL_ALIAS" to "SYM_FUNC_ALIAS_LOCAL"
to match the other "<noun>_<verb>" macros.
--
Josh
WARNING: multiple messages have this Message-ID (diff)
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Jiri Slaby <jslaby@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
ardb@kernel.org, broonie@kernel.org, catalin.marinas@arm.com,
dave.hansen@linux.intel.com,
linux-arm-kernel@lists.infradead.org, maz@kernel.org,
mingo@redhat.com, tabba@google.com, tglx@linutronix.de,
will@kernel.org
Subject: Re: [RFC PATCH 0/6] linkage: better symbol aliasing
Date: Mon, 6 Dec 2021 21:23:04 -0800 [thread overview]
Message-ID: <20211207052304.pb76ofjymf7o2yyb@treble> (raw)
In-Reply-To: <20211206124715.4101571-1-mark.rutland@arm.com>
On Mon, Dec 06, 2021 at 12:47:09PM +0000, Mark Rutland wrote:
> This avoids repetition and hopefully make it easier to ensure
> consistency (e.g. so each function has a single canonical name and
> associated metadata).
>
> I'm sending this as an RFC since I want to check:
>
> a) People are happy with the idea in principle.
>
> b) People are happy with the implementation within <linux/linkage.h>.
>
> ... and I haven't yet converted the headers under tools/, which is
> largely a copy+paste job.
Looks like a definite improvement to me.
The only suggestion I'd have would be to fix a minor naming
inconsistency: change "SYM_FUNC_LOCAL_ALIAS" to "SYM_FUNC_ALIAS_LOCAL"
to match the other "<noun>_<verb>" macros.
--
Josh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-07 5:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:47 [RFC PATCH 0/6] linkage: better symbol aliasing Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 1/6] linkage: add SYM_{ENTRY,START,END}_AT() Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 2/6] linkage: add SYM_FUNC_{LOCAL_,}ALIAS() Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 3/6] arm64: remove __dma_*_area() aliases Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-10 15:02 ` Catalin Marinas
2021-12-10 15:02 ` Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 4/6] arm64: clean up symbol aliasing Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-10 15:02 ` Catalin Marinas
2021-12-10 15:02 ` Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 5/6] x86: " Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 6/6] linkage: remove START/END ALIAS macros Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-06 14:06 ` [RFC PATCH 0/6] linkage: better symbol aliasing Ard Biesheuvel
2021-12-06 14:06 ` Ard Biesheuvel
2021-12-06 15:10 ` Mark Brown
2021-12-06 15:10 ` Mark Brown
2021-12-07 5:23 ` Josh Poimboeuf [this message]
2021-12-07 5:23 ` Josh Poimboeuf
2021-12-07 13:33 ` Mark Rutland
2021-12-07 13:33 ` Mark Rutland
2021-12-10 15:04 ` Catalin Marinas
2021-12-10 15:04 ` Catalin Marinas
2021-12-15 9:24 ` Mark Rutland
2021-12-15 9:24 ` Mark Rutland
2021-12-15 11:28 ` (subset) " Catalin Marinas
2021-12-15 11:28 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207052304.pb76ofjymf7o2yyb@treble \
--to=jpoimboe@redhat.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tabba@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.