All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zev Weiss <zev@bewilderbeest.net>
To: linux-hwmon@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.com>,
	openbmc@lists.ozlabs.org, Zev Weiss <zev@bewilderbeest.net>
Subject: [PATCH v3 0/2] hwmon: (pmbus) Add Delta AHE-50DC fan control module driver
Date: Mon,  6 Dec 2021 23:15:19 -0800	[thread overview]
Message-ID: <20211207071521.543-1-zev@bewilderbeest.net> (raw)

Hello,

These patches add a hwmon pmbus driver for the integrated fan control
module in the Delta AHE-50DC Open19 power shelf.  I don't know of a
datasheet or any proper documentation for it; the registers it has
available have deen deduced from a combination of an existing GPL
driver in a code release from LinkedIn [0] and some manual
experimentation with i2cdump.  In addition to some standard PMBus
sensors (three temperature readings, four fan speeds, and one
voltage), it also has a manufacturer-specific fourth temperature
reading available, which is supported via a virtual second page (the
device itself is not paged, but the driver remaps
PMBUS_READ_TEMPERATURE_1 in page 1 to the manufacturer-specific
TEMPERATURE_4).


Thanks,
Zev Weiss

Changes since v2 [2]:
 - converted to pmbus driver

Changes since v1 [1]:
 - fixed invalid name warning from __hwmon_device_register()

[0] https://github.com/linkedin/o19-bmc-firmware/blob/master/meta-openbmc/meta-linkedin/meta-deltapower/recipes-kernel/fancontrol-mod/files/fancontrol.c
[1] https://lore.kernel.org/linux-hwmon/20211206224419.15736-1-zev@bewilderbeest.net/
[2] https://lore.kernel.org/linux-hwmon/20211206230153.16891-1-zev@bewilderbeest.net/

Zev Weiss (2):
  hwmon: (pmbus) Add Delta AHE-50DC fan control module driver
  dt-bindings: add Delta AHE-50DC fan control module

 .../devicetree/bindings/trivial-devices.yaml  |  2 +
 MAINTAINERS                                   |  6 ++
 drivers/hwmon/pmbus/Kconfig                   | 12 +++
 drivers/hwmon/pmbus/Makefile                  |  1 +
 drivers/hwmon/pmbus/delta-ahe50dc-fan.c       | 84 +++++++++++++++++++
 5 files changed, 105 insertions(+)
 create mode 100644 drivers/hwmon/pmbus/delta-ahe50dc-fan.c

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zev@bewilderbeest.net>
To: linux-hwmon@vger.kernel.org
Cc: openbmc@lists.ozlabs.org, Jean Delvare <jdelvare@suse.com>,
	Zev Weiss <zev@bewilderbeest.net>,
	Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v3 0/2] hwmon: (pmbus) Add Delta AHE-50DC fan control module driver
Date: Mon,  6 Dec 2021 23:15:19 -0800	[thread overview]
Message-ID: <20211207071521.543-1-zev@bewilderbeest.net> (raw)

Hello,

These patches add a hwmon pmbus driver for the integrated fan control
module in the Delta AHE-50DC Open19 power shelf.  I don't know of a
datasheet or any proper documentation for it; the registers it has
available have deen deduced from a combination of an existing GPL
driver in a code release from LinkedIn [0] and some manual
experimentation with i2cdump.  In addition to some standard PMBus
sensors (three temperature readings, four fan speeds, and one
voltage), it also has a manufacturer-specific fourth temperature
reading available, which is supported via a virtual second page (the
device itself is not paged, but the driver remaps
PMBUS_READ_TEMPERATURE_1 in page 1 to the manufacturer-specific
TEMPERATURE_4).


Thanks,
Zev Weiss

Changes since v2 [2]:
 - converted to pmbus driver

Changes since v1 [1]:
 - fixed invalid name warning from __hwmon_device_register()

[0] https://github.com/linkedin/o19-bmc-firmware/blob/master/meta-openbmc/meta-linkedin/meta-deltapower/recipes-kernel/fancontrol-mod/files/fancontrol.c
[1] https://lore.kernel.org/linux-hwmon/20211206224419.15736-1-zev@bewilderbeest.net/
[2] https://lore.kernel.org/linux-hwmon/20211206230153.16891-1-zev@bewilderbeest.net/

Zev Weiss (2):
  hwmon: (pmbus) Add Delta AHE-50DC fan control module driver
  dt-bindings: add Delta AHE-50DC fan control module

 .../devicetree/bindings/trivial-devices.yaml  |  2 +
 MAINTAINERS                                   |  6 ++
 drivers/hwmon/pmbus/Kconfig                   | 12 +++
 drivers/hwmon/pmbus/Makefile                  |  1 +
 drivers/hwmon/pmbus/delta-ahe50dc-fan.c       | 84 +++++++++++++++++++
 5 files changed, 105 insertions(+)
 create mode 100644 drivers/hwmon/pmbus/delta-ahe50dc-fan.c

-- 
2.34.1


             reply	other threads:[~2021-12-07  7:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07  7:15 Zev Weiss [this message]
2021-12-07  7:15 ` [PATCH v3 0/2] hwmon: (pmbus) Add Delta AHE-50DC fan control module driver Zev Weiss
2021-12-07  7:15 ` [PATCH v3 1/2] " Zev Weiss
2021-12-07  7:15   ` Zev Weiss
2021-12-07 17:50   ` Guenter Roeck
2021-12-07 17:50     ` Guenter Roeck
2021-12-07 19:22     ` Zev Weiss
2021-12-07 19:22       ` Zev Weiss
2021-12-07 19:44       ` Guenter Roeck
2021-12-07 19:44         ` Guenter Roeck
2021-12-07 21:53         ` Zev Weiss
2021-12-07 21:53           ` Zev Weiss
2021-12-07 22:39           ` Zev Weiss
2021-12-07 22:39             ` Zev Weiss
2021-12-07 23:15           ` Guenter Roeck
2021-12-07 23:15             ` Guenter Roeck
2021-12-08  0:41             ` Zev Weiss
2021-12-08  0:41               ` Zev Weiss
2021-12-08  0:54               ` Guenter Roeck
2021-12-08  0:54                 ` Guenter Roeck
2021-12-07 19:53       ` Guenter Roeck
2021-12-07 19:53         ` Guenter Roeck
2021-12-07  7:15 ` [PATCH v3 2/2] dt-bindings: add Delta AHE-50DC fan control module Zev Weiss
2021-12-07  7:15   ` Zev Weiss
2021-12-07  7:58   ` Krzysztof Kozlowski
2021-12-07  7:58     ` Krzysztof Kozlowski
2021-12-07  8:48     ` Zev Weiss
2021-12-07  8:48       ` Zev Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211207071521.543-1-zev@bewilderbeest.net \
    --to=zev@bewilderbeest.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.