[PATCH] dt-bindings: pwm: Avoid selecting schema on node name match

[PATCH] dt-bindings: pwm: Avoid selecting schema on node name match

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

Currently any node whose name starts with the "pwm-" prefix will match
this schema and in turn required the "#pwm-cells" property. Avoid this
by marking the schema with select: false, therefore only activating the
schema when directly included from a PWM controller schema file.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Rob,

I've seen this used in some other schema files, but wanted to
double-check with you if this is the correct solution for this problem.

Thanks,
Thierry

 Documentation/devicetree/bindings/pwm/pwm.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
index 2effe6c0de6b..3c01f85029e5 100644
--- a/Documentation/devicetree/bindings/pwm/pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
@@ -9,6 +9,8 @@ title: PWM controllers (providers)
 maintainers:
   - Thierry Reding <thierry.reding@gmail.com>
 
+select: false
+
 properties:
   $nodename:
     pattern: "^pwm(@.*|-[0-9a-f])*$"
-- 
2.33.1

Re: [PATCH] dt-bindings: pwm: Avoid selecting schema on node name match

[Rob Herring]

On Tue, Dec 07, 2021 at 01:48:55PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Currently any node whose name starts with the "pwm-" prefix will match
> this schema and in turn required the "#pwm-cells" property. Avoid this
> by marking the schema with select: false, therefore only activating the
> schema when directly included from a PWM controller schema file.

Pinctrl nodes? I'd rather change pin node names.

> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Rob,
> 
> I've seen this used in some other schema files, but wanted to
> double-check with you if this is the correct solution for this problem.

I suppose this is fine. This schema is just about pointless as each 
producer has to define #pwm-cells anyways.

Acked-by: Rob Herring <robh@kernel.org>

> 
> Thanks,
> Thierry
> 
>  Documentation/devicetree/bindings/pwm/pwm.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
> index 2effe6c0de6b..3c01f85029e5 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
> @@ -9,6 +9,8 @@ title: PWM controllers (providers)
>  maintainers:
>    - Thierry Reding <thierry.reding@gmail.com>
>  
> +select: false
> +
>  properties:
>    $nodename:
>      pattern: "^pwm(@.*|-[0-9a-f])*$"
> -- 
> 2.33.1
> 
>