* [net-next v2 0/2] net: sched: allow user to select txqueue @ 2021-12-08 14:34 xiangxia.m.yue 2021-12-08 14:34 ` [net-next v2 1/2] net: sched: use queue_mapping to pick tx queue xiangxia.m.yue 2021-12-08 14:34 ` [net-next v2 2/2] net: sched: support hash/classid selecting " xiangxia.m.yue 0 siblings, 2 replies; 9+ messages in thread From: xiangxia.m.yue @ 2021-12-08 14:34 UTC (permalink / raw) To: netdev Cc: Tonghao Zhang, Jamal Hadi Salim, Cong Wang, Jiri Pirko, David S. Miller, Jakub Kicinski, Jonathan Lemon, Eric Dumazet, Alexander Lobakin, Paolo Abeni, Talal Ahmad, Kevin Hao, Ilias Apalodimas, Kees Cook, Kumar Kartikeya Dwivedi, Antoine Tenart, Wei Wang, Arnd Bergmann From: Tonghao Zhang <xiangxia.m.yue@gmail.com> Patch 1 allow user to select txqueue in clsact hook. Patch 2 support skb-hash and classid to select txqueue. Tonghao Zhang (2): net: sched: use queue_mapping to pick tx queue net: sched: support hash/classid selecting tx queue include/linux/netdevice.h | 21 +++++++++ include/net/tc_act/tc_skbedit.h | 1 + include/uapi/linux/tc_act/tc_skbedit.h | 6 +++ net/core/dev.c | 6 ++- net/sched/act_skbedit.c | 60 ++++++++++++++++++++++++-- 5 files changed, 89 insertions(+), 5 deletions(-) -- Cc: Jamal Hadi Salim <jhs@mojatatu.com> Cc: Cong Wang <xiyou.wangcong@gmail.com> Cc: Jiri Pirko <jiri@resnulli.us> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Jonathan Lemon <jonathan.lemon@gmail.com> Cc: Eric Dumazet <edumazet@google.com> Cc: Alexander Lobakin <alobakin@pm.me> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Talal Ahmad <talalahmad@google.com> Cc: Kevin Hao <haokexin@gmail.com> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org> Cc: Kees Cook <keescook@chromium.org> Cc: Kumar Kartikeya Dwivedi <memxor@gmail.com> Cc: Antoine Tenart <atenart@kernel.org> Cc: Wei Wang <weiwan@google.com> Cc: Arnd Bergmann <arnd@arndb.de> -- 2.27.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [net-next v2 1/2] net: sched: use queue_mapping to pick tx queue 2021-12-08 14:34 [net-next v2 0/2] net: sched: allow user to select txqueue xiangxia.m.yue @ 2021-12-08 14:34 ` xiangxia.m.yue 2021-12-08 14:34 ` [net-next v2 2/2] net: sched: support hash/classid selecting " xiangxia.m.yue 1 sibling, 0 replies; 9+ messages in thread From: xiangxia.m.yue @ 2021-12-08 14:34 UTC (permalink / raw) To: netdev Cc: Tonghao Zhang, Jamal Hadi Salim, Cong Wang, Jiri Pirko, David S. Miller, Jakub Kicinski, Jonathan Lemon, Eric Dumazet, Alexander Lobakin, Paolo Abeni, Talal Ahmad, Kevin Hao, Ilias Apalodimas, Kees Cook, Kumar Kartikeya Dwivedi, Antoine Tenart, Wei Wang, Arnd Bergmann From: Tonghao Zhang <xiangxia.m.yue@gmail.com> This patch fix issue: * If we install tc filters with act_skbedit in clsact hook. It doesn't work, because netdev_core_pick_tx() overwrites queue_mapping. $ tc filter ... action skbedit queue_mapping 1 And this patch is useful: * We can use FQ + EDT to implement efficient policies. Tx queues are picked by xps, ndo_select_queue of netdev driver, or skb hash in netdev_core_pick_tx(). In fact, the netdev driver, and skb hash are _not_ under control. xps uses the CPUs map to select Tx queues, but we can't figure out which task_struct of pod/containter running on this cpu in most case. We can use clsact filters to classify one pod/container traffic to one Tx queue. Why ? In containter networking environment, there are two kinds of pod/ containter/net-namespace. One kind (e.g. P1, P2), the high throughput is key in these applications. But avoid running out of network resource, the outbound traffic of these pods is limited, using or sharing one dedicated Tx queues assigned HTB/TBF/FQ Qdisc. Other kind of pods (e.g. Pn), the low latency of data access is key. And the traffic is not limited. Pods use or share other dedicated Tx queues assigned FIFO Qdisc. This choice provides two benefits. First, contention on the HTB/FQ Qdisc lock is significantly reduced since fewer CPUs contend for the same queue. More importantly, Qdisc contention can be eliminated completely if each CPU has its own FIFO Qdisc for the second kind of pods. There must be a mechanism in place to support classifying traffic based on pods/container to different Tx queues. Note that clsact is outside of Qdisc while Qdisc can run a classifier to select a sub-queue under the lock. In general recording the decision in the skb seems a little heavy handed. This patch introduces a per-CPU variable, suggested by Eric. The skip txqueue flag will be cleared to avoid picking Tx queue in next netdev, for example (not usual case): eth0 (macvlan in Pod, skbedit queue_mapping) -> eth0.3 (vlan in Host) -> eth0 (ixgbe in Host). +----+ +----+ +----+ | P1 | | P2 | | Pn | +----+ +----+ +----+ | | | +-----------+-----------+ | | clsact/skbedit | MQ v +-----------+-----------+ | q0 | q1 | qn v v v HTB/FQ HTB/FQ ... FIFO Cc: Jamal Hadi Salim <jhs@mojatatu.com> Cc: Cong Wang <xiyou.wangcong@gmail.com> Cc: Jiri Pirko <jiri@resnulli.us> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Jonathan Lemon <jonathan.lemon@gmail.com> Cc: Eric Dumazet <edumazet@google.com> Cc: Alexander Lobakin <alobakin@pm.me> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Talal Ahmad <talalahmad@google.com> Cc: Kevin Hao <haokexin@gmail.com> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org> Cc: Kees Cook <keescook@chromium.org> Cc: Kumar Kartikeya Dwivedi <memxor@gmail.com> Cc: Antoine Tenart <atenart@kernel.org> Cc: Wei Wang <weiwan@google.com> Cc: Arnd Bergmann <arnd@arndb.de> Suggested-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com> --- include/linux/netdevice.h | 21 +++++++++++++++++++++ net/core/dev.c | 6 +++++- net/sched/act_skbedit.c | 4 +++- 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 65117f01d5f2..64f12a819246 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -2997,6 +2997,7 @@ struct softnet_data { /* written and read only by owning cpu: */ struct { u16 recursion; + u8 skip_txqueue; u8 more; } xmit; #ifdef CONFIG_RPS @@ -4633,6 +4634,26 @@ static inline netdev_tx_t netdev_start_xmit(struct sk_buff *skb, struct net_devi return rc; } +static inline void netdev_xmit_skip_txqueue(void) +{ + __this_cpu_write(softnet_data.xmit.skip_txqueue, 1); +} + +static inline bool netdev_xmit_txqueue_skipped(void) +{ + return __this_cpu_read(softnet_data.xmit.skip_txqueue); +} + +static inline struct netdev_queue * +netdev_tx_queue_mapping(struct net_device *dev, struct sk_buff *skb) +{ + int qm = skb_get_queue_mapping(skb); + + /* Take effect only on current netdev. */ + __this_cpu_write(softnet_data.xmit.skip_txqueue, 0); + return netdev_get_tx_queue(dev, netdev_cap_txqueue(dev, qm)); +} + int netdev_class_create_file_ns(const struct class_attribute *class_attr, const void *ns); void netdev_class_remove_file_ns(const struct class_attribute *class_attr, diff --git a/net/core/dev.c b/net/core/dev.c index aba8acc1238c..a64297a4cc89 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4069,7 +4069,11 @@ static int __dev_queue_xmit(struct sk_buff *skb, struct net_device *sb_dev) else skb_dst_force(skb); - txq = netdev_core_pick_tx(dev, skb, sb_dev); + if (netdev_xmit_txqueue_skipped()) + txq = netdev_tx_queue_mapping(dev, skb); + else + txq = netdev_core_pick_tx(dev, skb, sb_dev); + q = rcu_dereference_bh(txq->qdisc); trace_net_dev_queue(skb); diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c index d30ecbfc8f84..498feedad70a 100644 --- a/net/sched/act_skbedit.c +++ b/net/sched/act_skbedit.c @@ -58,8 +58,10 @@ static int tcf_skbedit_act(struct sk_buff *skb, const struct tc_action *a, } } if (params->flags & SKBEDIT_F_QUEUE_MAPPING && - skb->dev->real_num_tx_queues > params->queue_mapping) + skb->dev->real_num_tx_queues > params->queue_mapping) { + netdev_xmit_skip_txqueue(); skb_set_queue_mapping(skb, params->queue_mapping); + } if (params->flags & SKBEDIT_F_MARK) { skb->mark &= ~params->mask; skb->mark |= params->mark & params->mask; -- 2.27.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [net-next v2 2/2] net: sched: support hash/classid selecting tx queue 2021-12-08 14:34 [net-next v2 0/2] net: sched: allow user to select txqueue xiangxia.m.yue 2021-12-08 14:34 ` [net-next v2 1/2] net: sched: use queue_mapping to pick tx queue xiangxia.m.yue @ 2021-12-08 14:34 ` xiangxia.m.yue 2021-12-08 22:21 ` kernel test robot 2021-12-08 22:32 ` kernel test robot 1 sibling, 2 replies; 9+ messages in thread From: xiangxia.m.yue @ 2021-12-08 14:34 UTC (permalink / raw) To: netdev Cc: Tonghao Zhang, Jamal Hadi Salim, Cong Wang, Jiri Pirko, David S. Miller, Jakub Kicinski, Jonathan Lemon, Eric Dumazet, Alexander Lobakin, Paolo Abeni, Talal Ahmad, Kevin Hao, Ilias Apalodimas, Kees Cook, Kumar Kartikeya Dwivedi, Antoine Tenart, Wei Wang, Arnd Bergmann From: Tonghao Zhang <xiangxia.m.yue@gmail.com> This patch allows users to select queue_mapping, range from A to B. And users can use skb-hash or cgroup classid to select Tx queues. Then the packets can load balance from A to B queue. $ tc filter ... action skbedit queue_mapping hash-type normal 0 4 "skbedit queue_mapping QUEUE_MAPPING" [0] is enhanced with two flags: SKBEDIT_F_QUEUE_MAPPING_HASH, SKBEDIT_F_QUEUE_MAPPING_CLASSID. The range is an unsigned 16bit value in decimal format. [0]: https://man7.org/linux/man-pages/man8/tc-skbedit.8.html Cc: Jamal Hadi Salim <jhs@mojatatu.com> Cc: Cong Wang <xiyou.wangcong@gmail.com> Cc: Jiri Pirko <jiri@resnulli.us> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Jonathan Lemon <jonathan.lemon@gmail.com> Cc: Eric Dumazet <edumazet@google.com> Cc: Alexander Lobakin <alobakin@pm.me> Cc: Paolo Abeni <pabeni@redhat.com> Cc: Talal Ahmad <talalahmad@google.com> Cc: Kevin Hao <haokexin@gmail.com> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org> Cc: Kees Cook <keescook@chromium.org> Cc: Kumar Kartikeya Dwivedi <memxor@gmail.com> Cc: Antoine Tenart <atenart@kernel.org> Cc: Wei Wang <weiwan@google.com> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com> --- include/net/tc_act/tc_skbedit.h | 1 + include/uapi/linux/tc_act/tc_skbedit.h | 6 +++ net/sched/act_skbedit.c | 58 ++++++++++++++++++++++++-- 3 files changed, 61 insertions(+), 4 deletions(-) diff --git a/include/net/tc_act/tc_skbedit.h b/include/net/tc_act/tc_skbedit.h index 00bfee70609e..ee96e0fa6566 100644 --- a/include/net/tc_act/tc_skbedit.h +++ b/include/net/tc_act/tc_skbedit.h @@ -17,6 +17,7 @@ struct tcf_skbedit_params { u32 mark; u32 mask; u16 queue_mapping; + u16 mapping_mod; u16 ptype; struct rcu_head rcu; }; diff --git a/include/uapi/linux/tc_act/tc_skbedit.h b/include/uapi/linux/tc_act/tc_skbedit.h index 800e93377218..8df288078dde 100644 --- a/include/uapi/linux/tc_act/tc_skbedit.h +++ b/include/uapi/linux/tc_act/tc_skbedit.h @@ -29,6 +29,11 @@ #define SKBEDIT_F_PTYPE 0x8 #define SKBEDIT_F_MASK 0x10 #define SKBEDIT_F_INHERITDSFIELD 0x20 +#define SKBEDIT_F_QUEUE_MAPPING_HASH 0x40 +#define SKBEDIT_F_QUEUE_MAPPING_CLASSID 0x80 + +#define SKBEDIT_F_QUEUE_MAPPING_HASH_MASK (SKBEDIT_F_QUEUE_MAPPING_HASH | \ + SKBEDIT_F_QUEUE_MAPPING_CLASSID) struct tc_skbedit { tc_gen; @@ -45,6 +50,7 @@ enum { TCA_SKBEDIT_PTYPE, TCA_SKBEDIT_MASK, TCA_SKBEDIT_FLAGS, + TCA_SKBEDIT_QUEUE_MAPPING_MAX, __TCA_SKBEDIT_MAX }; #define TCA_SKBEDIT_MAX (__TCA_SKBEDIT_MAX - 1) diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c index 498feedad70a..355b43999a4a 100644 --- a/net/sched/act_skbedit.c +++ b/net/sched/act_skbedit.c @@ -10,6 +10,7 @@ #include <linux/kernel.h> #include <linux/skbuff.h> #include <linux/rtnetlink.h> +#include <net/cls_cgroup.h> #include <net/netlink.h> #include <net/pkt_sched.h> #include <net/ip.h> @@ -23,6 +24,25 @@ static unsigned int skbedit_net_id; static struct tc_action_ops act_skbedit_ops; +static u16 tcf_skbedit_hash(struct tcf_skbedit_params *params, + struct sk_buff *skb) +{ + u16 queue_mapping = params->queue_mapping; + u16 mapping_mod = params->mapping_mod; + u32 hash; + + if (!(params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK)) + return netdev_cap_txqueue(skb->dev, queue_mapping); + + if (params->flags & SKBEDIT_F_QUEUE_MAPPING_CLASSID) + hash = jhash_1word(task_get_classid(skb), 0); + else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) + hash = skb_get_hash(skb); + + queue_mapping = queue_mapping + hash % mapping_mod; + return netdev_cap_txqueue(skb->dev, queue_mapping); +} + static int tcf_skbedit_act(struct sk_buff *skb, const struct tc_action *a, struct tcf_result *res) { @@ -57,10 +77,9 @@ static int tcf_skbedit_act(struct sk_buff *skb, const struct tc_action *a, break; } } - if (params->flags & SKBEDIT_F_QUEUE_MAPPING && - skb->dev->real_num_tx_queues > params->queue_mapping) { + if (params->flags & SKBEDIT_F_QUEUE_MAPPING) { netdev_xmit_skip_txqueue(); - skb_set_queue_mapping(skb, params->queue_mapping); + skb_set_queue_mapping(skb, tcf_skbedit_hash(params, skb)); } if (params->flags & SKBEDIT_F_MARK) { skb->mark &= ~params->mask; @@ -94,6 +113,7 @@ static const struct nla_policy skbedit_policy[TCA_SKBEDIT_MAX + 1] = { [TCA_SKBEDIT_PTYPE] = { .len = sizeof(u16) }, [TCA_SKBEDIT_MASK] = { .len = sizeof(u32) }, [TCA_SKBEDIT_FLAGS] = { .len = sizeof(u64) }, + [TCA_SKBEDIT_QUEUE_MAPPING_MAX] = { .len = sizeof(u16) }, }; static int tcf_skbedit_init(struct net *net, struct nlattr *nla, @@ -110,6 +130,7 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla, struct tcf_skbedit *d; u32 flags = 0, *priority = NULL, *mark = NULL, *mask = NULL; u16 *queue_mapping = NULL, *ptype = NULL; + u16 mapping_mod = 0; bool exists = false; int ret = 0, err; u32 index; @@ -157,6 +178,25 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla, if (*pure_flags & SKBEDIT_F_INHERITDSFIELD) flags |= SKBEDIT_F_INHERITDSFIELD; + if (*pure_flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK) { + u16 *queue_mapping_max; + + if (!tb[TCA_SKBEDIT_QUEUE_MAPPING_MAX]) + return -EINVAL; + + if (!tb[TCA_SKBEDIT_QUEUE_MAPPING]) + return -EINVAL; + + queue_mapping_max = + nla_data(tb[TCA_SKBEDIT_QUEUE_MAPPING_MAX]); + + if (*queue_mapping_max < *queue_mapping) + return -EINVAL; + + mapping_mod = *queue_mapping_max - *queue_mapping + 1; + flags |= *pure_flags & + SKBEDIT_F_QUEUE_MAPPING_HASH_MASK; + } } parm = nla_data(tb[TCA_SKBEDIT_PARMS]); @@ -206,8 +246,10 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla, params_new->flags = flags; if (flags & SKBEDIT_F_PRIORITY) params_new->priority = *priority; - if (flags & SKBEDIT_F_QUEUE_MAPPING) + if (flags & SKBEDIT_F_QUEUE_MAPPING) { params_new->queue_mapping = *queue_mapping; + params_new->mapping_mod = mapping_mod; + } if (flags & SKBEDIT_F_MARK) params_new->mark = *mark; if (flags & SKBEDIT_F_PTYPE) @@ -274,6 +316,14 @@ static int tcf_skbedit_dump(struct sk_buff *skb, struct tc_action *a, goto nla_put_failure; if (params->flags & SKBEDIT_F_INHERITDSFIELD) pure_flags |= SKBEDIT_F_INHERITDSFIELD; + if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK) { + if (nla_put_u16(skb, TCA_SKBEDIT_QUEUE_MAPPING_MAX, + params->queue_mapping + params->mapping_mod - 1)) + goto nla_put_failure; + + pure_flags |= params->flags & + SKBEDIT_F_QUEUE_MAPPING_HASH_MASK; + } if (pure_flags != 0 && nla_put(skb, TCA_SKBEDIT_FLAGS, sizeof(pure_flags), &pure_flags)) goto nla_put_failure; -- 2.27.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [net-next v2 2/2] net: sched: support hash/classid selecting tx queue 2021-12-08 14:34 ` [net-next v2 2/2] net: sched: support hash/classid selecting " xiangxia.m.yue @ 2021-12-08 22:21 ` kernel test robot 2021-12-08 22:32 ` kernel test robot 1 sibling, 0 replies; 9+ messages in thread From: kernel test robot @ 2021-12-08 22:21 UTC (permalink / raw) To: xiangxia.m.yue, netdev Cc: llvm, kbuild-all, Tonghao Zhang, Jamal Hadi Salim, Cong Wang, Jiri Pirko, Jakub Kicinski, Jonathan Lemon, Eric Dumazet, Alexander Lobakin, Paolo Abeni Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1fe5b01262844be03de98afdd56d1d393df04d7e config: i386-randconfig-r023-20211207 (https://download.01.org/0day-ci/archive/20211209/202112090603.PxlqXFRw-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/522fbcfdde012bc46d29aa216bdfa73f512adcbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 git checkout 522fbcfdde012bc46d29aa216bdfa73f512adcbd # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash mm/ net/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> net/sched/act_skbedit.c:39:11: warning: variable 'hash' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:42:34: note: uninitialized use occurs here queue_mapping = queue_mapping + hash % mapping_mod; ^~~~ net/sched/act_skbedit.c:39:7: note: remove the 'if' if its condition is always true else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:32:10: note: initialize the variable 'hash' to silence this warning u32 hash; ^ = 0 1 warning generated. vim +39 net/sched/act_skbedit.c 26 27 static u16 tcf_skbedit_hash(struct tcf_skbedit_params *params, 28 struct sk_buff *skb) 29 { 30 u16 queue_mapping = params->queue_mapping; 31 u16 mapping_mod = params->mapping_mod; 32 u32 hash; 33 34 if (!(params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK)) 35 return netdev_cap_txqueue(skb->dev, queue_mapping); 36 37 if (params->flags & SKBEDIT_F_QUEUE_MAPPING_CLASSID) 38 hash = jhash_1word(task_get_classid(skb), 0); > 39 else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) 40 hash = skb_get_hash(skb); 41 42 queue_mapping = queue_mapping + hash % mapping_mod; 43 return netdev_cap_txqueue(skb->dev, queue_mapping); 44 } 45 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [net-next v2 2/2] net: sched: support hash/classid selecting tx queue @ 2021-12-08 22:21 ` kernel test robot 0 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2021-12-08 22:21 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 3279 bytes --] Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1fe5b01262844be03de98afdd56d1d393df04d7e config: i386-randconfig-r023-20211207 (https://download.01.org/0day-ci/archive/20211209/202112090603.PxlqXFRw-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/522fbcfdde012bc46d29aa216bdfa73f512adcbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 git checkout 522fbcfdde012bc46d29aa216bdfa73f512adcbd # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash mm/ net/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> net/sched/act_skbedit.c:39:11: warning: variable 'hash' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:42:34: note: uninitialized use occurs here queue_mapping = queue_mapping + hash % mapping_mod; ^~~~ net/sched/act_skbedit.c:39:7: note: remove the 'if' if its condition is always true else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:32:10: note: initialize the variable 'hash' to silence this warning u32 hash; ^ = 0 1 warning generated. vim +39 net/sched/act_skbedit.c 26 27 static u16 tcf_skbedit_hash(struct tcf_skbedit_params *params, 28 struct sk_buff *skb) 29 { 30 u16 queue_mapping = params->queue_mapping; 31 u16 mapping_mod = params->mapping_mod; 32 u32 hash; 33 34 if (!(params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK)) 35 return netdev_cap_txqueue(skb->dev, queue_mapping); 36 37 if (params->flags & SKBEDIT_F_QUEUE_MAPPING_CLASSID) 38 hash = jhash_1word(task_get_classid(skb), 0); > 39 else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) 40 hash = skb_get_hash(skb); 41 42 queue_mapping = queue_mapping + hash % mapping_mod; 43 return netdev_cap_txqueue(skb->dev, queue_mapping); 44 } 45 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [net-next v2 2/2] net: sched: support hash/classid selecting tx queue 2021-12-08 22:21 ` kernel test robot @ 2021-12-09 1:51 ` Tonghao Zhang -1 siblings, 0 replies; 9+ messages in thread From: Tonghao Zhang @ 2021-12-09 1:51 UTC (permalink / raw) To: kernel test robot Cc: Linux Kernel Network Developers, llvm, kbuild-all, Jamal Hadi Salim, Cong Wang, Jiri Pirko, Jakub Kicinski, Jonathan Lemon, Eric Dumazet, Alexander Lobakin, Paolo Abeni On Thu, Dec 9, 2021 at 6:22 AM kernel test robot <lkp@intel.com> wrote: > > Hi, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: https://github.com/0day-ci/linux/commits/xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1fe5b01262844be03de98afdd56d1d393df04d7e > config: i386-randconfig-r023-20211207 (https://download.01.org/0day-ci/archive/20211209/202112090603.PxlqXFRw-lkp@intel.com/config) > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/522fbcfdde012bc46d29aa216bdfa73f512adcbd > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 > git checkout 522fbcfdde012bc46d29aa216bdfa73f512adcbd > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash mm/ net/sched/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > >> net/sched/act_skbedit.c:39:11: warning: variable 'hash' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > net/sched/act_skbedit.c:42:34: note: uninitialized use occurs here > queue_mapping = queue_mapping + hash % mapping_mod; > ^~~~ > net/sched/act_skbedit.c:39:7: note: remove the 'if' if its condition is always true > else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > net/sched/act_skbedit.c:32:10: note: initialize the variable 'hash' to silence this warning > u32 hash; > ^ > = 0 > 1 warning generated. v1 has set the hash = 0, in v2, I remove it, because the hash will be set by classid or skb-hash. In next version, I will fix that warning. > > vim +39 net/sched/act_skbedit.c > > 26 > 27 static u16 tcf_skbedit_hash(struct tcf_skbedit_params *params, > 28 struct sk_buff *skb) > 29 { > 30 u16 queue_mapping = params->queue_mapping; > 31 u16 mapping_mod = params->mapping_mod; > 32 u32 hash; > 33 > 34 if (!(params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK)) > 35 return netdev_cap_txqueue(skb->dev, queue_mapping); > 36 > 37 if (params->flags & SKBEDIT_F_QUEUE_MAPPING_CLASSID) > 38 hash = jhash_1word(task_get_classid(skb), 0); > > 39 else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) > 40 hash = skb_get_hash(skb); > 41 > 42 queue_mapping = queue_mapping + hash % mapping_mod; > 43 return netdev_cap_txqueue(skb->dev, queue_mapping); > 44 } > 45 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Best regards, Tonghao ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [net-next v2 2/2] net: sched: support hash/classid selecting tx queue @ 2021-12-09 1:51 ` Tonghao Zhang 0 siblings, 0 replies; 9+ messages in thread From: Tonghao Zhang @ 2021-12-09 1:51 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 3784 bytes --] On Thu, Dec 9, 2021 at 6:22 AM kernel test robot <lkp@intel.com> wrote: > > Hi, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: https://github.com/0day-ci/linux/commits/xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1fe5b01262844be03de98afdd56d1d393df04d7e > config: i386-randconfig-r023-20211207 (https://download.01.org/0day-ci/archive/20211209/202112090603.PxlqXFRw-lkp(a)intel.com/config) > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/522fbcfdde012bc46d29aa216bdfa73f512adcbd > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 > git checkout 522fbcfdde012bc46d29aa216bdfa73f512adcbd > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash mm/ net/sched/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > >> net/sched/act_skbedit.c:39:11: warning: variable 'hash' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > net/sched/act_skbedit.c:42:34: note: uninitialized use occurs here > queue_mapping = queue_mapping + hash % mapping_mod; > ^~~~ > net/sched/act_skbedit.c:39:7: note: remove the 'if' if its condition is always true > else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > net/sched/act_skbedit.c:32:10: note: initialize the variable 'hash' to silence this warning > u32 hash; > ^ > = 0 > 1 warning generated. v1 has set the hash = 0, in v2, I remove it, because the hash will be set by classid or skb-hash. In next version, I will fix that warning. > > vim +39 net/sched/act_skbedit.c > > 26 > 27 static u16 tcf_skbedit_hash(struct tcf_skbedit_params *params, > 28 struct sk_buff *skb) > 29 { > 30 u16 queue_mapping = params->queue_mapping; > 31 u16 mapping_mod = params->mapping_mod; > 32 u32 hash; > 33 > 34 if (!(params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK)) > 35 return netdev_cap_txqueue(skb->dev, queue_mapping); > 36 > 37 if (params->flags & SKBEDIT_F_QUEUE_MAPPING_CLASSID) > 38 hash = jhash_1word(task_get_classid(skb), 0); > > 39 else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) > 40 hash = skb_get_hash(skb); > 41 > 42 queue_mapping = queue_mapping + hash % mapping_mod; > 43 return netdev_cap_txqueue(skb->dev, queue_mapping); > 44 } > 45 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -- Best regards, Tonghao ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [net-next v2 2/2] net: sched: support hash/classid selecting tx queue 2021-12-08 14:34 ` [net-next v2 2/2] net: sched: support hash/classid selecting " xiangxia.m.yue @ 2021-12-08 22:32 ` kernel test robot 2021-12-08 22:32 ` kernel test robot 1 sibling, 0 replies; 9+ messages in thread From: kernel test robot @ 2021-12-08 22:32 UTC (permalink / raw) To: xiangxia.m.yue, netdev Cc: llvm, kbuild-all, Tonghao Zhang, Jamal Hadi Salim, Cong Wang, Jiri Pirko, Jakub Kicinski, Jonathan Lemon, Eric Dumazet, Alexander Lobakin, Paolo Abeni Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1fe5b01262844be03de98afdd56d1d393df04d7e config: i386-randconfig-a015-20211207 (https://download.01.org/0day-ci/archive/20211209/202112090601.FrUCO7HV-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/522fbcfdde012bc46d29aa216bdfa73f512adcbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 git checkout 522fbcfdde012bc46d29aa216bdfa73f512adcbd # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> net/sched/act_skbedit.c:39:11: warning: variable 'hash' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:42:34: note: uninitialized use occurs here queue_mapping = queue_mapping + hash % mapping_mod; ^~~~ net/sched/act_skbedit.c:39:7: note: remove the 'if' if its condition is always true else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:32:10: note: initialize the variable 'hash' to silence this warning u32 hash; ^ = 0 1 warning generated. vim +39 net/sched/act_skbedit.c 26 27 static u16 tcf_skbedit_hash(struct tcf_skbedit_params *params, 28 struct sk_buff *skb) 29 { 30 u16 queue_mapping = params->queue_mapping; 31 u16 mapping_mod = params->mapping_mod; 32 u32 hash; 33 34 if (!(params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK)) 35 return netdev_cap_txqueue(skb->dev, queue_mapping); 36 37 if (params->flags & SKBEDIT_F_QUEUE_MAPPING_CLASSID) 38 hash = jhash_1word(task_get_classid(skb), 0); > 39 else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) 40 hash = skb_get_hash(skb); 41 42 queue_mapping = queue_mapping + hash % mapping_mod; 43 return netdev_cap_txqueue(skb->dev, queue_mapping); 44 } 45 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [net-next v2 2/2] net: sched: support hash/classid selecting tx queue @ 2021-12-08 22:32 ` kernel test robot 0 siblings, 0 replies; 9+ messages in thread From: kernel test robot @ 2021-12-08 22:32 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 3275 bytes --] Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1fe5b01262844be03de98afdd56d1d393df04d7e config: i386-randconfig-a015-20211207 (https://download.01.org/0day-ci/archive/20211209/202112090601.FrUCO7HV-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/522fbcfdde012bc46d29aa216bdfa73f512adcbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review xiangxia-m-yue-gmail-com/net-sched-allow-user-to-select-txqueue/20211208-223656 git checkout 522fbcfdde012bc46d29aa216bdfa73f512adcbd # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> net/sched/act_skbedit.c:39:11: warning: variable 'hash' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:42:34: note: uninitialized use occurs here queue_mapping = queue_mapping + hash % mapping_mod; ^~~~ net/sched/act_skbedit.c:39:7: note: remove the 'if' if its condition is always true else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ net/sched/act_skbedit.c:32:10: note: initialize the variable 'hash' to silence this warning u32 hash; ^ = 0 1 warning generated. vim +39 net/sched/act_skbedit.c 26 27 static u16 tcf_skbedit_hash(struct tcf_skbedit_params *params, 28 struct sk_buff *skb) 29 { 30 u16 queue_mapping = params->queue_mapping; 31 u16 mapping_mod = params->mapping_mod; 32 u32 hash; 33 34 if (!(params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH_MASK)) 35 return netdev_cap_txqueue(skb->dev, queue_mapping); 36 37 if (params->flags & SKBEDIT_F_QUEUE_MAPPING_CLASSID) 38 hash = jhash_1word(task_get_classid(skb), 0); > 39 else if (params->flags & SKBEDIT_F_QUEUE_MAPPING_HASH) 40 hash = skb_get_hash(skb); 41 42 queue_mapping = queue_mapping + hash % mapping_mod; 43 return netdev_cap_txqueue(skb->dev, queue_mapping); 44 } 45 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-12-09 1:51 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-12-08 14:34 [net-next v2 0/2] net: sched: allow user to select txqueue xiangxia.m.yue 2021-12-08 14:34 ` [net-next v2 1/2] net: sched: use queue_mapping to pick tx queue xiangxia.m.yue 2021-12-08 14:34 ` [net-next v2 2/2] net: sched: support hash/classid selecting " xiangxia.m.yue 2021-12-08 22:21 ` kernel test robot 2021-12-08 22:21 ` kernel test robot 2021-12-09 1:51 ` Tonghao Zhang 2021-12-09 1:51 ` Tonghao Zhang 2021-12-08 22:32 ` kernel test robot 2021-12-08 22:32 ` kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.