[RFC PATCH 0/2] sched/tracing: sched_switch prev_state reported as TASK_RUNNING when it's not

[RFC PATCH 0/2] sched/tracing: sched_switch prev_state reported as TASK_RUNNING when it's not

[Valentin Schneider]

Hi folks,

Problem
=======

Abhijeet pointed out that the following sequence of trace events can be
observed:

  cat-1676  [001] d..3 103.010411: sched_waking: comm=grep pid=1677 prio=120 target_cpu=004
  grep-1677 [004] d..2 103.010440: sched_switch: prev_comm=grep prev_pid=1677 prev_prio=120 prev_state=R 0x0 ==> next_comm=swapper/4 next_pid=0 next_prio=120
  <idle>-0  [004] dNh3 103.0100459: sched_wakeup: comm=grep pid=1677 prio=120 target_cpu=004

IOW, not-yet-woken task gets presented as runnable and switched out in
favor of the idle task... Dietmar and I had a look, turns out this sequence
can happen: 

		      p->__state = TASK_INTERRUPTIBLE;
		      __schedule()
			deactivate_task(p);
  ttwu()
    READ !p->on_rq
    p->__state=TASK_WAKING
			trace_sched_switch()
			  __trace_sched_switch_state()
			    task_state_index()
			      return 0;

TASK_WAKING isn't in TASK_REPORT, hence why task_state_index(p) returns 0.
This can happen as of commit c6e7bd7afaeb ("sched/core: Optimize ttwu()
spinning on p->on_cpu") which punted the TASK_WAKING write to the other
side of

  smp_cond_load_acquire(&p->on_cpu, !VAL);

in ttwu().

Uwe reported on #linux-rt what I think is a similar issue with
TASK_RTLOCK_WAIT on PREEMPT_RT; again that state isn't in TASK_REPORT so
you get prev_state=0 despite the task blocking on a lock.

Both of those are very confusing for tooling or even human observers.

Patches
=======

For the TASK_WAKING case, pushing the prev_state read in __schedule() down
to __trace_sched_switch_state() seems sufficient. That's patch 1.

For TASK_RTLOCK_WAIT, it's a bit trickier. One could use ->saved_state as
prev_state, but
a) that is also susceptible to racing (see ttwu() / ttwu_state_match())
b) some lock substitutions (e.g. rt_spin_lock()) leave ->saved_state as
   TASK_RUNNING.

Patch 2 adds TASK_RTLOCK_WAIT to TASK_REPORT instead.

Testing
=======

Briefly tested on an Arm Juno via ftrace+hackbench against
o tip/sched/core@8c92606ab810
o v5.16-rc2-rt4 w/ CONFIG_PREEMPT_RT

Cheers,
Valentin

Valentin Schneider (2):
  sched/tracing: Don't re-read p->state when emitting sched_switch event
  sched/tracing: Add TASK_RTLOCK_WAIT to TASK_REPORT

 fs/proc/array.c                   |  3 ++-
 include/linux/sched.h             | 28 +++++++++++++++++-----------
 include/trace/events/sched.h      | 12 ++++++++----
 kernel/sched/core.c               |  4 ++--
 kernel/trace/fgraph.c             |  4 +++-
 kernel/trace/ftrace.c             |  4 +++-
 kernel/trace/trace_events.c       |  8 ++++++--
 kernel/trace/trace_sched_switch.c |  1 +
 8 files changed, 42 insertions(+), 22 deletions(-)

--
2.25.1

[RFC PATCH 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event

[Valentin Schneider]

As of commit

  c6e7bd7afaeb ("sched/core: Optimize ttwu() spinning on p->on_cpu")

the following sequence becomes possible:

		      p->__state = TASK_INTERRUPTIBLE;
		      __schedule()
			deactivate_task(p);
  ttwu()
    READ !p->on_rq
    p->__state=TASK_WAKING
			trace_sched_switch()
			  __trace_sched_switch_state()
			    task_state_index()
			      return 0;

TASK_WAKING isn't in TASK_REPORT, so the task appears as TASK_RUNNING in
the trace event.

Prevent this by pushing the value read from __schedule() down the trace
event.

Reported-by: Abhijeet Dharmapurikar <adharmap@quicinc.com>
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
 include/linux/sched.h             | 11 ++++++++---
 include/trace/events/sched.h      | 11 +++++++----
 kernel/sched/core.c               |  4 ++--
 kernel/trace/fgraph.c             |  4 +++-
 kernel/trace/ftrace.c             |  4 +++-
 kernel/trace/trace_events.c       |  8 ++++++--
 kernel/trace/trace_sched_switch.c |  1 +
 7 files changed, 30 insertions(+), 13 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index d2e261adb8ea..d00837d12b9d 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1616,10 +1616,10 @@ static inline pid_t task_pgrp_nr(struct task_struct *tsk)
 #define TASK_REPORT_IDLE	(TASK_REPORT + 1)
 #define TASK_REPORT_MAX		(TASK_REPORT_IDLE << 1)
 
-static inline unsigned int task_state_index(struct task_struct *tsk)
+static inline unsigned int __task_state_index(unsigned int tsk_state,
+					      unsigned int tsk_exit_state)
 {
-	unsigned int tsk_state = READ_ONCE(tsk->__state);
-	unsigned int state = (tsk_state | tsk->exit_state) & TASK_REPORT;
+	unsigned int state = (tsk_state | tsk_exit_state) & TASK_REPORT;
 
 	BUILD_BUG_ON_NOT_POWER_OF_2(TASK_REPORT_MAX);
 
@@ -1629,6 +1629,11 @@ static inline unsigned int task_state_index(struct task_struct *tsk)
 	return fls(state);
 }
 
+static inline unsigned int task_state_index(struct task_struct *tsk)
+{
+	return __task_state_index(READ_ONCE(tsk->__state), tsk->exit_state);
+}
+
 static inline char task_index_to_char(unsigned int state)
 {
 	static const char state_char[] = "RSDTtXZPI";
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index 94640482cfe7..65e786756321 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -187,7 +187,9 @@ DEFINE_EVENT(sched_wakeup_template, sched_wakeup_new,
 	     TP_ARGS(p));
 
 #ifdef CREATE_TRACE_POINTS
-static inline long __trace_sched_switch_state(bool preempt, struct task_struct *p)
+static inline long __trace_sched_switch_state(bool preempt,
+					      unsigned int prev_state,
+					      struct task_struct *p)
 {
 	unsigned int state;
 
@@ -208,7 +210,7 @@ static inline long __trace_sched_switch_state(bool preempt, struct task_struct *
 	 * it for left shift operation to get the correct task->state
 	 * mapping.
 	 */
-	state = task_state_index(p);
+	state = __task_state_index(prev_state, p->exit_state);
 
 	return state ? (1 << (state - 1)) : state;
 }
@@ -220,10 +222,11 @@ static inline long __trace_sched_switch_state(bool preempt, struct task_struct *
 TRACE_EVENT(sched_switch,
 
 	TP_PROTO(bool preempt,
+		 unsigned int prev_state,
 		 struct task_struct *prev,
 		 struct task_struct *next),
 
-	TP_ARGS(preempt, prev, next),
+	TP_ARGS(preempt, prev_state, prev, next),
 
 	TP_STRUCT__entry(
 		__array(	char,	prev_comm,	TASK_COMM_LEN	)
@@ -239,7 +242,7 @@ TRACE_EVENT(sched_switch,
 		memcpy(__entry->next_comm, next->comm, TASK_COMM_LEN);
 		__entry->prev_pid	= prev->pid;
 		__entry->prev_prio	= prev->prio;
-		__entry->prev_state	= __trace_sched_switch_state(preempt, prev);
+		__entry->prev_state	= __trace_sched_switch_state(preempt, prev_state, prev);
 		memcpy(__entry->prev_comm, prev->comm, TASK_COMM_LEN);
 		__entry->next_pid	= next->pid;
 		__entry->next_prio	= next->prio;
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index beaa8be6241e..91e6c33650ca 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4822,7 +4822,7 @@ static struct rq *finish_task_switch(struct task_struct *prev)
 {
 	struct rq *rq = this_rq();
 	struct mm_struct *mm = rq->prev_mm;
-	long prev_state;
+	unsigned int prev_state;
 
 	/*
 	 * The previous task will have left us with a preempt_count of 2
@@ -6287,7 +6287,7 @@ static void __sched notrace __schedule(unsigned int sched_mode)
 		migrate_disable_switch(rq, prev);
 		psi_sched_switch(prev, next, !task_on_rq_queued(prev));
 
-		trace_sched_switch(sched_mode & SM_MASK_PREEMPT, prev, next);
+		trace_sched_switch(sched_mode & SM_MASK_PREEMPT, prev_state, prev, next);
 
 		/* Also unlocks the rq: */
 		rq = context_switch(rq, prev, next, &rf);
diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
index 22061d38fc00..19028e072cdb 100644
--- a/kernel/trace/fgraph.c
+++ b/kernel/trace/fgraph.c
@@ -415,7 +415,9 @@ static int alloc_retstack_tasklist(struct ftrace_ret_stack **ret_stack_list)
 
 static void
 ftrace_graph_probe_sched_switch(void *ignore, bool preempt,
-			struct task_struct *prev, struct task_struct *next)
+				unsigned int prev_state,
+				struct task_struct *prev,
+				struct task_struct *next)
 {
 	unsigned long long timestamp;
 	int index;
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 30bc880c3849..e296ddeec99f 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -7311,7 +7311,9 @@ ftrace_func_t ftrace_ops_get_func(struct ftrace_ops *ops)
 
 static void
 ftrace_filter_pid_sched_switch_probe(void *data, bool preempt,
-		    struct task_struct *prev, struct task_struct *next)
+				     unsigned int prev_state,
+				     struct task_struct *prev,
+				     struct task_struct *next)
 {
 	struct trace_array *tr = data;
 	struct trace_pid_list *pid_list;
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 4021b9a79f93..6ddc6cc0d5d5 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -759,7 +759,9 @@ void trace_event_follow_fork(struct trace_array *tr, bool enable)
 
 static void
 event_filter_pid_sched_switch_probe_pre(void *data, bool preempt,
-		    struct task_struct *prev, struct task_struct *next)
+					unsigned int prev_state,
+					struct task_struct *prev,
+					struct task_struct *next)
 {
 	struct trace_array *tr = data;
 	struct trace_pid_list *no_pid_list;
@@ -783,7 +785,9 @@ event_filter_pid_sched_switch_probe_pre(void *data, bool preempt,
 
 static void
 event_filter_pid_sched_switch_probe_post(void *data, bool preempt,
-		    struct task_struct *prev, struct task_struct *next)
+					 unsigned int prev_state,
+					 struct task_struct *prev,
+					 struct task_struct *next)
 {
 	struct trace_array *tr = data;
 	struct trace_pid_list *no_pid_list;
diff --git a/kernel/trace/trace_sched_switch.c b/kernel/trace/trace_sched_switch.c
index e304196d7c28..993b0ed10d8c 100644
--- a/kernel/trace/trace_sched_switch.c
+++ b/kernel/trace/trace_sched_switch.c
@@ -22,6 +22,7 @@ static DEFINE_MUTEX(sched_register_mutex);
 
 static void
 probe_sched_switch(void *ignore, bool preempt,
+		   unsigned int prev_state,
 		   struct task_struct *prev, struct task_struct *next)
 {
 	int flags;
-- 
2.25.1

[RFC PATCH 2/2] sched/tracing: Add TASK_RTLOCK_WAIT to TASK_REPORT

[Valentin Schneider]

TASK_RTLOCK_WAIT currently isn't part of TASK_REPORT, thus a task blocking
on an rtlock will appear as having a task state == 0, IOW TASK_RUNNING.

The actual state is saved in p->saved_state, but reading it after reading
p->__state has a few issues:
o that could still be TASK_RUNNING in the case of e.g. rt_spin_lock
o ttwu_state_match() might have changed that to TASK_RUNNING

Add TASK_RTLOCK_WAIT to TASK_REPORT.

Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
 fs/proc/array.c              |  3 ++-
 include/linux/sched.h        | 17 +++++++++--------
 include/trace/events/sched.h |  1 +
 3 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index ff869a66b34e..f4cae65529a6 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -128,9 +128,10 @@ static const char * const task_state_array[] = {
 	"X (dead)",		/* 0x10 */
 	"Z (zombie)",		/* 0x20 */
 	"P (parked)",		/* 0x40 */
+	"L (rt-locked)",        /* 0x80 */
 
 	/* states beyond TASK_REPORT: */
-	"I (idle)",		/* 0x80 */
+	"I (idle)",		/* 0x100 */
 };
 
 static inline const char *get_task_state(struct task_struct *tsk)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index d00837d12b9d..18fd77578dae 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -91,13 +91,14 @@ struct task_group;
 #define EXIT_TRACE			(EXIT_ZOMBIE | EXIT_DEAD)
 /* Used in tsk->state again: */
 #define TASK_PARKED			0x0040
-#define TASK_DEAD			0x0080
-#define TASK_WAKEKILL			0x0100
-#define TASK_WAKING			0x0200
-#define TASK_NOLOAD			0x0400
-#define TASK_NEW			0x0800
 /* RT specific auxilliary flag to mark RT lock waiters */
-#define TASK_RTLOCK_WAIT		0x1000
+#define TASK_RTLOCK_WAIT		0x0080
+
+#define TASK_DEAD			0x0100
+#define TASK_WAKEKILL			0x0200
+#define TASK_WAKING			0x0400
+#define TASK_NOLOAD			0x0800
+#define TASK_NEW			0x1000
 #define TASK_STATE_MAX			0x2000
 
 /* Convenience macros for the sake of set_current_state: */
@@ -114,7 +115,7 @@ struct task_group;
 #define TASK_REPORT			(TASK_RUNNING | TASK_INTERRUPTIBLE | \
 					 TASK_UNINTERRUPTIBLE | __TASK_STOPPED | \
 					 __TASK_TRACED | EXIT_DEAD | EXIT_ZOMBIE | \
-					 TASK_PARKED)
+					 TASK_PARKED | TASK_RTLOCK_WAIT)
 
 #define task_is_running(task)		(READ_ONCE((task)->__state) == TASK_RUNNING)
 
@@ -1636,7 +1637,7 @@ static inline unsigned int task_state_index(struct task_struct *tsk)
 
 static inline char task_index_to_char(unsigned int state)
 {
-	static const char state_char[] = "RSDTtXZPI";
+	static const char state_char[] = "RSDTtXZPLI";
 
 	BUILD_BUG_ON(1 + ilog2(TASK_REPORT_MAX) != sizeof(state_char) - 1);
 
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index 65e786756321..f86ec9af19ff 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -261,6 +261,7 @@ TRACE_EVENT(sched_switch,
 				{ EXIT_DEAD, "X" },
 				{ EXIT_ZOMBIE, "Z" },
 				{ TASK_PARKED, "P" },
+				{ TASK_RTLOCK_WAIT, "L" },
 				{ TASK_DEAD, "I" }) :
 		  "R",
 
-- 
2.25.1

Re: [RFC PATCH 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event

[kernel test robot]

Hi Valentin,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on rostedt-trace/for-next]
[also build test ERROR on tip/sched/core tip/master linux/master linus/master v5.16-rc3 next-20211129]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: hexagon-randconfig-r045-20211129 (https://download.01.org/0day-ci/archive/20211130/202111300012.4hj0hPuG-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
        git checkout 9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/trace/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_osnoise.c:1193:36: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           ret = register_trace_sched_switch(trace_sched_switch_callback, NULL);
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:260:31: note: expanded from macro '__DECLARE_TRACE'
           register_trace_##name(void (*probe)(data_proto), void *data)    \
                                        ^
   kernel/trace/trace_osnoise.c:1208:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(trace_sched_switch_callback, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   2 errors generated.


vim +1193 kernel/trace/trace_osnoise.c

bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1182  
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1183  /*
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1184   * hook_thread_events - Hook the insturmentation for thread noise
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1185   *
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1186   * Hook the osnoise tracer callbacks to handle the noise from other
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1187   * threads on the necessary kernel events.
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1188   */
f7d9f6370e0064 Daniel Bristot de Oliveira 2021-06-28  1189  static int hook_thread_events(void)
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1190  {
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1191  	int ret;
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1192  
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22 @1193  	ret = register_trace_sched_switch(trace_sched_switch_callback, NULL);
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1194  	if (ret)
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1195  		return -EINVAL;
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1196  
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1197  	return 0;
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1198  }
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1199  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Re: [RFC PATCH 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 6033 bytes --]

Hi Valentin,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on rostedt-trace/for-next]
[also build test ERROR on tip/sched/core tip/master linux/master linus/master v5.16-rc3 next-20211129]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: hexagon-randconfig-r045-20211129 (https://download.01.org/0day-ci/archive/20211130/202111300012.4hj0hPuG-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
        git checkout 9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/trace/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_osnoise.c:1193:36: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           ret = register_trace_sched_switch(trace_sched_switch_callback, NULL);
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:260:31: note: expanded from macro '__DECLARE_TRACE'
           register_trace_##name(void (*probe)(data_proto), void *data)    \
                                        ^
   kernel/trace/trace_osnoise.c:1208:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(trace_sched_switch_callback, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   2 errors generated.


vim +1193 kernel/trace/trace_osnoise.c

bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1182  
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1183  /*
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1184   * hook_thread_events - Hook the insturmentation for thread noise
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1185   *
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1186   * Hook the osnoise tracer callbacks to handle the noise from other
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1187   * threads on the necessary kernel events.
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1188   */
f7d9f6370e0064 Daniel Bristot de Oliveira 2021-06-28  1189  static int hook_thread_events(void)
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1190  {
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1191  	int ret;
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1192  
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22 @1193  	ret = register_trace_sched_switch(trace_sched_switch_callback, NULL);
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1194  	if (ret)
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1195  		return -EINVAL;
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1196  
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1197  	return 0;
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1198  }
bce29ac9ce0bb0 Daniel Bristot de Oliveira 2021-06-22  1199  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

Re: [RFC PATCH 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event

[kernel test robot]

Hi Valentin,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on rostedt-trace/for-next]
[also build test ERROR on tip/sched/core tip/master linux/master linus/master v5.16-rc3 next-20211129]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: hexagon-buildonly-randconfig-r004-20211128 (https://download.01.org/0day-ci/archive/20211130/202111300028.pBo6qRlf-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
        git checkout 9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/trace/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_sched_wakeup.c:617:36: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           ret = register_trace_sched_switch(probe_wakeup_sched_switch, NULL);
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:260:31: note: expanded from macro '__DECLARE_TRACE'
           register_trace_##name(void (*probe)(data_proto), void *data)    \
                                        ^
   kernel/trace/trace_sched_wakeup.c:647:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(probe_wakeup_sched_switch, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   kernel/trace/trace_sched_wakeup.c:658:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(probe_wakeup_sched_switch, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   3 errors generated.
--
>> kernel/trace/trace_osnoise.c:1193:36: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           ret = register_trace_sched_switch(trace_sched_switch_callback, NULL);
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:260:31: note: expanded from macro '__DECLARE_TRACE'
           register_trace_##name(void (*probe)(data_proto), void *data)    \
                                        ^
   kernel/trace/trace_osnoise.c:1208:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(trace_sched_switch_callback, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   2 errors generated.


vim +617 kernel/trace/trace_sched_wakeup.c

352ad25aa4a189 Steven Rostedt           2008-05-12  598  
e309b41dd65aa9 Ingo Molnar              2008-05-12  599  static void start_wakeup_tracer(struct trace_array *tr)
352ad25aa4a189 Steven Rostedt           2008-05-12  600  {
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  601  	int ret;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  602  
38516ab59fbc5b Steven Rostedt           2010-04-20  603  	ret = register_trace_sched_wakeup(probe_wakeup, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  604  	if (ret) {
b07c3f193a8074 Mathieu Desnoyers        2008-07-18  605  		pr_info("wakeup trace: Couldn't activate tracepoint"
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  606  			" probe to kernel_sched_wakeup\n");
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  607  		return;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  608  	}
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  609  
38516ab59fbc5b Steven Rostedt           2010-04-20  610  	ret = register_trace_sched_wakeup_new(probe_wakeup, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  611  	if (ret) {
b07c3f193a8074 Mathieu Desnoyers        2008-07-18  612  		pr_info("wakeup trace: Couldn't activate tracepoint"
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  613  			" probe to kernel_sched_wakeup_new\n");
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  614  		goto fail_deprobe;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  615  	}
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  616  
38516ab59fbc5b Steven Rostedt           2010-04-20 @617  	ret = register_trace_sched_switch(probe_wakeup_sched_switch, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  618  	if (ret) {
b07c3f193a8074 Mathieu Desnoyers        2008-07-18  619  		pr_info("sched trace: Couldn't activate tracepoint"
73d8b8bc4f24a9 Wenji Huang              2009-02-17  620  			" probe to kernel_sched_switch\n");
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  621  		goto fail_deprobe_wake_new;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  622  	}
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  623  
38516ab59fbc5b Steven Rostedt           2010-04-20  624  	ret = register_trace_sched_migrate_task(probe_wakeup_migrate_task, NULL);
478142c39c8c2f Steven Rostedt           2009-09-09  625  	if (ret) {
478142c39c8c2f Steven Rostedt           2009-09-09  626  		pr_info("wakeup trace: Couldn't activate tracepoint"
478142c39c8c2f Steven Rostedt           2009-09-09  627  			" probe to kernel_sched_migrate_task\n");
50f9ad607ea891 Kaitao Cheng             2019-12-31  628  		goto fail_deprobe_sched_switch;
478142c39c8c2f Steven Rostedt           2009-09-09  629  	}
478142c39c8c2f Steven Rostedt           2009-09-09  630  
352ad25aa4a189 Steven Rostedt           2008-05-12  631  	wakeup_reset(tr);
352ad25aa4a189 Steven Rostedt           2008-05-12  632  
352ad25aa4a189 Steven Rostedt           2008-05-12  633  	/*
352ad25aa4a189 Steven Rostedt           2008-05-12  634  	 * Don't let the tracer_enabled = 1 show up before
352ad25aa4a189 Steven Rostedt           2008-05-12  635  	 * the wakeup_task is reset. This may be overkill since
352ad25aa4a189 Steven Rostedt           2008-05-12  636  	 * wakeup_reset does a spin_unlock after setting the
352ad25aa4a189 Steven Rostedt           2008-05-12  637  	 * wakeup_task to NULL, but I want to be safe.
352ad25aa4a189 Steven Rostedt           2008-05-12  638  	 * This is a slow path anyway.
352ad25aa4a189 Steven Rostedt           2008-05-12  639  	 */
352ad25aa4a189 Steven Rostedt           2008-05-12  640  	smp_wmb();
352ad25aa4a189 Steven Rostedt           2008-05-12  641  
983f938ae69585 Steven Rostedt (Red Hat  2015-09-30  642) 	if (start_func_tracer(tr, is_graph(tr)))
7495a5beaa22f1 Jiri Olsa                2010-09-23  643  		printk(KERN_ERR "failed to start wakeup tracer\n");
ad591240ceadca Steven Rostedt           2008-07-10  644  
352ad25aa4a189 Steven Rostedt           2008-05-12  645  	return;
50f9ad607ea891 Kaitao Cheng             2019-12-31  646  fail_deprobe_sched_switch:
50f9ad607ea891 Kaitao Cheng             2019-12-31  647  	unregister_trace_sched_switch(probe_wakeup_sched_switch, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  648  fail_deprobe_wake_new:
38516ab59fbc5b Steven Rostedt           2010-04-20  649  	unregister_trace_sched_wakeup_new(probe_wakeup, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  650  fail_deprobe:
38516ab59fbc5b Steven Rostedt           2010-04-20  651  	unregister_trace_sched_wakeup(probe_wakeup, NULL);
352ad25aa4a189 Steven Rostedt           2008-05-12  652  }
352ad25aa4a189 Steven Rostedt           2008-05-12  653  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Re: [RFC PATCH 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 13219 bytes --]

Hi Valentin,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on rostedt-trace/for-next]
[also build test ERROR on tip/sched/core tip/master linux/master linus/master v5.16-rc3 next-20211129]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: hexagon-buildonly-randconfig-r004-20211128 (https://download.01.org/0day-ci/archive/20211130/202111300028.pBo6qRlf-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Valentin-Schneider/sched-tracing-sched_switch-prev_state-reported-as-TASK_RUNNING-when-it-s-not/20211129-203943
        git checkout 9d9dc2f12e741a72aeb54b49ed491ea17d0863a9
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/trace/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_sched_wakeup.c:617:36: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           ret = register_trace_sched_switch(probe_wakeup_sched_switch, NULL);
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:260:31: note: expanded from macro '__DECLARE_TRACE'
           register_trace_##name(void (*probe)(data_proto), void *data)    \
                                        ^
   kernel/trace/trace_sched_wakeup.c:647:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(probe_wakeup_sched_switch, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   kernel/trace/trace_sched_wakeup.c:658:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(probe_wakeup_sched_switch, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   3 errors generated.
--
>> kernel/trace/trace_osnoise.c:1193:36: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           ret = register_trace_sched_switch(trace_sched_switch_callback, NULL);
                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:260:31: note: expanded from macro '__DECLARE_TRACE'
           register_trace_##name(void (*probe)(data_proto), void *data)    \
                                        ^
   kernel/trace/trace_osnoise.c:1208:32: error: incompatible function pointer types passing 'void (void *, bool, struct task_struct *, struct task_struct *)' (aka 'void (void *, _Bool, struct task_struct *, struct task_struct *)') to parameter of type 'void (*)(void *, bool, unsigned int, struct task_struct *, struct task_struct *)' (aka 'void (*)(void *, _Bool, unsigned int, struct task_struct *, struct task_struct *)') [-Werror,-Wincompatible-function-pointer-types]
           unregister_trace_sched_switch(trace_sched_switch_callback, NULL);
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/events/sched.h:222:1: note: passing argument to parameter 'probe' here
   TRACE_EVENT(sched_switch,
   ^
   include/linux/tracepoint.h:553:2: note: expanded from macro 'TRACE_EVENT'
           DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
           ^
   include/linux/tracepoint.h:419:2: note: expanded from macro 'DECLARE_TRACE'
           __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),              \
           ^
   include/linux/tracepoint.h:273:33: note: expanded from macro '__DECLARE_TRACE'
           unregister_trace_##name(void (*probe)(data_proto), void *data)  \
                                          ^
   2 errors generated.


vim +617 kernel/trace/trace_sched_wakeup.c

352ad25aa4a189 Steven Rostedt           2008-05-12  598  
e309b41dd65aa9 Ingo Molnar              2008-05-12  599  static void start_wakeup_tracer(struct trace_array *tr)
352ad25aa4a189 Steven Rostedt           2008-05-12  600  {
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  601  	int ret;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  602  
38516ab59fbc5b Steven Rostedt           2010-04-20  603  	ret = register_trace_sched_wakeup(probe_wakeup, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  604  	if (ret) {
b07c3f193a8074 Mathieu Desnoyers        2008-07-18  605  		pr_info("wakeup trace: Couldn't activate tracepoint"
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  606  			" probe to kernel_sched_wakeup\n");
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  607  		return;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  608  	}
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  609  
38516ab59fbc5b Steven Rostedt           2010-04-20  610  	ret = register_trace_sched_wakeup_new(probe_wakeup, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  611  	if (ret) {
b07c3f193a8074 Mathieu Desnoyers        2008-07-18  612  		pr_info("wakeup trace: Couldn't activate tracepoint"
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  613  			" probe to kernel_sched_wakeup_new\n");
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  614  		goto fail_deprobe;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  615  	}
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  616  
38516ab59fbc5b Steven Rostedt           2010-04-20 @617  	ret = register_trace_sched_switch(probe_wakeup_sched_switch, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  618  	if (ret) {
b07c3f193a8074 Mathieu Desnoyers        2008-07-18  619  		pr_info("sched trace: Couldn't activate tracepoint"
73d8b8bc4f24a9 Wenji Huang              2009-02-17  620  			" probe to kernel_sched_switch\n");
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  621  		goto fail_deprobe_wake_new;
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  622  	}
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  623  
38516ab59fbc5b Steven Rostedt           2010-04-20  624  	ret = register_trace_sched_migrate_task(probe_wakeup_migrate_task, NULL);
478142c39c8c2f Steven Rostedt           2009-09-09  625  	if (ret) {
478142c39c8c2f Steven Rostedt           2009-09-09  626  		pr_info("wakeup trace: Couldn't activate tracepoint"
478142c39c8c2f Steven Rostedt           2009-09-09  627  			" probe to kernel_sched_migrate_task\n");
50f9ad607ea891 Kaitao Cheng             2019-12-31  628  		goto fail_deprobe_sched_switch;
478142c39c8c2f Steven Rostedt           2009-09-09  629  	}
478142c39c8c2f Steven Rostedt           2009-09-09  630  
352ad25aa4a189 Steven Rostedt           2008-05-12  631  	wakeup_reset(tr);
352ad25aa4a189 Steven Rostedt           2008-05-12  632  
352ad25aa4a189 Steven Rostedt           2008-05-12  633  	/*
352ad25aa4a189 Steven Rostedt           2008-05-12  634  	 * Don't let the tracer_enabled = 1 show up before
352ad25aa4a189 Steven Rostedt           2008-05-12  635  	 * the wakeup_task is reset. This may be overkill since
352ad25aa4a189 Steven Rostedt           2008-05-12  636  	 * wakeup_reset does a spin_unlock after setting the
352ad25aa4a189 Steven Rostedt           2008-05-12  637  	 * wakeup_task to NULL, but I want to be safe.
352ad25aa4a189 Steven Rostedt           2008-05-12  638  	 * This is a slow path anyway.
352ad25aa4a189 Steven Rostedt           2008-05-12  639  	 */
352ad25aa4a189 Steven Rostedt           2008-05-12  640  	smp_wmb();
352ad25aa4a189 Steven Rostedt           2008-05-12  641  
983f938ae69585 Steven Rostedt (Red Hat  2015-09-30  642) 	if (start_func_tracer(tr, is_graph(tr)))
7495a5beaa22f1 Jiri Olsa                2010-09-23  643  		printk(KERN_ERR "failed to start wakeup tracer\n");
ad591240ceadca Steven Rostedt           2008-07-10  644  
352ad25aa4a189 Steven Rostedt           2008-05-12  645  	return;
50f9ad607ea891 Kaitao Cheng             2019-12-31  646  fail_deprobe_sched_switch:
50f9ad607ea891 Kaitao Cheng             2019-12-31  647  	unregister_trace_sched_switch(probe_wakeup_sched_switch, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  648  fail_deprobe_wake_new:
38516ab59fbc5b Steven Rostedt           2010-04-20  649  	unregister_trace_sched_wakeup_new(probe_wakeup, NULL);
5b82a1b08a00b2 Mathieu Desnoyers        2008-05-12  650  fail_deprobe:
38516ab59fbc5b Steven Rostedt           2010-04-20  651  	unregister_trace_sched_wakeup(probe_wakeup, NULL);
352ad25aa4a189 Steven Rostedt           2008-05-12  652  }
352ad25aa4a189 Steven Rostedt           2008-05-12  653  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

Re: [RFC PATCH 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event

[Steven Rostedt]

On Mon, 29 Nov 2021 12:36:00 +0000
Valentin Schneider <valentin.schneider@arm.com> wrote:

> As of commit
> 
>   c6e7bd7afaeb ("sched/core: Optimize ttwu() spinning on p->on_cpu")
> 
> the following sequence becomes possible:
> 
> 		      p->__state = TASK_INTERRUPTIBLE;
> 		      __schedule()
> 			deactivate_task(p);
>   ttwu()
>     READ !p->on_rq
>     p->__state=TASK_WAKING
> 			trace_sched_switch()
> 			  __trace_sched_switch_state()
> 			    task_state_index()
> 			      return 0;
> 
> TASK_WAKING isn't in TASK_REPORT, so the task appears as TASK_RUNNING in
> the trace event.
> 
> Prevent this by pushing the value read from __schedule() down the trace
> event.
> 
> Reported-by: Abhijeet Dharmapurikar <adharmap@quicinc.com>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> ---
>  include/linux/sched.h             | 11 ++++++++---
>  include/trace/events/sched.h      | 11 +++++++----
>  kernel/sched/core.c               |  4 ++--
>  kernel/trace/fgraph.c             |  4 +++-
>  kernel/trace/ftrace.c             |  4 +++-
>  kernel/trace/trace_events.c       |  8 ++++++--
>  kernel/trace/trace_sched_switch.c |  1 +

I believe you may have missed some functions that register the sched_switch
event. Do a git grep on register_trace_sched_switch.

-- Steve


>  7 files changed, 30 insertions(+), 13 deletions(-)
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index d2e261adb8ea..d00837d12b9d 100644

Re: [RFC PATCH 2/2] sched/tracing: Add TASK_RTLOCK_WAIT to TASK_REPORT

[Steven Rostedt]

On Mon, 29 Nov 2021 12:36:01 +0000
Valentin Schneider <valentin.schneider@arm.com> wrote:

> TASK_RTLOCK_WAIT currently isn't part of TASK_REPORT, thus a task blocking
> on an rtlock will appear as having a task state == 0, IOW TASK_RUNNING.
> 
> The actual state is saved in p->saved_state, but reading it after reading
> p->__state has a few issues:
> o that could still be TASK_RUNNING in the case of e.g. rt_spin_lock
> o ttwu_state_match() might have changed that to TASK_RUNNING
> 
> Add TASK_RTLOCK_WAIT to TASK_REPORT.
> 

The patch looks good, but I may play with it more. But in the mean time...

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

Re: [RFC PATCH 1/2] sched/tracing: Don't re-read p->state when emitting sched_switch event

[Valentin Schneider]

On 08/12/21 15:12, Steven Rostedt wrote:
> On Mon, 29 Nov 2021 12:36:00 +0000
> Valentin Schneider <valentin.schneider@arm.com> wrote:
>
>> As of commit
>>
>>   c6e7bd7afaeb ("sched/core: Optimize ttwu() spinning on p->on_cpu")
>>
>> the following sequence becomes possible:
>>
>>                    p->__state = TASK_INTERRUPTIBLE;
>>                    __schedule()
>>                      deactivate_task(p);
>>   ttwu()
>>     READ !p->on_rq
>>     p->__state=TASK_WAKING
>>                      trace_sched_switch()
>>                        __trace_sched_switch_state()
>>                          task_state_index()
>>                            return 0;
>>
>> TASK_WAKING isn't in TASK_REPORT, so the task appears as TASK_RUNNING in
>> the trace event.
>>
>> Prevent this by pushing the value read from __schedule() down the trace
>> event.
>>
>> Reported-by: Abhijeet Dharmapurikar <adharmap@quicinc.com>
>> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
>> ---
>>  include/linux/sched.h             | 11 ++++++++---
>>  include/trace/events/sched.h      | 11 +++++++----
>>  kernel/sched/core.c               |  4 ++--
>>  kernel/trace/fgraph.c             |  4 +++-
>>  kernel/trace/ftrace.c             |  4 +++-
>>  kernel/trace/trace_events.c       |  8 ++++++--
>>  kernel/trace/trace_sched_switch.c |  1 +
>
> I believe you may have missed some functions that register the sched_switch
> event. Do a git grep on register_trace_sched_switch.
>

Thanks! I'll wait a bit to see if anyone truly hates the idea and then will
patch those up.

> -- Steve
>
>
>>  7 files changed, 30 insertions(+), 13 deletions(-)
>>
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>> index d2e261adb8ea..d00837d12b9d 100644

Re: [RFC PATCH 2/2] sched/tracing: Add TASK_RTLOCK_WAIT to TASK_REPORT

[Sebastian Andrzej Siewior]

On 2021-11-29 12:36:01 [+0000], Valentin Schneider wrote:
> TASK_RTLOCK_WAIT currently isn't part of TASK_REPORT, thus a task blocking
> on an rtlock will appear as having a task state == 0, IOW TASK_RUNNING.
> 
> The actual state is saved in p->saved_state, but reading it after reading
> p->__state has a few issues:
> o that could still be TASK_RUNNING in the case of e.g. rt_spin_lock
> o ttwu_state_match() might have changed that to TASK_RUNNING
> 
> Add TASK_RTLOCK_WAIT to TASK_REPORT.
> 
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>

We used to have the D state which was used in the locked case and was
sufficient. With the rework to TASK_RTLOCK_WAIT (which made other things
easier) we lost that. It makes debuging/ looking into the system more
obvious or does not hide things so why not.

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian