All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Zheng Wu <wu.zheng@intel.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: fix possible initialization failure for P4500/P4600 SSDs
Date: Fri, 10 Dec 2021 09:31:45 -0800	[thread overview]
Message-ID: <20211210173145.GC3856533@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <1623945952-18861-1-git-send-email-wu.zheng@intel.com>

On Thu, Jun 17, 2021 at 12:05:52PM -0400, Zheng Wu wrote:
> From: Wu Zheng <wu.zheng@intel.com>
> 
> Subnqn isn't supported in P4500/P4600 SSDs.
> It's a fixed unavailable value in each P4500/P4600 SSD.

According to ark.intel.com, P4500/4600 were released nearly 4 years ago.
My understanding was these were a popular product. Why are we hearing
about this issue only now? Is this issue specific to a particular
firmware version, or has Linux really been incompatible with these this
entire time?

> @@ -3326,7 +3326,8 @@ static const struct pci_device_id nvme_id_table[] = {
>  				NVME_QUIRK_DEALLOCATE_ZEROES, },
>  	{ PCI_VDEVICE(INTEL, 0x0a54),	/* Intel P4500/P4600 */
>  		.driver_data = NVME_QUIRK_STRIPE_SIZE |
> -				NVME_QUIRK_DEALLOCATE_ZEROES, },
> +				NVME_QUIRK_DEALLOCATE_ZEROES |
> +				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
>  	{ PCI_VDEVICE(INTEL, 0x0a55),	/* Dell Express Flash P4600 */
>  		.driver_data = NVME_QUIRK_STRIPE_SIZE |
>  				NVME_QUIRK_DEALLOCATE_ZEROES, },

So the generic P4600 is broken, but Dell's is not?


  reply	other threads:[~2021-12-10 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 16:05 [PATCH] nvme: fix possible initialization failure for P4500/P4600 SSDs Zheng Wu
2021-12-10 17:31 ` Keith Busch [this message]
2021-06-21 23:07 Zheng Wu
2022-01-10 16:03 ` Keith Busch
2022-01-26 16:14 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211210173145.GC3856533@dhcp-10-100-145-180.wdc.com \
    --to=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=wu.zheng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.