All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Zheng Wu <wu.zheng@intel.com>
Cc: linux-nvme@lists.infradead.org, Ye Jinhe <jinhe.ye@intel.com>
Subject: Re: [PATCH] nvme: fix possible initialization failure for P4500/P4600 SSDs
Date: Mon, 10 Jan 2022 08:03:09 -0800	[thread overview]
Message-ID: <20220110160309.GA3226660@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <1624316821-21154-1-git-send-email-wu.zheng@intel.com>

On Mon, Jun 21, 2021 at 07:07:01PM -0400, Zheng Wu wrote:
> From: Wu Zheng <wu.zheng@intel.com>
> 
> Subnqn isn't supported in P4500/P4600 SSDs.
> It's a fixed unavailable value in each P4500/P4600 SSD.
> 
> Multiple SSDs need to return the different subnqn when SSDs are initialization.
> To P4500/P4600 SSDs, in nvme_init_subnqn, id->subnqn is not null and
> it's from P4500/P4600. However, multiple P4500/P4600 SSDs return the same subnqn.
> It causes the possible initialization failure.
> 
> To fix this, the flag of NVME_QUIRK_IGNORE_DEV_SUBNQN need to be added to
> driver_data of P4500/P4600 for nvme_id_table.
> 
> Signed-off-by: Zheng Wu <wu.zheng@intel.com>
> Signed-off-by: Ye Jinhe <jinhe.ye@intel.com>

Looks fine.

Reviewed-by: Keith Busch <kbusch@kernel.org>


  reply	other threads:[~2022-01-10 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 23:07 [PATCH] nvme: fix possible initialization failure for P4500/P4600 SSDs Zheng Wu
2022-01-10 16:03 ` Keith Busch [this message]
2022-01-26 16:14 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2021-06-17 16:05 Zheng Wu
2021-12-10 17:31 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110160309.GA3226660@dhcp-10-100-145-180.wdc.com \
    --to=kbusch@kernel.org \
    --cc=jinhe.ye@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=wu.zheng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.