* sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
@ 2021-12-10 13:17 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-12-10 13:17 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4518 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Mark Brown <broonie@kernel.org>
CC: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
Hi Srinivas,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c741e49150dbb0c0aebe234389f4aa8b47958fa8
commit: cf989b68fcadbeeea1446e50fd8b2f24a0f1275c ASoC: qdsp6: audioreach: add Kconfig and Makefile
date: 6 weeks ago
:::::: branch date: 16 hours ago
:::::: commit date: 6 weeks ago
config: riscv-randconfig-m031-20211210 (https://download.01.org/0day-ci/archive/20211210/202112102127.p5MeK8y5-lkp(a)intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
sound/soc/qcom/qdsp6/audioreach.c:228 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct apm_cmd_header'? 0
vim +212 sound/soc/qcom/qdsp6/audioreach.c
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 196
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 197 static void *__audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 198 uint32_t src_port, uint32_t dest_port, bool has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 199 {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 200 struct gpr_pkt *pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 201 void *p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 202 int pkt_size = GPR_HDR_SIZE + payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 203
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 204 if (has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 205 pkt_size += APM_CMD_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 206
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 207 p = kzalloc(pkt_size, GFP_KERNEL);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 208 if (!p)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 209 return ERR_PTR(-ENOMEM);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 210
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 211 pkt = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @212 pkt->hdr.version = GPR_PKT_VER;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 213 pkt->hdr.hdr_size = GPR_PKT_HEADER_WORD_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 214 pkt->hdr.pkt_size = pkt_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 215 pkt->hdr.dest_port = dest_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 216 pkt->hdr.src_port = src_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 217
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 218 pkt->hdr.dest_domain = GPR_DOMAIN_ID_ADSP;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 219 pkt->hdr.src_domain = GPR_DOMAIN_ID_APPS;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 220 pkt->hdr.token = token;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 221 pkt->hdr.opcode = opcode;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 222
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 223 if (has_cmd_hdr) {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 224 struct apm_cmd_header *cmd_header;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 225
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 226 p = p + GPR_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 227 cmd_header = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @228 cmd_header->payload_size = payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 229 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 230
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 231 return pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 232 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 233
:::::: The code at line 212 was first introduced by commit
:::::: 44c28dbdb6195b2a92e1fcb2946d1e987658f8b5 ASoC: qdsp6: audioreach: add basic pkt alloc support
:::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
@ 2022-04-18 23:49 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-04-18 23:49 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4477 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Mark Brown <broonie@kernel.org>
CC: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
Hi Srinivas,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b2d229d4ddb17db541098b83524d901257e93845
commit: cf989b68fcadbeeea1446e50fd8b2f24a0f1275c ASoC: qdsp6: audioreach: add Kconfig and Makefile
date: 6 months ago
:::::: branch date: 27 hours ago
:::::: commit date: 6 months ago
config: h8300-randconfig-m031-20220418 (https://download.01.org/0day-ci/archive/20220419/202204190757.4MAD8TdC-lkp(a)intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
sound/soc/qcom/qdsp6/audioreach.c:228 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct apm_cmd_header'? 0
vim +212 sound/soc/qcom/qdsp6/audioreach.c
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 196
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 197 static void *__audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 198 uint32_t src_port, uint32_t dest_port, bool has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 199 {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 200 struct gpr_pkt *pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 201 void *p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 202 int pkt_size = GPR_HDR_SIZE + payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 203
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 204 if (has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 205 pkt_size += APM_CMD_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 206
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 207 p = kzalloc(pkt_size, GFP_KERNEL);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 208 if (!p)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 209 return ERR_PTR(-ENOMEM);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 210
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 211 pkt = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @212 pkt->hdr.version = GPR_PKT_VER;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 213 pkt->hdr.hdr_size = GPR_PKT_HEADER_WORD_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 214 pkt->hdr.pkt_size = pkt_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 215 pkt->hdr.dest_port = dest_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 216 pkt->hdr.src_port = src_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 217
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 218 pkt->hdr.dest_domain = GPR_DOMAIN_ID_ADSP;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 219 pkt->hdr.src_domain = GPR_DOMAIN_ID_APPS;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 220 pkt->hdr.token = token;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 221 pkt->hdr.opcode = opcode;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 222
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 223 if (has_cmd_hdr) {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 224 struct apm_cmd_header *cmd_header;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 225
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 226 p = p + GPR_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 227 cmd_header = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @228 cmd_header->payload_size = payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 229 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 230
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 231 return pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 232 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 233
:::::: The code at line 212 was first introduced by commit
:::::: 44c28dbdb6195b2a92e1fcb2946d1e987658f8b5 ASoC: qdsp6: audioreach: add basic pkt alloc support
:::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 6+ messages in thread
* sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
@ 2022-03-19 18:02 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-03-19 18:02 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4479 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Mark Brown <broonie@kernel.org>
CC: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
Hi Srinivas,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 34e047aa16c0123bbae8e2f6df33e5ecc1f56601
commit: cf989b68fcadbeeea1446e50fd8b2f24a0f1275c ASoC: qdsp6: audioreach: add Kconfig and Makefile
date: 5 months ago
:::::: branch date: 22 hours ago
:::::: commit date: 5 months ago
config: openrisc-randconfig-m031-20220319 (https://download.01.org/0day-ci/archive/20220320/202203200147.9WZMpDX8-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
sound/soc/qcom/qdsp6/audioreach.c:228 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct apm_cmd_header'? 0
vim +212 sound/soc/qcom/qdsp6/audioreach.c
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 196
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 197 static void *__audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 198 uint32_t src_port, uint32_t dest_port, bool has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 199 {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 200 struct gpr_pkt *pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 201 void *p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 202 int pkt_size = GPR_HDR_SIZE + payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 203
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 204 if (has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 205 pkt_size += APM_CMD_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 206
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 207 p = kzalloc(pkt_size, GFP_KERNEL);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 208 if (!p)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 209 return ERR_PTR(-ENOMEM);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 210
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 211 pkt = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @212 pkt->hdr.version = GPR_PKT_VER;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 213 pkt->hdr.hdr_size = GPR_PKT_HEADER_WORD_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 214 pkt->hdr.pkt_size = pkt_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 215 pkt->hdr.dest_port = dest_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 216 pkt->hdr.src_port = src_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 217
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 218 pkt->hdr.dest_domain = GPR_DOMAIN_ID_ADSP;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 219 pkt->hdr.src_domain = GPR_DOMAIN_ID_APPS;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 220 pkt->hdr.token = token;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 221 pkt->hdr.opcode = opcode;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 222
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 223 if (has_cmd_hdr) {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 224 struct apm_cmd_header *cmd_header;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 225
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 226 p = p + GPR_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 227 cmd_header = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @228 cmd_header->payload_size = payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 229 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 230
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 231 return pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 232 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 233
:::::: The code at line 212 was first introduced by commit
:::::: 44c28dbdb6195b2a92e1fcb2946d1e987658f8b5 ASoC: qdsp6: audioreach: add basic pkt alloc support
:::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 6+ messages in thread
* sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
@ 2022-01-20 4:29 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-01-20 4:29 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4455 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Mark Brown <broonie@kernel.org>
CC: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1d1df41c5a33359a00e919d54eaebfb789711fdc
commit: cf989b68fcadbeeea1446e50fd8b2f24a0f1275c ASoC: qdsp6: audioreach: add Kconfig and Makefile
date: 3 months ago
:::::: branch date: 19 hours ago
:::::: commit date: 3 months ago
config: arc-randconfig-m031-20220117 (https://download.01.org/0day-ci/archive/20220120/202201201220.9qaDvQQ7-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
sound/soc/qcom/qdsp6/audioreach.c:228 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct apm_cmd_header'? 0
vim +212 sound/soc/qcom/qdsp6/audioreach.c
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 196
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 197 static void *__audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 198 uint32_t src_port, uint32_t dest_port, bool has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 199 {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 200 struct gpr_pkt *pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 201 void *p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 202 int pkt_size = GPR_HDR_SIZE + payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 203
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 204 if (has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 205 pkt_size += APM_CMD_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 206
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 207 p = kzalloc(pkt_size, GFP_KERNEL);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 208 if (!p)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 209 return ERR_PTR(-ENOMEM);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 210
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 211 pkt = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @212 pkt->hdr.version = GPR_PKT_VER;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 213 pkt->hdr.hdr_size = GPR_PKT_HEADER_WORD_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 214 pkt->hdr.pkt_size = pkt_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 215 pkt->hdr.dest_port = dest_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 216 pkt->hdr.src_port = src_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 217
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 218 pkt->hdr.dest_domain = GPR_DOMAIN_ID_ADSP;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 219 pkt->hdr.src_domain = GPR_DOMAIN_ID_APPS;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 220 pkt->hdr.token = token;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 221 pkt->hdr.opcode = opcode;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 222
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 223 if (has_cmd_hdr) {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 224 struct apm_cmd_header *cmd_header;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 225
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 226 p = p + GPR_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 227 cmd_header = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @228 cmd_header->payload_size = payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 229 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 230
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 231 return pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 232 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 233
:::::: The code at line 212 was first introduced by commit
:::::: 44c28dbdb6195b2a92e1fcb2946d1e987658f8b5 ASoC: qdsp6: audioreach: add basic pkt alloc support
:::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
@ 2021-12-10 11:45 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-12-10 11:45 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4518 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Mark Brown <broonie@kernel.org>
CC: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
Hi Srinivas,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c741e49150dbb0c0aebe234389f4aa8b47958fa8
commit: cf989b68fcadbeeea1446e50fd8b2f24a0f1275c ASoC: qdsp6: audioreach: add Kconfig and Makefile
date: 6 weeks ago
:::::: branch date: 14 hours ago
:::::: commit date: 6 weeks ago
config: riscv-randconfig-m031-20211210 (https://download.01.org/0day-ci/archive/20211210/202112101903.hDp4bziV-lkp(a)intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
sound/soc/qcom/qdsp6/audioreach.c:228 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct apm_cmd_header'? 0
vim +212 sound/soc/qcom/qdsp6/audioreach.c
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 196
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 197 static void *__audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 198 uint32_t src_port, uint32_t dest_port, bool has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 199 {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 200 struct gpr_pkt *pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 201 void *p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 202 int pkt_size = GPR_HDR_SIZE + payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 203
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 204 if (has_cmd_hdr)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 205 pkt_size += APM_CMD_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 206
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 207 p = kzalloc(pkt_size, GFP_KERNEL);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 208 if (!p)
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 209 return ERR_PTR(-ENOMEM);
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 210
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 211 pkt = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @212 pkt->hdr.version = GPR_PKT_VER;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 213 pkt->hdr.hdr_size = GPR_PKT_HEADER_WORD_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 214 pkt->hdr.pkt_size = pkt_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 215 pkt->hdr.dest_port = dest_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 216 pkt->hdr.src_port = src_port;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 217
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 218 pkt->hdr.dest_domain = GPR_DOMAIN_ID_ADSP;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 219 pkt->hdr.src_domain = GPR_DOMAIN_ID_APPS;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 220 pkt->hdr.token = token;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 221 pkt->hdr.opcode = opcode;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 222
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 223 if (has_cmd_hdr) {
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 224 struct apm_cmd_header *cmd_header;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 225
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 226 p = p + GPR_HDR_SIZE;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 227 cmd_header = p;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 @228 cmd_header->payload_size = payload_size;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 229 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 230
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 231 return pkt;
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 232 }
44c28dbdb6195b Srinivas Kandagatla 2021-10-26 233
:::::: The code at line 212 was first introduced by commit
:::::: 44c28dbdb6195b2a92e1fcb2946d1e987658f8b5 ASoC: qdsp6: audioreach: add basic pkt alloc support
:::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
@ 2021-11-25 14:03 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-11-25 14:03 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4497 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Mark Brown <broonie@kernel.org>
CC: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5f53fa508db098c9d372423a6dac31c8a5679cdf
commit: cf989b68fcadbeeea1446e50fd8b2f24a0f1275c ASoC: qdsp6: audioreach: add Kconfig and Makefile
date: 4 weeks ago
:::::: branch date: 20 hours ago
:::::: commit date: 4 weeks ago
config: openrisc-randconfig-m031-20211122 (https://download.01.org/0day-ci/archive/20211125/202111252106.YdRVfIXR-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min
sound/soc/qcom/qdsp6/audioreach.c:228 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct apm_cmd_header'? 0
vim +212 sound/soc/qcom/qdsp6/audioreach.c
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 196
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 197 static void *__audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 198 uint32_t src_port, uint32_t dest_port, bool has_cmd_hdr)
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 199 {
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 200 struct gpr_pkt *pkt;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 201 void *p;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 202 int pkt_size = GPR_HDR_SIZE + payload_size;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 203
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 204 if (has_cmd_hdr)
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 205 pkt_size += APM_CMD_HDR_SIZE;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 206
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 207 p = kzalloc(pkt_size, GFP_KERNEL);
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 208 if (!p)
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 209 return ERR_PTR(-ENOMEM);
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 210
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 211 pkt = p;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 @212 pkt->hdr.version = GPR_PKT_VER;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 213 pkt->hdr.hdr_size = GPR_PKT_HEADER_WORD_SIZE;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 214 pkt->hdr.pkt_size = pkt_size;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 215 pkt->hdr.dest_port = dest_port;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 216 pkt->hdr.src_port = src_port;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 217
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 218 pkt->hdr.dest_domain = GPR_DOMAIN_ID_ADSP;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 219 pkt->hdr.src_domain = GPR_DOMAIN_ID_APPS;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 220 pkt->hdr.token = token;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 221 pkt->hdr.opcode = opcode;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 222
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 223 if (has_cmd_hdr) {
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 224 struct apm_cmd_header *cmd_header;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 225
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 226 p = p + GPR_HDR_SIZE;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 227 cmd_header = p;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 @228 cmd_header->payload_size = payload_size;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 229 }
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 230
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 231 return pkt;
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 232 }
44c28dbdb6195b2 Srinivas Kandagatla 2021-10-26 233
:::::: The code at line 212 was first introduced by commit
:::::: 44c28dbdb6195b2a92e1fcb2946d1e987658f8b5 ASoC: qdsp6: audioreach: add basic pkt alloc support
:::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-18 23:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-10 13:17 sound/soc/qcom/qdsp6/audioreach.c:212 __audioreach_alloc_pkt() warn: is 'p' large enough for 'struct gpr_pkt'? s32min kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-04-18 23:49 kernel test robot
2022-03-19 18:02 kernel test robot
2022-01-20 4:29 kernel test robot
2021-12-10 11:45 kernel test robot
2021-11-25 14:03 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.