All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fpga: stratix10-soc: fix typo in a comment
@ 2021-12-12  3:19 Jason Wang
  2021-12-12 16:19 ` Tom Rix
  0 siblings, 1 reply; 3+ messages in thread
From: Jason Wang @ 2021-12-12  3:19 UTC (permalink / raw)
  To: hao.wu; +Cc: mdf, yilun.xu, trix, linux-fpga, linux-kernel, Jason Wang

The double `if' in the comment in line 288 is repeated. Remove one
of them from the comment.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/fpga/stratix10-soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 357cea58ec98..e4f2e83a615b 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
 
 	/*
 	 * Loop waiting for buffers to be returned.  When a buffer is returned,
-	 * reuse it to send more data or free if if all data has been sent.
+	 * reuse it to send more data or free if all data has been sent.
 	 */
 	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
 		reinit_completion(&priv->status_return_completion);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] fpga: stratix10-soc: fix typo in a comment
  2021-12-12  3:19 [PATCH] fpga: stratix10-soc: fix typo in a comment Jason Wang
@ 2021-12-12 16:19 ` Tom Rix
  2021-12-13  1:28   ` Xu Yilun
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Rix @ 2021-12-12 16:19 UTC (permalink / raw)
  To: Jason Wang, hao.wu; +Cc: mdf, yilun.xu, linux-fpga, linux-kernel


On 12/11/21 7:19 PM, Jason Wang wrote:
> The double `if' in the comment in line 288 is repeated. Remove one
> of them from the comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>   drivers/fpga/stratix10-soc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 357cea58ec98..e4f2e83a615b 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
>   
>   	/*
>   	 * Loop waiting for buffers to be returned.  When a buffer is returned,
> -	 * reuse it to send more data or free if if all data has been sent.
> +	 * reuse it to send more data or free if all data has been sent.

This looks fine.

Reviewed-by: Tom Rix <trix@redhat.com>

>   	 */
>   	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
>   		reinit_completion(&priv->status_return_completion);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fpga: stratix10-soc: fix typo in a comment
  2021-12-12 16:19 ` Tom Rix
@ 2021-12-13  1:28   ` Xu Yilun
  0 siblings, 0 replies; 3+ messages in thread
From: Xu Yilun @ 2021-12-13  1:28 UTC (permalink / raw)
  To: Tom Rix; +Cc: Jason Wang, hao.wu, mdf, linux-fpga, linux-kernel

On Sun, Dec 12, 2021 at 08:19:00AM -0800, Tom Rix wrote:
> 
> On 12/11/21 7:19 PM, Jason Wang wrote:
> > The double `if' in the comment in line 288 is repeated. Remove one
> > of them from the comment.
> > 
> > Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> > ---
> >   drivers/fpga/stratix10-soc.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 357cea58ec98..e4f2e83a615b 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
> >   	/*
> >   	 * Loop waiting for buffers to be returned.  When a buffer is returned,
> > -	 * reuse it to send more data or free if if all data has been sent.
> > +	 * reuse it to send more data or free if all data has been sent.
> 
> This looks fine.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Thanks,
Yilun

> 
> >   	 */
> >   	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
> >   		reinit_completion(&priv->status_return_completion);

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-13  1:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-12  3:19 [PATCH] fpga: stratix10-soc: fix typo in a comment Jason Wang
2021-12-12 16:19 ` Tom Rix
2021-12-13  1:28   ` Xu Yilun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.