* [PATCH] drm/ast: potential dereference of null pointer
@ 2021-12-13 5:39 ` Jiasheng Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Jiasheng Jiang @ 2021-12-13 5:39 UTC (permalink / raw)
To: airlied, tzimmermann, airlied, daniel
Cc: Jiasheng Jiang, linux-kernel, dri-devel
he return value of kzalloc() needs to be checked.
To avoid use of null pointer '&ast_state->base' in case of the
failure of alloc.
Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/ast/ast_mode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 36d9575aa27b..67f8e3f90ea2 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -1120,7 +1120,8 @@ static void ast_crtc_reset(struct drm_crtc *crtc)
if (crtc->state)
crtc->funcs->atomic_destroy_state(crtc, crtc->state);
- __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
+ if (ast_state)
+ __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
}
static struct drm_crtc_state *
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm/ast: potential dereference of null pointer
@ 2021-12-13 5:39 ` Jiasheng Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Jiasheng Jiang @ 2021-12-13 5:39 UTC (permalink / raw)
To: airlied, tzimmermann, airlied, daniel
Cc: dri-devel, linux-kernel, Jiasheng Jiang
he return value of kzalloc() needs to be checked.
To avoid use of null pointer '&ast_state->base' in case of the
failure of alloc.
Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/ast/ast_mode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 36d9575aa27b..67f8e3f90ea2 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -1120,7 +1120,8 @@ static void ast_crtc_reset(struct drm_crtc *crtc)
if (crtc->state)
crtc->funcs->atomic_destroy_state(crtc, crtc->state);
- __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
+ if (ast_state)
+ __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
}
static struct drm_crtc_state *
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/ast: potential dereference of null pointer
2021-12-13 5:39 ` Jiasheng Jiang
(?)
@ 2021-12-13 9:59 ` Thomas Zimmermann
-1 siblings, 0 replies; 5+ messages in thread
From: Thomas Zimmermann @ 2021-12-13 9:59 UTC (permalink / raw)
To: Jiasheng Jiang, airlied, airlied, daniel; +Cc: linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1440 bytes --]
Hi,
thanks for the patch.
Am 13.12.21 um 06:39 schrieb Jiasheng Jiang:
> he return value of kzalloc() needs to be checked.
'The'
> To avoid use of null pointer '&ast_state->base' in case of the
> failure of alloc.
>
> Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/gpu/drm/ast/ast_mode.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 36d9575aa27b..67f8e3f90ea2 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -1120,7 +1120,8 @@ static void ast_crtc_reset(struct drm_crtc *crtc)
> if (crtc->state)
> crtc->funcs->atomic_destroy_state(crtc, crtc->state);
>
> - __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
> + if (ast_state)
> + __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
If ast_state is NULL, __drm_atomic_helper_crtc_reset() has to be called
with a state of NULL. Otherwise the reset might leave the dangling
pointer in the CRTC's state field.
Best regards
Thomas
> }
>
> static struct drm_crtc_state *
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/ast: potential dereference of null pointer
@ 2021-12-14 1:37 ` Jiasheng Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Jiasheng Jiang @ 2021-12-14 1:37 UTC (permalink / raw)
To: airlied, tzimmermann, airlied, daniel
Cc: Jiasheng Jiang, linux-kernel, dri-devel
The return value of kzalloc() needs to be checked.
To avoid use of null pointer '&ast_state->base' in case of the
failure of alloc.
Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/ast/ast_mode.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 36d9575aa27b..65099f0359f9 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -1120,7 +1120,10 @@ static void ast_crtc_reset(struct drm_crtc *crtc)
if (crtc->state)
crtc->funcs->atomic_destroy_state(crtc, crtc->state);
- __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
+ if (ast_state)
+ __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
+ else
+ __drm_atomic_helper_crtc_reset(crtc, NULL);
}
static struct drm_crtc_state *
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm/ast: potential dereference of null pointer
@ 2021-12-14 1:37 ` Jiasheng Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Jiasheng Jiang @ 2021-12-14 1:37 UTC (permalink / raw)
To: airlied, tzimmermann, airlied, daniel
Cc: dri-devel, linux-kernel, Jiasheng Jiang
The return value of kzalloc() needs to be checked.
To avoid use of null pointer '&ast_state->base' in case of the
failure of alloc.
Fixes: f0adbc382b8b ("drm/ast: Allocate initial CRTC state of the correct size")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/ast/ast_mode.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 36d9575aa27b..65099f0359f9 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -1120,7 +1120,10 @@ static void ast_crtc_reset(struct drm_crtc *crtc)
if (crtc->state)
crtc->funcs->atomic_destroy_state(crtc, crtc->state);
- __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
+ if (ast_state)
+ __drm_atomic_helper_crtc_reset(crtc, &ast_state->base);
+ else
+ __drm_atomic_helper_crtc_reset(crtc, NULL);
}
static struct drm_crtc_state *
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-14 1:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 5:39 [PATCH] drm/ast: potential dereference of null pointer Jiasheng Jiang
2021-12-13 5:39 ` Jiasheng Jiang
2021-12-13 9:59 ` Thomas Zimmermann
2021-12-14 1:37 Jiasheng Jiang
2021-12-14 1:37 ` Jiasheng Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.