From: kernel test robot <lkp@intel.com>
To: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, davem@davemloft.net, kuba@kernel.org,
dsahern@kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net-next 1/4] fib: remove suppress indirection
Date: Tue, 14 Dec 2021 05:03:57 +0800 [thread overview]
Message-ID: <202112140516.lS6zCrEh-lkp@intel.com> (raw)
In-Reply-To: <20211213153147.17635-2-fw@strlen.de>
Hi Florian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Westphal/fib-remove-suppress-indirection-merge-nl-policies/20211213-233429
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 97884b07122aabb2d6891ce17f54e0e8e94d0bc5
config: i386-randconfig-a015-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140516.lS6zCrEh-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/585507534b121a41b45edaec79fe6c3d94a50b5f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Florian-Westphal/fib-remove-suppress-indirection-merge-nl-policies/20211213-233429
git checkout 585507534b121a41b45edaec79fe6c3d94a50b5f
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/core/fib_rules.c: In function 'fib4_rule_suppress':
net/core/fib_rules.c:300:31: error: implicit declaration of function 'fib_info_nhc'; did you mean 'fib_info_put'? [-Werror=implicit-function-declaration]
300 | struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
| ^~~~~~~~~~~~
| fib_info_put
>> net/core/fib_rules.c:300:31: warning: initialization of 'struct fib_nh_common *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
net/core/fib_rules.c: In function 'fib6_rule_suppress':
net/core/fib_rules.c:330:27: error: dereferencing pointer to incomplete type 'struct fib6_result'
330 | struct rt6_info *rt = res->rt6;
| ^~
net/core/fib_rules.c:336:8: error: dereferencing pointer to incomplete type 'struct rt6_info'
336 | if (rt->rt6i_idev)
| ^~
net/core/fib_rules.c:354:2: error: implicit declaration of function 'ip6_rt_put_flags' [-Werror=implicit-function-declaration]
354 | ip6_rt_put_flags(rt, flags);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +300 net/core/fib_rules.c
291
292 static bool fib4_rule_suppress(struct fib_rule *rule,
293 int flags,
294 struct fib_lookup_arg *arg)
295 {
296 struct fib_result *result = (struct fib_result *)arg->result;
297 struct net_device *dev = NULL;
298
299 if (result->fi) {
> 300 struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
301
302 dev = nhc->nhc_dev;
303 }
304
305 /* do not accept result if the route does
306 * not meet the required prefix length
307 */
308 if (result->prefixlen <= rule->suppress_prefixlen)
309 goto suppress_route;
310
311 /* do not accept result if the route uses a device
312 * belonging to a forbidden interface group
313 */
314 if (rule->suppress_ifgroup != -1 && dev && dev->group == rule->suppress_ifgroup)
315 goto suppress_route;
316
317 return false;
318
319 suppress_route:
320 if (!(arg->flags & FIB_LOOKUP_NOREF))
321 fib_info_put(result->fi);
322 return true;
323 }
324
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 1/4] fib: remove suppress indirection
Date: Tue, 14 Dec 2021 05:03:57 +0800 [thread overview]
Message-ID: <202112140516.lS6zCrEh-lkp@intel.com> (raw)
In-Reply-To: <20211213153147.17635-2-fw@strlen.de>
[-- Attachment #1: Type: text/plain, Size: 3664 bytes --]
Hi Florian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Westphal/fib-remove-suppress-indirection-merge-nl-policies/20211213-233429
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 97884b07122aabb2d6891ce17f54e0e8e94d0bc5
config: i386-randconfig-a015-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140516.lS6zCrEh-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/585507534b121a41b45edaec79fe6c3d94a50b5f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Florian-Westphal/fib-remove-suppress-indirection-merge-nl-policies/20211213-233429
git checkout 585507534b121a41b45edaec79fe6c3d94a50b5f
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/core/fib_rules.c: In function 'fib4_rule_suppress':
net/core/fib_rules.c:300:31: error: implicit declaration of function 'fib_info_nhc'; did you mean 'fib_info_put'? [-Werror=implicit-function-declaration]
300 | struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
| ^~~~~~~~~~~~
| fib_info_put
>> net/core/fib_rules.c:300:31: warning: initialization of 'struct fib_nh_common *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
net/core/fib_rules.c: In function 'fib6_rule_suppress':
net/core/fib_rules.c:330:27: error: dereferencing pointer to incomplete type 'struct fib6_result'
330 | struct rt6_info *rt = res->rt6;
| ^~
net/core/fib_rules.c:336:8: error: dereferencing pointer to incomplete type 'struct rt6_info'
336 | if (rt->rt6i_idev)
| ^~
net/core/fib_rules.c:354:2: error: implicit declaration of function 'ip6_rt_put_flags' [-Werror=implicit-function-declaration]
354 | ip6_rt_put_flags(rt, flags);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +300 net/core/fib_rules.c
291
292 static bool fib4_rule_suppress(struct fib_rule *rule,
293 int flags,
294 struct fib_lookup_arg *arg)
295 {
296 struct fib_result *result = (struct fib_result *)arg->result;
297 struct net_device *dev = NULL;
298
299 if (result->fi) {
> 300 struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
301
302 dev = nhc->nhc_dev;
303 }
304
305 /* do not accept result if the route does
306 * not meet the required prefix length
307 */
308 if (result->prefixlen <= rule->suppress_prefixlen)
309 goto suppress_route;
310
311 /* do not accept result if the route uses a device
312 * belonging to a forbidden interface group
313 */
314 if (rule->suppress_ifgroup != -1 && dev && dev->group == rule->suppress_ifgroup)
315 goto suppress_route;
316
317 return false;
318
319 suppress_route:
320 if (!(arg->flags & FIB_LOOKUP_NOREF))
321 fib_info_put(result->fi);
322 return true;
323 }
324
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-13 21:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 15:31 [PATCH net-next 0/4] fib: remove suppress indirection, merge nl policies Florian Westphal
2021-12-13 15:31 ` [PATCH net-next 1/4] fib: remove suppress indirection Florian Westphal
2021-12-13 20:39 ` kernel test robot
2021-12-13 20:39 ` kernel test robot
2021-12-13 21:03 ` kernel test robot [this message]
2021-12-13 21:03 ` kernel test robot
2021-12-13 21:14 ` kernel test robot
2021-12-13 21:14 ` kernel test robot
2021-12-13 15:31 ` [PATCH net-next 2/4] fib: place common code in a helper Florian Westphal
2021-12-13 15:31 ` [PATCH net-next 3/4] fib: rules: remove duplicated nla policies Florian Westphal
2021-12-13 15:31 ` [PATCH net-next 4/4] fib: expand fib_rule_policy Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112140516.lS6zCrEh-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.