From: "Pali Rohár" <pali@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: "Stefan Roese" <sr@denx.de>,
u-boot@lists.denx.de, "Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH u-boot-marvell v2 8/9] arm: mvebu: spl: Use IS_ENABLED() instead of #ifdef where possible
Date: Tue, 14 Dec 2021 10:36:00 +0100 [thread overview]
Message-ID: <20211214093600.e2sy5yrtpz7gvfna@pali> (raw)
In-Reply-To: <20211126143738.23830-9-kabel@kernel.org>
On Friday 26 November 2021 15:37:37 Marek Behún wrote:
> @@ -340,17 +333,17 @@ void board_init_f(ulong dummy)
> timer_init();
>
> /* Armada 375 does not support SerDes and DDR3 init yet */
> -#if !defined(CONFIG_ARMADA_375)
> - /* First init the serdes PHY's */
> - serdes_phy_config();
> -
> - /* Setup DDR */
> - ret = ddr3_init();
> - if (ret) {
> - debug("ddr3_init() failed: %d\n", ret);
> - hang();
> + if (!IS_ENABLED(CONFIG_ARMADA_375)) {
> + /* First init the serdes PHY's */
> + serdes_phy_config();
> +
> + /* Setup DDR */
> + ret = ddr3_init();
> + if (ret) {
> + debug("ddr3_init() failed: %d\n", ret);
> + hang();
> + }
> }
> -#endif
As written in comment above there is no SerDes and DDR3 support for
Armada 375 and therefore there is no serdes_phy_config() or ddr3_init()
function. So this code needs not to be compiled at all and usage of
#ifdef is correct here.
next prev parent reply other threads:[~2021-12-14 9:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 14:37 [PATCH u-boot-marvell v2 0/9] More verifications for kwbimage in SPL Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 1/9] arm: mvebu: Check that kwbimage offset and blocksize are valid Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 2/9] SPL: Add struct spl_boot_device parameter into spl_parse_board_header() Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 3/9] arm: mvebu: Check that kwbimage blockid matches boot mode Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 4/9] SPL: Add support for checking board / BootROM specific image types Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 5/9] arm: mvebu: Check for kwbimage data checksum Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 6/9] arm: mvebu: spl: Print srcaddr in error message Marek Behún
2021-11-30 6:20 ` Stefan Roese
2021-12-14 11:10 ` Pali Rohár
2021-12-14 13:11 ` Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 7/9] arm: mvebu: spl: Use preferred types u8/u16/u32 instead of uintN_t Marek Behún
2021-11-30 6:20 ` Stefan Roese
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 8/9] arm: mvebu: spl: Use IS_ENABLED() instead of #ifdef where possible Marek Behún
2021-11-30 6:22 ` Stefan Roese
2021-12-14 9:36 ` Pali Rohár [this message]
2021-12-14 9:45 ` Marek Behún
2021-12-14 11:12 ` Pali Rohár
2021-12-14 12:45 ` Marek Behún
2021-12-14 12:48 ` Stefan Roese
2021-12-14 13:01 ` Marek Behún
2021-12-16 18:16 ` Pali Rohár
2021-12-16 22:09 ` Marek Behún
2021-12-16 22:17 ` Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 9/9] arm: mvebu: spl: Fix 100 column exceeds Marek Behún
2021-11-30 6:22 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214093600.e2sy5yrtpz7gvfna@pali \
--to=pali@kernel.org \
--cc=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.