All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate'
@ 2021-12-14 17:33 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-12-14 17:33 UTC (permalink / raw)
  To: Ryder Lee; +Cc: llvm, kbuild-all, linux-kernel, Felix Fietkau

Hi Ryder,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
commit: 9a93364d6595358a11d07e7f4261ae263ae2a02a mt76: mt7915: rework debugfs fixed-rate knob
date:   7 weeks ago
config: arm64-randconfig-r026-20211214 (https://download.01.org/0day-ci/archive/20211215/202112150129.mnFkjamR-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9a93364d6595358a11d07e7f4261ae263ae2a02a
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 9a93364d6595358a11d07e7f4261ae263ae2a02a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/wireless/mediatek/mt76/mt7915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate' [-Wmissing-prototypes]
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
       ^
   drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
   ^
   static 
   1 warning generated.


vim +/mt7915_mcu_set_fixed_rate +2393 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

e57b7901469fc0b Ryder Lee     2020-04-25  2392  
9fac3c81eebd81b Ryder Lee     2020-04-25 @2393  int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
9fac3c81eebd81b Ryder Lee     2020-04-25  2394  			      struct ieee80211_sta *sta, u32 rate)
9fac3c81eebd81b Ryder Lee     2020-04-25  2395  {
9fac3c81eebd81b Ryder Lee     2020-04-25  2396  	struct mt7915_sta *msta = (struct mt7915_sta *)sta->drv_priv;
9fac3c81eebd81b Ryder Lee     2020-04-25  2397  	struct mt7915_vif *mvif = msta->vif;
9fac3c81eebd81b Ryder Lee     2020-04-25  2398  	struct sta_rec_ra_fixed *ra;
9fac3c81eebd81b Ryder Lee     2020-04-25  2399  	struct sk_buff *skb;
9fac3c81eebd81b Ryder Lee     2020-04-25  2400  	struct tlv *tlv;
3e68af622254bad Ryder Lee     2020-05-12  2401  	int len = sizeof(struct sta_req_hdr) + sizeof(*ra);
9fac3c81eebd81b Ryder Lee     2020-04-25  2402  
3e68af622254bad Ryder Lee     2020-05-12  2403  	skb = mt7915_mcu_alloc_sta_req(dev, mvif, msta, len);
9fac3c81eebd81b Ryder Lee     2020-04-25  2404  	if (IS_ERR(skb))
9fac3c81eebd81b Ryder Lee     2020-04-25  2405  		return PTR_ERR(skb);
9fac3c81eebd81b Ryder Lee     2020-04-25  2406  
9fac3c81eebd81b Ryder Lee     2020-04-25  2407  	tlv = mt7915_mcu_add_tlv(skb, STA_REC_RA_UPDATE, sizeof(*ra));
9fac3c81eebd81b Ryder Lee     2020-04-25  2408  	ra = (struct sta_rec_ra_fixed *)tlv;
9fac3c81eebd81b Ryder Lee     2020-04-25  2409  
9fac3c81eebd81b Ryder Lee     2020-04-25  2410  	if (!rate) {
9fac3c81eebd81b Ryder Lee     2020-04-25  2411  		ra->field = cpu_to_le32(RATE_PARAM_AUTO);
9fac3c81eebd81b Ryder Lee     2020-04-25  2412  		goto out;
9fac3c81eebd81b Ryder Lee     2020-04-25  2413  	}
9fac3c81eebd81b Ryder Lee     2020-04-25  2414  
4d2423326de9e98 Ryder Lee     2021-08-07  2415  	ra->field = cpu_to_le32(RATE_PARAM_FIXED);
9fac3c81eebd81b Ryder Lee     2020-04-25  2416  	ra->phy.type = FIELD_GET(RATE_CFG_PHY_TYPE, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2417  	ra->phy.bw = FIELD_GET(RATE_CFG_BW, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2418  	ra->phy.nss = FIELD_GET(RATE_CFG_NSS, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2419  	ra->phy.mcs = FIELD_GET(RATE_CFG_MCS, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2420  	ra->phy.stbc = FIELD_GET(RATE_CFG_STBC, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2421  
9fac3c81eebd81b Ryder Lee     2020-04-25  2422  	if (ra->phy.bw)
9fac3c81eebd81b Ryder Lee     2020-04-25  2423  		ra->phy.ldpc = 7;
9fac3c81eebd81b Ryder Lee     2020-04-25  2424  	else
9fac3c81eebd81b Ryder Lee     2020-04-25  2425  		ra->phy.ldpc = FIELD_GET(RATE_CFG_LDPC, rate) * 7;
9fac3c81eebd81b Ryder Lee     2020-04-25  2426  
9fac3c81eebd81b Ryder Lee     2020-04-25  2427  	/* HT/VHT - SGI: 1, LGI: 0; HE - SGI: 0, MGI: 1, LGI: 2 */
4d2423326de9e98 Ryder Lee     2021-08-07  2428  	if (ra->phy.type > MT_PHY_TYPE_VHT) {
4d2423326de9e98 Ryder Lee     2021-08-07  2429  		ra->phy.he_ltf = FIELD_GET(RATE_CFG_HE_LTF, rate) * 85;
4d2423326de9e98 Ryder Lee     2021-08-07  2430  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 85;
4d2423326de9e98 Ryder Lee     2021-08-07  2431  	} else {
4d2423326de9e98 Ryder Lee     2021-08-07  2432  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 15;
4d2423326de9e98 Ryder Lee     2021-08-07  2433  	}
9fac3c81eebd81b Ryder Lee     2020-04-25  2434  
9fac3c81eebd81b Ryder Lee     2020-04-25  2435  out:
fa62d0e0080bca7 Felix Fietkau 2020-09-30  2436  	return mt76_mcu_skb_send_msg(&dev->mt76, skb,
c203dd621780842 Felix Fietkau 2021-01-06  2437  				     MCU_EXT_CMD(STA_REC_UPDATE), true);
9fac3c81eebd81b Ryder Lee     2020-04-25  2438  }
9fac3c81eebd81b Ryder Lee     2020-04-25  2439  

:::::: The code at line 2393 was first introduced by commit
:::::: 9fac3c81eebd81bbce8b050e15b03d3490841717 mt76: mt7915: set peer Tx fixed rate through debugfs

:::::: TO: Ryder Lee <ryder.lee@mediatek.com>
:::::: CC: Felix Fietkau <nbd@nbd.name>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate'
@ 2021-12-14 17:33 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-12-14 17:33 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 6218 bytes --]

Hi Ryder,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
commit: 9a93364d6595358a11d07e7f4261ae263ae2a02a mt76: mt7915: rework debugfs fixed-rate knob
date:   7 weeks ago
config: arm64-randconfig-r026-20211214 (https://download.01.org/0day-ci/archive/20211215/202112150129.mnFkjamR-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9a93364d6595358a11d07e7f4261ae263ae2a02a
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 9a93364d6595358a11d07e7f4261ae263ae2a02a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/wireless/mediatek/mt76/mt7915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate' [-Wmissing-prototypes]
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
       ^
   drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
   ^
   static 
   1 warning generated.


vim +/mt7915_mcu_set_fixed_rate +2393 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

e57b7901469fc0b Ryder Lee     2020-04-25  2392  
9fac3c81eebd81b Ryder Lee     2020-04-25 @2393  int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
9fac3c81eebd81b Ryder Lee     2020-04-25  2394  			      struct ieee80211_sta *sta, u32 rate)
9fac3c81eebd81b Ryder Lee     2020-04-25  2395  {
9fac3c81eebd81b Ryder Lee     2020-04-25  2396  	struct mt7915_sta *msta = (struct mt7915_sta *)sta->drv_priv;
9fac3c81eebd81b Ryder Lee     2020-04-25  2397  	struct mt7915_vif *mvif = msta->vif;
9fac3c81eebd81b Ryder Lee     2020-04-25  2398  	struct sta_rec_ra_fixed *ra;
9fac3c81eebd81b Ryder Lee     2020-04-25  2399  	struct sk_buff *skb;
9fac3c81eebd81b Ryder Lee     2020-04-25  2400  	struct tlv *tlv;
3e68af622254bad Ryder Lee     2020-05-12  2401  	int len = sizeof(struct sta_req_hdr) + sizeof(*ra);
9fac3c81eebd81b Ryder Lee     2020-04-25  2402  
3e68af622254bad Ryder Lee     2020-05-12  2403  	skb = mt7915_mcu_alloc_sta_req(dev, mvif, msta, len);
9fac3c81eebd81b Ryder Lee     2020-04-25  2404  	if (IS_ERR(skb))
9fac3c81eebd81b Ryder Lee     2020-04-25  2405  		return PTR_ERR(skb);
9fac3c81eebd81b Ryder Lee     2020-04-25  2406  
9fac3c81eebd81b Ryder Lee     2020-04-25  2407  	tlv = mt7915_mcu_add_tlv(skb, STA_REC_RA_UPDATE, sizeof(*ra));
9fac3c81eebd81b Ryder Lee     2020-04-25  2408  	ra = (struct sta_rec_ra_fixed *)tlv;
9fac3c81eebd81b Ryder Lee     2020-04-25  2409  
9fac3c81eebd81b Ryder Lee     2020-04-25  2410  	if (!rate) {
9fac3c81eebd81b Ryder Lee     2020-04-25  2411  		ra->field = cpu_to_le32(RATE_PARAM_AUTO);
9fac3c81eebd81b Ryder Lee     2020-04-25  2412  		goto out;
9fac3c81eebd81b Ryder Lee     2020-04-25  2413  	}
9fac3c81eebd81b Ryder Lee     2020-04-25  2414  
4d2423326de9e98 Ryder Lee     2021-08-07  2415  	ra->field = cpu_to_le32(RATE_PARAM_FIXED);
9fac3c81eebd81b Ryder Lee     2020-04-25  2416  	ra->phy.type = FIELD_GET(RATE_CFG_PHY_TYPE, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2417  	ra->phy.bw = FIELD_GET(RATE_CFG_BW, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2418  	ra->phy.nss = FIELD_GET(RATE_CFG_NSS, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2419  	ra->phy.mcs = FIELD_GET(RATE_CFG_MCS, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2420  	ra->phy.stbc = FIELD_GET(RATE_CFG_STBC, rate);
9fac3c81eebd81b Ryder Lee     2020-04-25  2421  
9fac3c81eebd81b Ryder Lee     2020-04-25  2422  	if (ra->phy.bw)
9fac3c81eebd81b Ryder Lee     2020-04-25  2423  		ra->phy.ldpc = 7;
9fac3c81eebd81b Ryder Lee     2020-04-25  2424  	else
9fac3c81eebd81b Ryder Lee     2020-04-25  2425  		ra->phy.ldpc = FIELD_GET(RATE_CFG_LDPC, rate) * 7;
9fac3c81eebd81b Ryder Lee     2020-04-25  2426  
9fac3c81eebd81b Ryder Lee     2020-04-25  2427  	/* HT/VHT - SGI: 1, LGI: 0; HE - SGI: 0, MGI: 1, LGI: 2 */
4d2423326de9e98 Ryder Lee     2021-08-07  2428  	if (ra->phy.type > MT_PHY_TYPE_VHT) {
4d2423326de9e98 Ryder Lee     2021-08-07  2429  		ra->phy.he_ltf = FIELD_GET(RATE_CFG_HE_LTF, rate) * 85;
4d2423326de9e98 Ryder Lee     2021-08-07  2430  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 85;
4d2423326de9e98 Ryder Lee     2021-08-07  2431  	} else {
4d2423326de9e98 Ryder Lee     2021-08-07  2432  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 15;
4d2423326de9e98 Ryder Lee     2021-08-07  2433  	}
9fac3c81eebd81b Ryder Lee     2020-04-25  2434  
9fac3c81eebd81b Ryder Lee     2020-04-25  2435  out:
fa62d0e0080bca7 Felix Fietkau 2020-09-30  2436  	return mt76_mcu_skb_send_msg(&dev->mt76, skb,
c203dd621780842 Felix Fietkau 2021-01-06  2437  				     MCU_EXT_CMD(STA_REC_UPDATE), true);
9fac3c81eebd81b Ryder Lee     2020-04-25  2438  }
9fac3c81eebd81b Ryder Lee     2020-04-25  2439  

:::::: The code at line 2393 was first introduced by commit
:::::: 9fac3c81eebd81bbce8b050e15b03d3490841717 mt76: mt7915: set peer Tx fixed rate through debugfs

:::::: TO: Ryder Lee <ryder.lee@mediatek.com>
:::::: CC: Felix Fietkau <nbd@nbd.name>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate'
@ 2021-11-05  1:28 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-11-05  1:28 UTC (permalink / raw)
  To: Ryder Lee; +Cc: llvm, kbuild-all, linux-kernel, Felix Fietkau

[-- Attachment #1: Type: text/plain, Size: 5853 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d4439a1189f93d0ac1eaf0197db8e6b3e197d5c7
commit: 9a93364d6595358a11d07e7f4261ae263ae2a02a mt76: mt7915: rework debugfs fixed-rate knob
date:   13 days ago
config: arm-randconfig-r025-20211105 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 847a6807332b13f43704327c2d30103ec0347c77)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9a93364d6595358a11d07e7f4261ae263ae2a02a
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 9a93364d6595358a11d07e7f4261ae263ae2a02a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate' [-Wmissing-prototypes]
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
       ^
   drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
   ^
   static 
   1 warning generated.


vim +/mt7915_mcu_set_fixed_rate +2393 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

e57b7901469fc0 Ryder Lee     2020-04-25  2392  
9fac3c81eebd81 Ryder Lee     2020-04-25 @2393  int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
9fac3c81eebd81 Ryder Lee     2020-04-25  2394  			      struct ieee80211_sta *sta, u32 rate)
9fac3c81eebd81 Ryder Lee     2020-04-25  2395  {
9fac3c81eebd81 Ryder Lee     2020-04-25  2396  	struct mt7915_sta *msta = (struct mt7915_sta *)sta->drv_priv;
9fac3c81eebd81 Ryder Lee     2020-04-25  2397  	struct mt7915_vif *mvif = msta->vif;
9fac3c81eebd81 Ryder Lee     2020-04-25  2398  	struct sta_rec_ra_fixed *ra;
9fac3c81eebd81 Ryder Lee     2020-04-25  2399  	struct sk_buff *skb;
9fac3c81eebd81 Ryder Lee     2020-04-25  2400  	struct tlv *tlv;
3e68af622254ba Ryder Lee     2020-05-12  2401  	int len = sizeof(struct sta_req_hdr) + sizeof(*ra);
9fac3c81eebd81 Ryder Lee     2020-04-25  2402  
3e68af622254ba Ryder Lee     2020-05-12  2403  	skb = mt7915_mcu_alloc_sta_req(dev, mvif, msta, len);
9fac3c81eebd81 Ryder Lee     2020-04-25  2404  	if (IS_ERR(skb))
9fac3c81eebd81 Ryder Lee     2020-04-25  2405  		return PTR_ERR(skb);
9fac3c81eebd81 Ryder Lee     2020-04-25  2406  
9fac3c81eebd81 Ryder Lee     2020-04-25  2407  	tlv = mt7915_mcu_add_tlv(skb, STA_REC_RA_UPDATE, sizeof(*ra));
9fac3c81eebd81 Ryder Lee     2020-04-25  2408  	ra = (struct sta_rec_ra_fixed *)tlv;
9fac3c81eebd81 Ryder Lee     2020-04-25  2409  
9fac3c81eebd81 Ryder Lee     2020-04-25  2410  	if (!rate) {
9fac3c81eebd81 Ryder Lee     2020-04-25  2411  		ra->field = cpu_to_le32(RATE_PARAM_AUTO);
9fac3c81eebd81 Ryder Lee     2020-04-25  2412  		goto out;
9fac3c81eebd81 Ryder Lee     2020-04-25  2413  	}
9fac3c81eebd81 Ryder Lee     2020-04-25  2414  
4d2423326de9e9 Ryder Lee     2021-08-07  2415  	ra->field = cpu_to_le32(RATE_PARAM_FIXED);
9fac3c81eebd81 Ryder Lee     2020-04-25  2416  	ra->phy.type = FIELD_GET(RATE_CFG_PHY_TYPE, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2417  	ra->phy.bw = FIELD_GET(RATE_CFG_BW, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2418  	ra->phy.nss = FIELD_GET(RATE_CFG_NSS, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2419  	ra->phy.mcs = FIELD_GET(RATE_CFG_MCS, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2420  	ra->phy.stbc = FIELD_GET(RATE_CFG_STBC, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2421  
9fac3c81eebd81 Ryder Lee     2020-04-25  2422  	if (ra->phy.bw)
9fac3c81eebd81 Ryder Lee     2020-04-25  2423  		ra->phy.ldpc = 7;
9fac3c81eebd81 Ryder Lee     2020-04-25  2424  	else
9fac3c81eebd81 Ryder Lee     2020-04-25  2425  		ra->phy.ldpc = FIELD_GET(RATE_CFG_LDPC, rate) * 7;
9fac3c81eebd81 Ryder Lee     2020-04-25  2426  
9fac3c81eebd81 Ryder Lee     2020-04-25  2427  	/* HT/VHT - SGI: 1, LGI: 0; HE - SGI: 0, MGI: 1, LGI: 2 */
4d2423326de9e9 Ryder Lee     2021-08-07  2428  	if (ra->phy.type > MT_PHY_TYPE_VHT) {
4d2423326de9e9 Ryder Lee     2021-08-07  2429  		ra->phy.he_ltf = FIELD_GET(RATE_CFG_HE_LTF, rate) * 85;
4d2423326de9e9 Ryder Lee     2021-08-07  2430  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 85;
4d2423326de9e9 Ryder Lee     2021-08-07  2431  	} else {
4d2423326de9e9 Ryder Lee     2021-08-07  2432  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 15;
4d2423326de9e9 Ryder Lee     2021-08-07  2433  	}
9fac3c81eebd81 Ryder Lee     2020-04-25  2434  
9fac3c81eebd81 Ryder Lee     2020-04-25  2435  out:
fa62d0e0080bca Felix Fietkau 2020-09-30  2436  	return mt76_mcu_skb_send_msg(&dev->mt76, skb,
c203dd62178084 Felix Fietkau 2021-01-06  2437  				     MCU_EXT_CMD(STA_REC_UPDATE), true);
9fac3c81eebd81 Ryder Lee     2020-04-25  2438  }
9fac3c81eebd81 Ryder Lee     2020-04-25  2439  

:::::: The code at line 2393 was first introduced by commit
:::::: 9fac3c81eebd81bbce8b050e15b03d3490841717 mt76: mt7915: set peer Tx fixed rate through debugfs

:::::: TO: Ryder Lee <ryder.lee@mediatek.com>
:::::: CC: Felix Fietkau <nbd@nbd.name>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47640 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate'
@ 2021-11-05  1:28 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-11-05  1:28 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5948 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d4439a1189f93d0ac1eaf0197db8e6b3e197d5c7
commit: 9a93364d6595358a11d07e7f4261ae263ae2a02a mt76: mt7915: rework debugfs fixed-rate knob
date:   13 days ago
config: arm-randconfig-r025-20211105 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 847a6807332b13f43704327c2d30103ec0347c77)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9a93364d6595358a11d07e7f4261ae263ae2a02a
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 9a93364d6595358a11d07e7f4261ae263ae2a02a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate' [-Wmissing-prototypes]
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
       ^
   drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
   ^
   static 
   1 warning generated.


vim +/mt7915_mcu_set_fixed_rate +2393 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

e57b7901469fc0 Ryder Lee     2020-04-25  2392  
9fac3c81eebd81 Ryder Lee     2020-04-25 @2393  int mt7915_mcu_set_fixed_rate(struct mt7915_dev *dev,
9fac3c81eebd81 Ryder Lee     2020-04-25  2394  			      struct ieee80211_sta *sta, u32 rate)
9fac3c81eebd81 Ryder Lee     2020-04-25  2395  {
9fac3c81eebd81 Ryder Lee     2020-04-25  2396  	struct mt7915_sta *msta = (struct mt7915_sta *)sta->drv_priv;
9fac3c81eebd81 Ryder Lee     2020-04-25  2397  	struct mt7915_vif *mvif = msta->vif;
9fac3c81eebd81 Ryder Lee     2020-04-25  2398  	struct sta_rec_ra_fixed *ra;
9fac3c81eebd81 Ryder Lee     2020-04-25  2399  	struct sk_buff *skb;
9fac3c81eebd81 Ryder Lee     2020-04-25  2400  	struct tlv *tlv;
3e68af622254ba Ryder Lee     2020-05-12  2401  	int len = sizeof(struct sta_req_hdr) + sizeof(*ra);
9fac3c81eebd81 Ryder Lee     2020-04-25  2402  
3e68af622254ba Ryder Lee     2020-05-12  2403  	skb = mt7915_mcu_alloc_sta_req(dev, mvif, msta, len);
9fac3c81eebd81 Ryder Lee     2020-04-25  2404  	if (IS_ERR(skb))
9fac3c81eebd81 Ryder Lee     2020-04-25  2405  		return PTR_ERR(skb);
9fac3c81eebd81 Ryder Lee     2020-04-25  2406  
9fac3c81eebd81 Ryder Lee     2020-04-25  2407  	tlv = mt7915_mcu_add_tlv(skb, STA_REC_RA_UPDATE, sizeof(*ra));
9fac3c81eebd81 Ryder Lee     2020-04-25  2408  	ra = (struct sta_rec_ra_fixed *)tlv;
9fac3c81eebd81 Ryder Lee     2020-04-25  2409  
9fac3c81eebd81 Ryder Lee     2020-04-25  2410  	if (!rate) {
9fac3c81eebd81 Ryder Lee     2020-04-25  2411  		ra->field = cpu_to_le32(RATE_PARAM_AUTO);
9fac3c81eebd81 Ryder Lee     2020-04-25  2412  		goto out;
9fac3c81eebd81 Ryder Lee     2020-04-25  2413  	}
9fac3c81eebd81 Ryder Lee     2020-04-25  2414  
4d2423326de9e9 Ryder Lee     2021-08-07  2415  	ra->field = cpu_to_le32(RATE_PARAM_FIXED);
9fac3c81eebd81 Ryder Lee     2020-04-25  2416  	ra->phy.type = FIELD_GET(RATE_CFG_PHY_TYPE, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2417  	ra->phy.bw = FIELD_GET(RATE_CFG_BW, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2418  	ra->phy.nss = FIELD_GET(RATE_CFG_NSS, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2419  	ra->phy.mcs = FIELD_GET(RATE_CFG_MCS, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2420  	ra->phy.stbc = FIELD_GET(RATE_CFG_STBC, rate);
9fac3c81eebd81 Ryder Lee     2020-04-25  2421  
9fac3c81eebd81 Ryder Lee     2020-04-25  2422  	if (ra->phy.bw)
9fac3c81eebd81 Ryder Lee     2020-04-25  2423  		ra->phy.ldpc = 7;
9fac3c81eebd81 Ryder Lee     2020-04-25  2424  	else
9fac3c81eebd81 Ryder Lee     2020-04-25  2425  		ra->phy.ldpc = FIELD_GET(RATE_CFG_LDPC, rate) * 7;
9fac3c81eebd81 Ryder Lee     2020-04-25  2426  
9fac3c81eebd81 Ryder Lee     2020-04-25  2427  	/* HT/VHT - SGI: 1, LGI: 0; HE - SGI: 0, MGI: 1, LGI: 2 */
4d2423326de9e9 Ryder Lee     2021-08-07  2428  	if (ra->phy.type > MT_PHY_TYPE_VHT) {
4d2423326de9e9 Ryder Lee     2021-08-07  2429  		ra->phy.he_ltf = FIELD_GET(RATE_CFG_HE_LTF, rate) * 85;
4d2423326de9e9 Ryder Lee     2021-08-07  2430  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 85;
4d2423326de9e9 Ryder Lee     2021-08-07  2431  	} else {
4d2423326de9e9 Ryder Lee     2021-08-07  2432  		ra->phy.sgi = FIELD_GET(RATE_CFG_GI, rate) * 15;
4d2423326de9e9 Ryder Lee     2021-08-07  2433  	}
9fac3c81eebd81 Ryder Lee     2020-04-25  2434  
9fac3c81eebd81 Ryder Lee     2020-04-25  2435  out:
fa62d0e0080bca Felix Fietkau 2020-09-30  2436  	return mt76_mcu_skb_send_msg(&dev->mt76, skb,
c203dd62178084 Felix Fietkau 2021-01-06  2437  				     MCU_EXT_CMD(STA_REC_UPDATE), true);
9fac3c81eebd81 Ryder Lee     2020-04-25  2438  }
9fac3c81eebd81 Ryder Lee     2020-04-25  2439  

:::::: The code at line 2393 was first introduced by commit
:::::: 9fac3c81eebd81bbce8b050e15b03d3490841717 mt76: mt7915: set peer Tx fixed rate through debugfs

:::::: TO: Ryder Lee <ryder.lee@mediatek.com>
:::::: CC: Felix Fietkau <nbd@nbd.name>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 47640 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-14 17:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 17:33 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2393:5: warning: no previous prototype for function 'mt7915_mcu_set_fixed_rate' kernel test robot
2021-12-14 17:33 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-11-05  1:28 kernel test robot
2021-11-05  1:28 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.