* [PATCH net-next] net: dsa: rtl8365mb: add GMII as user port mode
@ 2021-12-15 3:41 luizluca
2021-12-16 11:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 4+ messages in thread
From: luizluca @ 2021-12-15 3:41 UTC (permalink / raw)
To: netdev
Cc: alsi, linus.walleij, Luiz Angelo Daros de Luca,
Arınç ÜNAL
From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Recent net-next fails to initialize ports with:
realtek-smi switch: phy mode gmii is unsupported on port 0
realtek-smi switch lan5 (uninitialized): validation of gmii with
support 0000000,00000000,000062ef and advertisement
0000000,00000000,000062ef failed: -22
realtek-smi switch lan5 (uninitialized): failed to connect to PHY:
-EINVAL
realtek-smi switch lan5 (uninitialized): error -22 setting up PHY
for tree 1, switch 0, port 0
Current net branch(3dd7d40b43663f58d11ee7a3d3798813b26a48f1) is not
affected.
I also noticed the same issue before with older versions but using
a MDIO interface driver, not realtek-smi.
Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
drivers/net/dsa/rtl8365mb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/rtl8365mb.c b/drivers/net/dsa/rtl8365mb.c
index 2ac68c867636..3b729544798b 100644
--- a/drivers/net/dsa/rtl8365mb.c
+++ b/drivers/net/dsa/rtl8365mb.c
@@ -900,7 +900,8 @@ static bool rtl8365mb_phy_mode_supported(struct dsa_switch *ds, int port,
{
if (dsa_is_user_port(ds, port) &&
(interface == PHY_INTERFACE_MODE_NA ||
- interface == PHY_INTERFACE_MODE_INTERNAL))
+ interface == PHY_INTERFACE_MODE_INTERNAL ||
+ interface == PHY_INTERFACE_MODE_GMII))
/* Internal PHY */
return true;
else if (dsa_is_cpu_port(ds, port) &&
--
2.34.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: rtl8365mb: add GMII as user port mode
2021-12-15 3:41 [PATCH net-next] net: dsa: rtl8365mb: add GMII as user port mode luizluca
@ 2021-12-16 11:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-16 11:00 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca; +Cc: netdev, alsi, linus.walleij, arinc.unal
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 15 Dec 2021 00:41:28 -0300 you wrote:
> From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
>
> Recent net-next fails to initialize ports with:
>
> realtek-smi switch: phy mode gmii is unsupported on port 0
> realtek-smi switch lan5 (uninitialized): validation of gmii with
> support 0000000,00000000,000062ef and advertisement
> 0000000,00000000,000062ef failed: -22
> realtek-smi switch lan5 (uninitialized): failed to connect to PHY:
> -EINVAL
> realtek-smi switch lan5 (uninitialized): error -22 setting up PHY
> for tree 1, switch 0, port 0
>
> [...]
Here is the summary with links:
- [net-next] net: dsa: rtl8365mb: add GMII as user port mode
https://git.kernel.org/netdev/net-next/c/a5dba0f207e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: rtl8365mb: add GMII as user port mode
2021-12-14 19:07 luizluca
@ 2021-12-15 2:36 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2021-12-15 2:36 UTC (permalink / raw)
To: luizluca; +Cc: netdev, alsi, Arınç ÜNAL
On Tue, 14 Dec 2021 16:07:05 -0300 luizluca@gmail.com wrote:
> From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
>
> Recent net-next fails to initialize ports with:
>
> realtek-smi switch: phy mode gmii is unsupported on port 0
> realtek-smi switch lan5 (uninitialized): validation of gmii with
> support 0000000,00000000,000062ef and advertisement
> 0000000,00000000,000062ef failed: -22
> realtek-smi switch lan5 (uninitialized): failed to connect to PHY:
> -EINVAL
> realtek-smi switch lan5 (uninitialized): error -22 setting up PHY
> for tree 1, switch 0, port 0
>
> Current net branch(3dd7d40b43663f58d11ee7a3d3798813b26a48f1) is not
> affected.
>
> I also noticed the same issue before with older versions but using
> a MDIO interface driver, not realtek-smi.
>
> Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Please use get_maintainer.pl to find appropriate reviewers, and repost
with them CCed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next] net: dsa: rtl8365mb: add GMII as user port mode
@ 2021-12-14 19:07 luizluca
2021-12-15 2:36 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: luizluca @ 2021-12-14 19:07 UTC (permalink / raw)
To: netdev; +Cc: alsi, Luiz Angelo Daros de Luca, Arınç ÜNAL
From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Recent net-next fails to initialize ports with:
realtek-smi switch: phy mode gmii is unsupported on port 0
realtek-smi switch lan5 (uninitialized): validation of gmii with
support 0000000,00000000,000062ef and advertisement
0000000,00000000,000062ef failed: -22
realtek-smi switch lan5 (uninitialized): failed to connect to PHY:
-EINVAL
realtek-smi switch lan5 (uninitialized): error -22 setting up PHY
for tree 1, switch 0, port 0
Current net branch(3dd7d40b43663f58d11ee7a3d3798813b26a48f1) is not
affected.
I also noticed the same issue before with older versions but using
a MDIO interface driver, not realtek-smi.
Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
drivers/net/dsa/rtl8365mb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/rtl8365mb.c b/drivers/net/dsa/rtl8365mb.c
index 2ac68c867636..3b729544798b 100644
--- a/drivers/net/dsa/rtl8365mb.c
+++ b/drivers/net/dsa/rtl8365mb.c
@@ -900,7 +900,8 @@ static bool rtl8365mb_phy_mode_supported(struct dsa_switch *ds, int port,
{
if (dsa_is_user_port(ds, port) &&
(interface == PHY_INTERFACE_MODE_NA ||
- interface == PHY_INTERFACE_MODE_INTERNAL))
+ interface == PHY_INTERFACE_MODE_INTERNAL ||
+ interface == PHY_INTERFACE_MODE_GMII))
/* Internal PHY */
return true;
else if (dsa_is_cpu_port(ds, port) &&
--
2.34.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-16 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 3:41 [PATCH net-next] net: dsa: rtl8365mb: add GMII as user port mode luizluca
2021-12-16 11:00 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2021-12-14 19:07 luizluca
2021-12-15 2:36 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.