All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: linux-clk@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dom Cobley <dom@raspberrypi.com>, Emma Anholt <emma@anholt.net>,
	linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v2 0/3] clk: Implement a clock request API
Date: Wed, 15 Dec 2021 15:08:36 +0100	[thread overview]
Message-ID: <20211215140836.bpxyau4atm74sfkk@houat> (raw)
In-Reply-To: <20210914093515.260031-1-maxime@cerno.tech>

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Hi Stephen, Mike,

On Tue, Sep 14, 2021 at 11:35:12AM +0200, Maxime Ripard wrote:
> Hi,
> 
> This is a follow-up of the discussion here:
> https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/
> 
> This implements a mechanism to raise and lower clock rates based on consumer
> workloads, with an example of such an implementation for the RaspberryPi4 HDMI
> controller.
> 
> There's a couple of things worth discussing:
> 
>   - The name is in conflict with clk_request_rate, and even though it feels
>     like the right name to me, we should probably avoid any confusion
> 
>   - The code so far implements a policy of always going for the lowest rate
>     possible. While we don't have an use-case for something else, this should
>     maybe be made more flexible?

This has been posted around 8 monthes ago now:
https://lore.kernel.org/all/20210413101320.321584-1-maxime@cerno.tech/

I haven't had any review on this, and I'm struggling to see how we can
move forward. Given your initial reaction, I'm guessing you were a bit
reluctant at first with the approach, if so, can you share *any*
direction in which I should amend that series to support similar
features?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: Dom Cobley <dom@raspberrypi.com>, Emma Anholt <emma@anholt.net>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	linux-kernel@vger.kernel.org,
	Tim Gover <tim.gover@raspberrypi.com>,
	linux-clk@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH v2 0/3] clk: Implement a clock request API
Date: Wed, 15 Dec 2021 15:08:36 +0100	[thread overview]
Message-ID: <20211215140836.bpxyau4atm74sfkk@houat> (raw)
In-Reply-To: <20210914093515.260031-1-maxime@cerno.tech>

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Hi Stephen, Mike,

On Tue, Sep 14, 2021 at 11:35:12AM +0200, Maxime Ripard wrote:
> Hi,
> 
> This is a follow-up of the discussion here:
> https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/
> 
> This implements a mechanism to raise and lower clock rates based on consumer
> workloads, with an example of such an implementation for the RaspberryPi4 HDMI
> controller.
> 
> There's a couple of things worth discussing:
> 
>   - The name is in conflict with clk_request_rate, and even though it feels
>     like the right name to me, we should probably avoid any confusion
> 
>   - The code so far implements a policy of always going for the lowest rate
>     possible. While we don't have an use-case for something else, this should
>     maybe be made more flexible?

This has been posted around 8 monthes ago now:
https://lore.kernel.org/all/20210413101320.321584-1-maxime@cerno.tech/

I haven't had any review on this, and I'm struggling to see how we can
move forward. Given your initial reaction, I'm guessing you were a bit
reluctant at first with the approach, if so, can you share *any*
direction in which I should amend that series to support similar
features?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2021-12-15 14:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  9:35 [PATCH v2 0/3] clk: Implement a clock request API Maxime Ripard
2021-09-14  9:35 ` [PATCH v2 1/3] clk: Introduce " Maxime Ripard
2022-01-12  3:37   ` Stephen Boyd
2022-01-12  3:37     ` Stephen Boyd
2022-01-12 11:46     ` Maxime Ripard
2022-01-12 11:46       ` Maxime Ripard
2022-01-13 21:44       ` Stephen Boyd
2022-01-13 21:44         ` Stephen Boyd
2022-01-14 16:15         ` Maxime Ripard
2022-01-14 16:15           ` Maxime Ripard
2022-01-14 22:38           ` Stephen Boyd
2022-01-14 22:38             ` Stephen Boyd
2022-01-14 22:41           ` Stephen Boyd
2022-01-14 22:41             ` Stephen Boyd
2021-09-14  9:35 ` [PATCH v2 2/3] drm/vc4: hdmi: Convert to the new " Maxime Ripard
2021-09-14  9:35 ` [PATCH v2 3/3] drm/vc4: hvs: " Maxime Ripard
2021-12-15 14:08 ` Maxime Ripard [this message]
2021-12-15 14:08   ` [PATCH v2 0/3] clk: Implement a " Maxime Ripard
2022-01-12 13:28 ` Dmitry Osipenko
2022-01-12 13:28   ` Dmitry Osipenko
2022-01-12 13:51   ` Maxime Ripard
2022-01-12 13:51     ` Maxime Ripard
2022-01-12 14:13     ` Dmitry Osipenko
2022-01-12 14:13       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211215140836.bpxyau4atm74sfkk@houat \
    --to=maxime@cerno.tech \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dom@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mturquette@baylibre.com \
    --cc=phil@raspberrypi.com \
    --cc=sboyd@kernel.org \
    --cc=tim.gover@raspberrypi.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.