* [PATCH] migration: Report the error returned when save_live_iterate fails
@ 2021-12-15 14:14 David Edmondson
2021-12-15 19:38 ` Dr. David Alan Gilbert
2022-01-26 20:24 ` Juan Quintela
0 siblings, 2 replies; 3+ messages in thread
From: David Edmondson @ 2021-12-15 14:14 UTC (permalink / raw)
To: qemu-devel; +Cc: David Edmondson, Dr. David Alan Gilbert, Juan Quintela
Should qemu_savevm_state_iterate() encounter a failure when calling a
particular save_live_iterate function, report the error code returned
by the function.
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
---
migration/savevm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index d59e976d50..26aac04d91 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1298,8 +1298,9 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool postcopy)
save_section_footer(f, se);
if (ret < 0) {
- error_report("failed to save SaveStateEntry with id(name): %d(%s)",
- se->section_id, se->idstr);
+ error_report("failed to save SaveStateEntry with id(name): "
+ "%d(%s): %d",
+ se->section_id, se->idstr, ret);
qemu_file_set_error(f, ret);
}
if (ret <= 0) {
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] migration: Report the error returned when save_live_iterate fails
2021-12-15 14:14 [PATCH] migration: Report the error returned when save_live_iterate fails David Edmondson
@ 2021-12-15 19:38 ` Dr. David Alan Gilbert
2022-01-26 20:24 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2021-12-15 19:38 UTC (permalink / raw)
To: David Edmondson; +Cc: qemu-devel, Juan Quintela
* David Edmondson (david.edmondson@oracle.com) wrote:
> Should qemu_savevm_state_iterate() encounter a failure when calling a
> particular save_live_iterate function, report the error code returned
> by the function.
>
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
> migration/savevm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index d59e976d50..26aac04d91 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1298,8 +1298,9 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool postcopy)
> save_section_footer(f, se);
>
> if (ret < 0) {
> - error_report("failed to save SaveStateEntry with id(name): %d(%s)",
> - se->section_id, se->idstr);
> + error_report("failed to save SaveStateEntry with id(name): "
> + "%d(%s): %d",
> + se->section_id, se->idstr, ret);
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> qemu_file_set_error(f, ret);
> }
> if (ret <= 0) {
> --
> 2.33.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] migration: Report the error returned when save_live_iterate fails
2021-12-15 14:14 [PATCH] migration: Report the error returned when save_live_iterate fails David Edmondson
2021-12-15 19:38 ` Dr. David Alan Gilbert
@ 2022-01-26 20:24 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2022-01-26 20:24 UTC (permalink / raw)
To: David Edmondson; +Cc: qemu-devel, Dr. David Alan Gilbert
David Edmondson <david.edmondson@oracle.com> wrote:
> Should qemu_savevm_state_iterate() encounter a failure when calling a
> particular save_live_iterate function, report the error code returned
> by the function.
>
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-26 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 14:14 [PATCH] migration: Report the error returned when save_live_iterate fails David Edmondson
2021-12-15 19:38 ` Dr. David Alan Gilbert
2022-01-26 20:24 ` Juan Quintela
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.