* [PATCH] efi: fix unmet dependency on CRYPTO for CRYPTO_LIB_SHA256
@ 2021-12-15 23:38 Julian Braha
0 siblings, 0 replies; only message in thread
From: Julian Braha @ 2021-12-15 23:38 UTC (permalink / raw)
To: ardb; +Cc: linux-efi, linux-kernel, fazilyildiran
When EFI_EMBEDDED_FIRMWARE is selected,
and CRYPTO is not selected,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256,
without selecting or depending on CRYPTO, despite
CRYPTO_LIB_SHA256 depending on CRYPTO.
This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/firmware/efi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2c3dac5ecb36..f914da9845ac 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -248,6 +248,7 @@ endmenu
config EFI_EMBEDDED_FIRMWARE
bool
depends on EFI
+ select CRYPTO
select CRYPTO_LIB_SHA256
config UEFI_CPER
--
2.32.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-15 23:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 23:38 [PATCH] efi: fix unmet dependency on CRYPTO for CRYPTO_LIB_SHA256 Julian Braha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.