All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
	broonie@kernel.org, tiwai@suse.com
Subject: [PATCH 2/5] ASoC: Intel: catpt: Reduce size of catpt_component_open()
Date: Thu, 16 Dec 2021 12:57:40 +0100	[thread overview]
Message-ID: <20211216115743.2130622-3-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20211216115743.2130622-1-cezary.rojewski@intel.com>

With some improved if-logy, function's size can be reduced slightly.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/intel/catpt/pcm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c
index ebb27daeb1c7..16146c693c08 100644
--- a/sound/soc/intel/catpt/pcm.c
+++ b/sound/soc/intel/catpt/pcm.c
@@ -595,9 +595,8 @@ static int catpt_component_open(struct snd_soc_component *component,
 {
 	struct snd_soc_pcm_runtime *rtm = substream->private_data;
 
-	if (rtm->dai_link->no_pcm)
-		return 0;
-	snd_soc_set_runtime_hwparams(substream, &catpt_pcm_hardware);
+	if (!rtm->dai_link->no_pcm)
+		snd_soc_set_runtime_hwparams(substream, &catpt_pcm_hardware);
 	return 0;
 }
 
-- 
2.25.1


  parent reply	other threads:[~2021-12-16 11:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 11:57 [PATCH 0/5] ASoC: Intel: catpt: Dma-transfer fix and couple Cezary Rojewski
2021-12-16 11:57 ` [PATCH 1/5] ASoC: Intel: catpt: Test dmaengine_submit() result before moving on Cezary Rojewski
2021-12-16 11:57 ` Cezary Rojewski [this message]
2021-12-16 11:57 ` [PATCH 3/5] ASoC: Intel: catpt: Streamline locals declaration for PCM-functions Cezary Rojewski
2021-12-16 11:57 ` [PATCH 4/5] ASoC: Intel: catpt: Drop SND_SOC_ACPI_INTEL_MATCH dependency Cezary Rojewski
2021-12-16 14:11   ` Pierre-Louis Bossart
2021-12-16 14:37     ` Cezary Rojewski
2021-12-16 15:13       ` Pierre-Louis Bossart
2021-12-16 15:59         ` Cezary Rojewski
2021-12-16 16:29           ` Pierre-Louis Bossart
2021-12-16 16:50             ` Cezary Rojewski
2021-12-16 18:04               ` Pierre-Louis Bossart
2021-12-17  9:06                 ` Cezary Rojewski
2021-12-17  2:42   ` kernel test robot
2021-12-16 11:57 ` [PATCH 5/5] ASoC: Intel: Drop legacy HSW/BDW board-match information Cezary Rojewski
2021-12-21  2:50 ` (subset) [PATCH 0/5] ASoC: Intel: catpt: Dma-transfer fix and couple Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211216115743.2130622-3-cezary.rojewski@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.