From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
<alsa-devel@alsa-project.org>
Cc: broonie@kernel.org, tiwai@suse.com
Subject: Re: [PATCH 4/5] ASoC: Intel: catpt: Drop SND_SOC_ACPI_INTEL_MATCH dependency
Date: Fri, 17 Dec 2021 10:06:19 +0100 [thread overview]
Message-ID: <d9fd60e0-a157-bda7-a918-5548918d1552@intel.com> (raw)
In-Reply-To: <687da06e-67e0-c648-7d92-88fc2ed7078f@linux.intel.com>
On 2021-12-16 7:04 PM, Pierre-Louis Bossart wrote:
...
>> Hmm.. doesn't it really? Are the glk/cnl/cfl/cml/icl/jsl/tgl/ehl/adl
>> tables "common" for the Intel audio drivers? There are not used by
>> anything except for SOF. It seems reasonable to have them present
>> locally too. SOF solution becomes more cohesively organized in such
>> case, just like catpt is after this patch.
>
> We could also move the boards/ while we're at it, on the grounds they
> are not all used by all drivers.
>
> My take is that unless a new feature is added that warrants moving the
> tables around, let's keep the existing code as is.
>
I agree with the relocation of the boards! In general, improving the
maintainability is worth it, even if it takes a larger number of patches.
Hmm.. avs-driver related boards are kind of an argument in this
discussion. I can delay patches 4/5 and 5/5 until they're on the list,
no problem.
Mark,
Should I re-send the series as 3, or is it fine as is and simply last
two patches could be omitted?
Regards,
Czarek
next prev parent reply other threads:[~2021-12-17 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 11:57 [PATCH 0/5] ASoC: Intel: catpt: Dma-transfer fix and couple Cezary Rojewski
2021-12-16 11:57 ` [PATCH 1/5] ASoC: Intel: catpt: Test dmaengine_submit() result before moving on Cezary Rojewski
2021-12-16 11:57 ` [PATCH 2/5] ASoC: Intel: catpt: Reduce size of catpt_component_open() Cezary Rojewski
2021-12-16 11:57 ` [PATCH 3/5] ASoC: Intel: catpt: Streamline locals declaration for PCM-functions Cezary Rojewski
2021-12-16 11:57 ` [PATCH 4/5] ASoC: Intel: catpt: Drop SND_SOC_ACPI_INTEL_MATCH dependency Cezary Rojewski
2021-12-16 14:11 ` Pierre-Louis Bossart
2021-12-16 14:37 ` Cezary Rojewski
2021-12-16 15:13 ` Pierre-Louis Bossart
2021-12-16 15:59 ` Cezary Rojewski
2021-12-16 16:29 ` Pierre-Louis Bossart
2021-12-16 16:50 ` Cezary Rojewski
2021-12-16 18:04 ` Pierre-Louis Bossart
2021-12-17 9:06 ` Cezary Rojewski [this message]
2021-12-17 2:42 ` kernel test robot
2021-12-16 11:57 ` [PATCH 5/5] ASoC: Intel: Drop legacy HSW/BDW board-match information Cezary Rojewski
2021-12-21 2:50 ` (subset) [PATCH 0/5] ASoC: Intel: catpt: Dma-transfer fix and couple Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9fd60e0-a157-bda7-a918-5548918d1552@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.