* [PATCH] net: vertexcom: Remove unneeded semicolon
@ 2021-12-17 8:48 cgel.zte
2021-12-17 9:42 ` Stefan Wahren
2021-12-17 16:47 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2021-12-17 8:48 UTC (permalink / raw)
To: davem
Cc: kuba, deng.changcheng, stefan.wahren, netdev, linux-kernel, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Fix the following coccicheck review:
./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/net/ethernet/vertexcom/mse102x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/vertexcom/mse102x.c b/drivers/net/ethernet/vertexcom/mse102x.c
index a3c2426e5597..89a31783fbb4 100644
--- a/drivers/net/ethernet/vertexcom/mse102x.c
+++ b/drivers/net/ethernet/vertexcom/mse102x.c
@@ -411,7 +411,7 @@ static int mse102x_tx_pkt_spi(struct mse102x_net *mse, struct sk_buff *txb,
} else {
msleep(20);
}
- };
+ }
ret = mse102x_tx_frame_spi(mse, txb, pad);
if (ret)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: vertexcom: Remove unneeded semicolon
2021-12-17 8:48 [PATCH] net: vertexcom: Remove unneeded semicolon cgel.zte
@ 2021-12-17 9:42 ` Stefan Wahren
2021-12-17 16:47 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2021-12-17 9:42 UTC (permalink / raw)
To: cgel.zte, davem; +Cc: kuba, deng.changcheng, netdev, linux-kernel, Zeal Robot
Am 17.12.21 um 09:48 schrieb cgel.zte@gmail.com:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: vertexcom: Remove unneeded semicolon
2021-12-17 8:48 [PATCH] net: vertexcom: Remove unneeded semicolon cgel.zte
2021-12-17 9:42 ` Stefan Wahren
@ 2021-12-17 16:47 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2021-12-17 16:47 UTC (permalink / raw)
To: cgel.zte
Cc: davem, deng.changcheng, stefan.wahren, netdev, linux-kernel, Zeal Robot
On Fri, 17 Dec 2021 08:48:27 +0000 cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/net/ethernet/vertexcom/mse102x.c: 414: 2-3: Unneeded semicolon
The Alibaba bot has beaten you to the punch, see commit 431b9b4d9789
("net: vertexcom: remove unneeded semicolon") in net-next.
Here we thought that "robot wars" will be like Terminator, what we got
instead is false scarcity of concert tickets and auto-generated patches
which often don't build :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-17 16:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-17 8:48 [PATCH] net: vertexcom: Remove unneeded semicolon cgel.zte
2021-12-17 9:42 ` Stefan Wahren
2021-12-17 16:47 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.