* [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema
@ 2021-12-17 17:05 Thierry Reding
2021-12-17 17:05 ` [PATCH 2/6] dt-bindings: regulator: pwm: " Thierry Reding
` (6 more replies)
0 siblings, 7 replies; 15+ messages in thread
From: Thierry Reding @ 2021-12-17 17:05 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: devicetree, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Convert the Texas Instruments Palmas bindings from the free-form text
format to json-schema.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../clock/clk-palmas-clk32kg-clocks.txt | 35 ----
.../bindings/clock/ti,palmas-clk32k.yaml | 68 ++++++++
.../bindings/extcon/extcon-palmas.txt | 22 ---
.../bindings/extcon/ti,palmas-usb-vid.yaml | 65 ++++++++
.../devicetree/bindings/gpio/gpio-palmas.txt | 27 ---
.../bindings/gpio/ti,palmas-gpio.yaml | 53 ++++++
.../bindings/iio/adc/ti,palmas-gpadc.yaml | 26 ++-
.../bindings/input/ti,palmas-pwrbutton.txt | 35 ----
.../bindings/input/ti,palmas-pwrbutton.yaml | 76 +++++++++
.../devicetree/bindings/mfd/palmas.txt | 52 ------
.../devicetree/bindings/mfd/ti,palmas.yaml | 117 +++++++++++++
.../bindings/pinctrl/pinctrl-palmas.txt | 105 ------------
.../bindings/pinctrl/ti,palmas-pinctrl.yaml | 154 ++++++++++++++++++
.../bindings/regulator/palmas-pmic.txt | 89 ----------
.../bindings/regulator/ti,palmas-pmic.yaml | 144 ++++++++++++++++
.../devicetree/bindings/rtc/rtc-palmas.txt | 32 ----
.../bindings/rtc/ti,palmas-rtc.yaml | 62 +++++++
17 files changed, 756 insertions(+), 406 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt
create mode 100644 Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml
delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-palmas.txt
create mode 100644 Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-palmas.txt
create mode 100644 Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml
delete mode 100644 Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt
create mode 100644 Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
create mode 100644 Documentation/devicetree/bindings/mfd/ti,palmas.yaml
delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
create mode 100644 Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/palmas-pmic.txt
create mode 100644 Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
diff --git a/Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt b/Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt
deleted file mode 100644
index 4208886d834a..000000000000
--- a/Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-* Palmas 32KHz clocks *
-
-Palmas device has two clock output pins for 32KHz, KG and KG_AUDIO.
-
-This binding uses the common clock binding ./clock-bindings.txt.
-
-Required properties:
-- compatible : "ti,palmas-clk32kg" for clk32kg clock
- "ti,palmas-clk32kgaudio" for clk32kgaudio clock
-- #clock-cells : shall be set to 0.
-
-Optional property:
-- ti,external-sleep-control: The external enable input pins controlled the
- enable/disable of clocks. The external enable input pins ENABLE1,
- ENABLE2 and NSLEEP. The valid values for the external pins are:
- PALMAS_EXT_CONTROL_PIN_ENABLE1 for ENABLE1 pin
- PALMAS_EXT_CONTROL_PIN_ENABLE2 for ENABLE2 pin
- PALMAS_EXT_CONTROL_PIN_NSLEEP for NSLEEP pin
- Option 0 or missing this property means the clock is enabled/disabled
- via register access and these pins do not have any control.
- The macros of external control pins for DTS is defined at
- dt-bindings/mfd/palmas.h
-
-Example:
- #include <dt-bindings/mfd/palmas.h>
- ...
- palmas: tps65913@58 {
- ...
- clk32kg: palmas_clk32k@0 {
- compatible = "ti,palmas-clk32kg";
- #clock-cells = <0>;
- ti,external-sleep-control = <PALMAS_EXT_CONTROL_PIN_NSLEEP>;
- };
- ...
- };
diff --git a/Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml b/Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml
new file mode 100644
index 000000000000..c24887e76481
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/ti,palmas-clk32k.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of Power-Management ICs (clocks)
+
+maintainers:
+ - Michael Turquette <mturquette@baylibre.com>
+ - Stephen Boyd <sboyd@kernel.org>
+
+description:
+ Palmas devices have two clock output pins for 32KHz, KG and KG_AUDIO. This binding uses the
+ common clock binding ./clock-bindings.txt.
+
+properties:
+ compatible:
+ enum:
+ - ti,palmas-clk32kg
+ - ti,palmas-clk32kgaudio
+
+ "#clock-cells":
+ const: 0
+
+ ti,external-sleep-control:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ The external enable input pins controlled the enable/disable of clocks. The external enable
+ input pins ENABLE1, ENABLE2 and NSLEEP. The valid values for the external pins are:
+
+ PALMAS_EXT_CONTROL_PIN_ENABLE1 for ENABLE1 pin
+ PALMAS_EXT_CONTROL_PIN_ENABLE2 for ENABLE2 pin
+ PALMAS_EXT_CONTROL_PIN_NSLEEP for NSLEEP pin
+
+ Option 0 or missing this property means the clock is enabled/disabled via register access
+ and these pins do not have any control. The macros of external control pins for DTS are
+ defined in dt-bindings/mfd/palmas.h.
+ enum: [ 0, 1, 2, 3 ]
+
+additionalProperties: false
+
+required:
+ - compatible
+ - "#clock-cells"
+
+examples:
+ - |
+ #include <dt-bindings/mfd/palmas.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tps65913@58 {
+ compatible = "ti,tps65913", "ti,palmas";
+ reg = <0x58>;
+
+ #interrupt-cells = <2>;
+ interrupt-controller;
+
+ clk32k {
+ compatible = "ti,palmas-clk32kg";
+ #clock-cells = <0>;
+ ti,external-sleep-control = <PALMAS_EXT_CONTROL_PIN_NSLEEP>;
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
deleted file mode 100644
index f61d5af44a27..000000000000
--- a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-EXTCON FOR PALMAS/TWL CHIPS
-
-PALMAS USB COMPARATOR
-Required Properties:
- - compatible: should contain one of:
- * "ti,palmas-usb-vid".
- * "ti,twl6035-usb-vid".
- * "ti,palmas-usb" (DEPRECATED - use "ti,palmas-usb-vid").
- * "ti,twl6035-usb" (DEPRECATED - use "ti,twl6035-usb-vid").
-
-Optional Properties:
- - ti,wakeup : To enable the wakeup comparator in probe
- - ti,enable-id-detection: Perform ID detection. If id-gpio is specified
- it performs id-detection using GPIO else using OTG core.
- - ti,enable-vbus-detection: Perform VBUS detection.
- - id-gpio: gpio for GPIO ID detection. See gpio binding.
- - debounce-delay-ms: debounce delay for GPIO ID pin in milliseconds.
-
-palmas-usb {
- compatible = "ti,twl6035-usb", "ti,palmas-usb";
- ti,wakeup;
-};
diff --git a/Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml b/Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml
new file mode 100644
index 000000000000..29cd9bd68676
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/extcon/ti,palmas-usb-vid.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of Power-Management ICs (extcon)
+
+maintainers:
+ - MyungJoo Ham <myungjoo.ham@samsung.com>
+ - Chanwoo Choi <cw00.choi@samsung.com>
+
+properties:
+ compatible:
+ oneOf:
+ - const: ti,palmas-usb-vid
+ - const: ti,twl6035-usb-vid
+ - const: ti,palmas-usb
+ deprecated: true
+ - const: ti,twl6035-usb
+ deprecated: true
+
+ ti,wakeup:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: To enable the wakeup comparator in probe
+
+ ti,enable-id-detection:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Perform ID detection. If id-gpios is specified it performs id-detection using
+ GPIO else using OTG core.
+
+ ti,enable-vbus-detection:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Perform VBUS detection.
+
+ id-gpios:
+ description: GPIO for GPIO ID detection. See GPIO bindings.
+
+ debounce-delay-ms:
+ description: debounce delay for GPIO ID pin in milliseconds
+
+additionalProperties: false
+
+required:
+ - compatible
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@38 {
+ compatible = "ti,tps65913", "ti,palmas";
+ reg = <0x38>;
+
+ #interrupt-cells = <2>;
+ interrupt-controller;
+
+ palmas_usb {
+ compatible = "ti,palmas-usb-vid";
+ ti,wakeup;
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/gpio/gpio-palmas.txt b/Documentation/devicetree/bindings/gpio/gpio-palmas.txt
deleted file mode 100644
index 08b5b52a3ae0..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-palmas.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-Palmas GPIO controller bindings
-
-Required properties:
-- compatible:
- - "ti,palams-gpio" for palma series of the GPIO controller
- - "ti,tps80036-gpio" for Palma series device TPS80036.
- - "ti,tps65913-gpio" for palma series device TPS65913.
- - "ti,tps65914-gpio" for palma series device TPS65914.
-- #gpio-cells : Should be two.
- - first cell is the gpio pin number
- - second cell is used to specify the gpio polarity:
- 0 = active high
- 1 = active low
-- gpio-controller : Marks the device node as a GPIO controller.
-
-Note: This gpio node will be sub node of palmas node.
-
-Example:
- palmas: tps65913@58 {
- :::::::::::
- palmas_gpio: palmas_gpio {
- compatible = "ti,palmas-gpio";
- gpio-controller;
- #gpio-cells = <2>;
- };
- :::::::::::
- };
diff --git a/Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml b/Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml
new file mode 100644
index 000000000000..46cd30b5541a
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/ti,palmas-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of Power-Management ICs (GPIO)
+
+maintainers:
+ - Linus Walleij <linus.walleij@linaro.org>
+
+properties:
+ compatible:
+ enum:
+ - ti,palmas-gpio
+ - ti,tps80036-gpio
+ - ti,tps65913-gpio
+ - ti,tps65914-gpio
+
+ # from gpio.yaml
+ gpio-controller: true
+ "#gpio-cells": true
+
+allOf:
+ - $ref: gpio.yaml
+
+additionalProperties: false
+
+required:
+ - compatible
+ - gpio-controller
+ - "#gpio-cells"
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@58 {
+ compatible = "ti,tps65913", "ti,palmas";
+ reg = <0x58>;
+
+ #interrupt-cells = <2>;
+ interrupt-controller;
+
+ palmas_gpio {
+ compatible = "ti,palmas-gpio";
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
index 7b895784e008..a1f4271b9aa6 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
@@ -70,16 +70,24 @@ required:
examples:
- |
#include <dt-bindings/clock/mt8183-clk.h>
- pmic {
- compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
+
+ i2c {
+ #address-cells = <1>;
+ #size-cels = <0>;
+
+ pmic@48 {
+ compatible = "ti,palmas";
+ reg = <0x48>;
+
adc {
- compatible = "ti,palmas-gpadc";
- interrupts = <18 0
- 16 0
- 17 0>;
- #io-channel-cells = <1>;
- ti,channel0-current-microamp = <5>;
- ti,channel3-current-microamp = <10>;
+ compatible = "ti,palmas-gpadc";
+ interrupts = <18 0>,
+ <16 0>,
+ <17 0>;
+ #io-channel-cells = <1>;
+ ti,channel0-current-microamp = <5>;
+ ti,channel3-current-microamp = <10>;
};
+ };
};
...
diff --git a/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt b/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt
deleted file mode 100644
index c829e18e1a05..000000000000
--- a/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-Texas Instruments Palmas family power button module
-
-This module is part of the Palmas family of PMICs. For more details
-about the whole chip see:
-Documentation/devicetree/bindings/mfd/palmas.txt.
-
-This module provides a simple power button event via an Interrupt.
-
-Required properties:
-- compatible: should be one of the following
- - "ti,palmas-pwrbutton": For Palmas compatible power on button
-- interrupts: Interrupt number of power button submodule on device.
-
-Optional Properties:
-
-- ti,palmas-long-press-seconds: Duration in seconds which the power
- button should be kept pressed for Palmas to power off automatically.
- NOTE: This depends on OTP support and POWERHOLD signal configuration
- on platform. Valid values are 6, 8, 10 and 12.
-- ti,palmas-pwron-debounce-milli-seconds: Duration in milliseconds
- which the power button should be kept pressed for Palmas to register
- a press for debouncing purposes. NOTE: This depends on specific
- Palmas variation capability. Valid values are 15, 100, 500 and 1000.
-
-Example:
-
-&palmas {
- palmas_pwr_button: pwrbutton {
- compatible = "ti,palmas-pwrbutton";
- interrupt-parent = <&tps659038>;
- interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
- ti,palmas-long-press-seconds = <12>;
- ti,palmas-pwron-debounce-milli-seconds = <15>;
- };
-};
diff --git a/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml b/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml
new file mode 100644
index 000000000000..c248ed1d0e67
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/ti,palmas-pwrbutton.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of Power-Management ICs (power button)
+
+maintainers:
+ - Nishanth Menon <nm@ti.com>
+
+description: |
+ This module is part of the Palmas family of PMICs. For more details about the whole chip see:
+
+ Documentation/devicetree/bindings/mfd/palmas.txt
+
+ This module provides a simple power button event via an interrupt.
+
+properties:
+ compatible:
+ const: ti,palmas-pwrbutton
+
+ interrupts:
+ maxItems: 1
+
+ wakeup-source:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Enables wake up of host system on power button press.
+
+ ti,palmas-long-press-seconds:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Duration in seconds which the power button should be kept pressed for Palmas to power off
+ automatically.
+
+ NOTE: This depends on OTP support and POWERHOLD signal configuration on platform.
+ enum: [ 6, 8, 10, 12 ]
+
+ ti,palmas-pwron-debounce-milli-seconds:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: |
+ Duration in milliseconds which the power button should be kept pressed for Palmas to
+ register a press for debouncing purposes. NOTE: This depends on specific Palmas variation
+ capability.
+ enum: [ 15, 100, 500, 1000 ]
+
+additionalProperties: false
+
+required:
+ - compatible
+ - interrupts
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@48 {
+ compatible = "ti,tps65913", "ti,palmas";
+ reg = <0x48>;
+
+ #interrupt-cells = <2>;
+ interrupt-controller;
+
+ pwrbutton {
+ compatible = "ti,palmas-pwrbutton";
+ interrupt-parent = <&tps659038>;
+ interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+ ti,palmas-long-press-seconds = <12>;
+ ti,palmas-pwron-debounce-milli-seconds = <15>;
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt
deleted file mode 100644
index e736ab3012a6..000000000000
--- a/Documentation/devicetree/bindings/mfd/palmas.txt
+++ /dev/null
@@ -1,52 +0,0 @@
-* palmas device tree bindings
-
-The TI palmas family current members :-
-twl6035 (palmas)
-twl6037 (palmas)
-tps65913 (palmas)
-tps65914 (palmas)
-tps659038
-tps65917
-
-Required properties:
-- compatible : Should be from the list
- ti,twl6035
- ti,twl6036
- ti,twl6037
- ti,tps65913
- ti,tps65914
- ti,tps80036
- ti,tps659038
- ti,tps65917
-and also the generic series names
- ti,palmas
-- interrupt-controller : palmas has its own internal IRQs
-- #interrupt-cells : should be set to 2 for IRQ number and flags
- The first cell is the IRQ number.
- The second cell is the flags, encoded as the trigger masks from
- Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
-
-Optional properties:
- ti,mux-padX : set the pad register X (1-2) to the correct muxing for the
- hardware, if not set will use muxing in OTP.
-
-Example:
-
-palmas {
- compatible = "ti,twl6035", "ti,palmas";
- reg = <0x48>
- interrupt-parent = <&intc>;
- interrupt-controller;
- #interrupt-cells = <2>;
-
- ti,mux-pad1 = <0>;
- ti,mux-pad2 = <0>;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- pmic {
- compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
- ....
- };
-}
diff --git a/Documentation/devicetree/bindings/mfd/ti,palmas.yaml b/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
new file mode 100644
index 000000000000..3d8c823bba13
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
@@ -0,0 +1,117 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ti,palmas.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of Power-Management ICs
+
+maintainers:
+ - Lee Jones <lee.jones@linaro.org>
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - ti,twl6035
+ - ti,twl6036
+ - ti,twl6037
+ - ti,tps65913
+ - ti,tps65914
+ - ti,tps80036
+ - ti,tps659038
+ - ti,tps65917
+ - const: ti,palmas
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-controller:
+ description: The Palmas chip has its own internal IRQs.
+
+ "#interrupt-cells":
+ description: The first cell is the IRQ number and the second cell is the flags, encoded as the
+ trigger mask from ../interrupt-controller/interrupts.txt.
+ const: 2
+
+ ti,mux-pad1:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Set the pad register 1 to the correct muxing for the hardware. Otherwise the
+ muxing will be obtained from OTP.
+
+ ti,mux-pad2:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Set the pad register 2 to the correct muxing for the hardware. Otherwise the
+ muxing will be obtained from OTP.
+
+ ti,power-ctrl:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Specifies the value to program into the POWER_CTRL register.
+
+ ti,system-power-controller:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Specifies whether or not this PMIC is controlling the system power.
+
+ pinctrl:
+ $ref: ../pinctrl/ti,palmas-pinctrl.yaml
+
+ pwrbutton:
+ $ref: ../input/ti,palmas-pwrbutton.yaml
+
+ rtc:
+ $ref: ../rtc/ti,palmas-rtc.yaml
+
+patternProperties:
+ "^(palmas_)?adc$":
+ $ref: ../iio/adc/ti,palmas-gpadc.yaml
+
+ "^(palmas_)?(clk32k|clk32kg|clk32kgaudio)$":
+ $ref: ../clock/ti,palmas-clk32k.yaml
+
+ "^(palmas_)?gpio$":
+ $ref: ../gpio/ti,palmas-gpio.yaml
+
+ "^(palmas_)?pinmux$":
+ $ref: ../pinctrl/ti,palmas-pinctrl.yaml
+
+ "^(palmas_)?pmic$":
+ $ref: ../regulator/ti,palmas-pmic.yaml
+
+ "^(palmas_)?usb$":
+ $ref: ../extcon/ti,palmas-usb-vid.yaml
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupt-controller
+ - "#interrupt-cells"
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@48 {
+ compatible = "ti,twl6035", "ti,palmas";
+ reg = <0x48>;
+ interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&intc>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ ti,mux-pad1 = <0>;
+ ti,mux-pad2 = <0>;
+
+ pmic {
+ compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
deleted file mode 100644
index c28d4eb83b76..000000000000
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
+++ /dev/null
@@ -1,105 +0,0 @@
-Palmas Pincontrol bindings
-
-The pins of Palmas device can be set on different option and provides
-the configuration for Pull UP/DOWN, open drain etc.
-
-Required properties:
-- compatible: It must be one of following:
- - "ti,palmas-pinctrl" for Palma series of the pincontrol.
- - "ti,tps65913-pinctrl" for Palma series device TPS65913.
- - "ti,tps80036-pinctrl" for Palma series device TPS80036.
-
-Please refer to pinctrl-bindings.txt in this directory for details of the
-common pinctrl bindings used by client devices, including the meaning of the
-phrase "pin configuration node".
-
-Palmas's pin configuration nodes act as a container for an arbitrary number of
-subnodes. Each of these subnodes represents some desired configuration for a
-list of pins. This configuration can include the mux function to select on
-those pin(s), and various pin configuration parameters, such as pull-up,
-open drain.
-
-The name of each subnode is not important; all subnodes should be enumerated
-and processed purely based on their content.
-
-Each subnode only affects those parameters that are explicitly listed. In
-other words, a subnode that lists a mux function but no pin configuration
-parameters implies no information about any pin configuration parameters.
-Similarly, a pin subnode that describes a pullup parameter implies no
-information about e.g. the mux function.
-
-Optional properties:
-- ti,palmas-enable-dvfs1: Enable DVFS1. Configure pins for DVFS1 mode.
- Selection primary or secondary function associated to I2C2_SCL_SCE,
- I2C2_SDA_SDO pin/pad for DVFS1 interface
-- ti,palmas-enable-dvfs2: Enable DVFS2. Configure pins for DVFS2 mode.
- Selection primary or secondary function associated to GPADC_START
- and SYSEN2 pin/pad for DVFS2 interface
-- ti,palmas-override-powerhold: This is applicable for PMICs for which
- GPIO7 is configured in POWERHOLD mode which has higher priority
- over DEV_ON bit and keeps the PMIC supplies on even after the DEV_ON
- bit is turned off. This property enables driver to over ride the
- POWERHOLD value to GPIO7 so as to turn off the PMIC in power off
- scenarios. So for GPIO7 if ti,palmas-override-powerhold is set
- then the GPIO_7 field should never be muxed to anything else.
- It should be set to POWERHOLD by default and only in case of
- power off scenarios the driver will over ride the mux value.
-
-This binding uses the following generic properties as defined in
-pinctrl-bindings.txt:
-
-Required: pins
-Options: function, bias-disable, bias-pull-up, bias-pull-down,
- drive-open-drain.
-
-Note that many of these properties are only valid for certain specific pins.
-See the Palmas device datasheet for complete details regarding which pins
-support which functionality.
-
-Valid values for pin names are:
- gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7, gpio8, gpio9,
- gpio10, gpio11, gpio12, gpio13, gpio14, gpio15, vac, powergood,
- nreswarm, pwrdown, gpadc_start, reset_in, nsleep, enable1, enable2,
- int.
-
-Valid value of function names are:
- gpio, led, pwm, regen, sysen, clk32kgaudio, id, vbus_det, chrg_det,
- vac, vacok, powergood, usb_psel, msecure, pwrhold, int, nreswarm,
- simrsto, simrsti, low_vbat, wireless_chrg1, rcm, pwrdown, gpadc_start,
- reset_in, nsleep, enable.
-
-There are 4 special functions: opt0, opt1, opt2 and opt3. If any of these
-functions is selected then directly pins register will be written with 0, 1, 2
-or 3 respectively if it is valid for that pins or list of pins.
-
-Example:
- palmas: tps65913 {
- ....
- pinctrl {
- compatible = "ti,tps65913-pinctrl";
- ti,palmas-enable-dvfs1;
- pinctrl-names = "default";
- pinctrl-0 = <&palmas_pins_state>;
-
- palmas_pins_state: pinmux {
- gpio0 {
- pins = "gpio0";
- function = "id";
- bias-pull-up;
- };
-
- vac {
- pins = "vac";
- function = "vacok";
- bias-pull-down;
- };
-
- gpio5 {
- pins = "gpio5";
- function = "opt0";
- drive-open-drain = <1>;
- };
- };
- };
- ....
- };
diff --git a/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
new file mode 100644
index 000000000000..63f3b858fd62
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
@@ -0,0 +1,154 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/ti,palmas-pinctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of Power-Management ICs (pin control)
+
+maintainers:
+ - Linus Walleij <linus.walleij@linaro.org>
+
+description: The pins of Palmas device can be set on different option and provides the
+ configuration for Pull UP/DOWN, open drain etc.
+
+properties:
+ compatible:
+ enum:
+ - ti,palmas-pinctrl
+ - ti,tps65913-pinctrl
+ - ti,tps80036-pinctrl
+
+ ti,palmas-enable-dvfs1:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Enable DVFS1. Configure pins for DVFS1 mode. Selection primary or secondary
+ function associated to I2C2_SCL_SCE, I2C2_SDA_SDO pin/pad for DVFS1 interface.
+
+ ti,palmas-enable-dvfs2:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Enable DVFS2. Configure pins for DVFS2 mode. Selection primary or secondary
+ function associated to GPADC_START and SYSEN2 pin/pad for DVFS2 interface.
+
+ ti,palmas-override-powerhold:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: This is applicable for PMICs for which GPIO7 is configured in POWERHOLD mode
+ which has higher priority over DEV_ON bit and keeps the PMIC supplies on even after the
+ DEV_ON bit is turned off. This property enables driver to over ride the POWERHOLD value to
+ GPIO7 so as to turn off the PMIC in power off scenarios. So for GPIO7 if
+ ti,palmas-override-powerhold is set then the GPIO_7 field should never be muxed to anything
+ else. It should be set to POWERHOLD by default and only in case of power off scenarios the
+ driver will over ride the mux value.
+
+required:
+ - compatible
+
+additionalProperties:
+ type: object
+ description: |
+ Please refer to pinctrl-bindings.txt in this directory for details of the common pinctrl
+ bindings used by client devices, including the meaning of the phrase "pin configuration node".
+
+ Palmas's pin configuration nodes act as a container for an arbitrary number of subnodes. Each
+ of these subnodes represents some desired configuration for a list of pins. This configuration
+ can include the mux function to select on those pin(s), and various pin configuration
+ parameters, such as pull-up, open drain.
+
+ properties:
+ phandle:
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ additionalProperties:
+ type: object
+ description: |
+ The name of each subnode is not important; all subnodes should be enumerated and processed
+ purely based on their content.
+
+ Each subnode only affects those parameters that are explicitly listed. In other words, a
+ subnode that lists a mux function but no pin configuration parameters implies no information
+ about any pin configuration parameters. Similarly, a pin subnode that describes a pullup
+ parameter implies no information about e.g. the mux function.
+
+ Note that many of these properties are only valid for certain specific pins. See the Palmas
+ device datasheet for complete details regarding which pins support which functionality.
+
+ properties:
+ pins:
+ $ref: /schemas/types.yaml#/definitions/string-array
+ items:
+ enum: [ gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7, gpio8, gpio9, gpio10,
+ gpio11, gpio12, gpio13, gpio14, gpio15, vac, powergood, nreswarm, pwrdown,
+ gpadc_start, reset_in, nsleep, enable1, enable2, int ]
+
+ function:
+ $ref: /schemas/types.yaml#/definitions/string
+ description: Note that the opt0, opt1, opt2 and opt3 functions are special and if any of
+ these functions is selected then directly pins register will be written with 0, 1, 2 or 3,
+ respectively, if the function is valid for that pin or list of pins.
+ enum: [ gpio, led, pwm, regen, sysen, clk32kgaudio, id, vbus_det, chrg_det, vac, vacok,
+ powergood, usb_psel, msecure, pwrhold, int, nreswarm, simrsto, simrsti, low_vbat,
+ wireless_chrg1, rcm, pwrdown, gpadc_start, reset_in, nsleep, enable, opt0, opt1,
+ opt2, opt3 ]
+
+ bias-disable:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: disable bias
+
+ bias-pull-up:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: pull-up bias
+
+ bias-pull-down:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: pull-down bias
+
+ drive-open-drain:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: configure for open drain
+ enum: [ 0, 1 ]
+
+ additionalProperties: false
+
+ required:
+ - pins
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@58 {
+ compatible = "ti,tps65913", "ti,palmas";
+ reg = <0x58>;
+
+ #interrupt-cells = <2>;
+ interrupt-controller;
+
+ pinctrl {
+ compatible = "ti,tps65913-pinctrl";
+ ti,palmas-enable-dvfs1;
+ pinctrl-names = "default";
+ pinctrl-0 = <&palmas_pins_state>;
+
+ palmas_pins_state: pinmux {
+ gpio0 {
+ pins = "gpio0";
+ function = "id";
+ bias-pull-up;
+ };
+
+ vac {
+ pins = "vac";
+ function = "vacok";
+ bias-pull-down;
+ };
+
+ gpio5 {
+ pins = "gpio5";
+ function = "opt0";
+ drive-open-drain = <1>;
+ };
+ };
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
deleted file mode 100644
index 84bc76a7c39e..000000000000
--- a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
+++ /dev/null
@@ -1,89 +0,0 @@
-* palmas regulator IP block devicetree bindings
-
-The tps659038 for the AM57x class have OTP spins that
-have different part numbers but the same functionality. There
-is not a need to add the OTP spins to the palmas driver. The
-spin devices should use the tps659038 as it's compatible value.
-This is the list of those devices:
-tps659037
-
-Required properties:
-- compatible : Should be from the list
- ti,twl6035-pmic
- ti,twl6036-pmic
- ti,twl6037-pmic
- ti,tps65913-pmic
- ti,tps65914-pmic
- ti,tps65917-pmic
- ti,tps659038-pmic
-and also the generic series names
- ti,palmas-pmic
-- interrupts : The interrupt number and the type which can be looked up here:
- arch/arm/boot/dts/include/dt-bindings/interrupt-controller/irq.h
-- interrupts-name: The names of the individual interrupts.
-
-Optional properties:
-- ti,ldo6-vibrator : ldo6 is in vibrator mode
-
-Optional nodes:
-- regulators : Must contain a sub-node per regulator from the list below.
- Each sub-node should contain the constraints and initialization
- information for that regulator. See regulator.txt for a
- description of standard properties for these sub-nodes.
- Additional custom properties are listed below.
-
- For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP,
- smps45, smps457, smps7 depending on variant, smps6, smps[8-9],
- smps10_out2, smps10_out1, ldo[1-9], ldoln, ldousb.
-
- Optional sub-node properties:
- ti,warm-reset - maintain voltage during warm reset(boolean)
- ti,roof-floor - This takes as optional argument on platform supporting
- the rail from desired external control. If there is no argument then
- it will be assume that it is controlled by NSLEEP pin.
- The valid value for external pins are:
- ENABLE1 then 1,
- ENABLE2 then 2 or
- NSLEEP then 3.
- ti,mode-sleep - mode to adopt in pmic sleep 0 - off, 1 - auto,
- 2 - eco, 3 - forced pwm
- ti,smps-range - OTP has the wrong range set for the hardware so override
- 0 - low range, 1 - high range.
-
-- ti,system-power-controller: Telling whether or not this pmic is controlling
- the system power.
-
-Example:
-
-#include <dt-bindings/interrupt-controller/irq.h>
-
-pmic {
- compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
- interrupt-parent = <&palmas>;
- interrupts = <14 IRQ_TYPE_NONE>;
- interrupts-name = "short-irq";
-
- ti,ldo6-vibrator;
-
- ti,system-power-controller;
-
- regulators {
- smps12_reg : smps12 {
- regulator-name = "smps12";
- regulator-min-microvolt = < 600000>;
- regulator-max-microvolt = <1500000>;
- regulator-always-on;
- regulator-boot-on;
- ti,warm-reset;
- ti,roof-floor = <1>; /* ENABLE1 control */
- ti,mode-sleep = <0>;
- ti,smps-range = <1>;
- };
-
- ldo1_reg: ldo1 {
- regulator-name = "ldo1";
- regulator-min-microvolt = <2800000>;
- regulator-max-microvolt = <2800000>;
- };
- };
-};
diff --git a/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml b/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
new file mode 100644
index 000000000000..da71e3ebcd32
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
@@ -0,0 +1,144 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,palmas-pmic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of PMICs regulator IP block
+
+maintainers:
+ - Mark Brown <broonie@kernel.org>
+
+description: |
+ The TPS659038 for the AM57x class have OTP spins that have different part numbers but the same
+ functionality. There is not a need to add the OTP spins to the Palmas driver. The spin devices
+ should use the TPS659038 as it's compatible value.
+
+ This is the list of those devices: tps659037
+
+definitions:
+ regulator:
+ type: object
+ properties:
+ ti,warm-reset:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: maintain voltage during warm reset
+
+ ti,roof-floor:
+ description: This takes as optional argument on platform supporting the rail from
+ desired external control. If there is no argument then it will be assume that it is
+ controlled by NSLEEP pin.
+ oneOf:
+ - $ref: /schemas/types.yaml#/definitions/flag
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ #oneOf:
+ # - description: ENABLE1 pin
+ # const: 1
+ # - description: ENABLE2 pin
+ # const: 2
+ # - description: NSLEEP pin
+ # const: 3
+
+ ti,mode-sleep:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Mode to adopt in PMIC sleep.
+ #oneOf:
+ # - description: off
+ # const: 0
+ # - description: auto
+ # const: 1
+ # - description: ECO
+ # const: 2
+ # - description: forced PWM
+ # const: 3
+
+ ti,smps-range:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: OTP has the wrong range set for the hardware so override
+ #oneOf:
+ # - description: low range
+ # const: 0
+ # - description: high range
+ # const: 1
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - ti,twl6035-pmic
+ - ti,twl6036-pmic
+ - ti,twl6037-pmic
+ - ti,tps65913-pmic
+ - ti,tps65914-pmic
+ - ti,tps65917-pmic
+ - ti,tps659038-pmic
+ - const: ti,palmas-pmic
+
+ interrupts:
+ maxItems: 1
+
+ ti,ldo6-vibrator:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Specifies whether LDO6 is in vibrator mode or not.
+
+ regulators:
+ type: object
+ description: |
+ Must contain a sub-node per regulator from the list below. Each sub-node should contain the
+ constraints and initialization information for that regulator. See regulator.txt for a
+ description of standard properties for these sub-nodes. Additional custom properties are
+ listed below.
+
+ patternProperties:
+ "^smps(12|123|3|34|457|6|7|8|9|10_out1|10_out2)$":
+ $ref: "#/definitions/regulator"
+
+ "^ldo[1-9]|ldoln|ldousb$":
+ $ref: "#/definitions/regulator"
+
+patternProperties:
+ "^smps(([1-9]|10)-in-)|(smps10-out2-)supply$":
+ description: Input supply for the corresponding SMPS regulator.
+
+ "^ldo([1-9]|ln|usb)-in-supply$":
+ description: Input supply for the corresponding LDO regulator.
+
+additionalProperties: false
+
+required:
+ - compatible
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ pmic {
+ compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
+ interrupt-parent = <&palmas>;
+ interrupts = <14 IRQ_TYPE_NONE>;
+ interrupts-name = "short-irq";
+
+ ti,ldo6-vibrator;
+
+ ti,system-power-controller;
+
+ regulators {
+ smps12_reg: smps12 {
+ regulator-name = "smps12";
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ ti,warm-reset;
+ ti,roof-floor = <1>; /* ENABLE1 control */
+ ti,mode-sleep = <0>;
+ ti,smps-range = <1>;
+ };
+
+ ldo1_reg: ldo1 {
+ regulator-name = "ldo1";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
deleted file mode 100644
index c6cf37758a77..000000000000
--- a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
+++ /dev/null
@@ -1,32 +0,0 @@
-Palmas RTC controller bindings
-
-Required properties:
-- compatible:
- - "ti,palmas-rtc" for palma series of the RTC controller
-- interrupts: Interrupt number of RTC submodule on device.
-
-Optional properties:
-
-- ti,backup-battery-chargeable: The Palmas series device like TPS65913 or
- TPS80036 supports the backup battery for powering the RTC when main
- battery is removed or in very low power state. The backup battery
- can be chargeable or non-chargeable. This flag will tells whether
- battery is chargeable or not. If charging battery then driver can
- enable the charging.
-- ti,backup-battery-charge-high-current: Enable high current charging in
- backup battery. Device supports the < 100uA and > 100uA charging.
- The high current will be > 100uA. Absence of this property will
- charge battery to lower current i.e. < 100uA.
-
-Example:
- palmas: tps65913@58 {
- ...
- palmas_rtc: rtc {
- compatible = "ti,palmas-rtc";
- interrupt-parent = <&palmas>;
- interrupts = <8 0>;
- ti,backup-battery-chargeable;
- ti,backup-battery-charge-high-current;
- };
- ...
- };
diff --git a/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml b/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
new file mode 100644
index 000000000000..f236385d5d66
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/ti,palmas-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Palmas family of Power-Management ICs (RTC)
+
+maintainers:
+ - Alexandre Belloni <alexandre.belloni@bootlin.com>
+
+properties:
+ compatible:
+ const: ti,palmas-rtc
+
+ interrupts:
+ maxItems: 1
+
+ ti,backup-battery-chargeable:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: The Palmas series device like TPS65913 or TPS80036 supports the backup battery
+ for powering the RTC when main battery is removed or in very low power state. The backup
+ battery can be chargeable or non-chargeable. This flag will tells whether battery is
+ chargeable or not. If charging battery then driver can enable the charging.
+
+ ti,backup-battery-charge-high-current:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Enable high current charging in backup battery. Device supports the < 100uA and >
+ 100uA charging. The high current will be > 100uA. Absence of this property will charge
+ battery to lower current i.e. < 100uA.
+
+allOf:
+ - $ref: rtc.yaml
+
+additionalProperties: false
+
+required:
+ - compatible
+ - interrupts
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tps65913@58 {
+ compatible = "ti,tps65913", "ti,palmas";
+ reg = <0x58>;
+
+ #interrupt-cells = <2>;
+ interrupt-controller;
+
+ rtc {
+ compatible = "ti,palmas-rtc";
+ interrupt-parent = <&palmas>;
+ interrupts = <8 0>;
+ ti,backup-battery-chargeable;
+ ti,backup-battery-charge-high-current;
+ };
+ };
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/6] dt-bindings: regulator: pwm: Convert to json-schema
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
@ 2021-12-17 17:05 ` Thierry Reding
2021-12-18 18:08 ` Rob Herring
2021-12-21 18:49 ` Rob Herring
2021-12-17 17:05 ` [PATCH 3/6] dt-bindings: regulator: tps51632: " Thierry Reding
` (5 subsequent siblings)
6 siblings, 2 replies; 15+ messages in thread
From: Thierry Reding @ 2021-12-17 17:05 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: devicetree, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Convert the generic PWM regulator bindings from the free-form text
format to json-schema.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../bindings/regulator/pwm-regulator.txt | 92 -------------
.../bindings/regulator/pwm-regulator.yaml | 121 ++++++++++++++++++
2 files changed, 121 insertions(+), 92 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/regulator/pwm-regulator.txt
create mode 100644 Documentation/devicetree/bindings/regulator/pwm-regulator.yaml
diff --git a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
deleted file mode 100644
index 3d78d507e29f..000000000000
--- a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
+++ /dev/null
@@ -1,92 +0,0 @@
-Bindings for the Generic PWM Regulator
-======================================
-
-Currently supports 2 modes of operation:
-
-Voltage Table: When in this mode, a voltage table (See below) of
- predefined voltage <=> duty-cycle values must be
- provided via DT. Limitations are that the regulator can
- only operate at the voltages supplied in the table.
- Intermediary duty-cycle values which would normally
- allow finer grained voltage selection are ignored and
- rendered useless. Although more control is given to
- the user if the assumptions made in continuous-voltage
- mode do not reign true.
-
-Continuous Voltage: This mode uses the regulator's maximum and minimum
- supplied voltages specified in the
- regulator-{min,max}-microvolt properties to calculate
- appropriate duty-cycle values. This allows for a much
- more fine grained solution when compared with
- voltage-table mode above. This solution does make an
- assumption that a %50 duty-cycle value will cause the
- regulator voltage to run at half way between the
- supplied max_uV and min_uV values.
-
-Required properties:
---------------------
-- compatible: Should be "pwm-regulator"
-
-- pwms: PWM specification (See: ../pwm/pwm.txt)
-
-Only required for Voltage Table Mode:
-- voltage-table: Voltage and Duty-Cycle table consisting of 2 cells
- First cell is voltage in microvolts (uV)
- Second cell is duty-cycle in percent (%)
-
-Optional properties for Continuous mode:
-- pwm-dutycycle-unit: Integer value encoding the duty cycle unit. If not
- defined, <100> is assumed, meaning that
- pwm-dutycycle-range contains values expressed in
- percent.
-
-- pwm-dutycycle-range: Should contain 2 entries. The first entry is encoding
- the dutycycle for regulator-min-microvolt and the
- second one the dutycycle for regulator-max-microvolt.
- Duty cycle values are expressed in pwm-dutycycle-unit.
- If not defined, <0 100> is assumed.
-
-NB: To be clear, if voltage-table is provided, then the device will be used
-in Voltage Table Mode. If no voltage-table is provided, then the device will
-be used in Continuous Voltage Mode.
-
-Optional properties:
---------------------
-- enable-gpios: GPIO to use to enable/disable the regulator
-
-Any property defined as part of the core regulator binding can also be used.
-(See: ../regulator/regulator.txt)
-
-Continuous Voltage With Enable GPIO Example:
- pwm_regulator {
- compatible = "pwm-regulator";
- pwms = <&pwm1 0 8448 0>;
- enable-gpios = <&gpio0 23 GPIO_ACTIVE_HIGH>;
- regulator-min-microvolt = <1016000>;
- regulator-max-microvolt = <1114000>;
- regulator-name = "vdd_logic";
- /* unit == per-mille */
- pwm-dutycycle-unit = <1000>;
- /*
- * Inverted PWM logic, and the duty cycle range is limited
- * to 30%-70%.
- */
- pwm-dutycycle-range = <700 300>; /* */
- };
-
-Voltage Table Example:
- pwm_regulator {
- compatible = "pwm-regulator";
- pwms = <&pwm1 0 8448 0>;
- regulator-min-microvolt = <1016000>;
- regulator-max-microvolt = <1114000>;
- regulator-name = "vdd_logic";
-
- /* Voltage Duty-Cycle */
- voltage-table = <1114000 0>,
- <1095000 10>,
- <1076000 20>,
- <1056000 30>,
- <1036000 40>,
- <1016000 50>;
- };
diff --git a/Documentation/devicetree/bindings/regulator/pwm-regulator.yaml b/Documentation/devicetree/bindings/regulator/pwm-regulator.yaml
new file mode 100644
index 000000000000..d87e8110989d
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/pwm-regulator.yaml
@@ -0,0 +1,121 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/pwm-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Generic PWM Regulator
+
+maintainers:
+ - Rob Herring <robh+dt@kernel.org>
+ - Mark Brown <broonie@kernel.org>
+
+description: |
+ Currently supports 2 modes of operation:
+
+ - Voltage Table: When in this mode, a voltage table (See below) of predefined voltage <=>
+ duty-cycle values must be provided via DT. Limitations are that the regulator can only
+ operate at the voltages supplied in the table. Intermediary duty-cycle values which would
+ normally allow finer grained voltage selection are ignored and rendered useless. Although
+ more control is given to the user if the assumptions made in continuous-voltage mode do not
+ reign true.
+
+ - Continuous Voltage: This mode uses the regulator's maximum and minimum supplied voltages
+ specified in the regulator-{min,max}-microvolt properties to calculate appropriate duty-cycle
+ values. This allows for a much more fine grained solution when compared with voltage-table
+ mode above. This solution does make an assumption that a %50 duty-cycle value will cause the
+ regulator voltage to run at half way between the supplied max_uV and min_uV values.
+
+ NB: To be clear, if voltage-table is provided, then the device will be used
+ in Voltage Table Mode. If no voltage-table is provided, then the device will
+ be used in Continuous Voltage Mode.
+
+ Any property defined as part of the core regulator binding can also be used. (See:
+ ../regulator/regulator.txt)
+
+properties:
+ compatible:
+ const: pwm-regulator
+
+ pwms:
+ $ref: "/schemas/types.yaml#/definitions/phandle-array"
+ description: phandle and PWM specifier (see ../pwm/pwm.txt)
+
+ # Only required for Voltage Table Mode:
+ voltage-table:
+ description: Voltage and Duty-Cycle table consisting of 2 cells. The first cell is the voltage
+ in microvolts (uV) and the second cell is duty-cycle in percent (%).
+ $ref: "/schemas/types.yaml#/definitions/uint32-matrix"
+
+ # Optional properties for Continuous mode:
+ pwm-dutycycle-unit:
+ description: Integer value encoding the duty cycle unit. If not defined, <100> is assumed,
+ meaning that pwm-dutycycle-range contains values expressed in percent.
+ $ref: "/schemas/types.yaml#/definitions/uint32"
+
+ pwm-dutycycle-range:
+ description: Should contain 2 entries. The first entry is encoding the dutycycle for
+ regulator-min-microvolt and the second one the dutycycle for regulator-max-microvolt. Duty
+ cycle values are expressed in pwm-dutycycle-unit. If not defined, <0 100> is assumed.
+ $ref: "/schemas/types.yaml#/definitions/uint32-array"
+
+ # Optional properties:
+ enable-gpios:
+ description: GPIO to use to enable/disable the regulator
+
+ # from regulator.yaml
+ regulator-enable-ramp-delay: true
+ regulator-max-microvolt: true
+ regulator-min-microvolt: true
+ regulator-name: true
+ regulator-ramp-delay: true
+ regulator-settling-time-us: true
+ vin-supply: true
+
+allOf:
+ - $ref: "regulator.yaml"
+
+additionalProperties: false
+
+required:
+ - compatible
+ - pwms
+
+examples:
+ # Continuous Voltage With Enable GPIO:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ pwm_regulator {
+ compatible = "pwm-regulator";
+ pwms = <&pwm1 0 8448 0>;
+ enable-gpios = <&gpio0 23 GPIO_ACTIVE_HIGH>;
+ regulator-min-microvolt = <1016000>;
+ regulator-max-microvolt = <1114000>;
+ regulator-name = "vdd_logic";
+ /* unit == per-mille */
+ pwm-dutycycle-unit = <1000>;
+ /*
+ * Inverted PWM logic, and the duty cycle range is limited
+ * to 30%-70%.
+ */
+ pwm-dutycycle-range = <700 300>; /* */
+ };
+
+ # Voltage Table:
+ - |
+ regulator {
+ compatible = "pwm-regulator";
+ pwms = <&pwm1 0 8448 0>;
+ regulator-min-microvolt = <1016000>;
+ regulator-max-microvolt = <1114000>;
+ regulator-name = "vdd_logic";
+
+ /* Voltage Duty-Cycle */
+ voltage-table = <1114000 0>,
+ <1095000 10>,
+ <1076000 20>,
+ <1056000 30>,
+ <1036000 40>,
+ <1016000 50>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 2/6] dt-bindings: regulator: pwm: Convert to json-schema
2021-12-17 17:05 ` [PATCH 2/6] dt-bindings: regulator: pwm: " Thierry Reding
@ 2021-12-18 18:08 ` Rob Herring
2021-12-21 18:49 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-18 18:08 UTC (permalink / raw)
To: Thierry Reding; +Cc: Lee Jones, devicetree, linux-kernel, Rob Herring
On Fri, 17 Dec 2021 18:05:03 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the generic PWM regulator bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/regulator/pwm-regulator.txt | 92 -------------
> .../bindings/regulator/pwm-regulator.yaml | 121 ++++++++++++++++++
> 2 files changed, 121 insertions(+), 92 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/regulator/pwm-regulator.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/pwm-regulator.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1570214
ppvar-bigcpu-pwm: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-dumo.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-inx.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-kd.dt.yaml
ppvar-centerlogic-pwm: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dt.yaml
ppvar-gpu-pwm: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-dumo.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-inx.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-kd.dt.yaml
ppvar-litcpu-pwm: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-dumo.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-inx.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet-kd.dt.yaml
pwm-regulator: 'max-duty-cycle', 'regulator-always-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/stih407-b2120.dt.yaml
arch/arm/boot/dts/stih410-b2120.dt.yaml
arch/arm/boot/dts/stih410-b2260.dt.yaml
arch/arm/boot/dts/stih418-b2199.dt.yaml
arch/arm/boot/dts/stih418-b2264.dt.yaml
regulator-vcck: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
regulator-vddcpu-a: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-s922x-khadas-vim3.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dt.yaml
regulator-vddcpu-b: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-s922x-khadas-vim3.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dt.yaml
regulator-vddcpu: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12a-u200.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dt.yaml
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dt.yaml
arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dt.yaml
arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dt.yaml
arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dt.yaml
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dt.yaml
regulator-vddcpu: 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dt.yaml
regulator-vddee: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
vdd-arm: 'regulator-always-on', 'regulator-boot-on', 'regulator-settling-time-up-us' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dt.yaml
vdd-arm-regulator: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/rk3229-evb.dt.yaml
arch/arm/boot/dts/rk3229-xms6.dt.yaml
vdd-center: 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-evb.dt.yaml
vdd-core: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on', 'regulator-init-microvolt', 'regulator-settling-time-up-us' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dt.yaml
vdd-core: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on', 'regulator-settling-time-up-us' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3308-evb.dt.yaml
vdd-logic: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/rk3288-veyron-brain.dt.yaml
arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml
arch/arm/boot/dts/rk3288-veyron-jaq.dt.yaml
arch/arm/boot/dts/rk3288-veyron-jerry.dt.yaml
arch/arm/boot/dts/rk3288-veyron-mickey.dt.yaml
arch/arm/boot/dts/rk3288-veyron-mighty.dt.yaml
arch/arm/boot/dts/rk3288-veyron-minnie.dt.yaml
arch/arm/boot/dts/rk3288-veyron-pinky.dt.yaml
arch/arm/boot/dts/rk3288-veyron-speedy.dt.yaml
arch/arm/boot/dts/rk3288-veyron-tiger.dt.yaml
vdd-log: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dt.yaml
vdd-log: 'regulator-always-on' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/rk3066a-bqcurie2.dt.yaml
arch/arm/boot/dts/rk3066a-marsboard.dt.yaml
arch/arm/boot/dts/rk3066a-rayeager.dt.yaml
vdd-log: 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-firefly.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-khadas-edge-captain.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-khadas-edge-v.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-orangepi.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a-plus.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-rockpro64-v2.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dt.yaml
arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dt.yaml
vdd-log: 'regulator-always-on', 'regulator-boot-on', 'regulator-settling-time-up-us' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dt.yaml
vdd-log: 'regulator-always-on', 'regulator-boot-on', 'regulator-state-mem' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dt.yaml
vdd-log-regulator: 'pwm-supply', 'regulator-always-on', 'regulator-boot-on' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/rk3229-evb.dt.yaml
arch/arm/boot/dts/rk3229-xms6.dt.yaml
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/6] dt-bindings: regulator: pwm: Convert to json-schema
2021-12-17 17:05 ` [PATCH 2/6] dt-bindings: regulator: pwm: " Thierry Reding
2021-12-18 18:08 ` Rob Herring
@ 2021-12-21 18:49 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-21 18:49 UTC (permalink / raw)
To: Thierry Reding; +Cc: Lee Jones, devicetree, linux-kernel
On Fri, Dec 17, 2021 at 06:05:03PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the generic PWM regulator bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/regulator/pwm-regulator.txt | 92 -------------
> .../bindings/regulator/pwm-regulator.yaml | 121 ++++++++++++++++++
> 2 files changed, 121 insertions(+), 92 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/regulator/pwm-regulator.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/pwm-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/pwm-regulator.yaml b/Documentation/devicetree/bindings/regulator/pwm-regulator.yaml
> new file mode 100644
> index 000000000000..d87e8110989d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/pwm-regulator.yaml
> @@ -0,0 +1,121 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/pwm-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic PWM Regulator
> +
> +maintainers:
> + - Rob Herring <robh+dt@kernel.org>
> + - Mark Brown <broonie@kernel.org>
> +
> +description: |
> + Currently supports 2 modes of operation:
> +
> + - Voltage Table: When in this mode, a voltage table (See below) of predefined voltage <=>
> + duty-cycle values must be provided via DT. Limitations are that the regulator can only
> + operate at the voltages supplied in the table. Intermediary duty-cycle values which would
> + normally allow finer grained voltage selection are ignored and rendered useless. Although
> + more control is given to the user if the assumptions made in continuous-voltage mode do not
> + reign true.
> +
> + - Continuous Voltage: This mode uses the regulator's maximum and minimum supplied voltages
> + specified in the regulator-{min,max}-microvolt properties to calculate appropriate duty-cycle
> + values. This allows for a much more fine grained solution when compared with voltage-table
> + mode above. This solution does make an assumption that a %50 duty-cycle value will cause the
> + regulator voltage to run at half way between the supplied max_uV and min_uV values.
> +
> + NB: To be clear, if voltage-table is provided, then the device will be used
> + in Voltage Table Mode. If no voltage-table is provided, then the device will
> + be used in Continuous Voltage Mode.
> +
> + Any property defined as part of the core regulator binding can also be used. (See:
> + ../regulator/regulator.txt)
> +
> +properties:
> + compatible:
> + const: pwm-regulator
> +
> + pwms:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
Already has a type. Just need 'maxItems: 1'
> + description: phandle and PWM specifier (see ../pwm/pwm.txt)
> +
> + # Only required for Voltage Table Mode:
> + voltage-table:
> + description: Voltage and Duty-Cycle table consisting of 2 cells. The first cell is the voltage
> + in microvolts (uV) and the second cell is duty-cycle in percent (%).
> + $ref: "/schemas/types.yaml#/definitions/uint32-matrix"
items:
maxItems: 2
minItems: 2
> +
> + # Optional properties for Continuous mode:
> + pwm-dutycycle-unit:
> + description: Integer value encoding the duty cycle unit. If not defined, <100> is assumed,
> + meaning that pwm-dutycycle-range contains values expressed in percent.
> + $ref: "/schemas/types.yaml#/definitions/uint32"
> +
> + pwm-dutycycle-range:
> + description: Should contain 2 entries. The first entry is encoding the dutycycle for
> + regulator-min-microvolt and the second one the dutycycle for regulator-max-microvolt. Duty
> + cycle values are expressed in pwm-dutycycle-unit. If not defined, <0 100> is assumed.
> + $ref: "/schemas/types.yaml#/definitions/uint32-array"
maxItems: 2
> +
> + # Optional properties:
> + enable-gpios:
> + description: GPIO to use to enable/disable the regulator
maxItems: 1
> +
> + # from regulator.yaml
> + regulator-enable-ramp-delay: true
> + regulator-max-microvolt: true
> + regulator-min-microvolt: true
> + regulator-name: true
> + regulator-ramp-delay: true
> + regulator-settling-time-us: true
Given the other properties still missing, probably better to drop all
these and use unevaluatedProperties.
> + vin-supply: true
> +
> +allOf:
> + - $ref: "regulator.yaml"
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - pwms
> +
> +examples:
> + # Continuous Voltage With Enable GPIO:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + pwm_regulator {
> + compatible = "pwm-regulator";
> + pwms = <&pwm1 0 8448 0>;
> + enable-gpios = <&gpio0 23 GPIO_ACTIVE_HIGH>;
> + regulator-min-microvolt = <1016000>;
> + regulator-max-microvolt = <1114000>;
> + regulator-name = "vdd_logic";
> + /* unit == per-mille */
> + pwm-dutycycle-unit = <1000>;
> + /*
> + * Inverted PWM logic, and the duty cycle range is limited
> + * to 30%-70%.
> + */
> + pwm-dutycycle-range = <700 300>; /* */
> + };
> +
> + # Voltage Table:
> + - |
> + regulator {
> + compatible = "pwm-regulator";
> + pwms = <&pwm1 0 8448 0>;
> + regulator-min-microvolt = <1016000>;
> + regulator-max-microvolt = <1114000>;
> + regulator-name = "vdd_logic";
> +
> + /* Voltage Duty-Cycle */
> + voltage-table = <1114000 0>,
> + <1095000 10>,
> + <1076000 20>,
> + <1056000 30>,
> + <1036000 40>,
> + <1016000 50>;
> + };
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/6] dt-bindings: regulator: tps51632: Convert to json-schema
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
2021-12-17 17:05 ` [PATCH 2/6] dt-bindings: regulator: pwm: " Thierry Reding
@ 2021-12-17 17:05 ` Thierry Reding
2021-12-21 18:51 ` Rob Herring
2021-12-17 17:05 ` [PATCH 4/6] dt-bindings: regulator: tps62360: " Thierry Reding
` (4 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Thierry Reding @ 2021-12-17 17:05 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: devicetree, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Convert the Texas Instruments TPS51632 bindings from the free-form text
format to json-schema.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../bindings/regulator/ti,tps51632.yaml | 53 +++++++++++++++++++
.../bindings/regulator/tps51632-regulator.txt | 27 ----------
2 files changed, 53 insertions(+), 27 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps51632.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/tps51632-regulator.txt
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps51632.yaml b/Documentation/devicetree/bindings/regulator/ti,tps51632.yaml
new file mode 100644
index 000000000000..ebe4d36dc750
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps51632.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps51632.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments TPS51632 voltage regulator
+
+maintainers:
+ - Mark Brown <broonie@kernel.org>
+
+properties:
+ compatible:
+ const: ti,tps51632
+
+ reg:
+ maxItems: 1
+
+ ti,enable-pwm-dvfs:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Enable the DVFS voltage control through the PWM interface.
+
+ ti,dvfs-step-20mV:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: The 20 mV step voltage when PWM DVFS enabled. Missing this will set 10 mV step
+ voltage in PWM DVFS mode. In normal mode, the voltage step is 10 mV as per datasheet.
+
+allOf:
+ - $ref: regulator.yaml
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ regulator@43 {
+ compatible = "ti,tps51632";
+ reg = <0x43>;
+ regulator-name = "tps51632-vout";
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ ti,enable-pwm-dvfs;
+ ti,dvfs-step-20mV;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/regulator/tps51632-regulator.txt b/Documentation/devicetree/bindings/regulator/tps51632-regulator.txt
deleted file mode 100644
index 2f7e44a96414..000000000000
--- a/Documentation/devicetree/bindings/regulator/tps51632-regulator.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-TPS51632 Voltage regulators
-
-Required properties:
-- compatible: Must be "ti,tps51632"
-- reg: I2C slave address
-
-Optional properties:
-- ti,enable-pwm-dvfs: Enable the DVFS voltage control through the PWM interface.
-- ti,dvfs-step-20mV: The 20mV step voltage when PWM DVFS enabled. Missing this
- will set 10mV step voltage in PWM DVFS mode. In normal mode, the voltage
- step is 10mV as per datasheet.
-
-Any property defined as part of the core regulator binding, defined in
-regulator.txt, can also be used.
-
-Example:
-
- tps51632 {
- compatible = "ti,tps51632";
- reg = <0x43>;
- regulator-name = "tps51632-vout";
- regulator-min-microvolt = <500000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on;
- ti,enable-pwm-dvfs;
- ti,dvfs-step-20mV;
- };
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 3/6] dt-bindings: regulator: tps51632: Convert to json-schema
2021-12-17 17:05 ` [PATCH 3/6] dt-bindings: regulator: tps51632: " Thierry Reding
@ 2021-12-21 18:51 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-21 18:51 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-kernel, devicetree, Lee Jones, Rob Herring
On Fri, 17 Dec 2021 18:05:04 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Texas Instruments TPS51632 bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/regulator/ti,tps51632.yaml | 53 +++++++++++++++++++
> .../bindings/regulator/tps51632-regulator.txt | 27 ----------
> 2 files changed, 53 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps51632.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/tps51632-regulator.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 4/6] dt-bindings: regulator: tps62360: Convert to json-schema
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
2021-12-17 17:05 ` [PATCH 2/6] dt-bindings: regulator: pwm: " Thierry Reding
2021-12-17 17:05 ` [PATCH 3/6] dt-bindings: regulator: tps51632: " Thierry Reding
@ 2021-12-17 17:05 ` Thierry Reding
2021-12-21 18:52 ` Rob Herring
2021-12-17 17:05 ` [PATCH 5/6] dt-bindings: regulator: tps6586x: " Thierry Reding
` (3 subsequent siblings)
6 siblings, 1 reply; 15+ messages in thread
From: Thierry Reding @ 2021-12-17 17:05 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: devicetree, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Convert the Texas Instruments TPS62360 bindings from the free-form text
format to json-schema.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../bindings/regulator/ti,tps62360.yaml | 80 +++++++++++++++++++
.../bindings/regulator/tps62360-regulator.txt | 44 ----------
2 files changed, 80 insertions(+), 44 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
new file mode 100644
index 000000000000..82558118284d
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps62360.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments TPS62360 voltage regulator
+
+maintainers:
+ - Mark Brown <broonie@kernel.org>
+
+properties:
+ compatible:
+ enum:
+ - ti,tps62360
+ - ti,tps62361
+ - ti,tps62362
+ - ti,tps62363
+
+ reg:
+ maxItems: 1
+
+ ti,enable-vout-discharge:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Enable output discharge.
+
+ ti,enable-pull-down:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Enable pull down.
+
+ ti,vsel0-gpio:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: GPIO for controlling VSEL0 line. If this property is missing, then assume that
+ there is no GPIO for VSEL0 control.
+
+ ti,vsel1-gpio:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: GPIO for controlling VSEL1 line. If this property is missing, then assume that
+ there is no GPIO for VSEL1 control.
+
+ ti,vsel0-state-high:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Initial state of VSEL0 input is high. If this property is missing, then assume
+ the state as low (0).
+
+ ti,vsel1-state-high:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: Initial state of VSEL1 input is high. If this property is missing, then assume
+ the state as low (0).
+
+allOf:
+ - $ref: regulator.yaml
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ regulator@60 {
+ compatible = "ti,tps62361";
+ reg = <0x60>;
+ regulator-name = "tps62361-vout";
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ ti,vsel0-gpio = <&gpio1 16 0>;
+ ti,vsel1-gpio = <&gpio1 17 0>;
+ ti,vsel0-state-high;
+ ti,vsel1-state-high;
+ ti,enable-pull-down;
+ ti,enable-vout-discharge;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt b/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
deleted file mode 100644
index 1b20c3dbcdb8..000000000000
--- a/Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
+++ /dev/null
@@ -1,44 +0,0 @@
-TPS62360 Voltage regulators
-
-Required properties:
-- compatible: Must be one of the following.
- "ti,tps62360"
- "ti,tps62361",
- "ti,tps62362",
- "ti,tps62363",
-- reg: I2C slave address
-
-Optional properties:
-- ti,enable-vout-discharge: Enable output discharge. This is boolean value.
-- ti,enable-pull-down: Enable pull down. This is boolean value.
-- ti,vsel0-gpio: GPIO for controlling VSEL0 line.
- If this property is missing, then assume that there is no GPIO
- for vsel0 control.
-- ti,vsel1-gpio: Gpio for controlling VSEL1 line.
- If this property is missing, then assume that there is no GPIO
- for vsel1 control.
-- ti,vsel0-state-high: Initial state of vsel0 input is high.
- If this property is missing, then assume the state as low (0).
-- ti,vsel1-state-high: Initial state of vsel1 input is high.
- If this property is missing, then assume the state as low (0).
-
-Any property defined as part of the core regulator binding, defined in
-regulator.txt, can also be used.
-
-Example:
-
- abc: tps62360 {
- compatible = "ti,tps62361";
- reg = <0x60>;
- regulator-name = "tps62361-vout";
- regulator-min-microvolt = <500000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on
- ti,vsel0-gpio = <&gpio1 16 0>;
- ti,vsel1-gpio = <&gpio1 17 0>;
- ti,vsel0-state-high;
- ti,vsel1-state-high;
- ti,enable-pull-down;
- ti,enable-force-pwm;
- ti,enable-vout-discharge;
- };
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 4/6] dt-bindings: regulator: tps62360: Convert to json-schema
2021-12-17 17:05 ` [PATCH 4/6] dt-bindings: regulator: tps62360: " Thierry Reding
@ 2021-12-21 18:52 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-21 18:52 UTC (permalink / raw)
To: Thierry Reding; +Cc: Rob Herring, linux-kernel, devicetree, Lee Jones
On Fri, 17 Dec 2021 18:05:05 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Texas Instruments TPS62360 bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/regulator/ti,tps62360.yaml | 80 +++++++++++++++++++
> .../bindings/regulator/tps62360-regulator.txt | 44 ----------
> 2 files changed, 80 insertions(+), 44 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/tps62360-regulator.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 5/6] dt-bindings: regulator: tps6586x: Convert to json-schema
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
` (2 preceding siblings ...)
2021-12-17 17:05 ` [PATCH 4/6] dt-bindings: regulator: tps62360: " Thierry Reding
@ 2021-12-17 17:05 ` Thierry Reding
2021-12-18 18:08 ` Rob Herring
2021-12-21 18:59 ` Rob Herring
2021-12-17 17:05 ` [PATCH 6/6] dt-bindings: regulator: tps65090: " Thierry Reding
` (2 subsequent siblings)
6 siblings, 2 replies; 15+ messages in thread
From: Thierry Reding @ 2021-12-17 17:05 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: devicetree, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Convert the Texas Instruments TPS6586x bindings from the free-form text
format to json-schema.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../bindings/regulator/ti,tps6586x.yaml | 184 ++++++++++++++++++
.../bindings/regulator/tps6586x.txt | 135 -------------
2 files changed, 184 insertions(+), 135 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/tps6586x.txt
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
new file mode 100644
index 000000000000..c5ea7012c653
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
@@ -0,0 +1,184 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps6586x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments TPS6586x family of voltage regulator
+
+maintainers:
+ - Mark Brown <broonie@kernel.org>
+
+properties:
+ compatible:
+ const: ti,tps6586x
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ sys-supply:
+ description: input supply for SYS
+
+ vin-sm0-supply:
+ description: input supply for SM0
+
+ vin-sm1-supply:
+ description: input supply for SM1
+
+ vin-sm2-supply:
+ description: input supply for SM2
+
+ vinldo01-supply:
+ description: input supply for LDO0 and LDO1
+
+ vinldo23-supply:
+ description: input supply for LDO2 and LDO3
+
+ vinldo4-supply:
+ description: input supply for LDO4
+
+ vinldo678-supply:
+ description: input supply for LDO6, LDO7 and LDO8
+
+ vinldo9-supply:
+ description: input supply for LDO9
+
+ ti,system-power-controller:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: If this property exists, it specifies that this PMIC controls the system power.
+
+ regulators:
+ type: object
+ description: |
+ A node that houses a sub-node for each regulator within the device. Each sub-node is
+ identified using the node's name (or the deprecated regulator-compatible property if
+ present), with valid values listed below. The content of each sub-node is defined by the
+ standard binding for regulators; see regulator.yaml.
+
+ Note: LDO5 and LDO_RTC is supplied by SYS regulator internally and the operating system
+ needs to take care of establishing the proper parent child relationships.
+
+ patternProperties:
+ "^sys|sm[0-2]|ldo[0-9]|ldo_rtc$":
+ $ref: regulator.yaml
+
+allOf:
+ - $ref: /schemas/gpio/gpio.yaml
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@34 {
+ compatible = "ti,tps6586x";
+ reg = <0x34>;
+ interrupts = <0 88 0x4>;
+
+ #gpio-cells = <2>;
+ gpio-controller;
+
+ ti,system-power-controller;
+
+ sys-supply = <&dummy>;
+ vin-sm0-supply = <&dummy>;
+ vin-sm1-supply = <&dummy>;
+ vin-sm2-supply = <&dummy>;
+ vinldo01-supply = <&dummy>;
+ vinldo23-supply = <&dummy>;
+ vinldo4-supply = <&dummy>;
+ vinldo678-supply = <&dummy>;
+ vinldo9-supply = <&dummy>;
+
+ regulators {
+ sys {
+ regulator-name = "vdd_sys";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sm0 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sm1 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sm2 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <4550000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo0 {
+ regulator-name = "PCIE CLK";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo1 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ };
+
+ ldo2 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ };
+
+ ldo3 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo4 {
+ regulator-min-microvolt = <1700000>;
+ regulator-max-microvolt = <2475000>;
+ };
+
+ ldo5 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo6 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo7 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo8 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo9 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/regulator/tps6586x.txt b/Documentation/devicetree/bindings/regulator/tps6586x.txt
deleted file mode 100644
index 8b40cac24d93..000000000000
--- a/Documentation/devicetree/bindings/regulator/tps6586x.txt
+++ /dev/null
@@ -1,135 +0,0 @@
-TPS6586x family of regulators
-
-Required properties:
-- compatible: "ti,tps6586x"
-- reg: I2C slave address
-- interrupts: the interrupt outputs of the controller
-- #gpio-cells: number of cells to describe a GPIO
-- gpio-controller: mark the device as a GPIO controller
-- regulators: A node that houses a sub-node for each regulator within the
- device. Each sub-node is identified using the node's name (or the deprecated
- regulator-compatible property if present), with valid values listed below.
- The content of each sub-node is defined by the standard binding for
- regulators; see regulator.txt.
- sys, sm[0-2], ldo[0-9] and ldo_rtc
-- sys-supply: The input supply for SYS.
-- vin-sm0-supply: The input supply for the SM0.
-- vin-sm1-supply: The input supply for the SM1.
-- vin-sm2-supply: The input supply for the SM2.
-- vinldo01-supply: The input supply for the LDO1 and LDO2
-- vinldo23-supply: The input supply for the LDO2 and LDO3
-- vinldo4-supply: The input supply for the LDO4
-- vinldo678-supply: The input supply for the LDO6, LDO7 and LDO8
-- vinldo9-supply: The input supply for the LDO9
-
-Optional properties:
-- ti,system-power-controller: Telling whether or not this pmic is controlling
- the system power.
-
-Each regulator is defined using the standard binding for regulators.
-
-Note: LDO5 and LDO_RTC is supplied by SYS regulator internally and driver
- take care of making proper parent child relationship.
-
-Example:
-
- pmu: tps6586x@34 {
- compatible = "ti,tps6586x";
- reg = <0x34>;
- interrupts = <0 88 0x4>;
-
- #gpio-cells = <2>;
- gpio-controller;
-
- ti,system-power-controller;
-
- sys-supply = <&some_reg>;
- vin-sm0-supply = <&some_reg>;
- vin-sm1-supply = <&some_reg>;
- vin-sm2-supply = <&some_reg>;
- vinldo01-supply = <...>;
- vinldo23-supply = <...>;
- vinldo4-supply = <...>;
- vinldo678-supply = <...>;
- vinldo9-supply = <...>;
-
- regulators {
- sys_reg: sys {
- regulator-name = "vdd_sys";
- regulator-boot-on;
- regulator-always-on;
- };
-
- sm0_reg: sm0 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- sm1_reg: sm1 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- sm2_reg: sm2 {
- regulator-min-microvolt = <3000000>;
- regulator-max-microvolt = <4550000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- ldo0_reg: ldo0 {
- regulator-name = "PCIE CLK";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo1_reg: ldo1 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- };
-
- ldo2_reg: ldo2 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- };
-
- ldo3_reg: ldo3 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo4_reg: ldo4 {
- regulator-min-microvolt = <1700000>;
- regulator-max-microvolt = <2475000>;
- };
-
- ldo5_reg: ldo5 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo6_reg: ldo6 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo7_reg: ldo7 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo8_reg: ldo8 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo9_reg: ldo9 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
- };
- };
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 5/6] dt-bindings: regulator: tps6586x: Convert to json-schema
2021-12-17 17:05 ` [PATCH 5/6] dt-bindings: regulator: tps6586x: " Thierry Reding
@ 2021-12-18 18:08 ` Rob Herring
2021-12-21 18:59 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-18 18:08 UTC (permalink / raw)
To: Thierry Reding; +Cc: devicetree, Rob Herring, linux-kernel, Lee Jones
On Fri, 17 Dec 2021 18:05:06 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Texas Instruments TPS6586x bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/regulator/ti,tps6586x.yaml | 184 ++++++++++++++++++
> .../bindings/regulator/tps6586x.txt | 135 -------------
> 2 files changed, 184 insertions(+), 135 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/tps6586x.txt
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1570217
pmic@34: regulators:ldo2:regulator-coupled-max-spread:0: [170000, 550000] is too long
arch/arm/boot/dts/tegra20-acer-a500-picasso.dt.yaml
pmic@34: regulators:sm0:regulator-coupled-max-spread:0: [170000, 550000] is too long
arch/arm/boot/dts/tegra20-acer-a500-picasso.dt.yaml
pmic@34: regulators:sm1:regulator-coupled-max-spread:0: [550000, 550000] is too long
arch/arm/boot/dts/tegra20-acer-a500-picasso.dt.yaml
tps6586x@34: regulators:ldo2:regulator-coupled-max-spread:0: [170000, 550000] is too long
arch/arm/boot/dts/tegra20-paz00.dt.yaml
arch/arm/boot/dts/tegra20-ventana.dt.yaml
tps6586x@34: regulators:sm0:regulator-coupled-max-spread:0: [170000, 550000] is too long
arch/arm/boot/dts/tegra20-paz00.dt.yaml
arch/arm/boot/dts/tegra20-ventana.dt.yaml
tps6586x@34: regulators:sm1:regulator-coupled-max-spread:0: [550000, 550000] is too long
arch/arm/boot/dts/tegra20-paz00.dt.yaml
arch/arm/boot/dts/tegra20-ventana.dt.yaml
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5/6] dt-bindings: regulator: tps6586x: Convert to json-schema
2021-12-17 17:05 ` [PATCH 5/6] dt-bindings: regulator: tps6586x: " Thierry Reding
2021-12-18 18:08 ` Rob Herring
@ 2021-12-21 18:59 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-21 18:59 UTC (permalink / raw)
To: Thierry Reding; +Cc: Lee Jones, devicetree, linux-kernel
On Fri, Dec 17, 2021 at 06:05:06PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Texas Instruments TPS6586x bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/regulator/ti,tps6586x.yaml | 184 ++++++++++++++++++
> .../bindings/regulator/tps6586x.txt | 135 -------------
> 2 files changed, 184 insertions(+), 135 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/tps6586x.txt
>
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> new file mode 100644
> index 000000000000..c5ea7012c653
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> @@ -0,0 +1,184 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/ti,tps6586x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TPS6586x family of voltage regulator
> +
> +maintainers:
> + - Mark Brown <broonie@kernel.org>
> +
> +properties:
> + compatible:
> + const: ti,tps6586x
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + sys-supply:
> + description: input supply for SYS
> +
> + vin-sm0-supply:
> + description: input supply for SM0
> +
> + vin-sm1-supply:
> + description: input supply for SM1
> +
> + vin-sm2-supply:
> + description: input supply for SM2
> +
> + vinldo01-supply:
> + description: input supply for LDO0 and LDO1
> +
> + vinldo23-supply:
> + description: input supply for LDO2 and LDO3
> +
> + vinldo4-supply:
> + description: input supply for LDO4
> +
> + vinldo678-supply:
> + description: input supply for LDO6, LDO7 and LDO8
> +
> + vinldo9-supply:
> + description: input supply for LDO9
> +
> + ti,system-power-controller:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: If this property exists, it specifies that this PMIC controls the system power.
> +
> + regulators:
> + type: object
> + description: |
> + A node that houses a sub-node for each regulator within the device. Each sub-node is
> + identified using the node's name (or the deprecated regulator-compatible property if
> + present), with valid values listed below. The content of each sub-node is defined by the
> + standard binding for regulators; see regulator.yaml.
> +
> + Note: LDO5 and LDO_RTC is supplied by SYS regulator internally and the operating system
> + needs to take care of establishing the proper parent child relationships.
> +
> + patternProperties:
> + "^sys|sm[0-2]|ldo[0-9]|ldo_rtc$":
> + $ref: regulator.yaml
> +
> +allOf:
> + - $ref: /schemas/gpio/gpio.yaml
You need to define #gpio-cells value. Usually we don't reference
gpio.yaml because of that and it's just 'gpio-controller' in addition.
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@34 {
> + compatible = "ti,tps6586x";
> + reg = <0x34>;
> + interrupts = <0 88 0x4>;
> +
> + #gpio-cells = <2>;
> + gpio-controller;
> +
> + ti,system-power-controller;
> +
> + sys-supply = <&dummy>;
> + vin-sm0-supply = <&dummy>;
> + vin-sm1-supply = <&dummy>;
> + vin-sm2-supply = <&dummy>;
> + vinldo01-supply = <&dummy>;
> + vinldo23-supply = <&dummy>;
> + vinldo4-supply = <&dummy>;
> + vinldo678-supply = <&dummy>;
> + vinldo9-supply = <&dummy>;
> +
> + regulators {
> + sys {
> + regulator-name = "vdd_sys";
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + sm0 {
> + regulator-min-microvolt = < 725000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + sm1 {
> + regulator-min-microvolt = < 725000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + sm2 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <4550000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + ldo0 {
> + regulator-name = "PCIE CLK";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + ldo1 {
> + regulator-min-microvolt = < 725000>;
> + regulator-max-microvolt = <1500000>;
> + };
> +
> + ldo2 {
> + regulator-min-microvolt = < 725000>;
> + regulator-max-microvolt = <1500000>;
> + };
> +
> + ldo3 {
> + regulator-min-microvolt = <1250000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + ldo4 {
> + regulator-min-microvolt = <1700000>;
> + regulator-max-microvolt = <2475000>;
> + };
> +
> + ldo5 {
> + regulator-min-microvolt = <1250000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + ldo6 {
> + regulator-min-microvolt = <1250000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + ldo7 {
> + regulator-min-microvolt = <1250000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + ldo8 {
> + regulator-min-microvolt = <1250000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + ldo9 {
> + regulator-min-microvolt = <1250000>;
> + regulator-max-microvolt = <3300000>;
> + };
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/regulator/tps6586x.txt b/Documentation/devicetree/bindings/regulator/tps6586x.txt
> deleted file mode 100644
> index 8b40cac24d93..000000000000
> --- a/Documentation/devicetree/bindings/regulator/tps6586x.txt
> +++ /dev/null
> @@ -1,135 +0,0 @@
> -TPS6586x family of regulators
> -
> -Required properties:
> -- compatible: "ti,tps6586x"
> -- reg: I2C slave address
> -- interrupts: the interrupt outputs of the controller
> -- #gpio-cells: number of cells to describe a GPIO
> -- gpio-controller: mark the device as a GPIO controller
> -- regulators: A node that houses a sub-node for each regulator within the
> - device. Each sub-node is identified using the node's name (or the deprecated
> - regulator-compatible property if present), with valid values listed below.
> - The content of each sub-node is defined by the standard binding for
> - regulators; see regulator.txt.
> - sys, sm[0-2], ldo[0-9] and ldo_rtc
> -- sys-supply: The input supply for SYS.
> -- vin-sm0-supply: The input supply for the SM0.
> -- vin-sm1-supply: The input supply for the SM1.
> -- vin-sm2-supply: The input supply for the SM2.
> -- vinldo01-supply: The input supply for the LDO1 and LDO2
> -- vinldo23-supply: The input supply for the LDO2 and LDO3
> -- vinldo4-supply: The input supply for the LDO4
> -- vinldo678-supply: The input supply for the LDO6, LDO7 and LDO8
> -- vinldo9-supply: The input supply for the LDO9
> -
> -Optional properties:
> -- ti,system-power-controller: Telling whether or not this pmic is controlling
> - the system power.
> -
> -Each regulator is defined using the standard binding for regulators.
> -
> -Note: LDO5 and LDO_RTC is supplied by SYS regulator internally and driver
> - take care of making proper parent child relationship.
> -
> -Example:
> -
> - pmu: tps6586x@34 {
> - compatible = "ti,tps6586x";
> - reg = <0x34>;
> - interrupts = <0 88 0x4>;
> -
> - #gpio-cells = <2>;
> - gpio-controller;
> -
> - ti,system-power-controller;
> -
> - sys-supply = <&some_reg>;
> - vin-sm0-supply = <&some_reg>;
> - vin-sm1-supply = <&some_reg>;
> - vin-sm2-supply = <&some_reg>;
> - vinldo01-supply = <...>;
> - vinldo23-supply = <...>;
> - vinldo4-supply = <...>;
> - vinldo678-supply = <...>;
> - vinldo9-supply = <...>;
> -
> - regulators {
> - sys_reg: sys {
> - regulator-name = "vdd_sys";
> - regulator-boot-on;
> - regulator-always-on;
> - };
> -
> - sm0_reg: sm0 {
> - regulator-min-microvolt = < 725000>;
> - regulator-max-microvolt = <1500000>;
> - regulator-boot-on;
> - regulator-always-on;
> - };
> -
> - sm1_reg: sm1 {
> - regulator-min-microvolt = < 725000>;
> - regulator-max-microvolt = <1500000>;
> - regulator-boot-on;
> - regulator-always-on;
> - };
> -
> - sm2_reg: sm2 {
> - regulator-min-microvolt = <3000000>;
> - regulator-max-microvolt = <4550000>;
> - regulator-boot-on;
> - regulator-always-on;
> - };
> -
> - ldo0_reg: ldo0 {
> - regulator-name = "PCIE CLK";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - };
> -
> - ldo1_reg: ldo1 {
> - regulator-min-microvolt = < 725000>;
> - regulator-max-microvolt = <1500000>;
> - };
> -
> - ldo2_reg: ldo2 {
> - regulator-min-microvolt = < 725000>;
> - regulator-max-microvolt = <1500000>;
> - };
> -
> - ldo3_reg: ldo3 {
> - regulator-min-microvolt = <1250000>;
> - regulator-max-microvolt = <3300000>;
> - };
> -
> - ldo4_reg: ldo4 {
> - regulator-min-microvolt = <1700000>;
> - regulator-max-microvolt = <2475000>;
> - };
> -
> - ldo5_reg: ldo5 {
> - regulator-min-microvolt = <1250000>;
> - regulator-max-microvolt = <3300000>;
> - };
> -
> - ldo6_reg: ldo6 {
> - regulator-min-microvolt = <1250000>;
> - regulator-max-microvolt = <3300000>;
> - };
> -
> - ldo7_reg: ldo7 {
> - regulator-min-microvolt = <1250000>;
> - regulator-max-microvolt = <3300000>;
> - };
> -
> - ldo8_reg: ldo8 {
> - regulator-min-microvolt = <1250000>;
> - regulator-max-microvolt = <3300000>;
> - };
> -
> - ldo9_reg: ldo9 {
> - regulator-min-microvolt = <1250000>;
> - regulator-max-microvolt = <3300000>;
> - };
> - };
> - };
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 6/6] dt-bindings: regulator: tps65090: Convert to json-schema
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
` (3 preceding siblings ...)
2021-12-17 17:05 ` [PATCH 5/6] dt-bindings: regulator: tps6586x: " Thierry Reding
@ 2021-12-17 17:05 ` Thierry Reding
2021-12-21 19:00 ` Rob Herring
2021-12-18 18:08 ` [PATCH 1/6] dt-bindings: regulator: palmas: " Rob Herring
2021-12-21 14:15 ` Rob Herring
6 siblings, 1 reply; 15+ messages in thread
From: Thierry Reding @ 2021-12-17 17:05 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: devicetree, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Convert the Texas Instruments TPS65090 bindings from the free-form text
format to json-schema.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
.../bindings/regulator/ti,tps65090.yaml | 199 ++++++++++++++++++
.../bindings/regulator/tps65090.txt | 126 -----------
2 files changed, 199 insertions(+), 126 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps65090.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/tps65090.txt
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65090.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65090.yaml
new file mode 100644
index 000000000000..9743746475a8
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps65090.yaml
@@ -0,0 +1,199 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps65090.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments TPS65090 voltage regulator
+
+maintainers:
+ - Mark Brown <broonie@kernel.org>
+
+properties:
+ compatible:
+ const: ti,tps65090
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ vsys1-supply:
+ description: input supply for DCDC1
+
+ vsys2-supply:
+ description: input supply for DCDC2
+
+ vsys3-supply:
+ description: input supply for DCDC3
+
+ infet1-supply:
+ description: input supply for FET1
+
+ infet2-supply:
+ description: input supply for FET2
+
+ infet3-supply:
+ description: input supply for FET3
+
+ infet4-supply:
+ description: input supply for FET4
+
+ infet5-supply:
+ description: input supply for FET5
+
+ infet6-supply:
+ description: input supply for FET6
+
+ infet7-supply:
+ description: input supply for FET7
+
+ vsys-l1-supply:
+ description: input supply for LDO1
+
+ vsys-l2-supply:
+ description: input supply for LDO2
+
+ charger:
+ $ref: ../power/supply/tps65090-charger.yaml
+
+ regulators:
+ type: object
+ description: A node that houses a sub-node for each regulator within the device. Each sub-node
+ is identified using the node's name, with valid values listed below. The content of each
+ sub-node is defined by the standard binding for regulators; see regulator.txt.
+
+ patternProperties:
+ "^dcdc[1-3]|fet[1-7]|ldo[1-2]$":
+ $ref: regulator.yaml
+ properties:
+ ti,enable-ext-control:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: This is applicable for DCDC1, DCDC2 and DCDC3. If DCDCs are externally
+ controlled then this property should be there.
+
+ dcdc-ext-control-gpios:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: This is applicable for DCDC1, DCDC2 and DCDC3. If DCDCs are externally
+ controlled and if it is from GPIO then GPIO number should be provided. If it is
+ externally controlled and no GPIO entry then driver will just configure this rails
+ as external control and will not provide any enable/disable APIs.
+
+ ti,overcurrent-wait:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: This is applicable to FET registers, which have a poorly defined
+ "overcurrent wait" field. If this property is present it should be between 0 - 3.
+ If this property isn't present we won't touch the "overcurrent wait" field and we'll
+ leave it to the BIOS/EC to deal with.
+ enum: [ 0, 1, 2, 3 ]
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - regulators
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@48 {
+ compatible = "ti,tps65090";
+ reg = <0x48>;
+ interrupts = <0 88 0x4>;
+
+ vsys1-supply = <&some_reg>;
+ vsys2-supply = <&some_reg>;
+ vsys3-supply = <&some_reg>;
+ infet1-supply = <&some_reg>;
+ infet2-supply = <&some_reg>;
+ infet3-supply = <&some_reg>;
+ infet4-supply = <&some_reg>;
+ infet5-supply = <&some_reg>;
+ infet6-supply = <&some_reg>;
+ infet7-supply = <&some_reg>;
+ vsys-l1-supply = <&some_reg>;
+ vsys-l2-supply = <&some_reg>;
+
+ regulators {
+ dcdc1 {
+ regulator-name = "dcdc1";
+ regulator-boot-on;
+ regulator-always-on;
+ ti,enable-ext-control;
+ dcdc-ext-control-gpios = <&gpio 10 0>;
+ };
+
+ dcdc2 {
+ regulator-name = "dcdc2";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ dcdc3 {
+ regulator-name = "dcdc3";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ fet1 {
+ regulator-name = "fet1";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ fet2 {
+ regulator-name = "fet2";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ fet3 {
+ regulator-name = "fet3";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ fet4 {
+ regulator-name = "fet4";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ fet5 {
+ regulator-name = "fet5";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ fet6 {
+ regulator-name = "fet6";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ fet7 {
+ regulator-name = "fet7";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1 {
+ regulator-name = "ldo1";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo2 {
+ regulator-name = "ldo2";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/regulator/tps65090.txt b/Documentation/devicetree/bindings/regulator/tps65090.txt
deleted file mode 100644
index ae326f263597..000000000000
--- a/Documentation/devicetree/bindings/regulator/tps65090.txt
+++ /dev/null
@@ -1,126 +0,0 @@
-TPS65090 regulators
-
-Required properties:
-- compatible: "ti,tps65090"
-- reg: I2C slave address
-- interrupts: the interrupt outputs of the controller
-- regulators: A node that houses a sub-node for each regulator within the
- device. Each sub-node is identified using the node's name, with valid
- values listed below. The content of each sub-node is defined by the
- standard binding for regulators; see regulator.txt.
- dcdc[1-3], fet[1-7] and ldo[1-2] respectively.
-- vsys[1-3]-supply: The input supply for DCDC[1-3] respectively.
-- infet[1-7]-supply: The input supply for FET[1-7] respectively.
-- vsys-l[1-2]-supply: The input supply for LDO[1-2] respectively.
-
-Optional properties:
-- ti,enable-ext-control: This is applicable for DCDC1, DCDC2 and DCDC3.
- If DCDCs are externally controlled then this property should be there.
-- dcdc-ext-control-gpios: This is applicable for DCDC1, DCDC2 and DCDC3.
- If DCDCs are externally controlled and if it is from GPIO then GPIO
- number should be provided. If it is externally controlled and no GPIO
- entry then driver will just configure this rails as external control
- and will not provide any enable/disable APIs.
-- ti,overcurrent-wait: This is applicable to FET registers, which have a
- poorly defined "overcurrent wait" field. If this property is present it
- should be between 0 - 3. If this property isn't present we won't touch the
- "overcurrent wait" field and we'll leave it to the BIOS/EC to deal with.
-
-Each regulator is defined using the standard binding for regulators.
-
-Example:
-
- tps65090@48 {
- compatible = "ti,tps65090";
- reg = <0x48>;
- interrupts = <0 88 0x4>;
-
- vsys1-supply = <&some_reg>;
- vsys2-supply = <&some_reg>;
- vsys3-supply = <&some_reg>;
- infet1-supply = <&some_reg>;
- infet2-supply = <&some_reg>;
- infet3-supply = <&some_reg>;
- infet4-supply = <&some_reg>;
- infet5-supply = <&some_reg>;
- infet6-supply = <&some_reg>;
- infet7-supply = <&some_reg>;
- vsys-l1-supply = <&some_reg>;
- vsys-l2-supply = <&some_reg>;
-
- regulators {
- dcdc1 {
- regulator-name = "dcdc1";
- regulator-boot-on;
- regulator-always-on;
- ti,enable-ext-control;
- dcdc-ext-control-gpios = <&gpio 10 0>;
- };
-
- dcdc2 {
- regulator-name = "dcdc2";
- regulator-boot-on;
- regulator-always-on;
- };
-
- dcdc3 {
- regulator-name = "dcdc3";
- regulator-boot-on;
- regulator-always-on;
- };
-
- fet1 {
- regulator-name = "fet1";
- regulator-boot-on;
- regulator-always-on;
- };
-
- fet2 {
- regulator-name = "fet2";
- regulator-boot-on;
- regulator-always-on;
- };
-
- fet3 {
- regulator-name = "fet3";
- regulator-boot-on;
- regulator-always-on;
- };
-
- fet4 {
- regulator-name = "fet4";
- regulator-boot-on;
- regulator-always-on;
- };
-
- fet5 {
- regulator-name = "fet5";
- regulator-boot-on;
- regulator-always-on;
- };
-
- fet6 {
- regulator-name = "fet6";
- regulator-boot-on;
- regulator-always-on;
- };
-
- fet7 {
- regulator-name = "fet7";
- regulator-boot-on;
- regulator-always-on;
- };
-
- ldo1 {
- regulator-name = "ldo1";
- regulator-boot-on;
- regulator-always-on;
- };
-
- ldo2 {
- regulator-name = "ldo2";
- regulator-boot-on;
- regulator-always-on;
- };
- };
- };
--
2.34.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 6/6] dt-bindings: regulator: tps65090: Convert to json-schema
2021-12-17 17:05 ` [PATCH 6/6] dt-bindings: regulator: tps65090: " Thierry Reding
@ 2021-12-21 19:00 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-21 19:00 UTC (permalink / raw)
To: Thierry Reding; +Cc: devicetree, Lee Jones, linux-kernel, Rob Herring
On Fri, 17 Dec 2021 18:05:07 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Texas Instruments TPS65090 bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/regulator/ti,tps65090.yaml | 199 ++++++++++++++++++
> .../bindings/regulator/tps65090.txt | 126 -----------
> 2 files changed, 199 insertions(+), 126 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps65090.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/tps65090.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
` (4 preceding siblings ...)
2021-12-17 17:05 ` [PATCH 6/6] dt-bindings: regulator: tps65090: " Thierry Reding
@ 2021-12-18 18:08 ` Rob Herring
2021-12-21 14:15 ` Rob Herring
6 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-18 18:08 UTC (permalink / raw)
To: Thierry Reding; +Cc: Rob Herring, linux-kernel, devicetree, Lee Jones
On Fri, 17 Dec 2021 18:05:02 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Texas Instruments Palmas bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../clock/clk-palmas-clk32kg-clocks.txt | 35 ----
> .../bindings/clock/ti,palmas-clk32k.yaml | 68 ++++++++
> .../bindings/extcon/extcon-palmas.txt | 22 ---
> .../bindings/extcon/ti,palmas-usb-vid.yaml | 65 ++++++++
> .../devicetree/bindings/gpio/gpio-palmas.txt | 27 ---
> .../bindings/gpio/ti,palmas-gpio.yaml | 53 ++++++
> .../bindings/iio/adc/ti,palmas-gpadc.yaml | 26 ++-
> .../bindings/input/ti,palmas-pwrbutton.txt | 35 ----
> .../bindings/input/ti,palmas-pwrbutton.yaml | 76 +++++++++
> .../devicetree/bindings/mfd/palmas.txt | 52 ------
> .../devicetree/bindings/mfd/ti,palmas.yaml | 117 +++++++++++++
> .../bindings/pinctrl/pinctrl-palmas.txt | 105 ------------
> .../bindings/pinctrl/ti,palmas-pinctrl.yaml | 154 ++++++++++++++++++
> .../bindings/regulator/palmas-pmic.txt | 89 ----------
> .../bindings/regulator/ti,palmas-pmic.yaml | 144 ++++++++++++++++
> .../devicetree/bindings/rtc/rtc-palmas.txt | 32 ----
> .../bindings/rtc/ti,palmas-rtc.yaml | 62 +++++++
> 17 files changed, 756 insertions(+), 406 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt
> create mode 100644 Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml
> delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml
> delete mode 100644 Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt
> create mode 100644 Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,palmas.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
> delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.example.dt.yaml: pmic: 'interrupts-name', 'ti,system-power-controller' do not match any of the regexes: '^ldo([1-9]|ln|usb)-in-supply$', '^smps(([1-9]|10)-in-)|(smps10-out2-)supply$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dts:27.13-26: Warning (reg_format): /example-0/i2c/pmic@48:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dts:21.13-39.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dts:25.19-38.13: Warning (avoid_default_addr_size): /example-0/i2c/pmic@48: Relying on default #size-cells value
Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: pmic@48: compatible:0: 'ti,palmas' is not one of ['ti,twl6035', 'ti,twl6036', 'ti,twl6037', 'ti,tps65913', 'ti,tps65914', 'ti,tps80036', 'ti,tps659038', 'ti,tps65917']
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: pmic@48: compatible: ['ti,palmas'] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: pmic@48: 'interrupt-controller' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dt.yaml: pmic@48: '#interrupt-cells' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/palmas.txt
Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml: Documentation/devicetree/bindings/mfd/palmas.txt
See https://patchwork.ozlabs.org/patch/1570213
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
` (5 preceding siblings ...)
2021-12-18 18:08 ` [PATCH 1/6] dt-bindings: regulator: palmas: " Rob Herring
@ 2021-12-21 14:15 ` Rob Herring
6 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-21 14:15 UTC (permalink / raw)
To: Thierry Reding; +Cc: Lee Jones, devicetree, linux-kernel
On Fri, Dec 17, 2021 at 06:05:02PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the Texas Instruments Palmas bindings from the free-form text
> format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../clock/clk-palmas-clk32kg-clocks.txt | 35 ----
> .../bindings/clock/ti,palmas-clk32k.yaml | 68 ++++++++
> .../bindings/extcon/extcon-palmas.txt | 22 ---
> .../bindings/extcon/ti,palmas-usb-vid.yaml | 65 ++++++++
> .../devicetree/bindings/gpio/gpio-palmas.txt | 27 ---
> .../bindings/gpio/ti,palmas-gpio.yaml | 53 ++++++
> .../bindings/iio/adc/ti,palmas-gpadc.yaml | 26 ++-
> .../bindings/input/ti,palmas-pwrbutton.txt | 35 ----
> .../bindings/input/ti,palmas-pwrbutton.yaml | 76 +++++++++
> .../devicetree/bindings/mfd/palmas.txt | 52 ------
> .../devicetree/bindings/mfd/ti,palmas.yaml | 117 +++++++++++++
> .../bindings/pinctrl/pinctrl-palmas.txt | 105 ------------
> .../bindings/pinctrl/ti,palmas-pinctrl.yaml | 154 ++++++++++++++++++
> .../bindings/regulator/palmas-pmic.txt | 89 ----------
> .../bindings/regulator/ti,palmas-pmic.yaml | 144 ++++++++++++++++
> .../devicetree/bindings/rtc/rtc-palmas.txt | 32 ----
> .../bindings/rtc/ti,palmas-rtc.yaml | 62 +++++++
> 17 files changed, 756 insertions(+), 406 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt
> create mode 100644 Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml
> delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml
> delete mode 100644 Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt
> create mode 100644 Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,palmas.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
> delete mode 100644 Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
> delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt b/Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt
> deleted file mode 100644
> index 4208886d834a..000000000000
> --- a/Documentation/devicetree/bindings/clock/clk-palmas-clk32kg-clocks.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -* Palmas 32KHz clocks *
> -
> -Palmas device has two clock output pins for 32KHz, KG and KG_AUDIO.
> -
> -This binding uses the common clock binding ./clock-bindings.txt.
> -
> -Required properties:
> -- compatible : "ti,palmas-clk32kg" for clk32kg clock
> - "ti,palmas-clk32kgaudio" for clk32kgaudio clock
> -- #clock-cells : shall be set to 0.
> -
> -Optional property:
> -- ti,external-sleep-control: The external enable input pins controlled the
> - enable/disable of clocks. The external enable input pins ENABLE1,
> - ENABLE2 and NSLEEP. The valid values for the external pins are:
> - PALMAS_EXT_CONTROL_PIN_ENABLE1 for ENABLE1 pin
> - PALMAS_EXT_CONTROL_PIN_ENABLE2 for ENABLE2 pin
> - PALMAS_EXT_CONTROL_PIN_NSLEEP for NSLEEP pin
> - Option 0 or missing this property means the clock is enabled/disabled
> - via register access and these pins do not have any control.
> - The macros of external control pins for DTS is defined at
> - dt-bindings/mfd/palmas.h
> -
> -Example:
> - #include <dt-bindings/mfd/palmas.h>
> - ...
> - palmas: tps65913@58 {
> - ...
> - clk32kg: palmas_clk32k@0 {
> - compatible = "ti,palmas-clk32kg";
> - #clock-cells = <0>;
> - ti,external-sleep-control = <PALMAS_EXT_CONTROL_PIN_NSLEEP>;
> - };
> - ...
> - };
> diff --git a/Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml b/Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml
> new file mode 100644
> index 000000000000..c24887e76481
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti,palmas-clk32k.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti,palmas-clk32k.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of Power-Management ICs (clocks)
> +
> +maintainers:
> + - Michael Turquette <mturquette@baylibre.com>
> + - Stephen Boyd <sboyd@kernel.org>
> +
> +description:
> + Palmas devices have two clock output pins for 32KHz, KG and KG_AUDIO. This binding uses the
> + common clock binding ./clock-bindings.txt.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,palmas-clk32kg
> + - ti,palmas-clk32kgaudio
> +
> + "#clock-cells":
> + const: 0
> +
> + ti,external-sleep-control:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The external enable input pins controlled the enable/disable of clocks. The external enable
> + input pins ENABLE1, ENABLE2 and NSLEEP. The valid values for the external pins are:
> +
> + PALMAS_EXT_CONTROL_PIN_ENABLE1 for ENABLE1 pin
> + PALMAS_EXT_CONTROL_PIN_ENABLE2 for ENABLE2 pin
> + PALMAS_EXT_CONTROL_PIN_NSLEEP for NSLEEP pin
> +
> + Option 0 or missing this property means the clock is enabled/disabled via register access
> + and these pins do not have any control. The macros of external control pins for DTS are
> + defined in dt-bindings/mfd/palmas.h.
> + enum: [ 0, 1, 2, 3 ]
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - "#clock-cells"
> +
> +examples:
> + - |
> + #include <dt-bindings/mfd/palmas.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + tps65913@58 {
> + compatible = "ti,tps65913", "ti,palmas";
> + reg = <0x58>;
> +
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + clk32k {
> + compatible = "ti,palmas-clk32kg";
> + #clock-cells = <0>;
> + ti,external-sleep-control = <PALMAS_EXT_CONTROL_PIN_NSLEEP>;
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
> deleted file mode 100644
> index f61d5af44a27..000000000000
> --- a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -EXTCON FOR PALMAS/TWL CHIPS
> -
> -PALMAS USB COMPARATOR
> -Required Properties:
> - - compatible: should contain one of:
> - * "ti,palmas-usb-vid".
> - * "ti,twl6035-usb-vid".
> - * "ti,palmas-usb" (DEPRECATED - use "ti,palmas-usb-vid").
> - * "ti,twl6035-usb" (DEPRECATED - use "ti,twl6035-usb-vid").
> -
> -Optional Properties:
> - - ti,wakeup : To enable the wakeup comparator in probe
> - - ti,enable-id-detection: Perform ID detection. If id-gpio is specified
> - it performs id-detection using GPIO else using OTG core.
> - - ti,enable-vbus-detection: Perform VBUS detection.
> - - id-gpio: gpio for GPIO ID detection. See gpio binding.
> - - debounce-delay-ms: debounce delay for GPIO ID pin in milliseconds.
> -
> -palmas-usb {
> - compatible = "ti,twl6035-usb", "ti,palmas-usb";
> - ti,wakeup;
> -};
> diff --git a/Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml b/Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml
> new file mode 100644
> index 000000000000..29cd9bd68676
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/ti,palmas-usb-vid.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/extcon/ti,palmas-usb-vid.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of Power-Management ICs (extcon)
> +
> +maintainers:
> + - MyungJoo Ham <myungjoo.ham@samsung.com>
> + - Chanwoo Choi <cw00.choi@samsung.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: ti,palmas-usb-vid
> + - const: ti,twl6035-usb-vid
> + - const: ti,palmas-usb
> + deprecated: true
> + - const: ti,twl6035-usb
> + deprecated: true
> +
> + ti,wakeup:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: To enable the wakeup comparator in probe
> +
> + ti,enable-id-detection:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Perform ID detection. If id-gpios is specified it performs id-detection using
> + GPIO else using OTG core.
> +
> + ti,enable-vbus-detection:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Perform VBUS detection.
> +
> + id-gpios:
> + description: GPIO for GPIO ID detection. See GPIO bindings.
maxItems: 1
> +
> + debounce-delay-ms:
> + description: debounce delay for GPIO ID pin in milliseconds
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@38 {
> + compatible = "ti,tps65913", "ti,palmas";
> + reg = <0x38>;
> +
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + palmas_usb {
> + compatible = "ti,palmas-usb-vid";
> + ti,wakeup;
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-palmas.txt b/Documentation/devicetree/bindings/gpio/gpio-palmas.txt
> deleted file mode 100644
> index 08b5b52a3ae0..000000000000
> --- a/Documentation/devicetree/bindings/gpio/gpio-palmas.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -Palmas GPIO controller bindings
> -
> -Required properties:
> -- compatible:
> - - "ti,palams-gpio" for palma series of the GPIO controller
> - - "ti,tps80036-gpio" for Palma series device TPS80036.
> - - "ti,tps65913-gpio" for palma series device TPS65913.
> - - "ti,tps65914-gpio" for palma series device TPS65914.
> -- #gpio-cells : Should be two.
> - - first cell is the gpio pin number
> - - second cell is used to specify the gpio polarity:
> - 0 = active high
> - 1 = active low
> -- gpio-controller : Marks the device node as a GPIO controller.
> -
> -Note: This gpio node will be sub node of palmas node.
> -
> -Example:
> - palmas: tps65913@58 {
> - :::::::::::
> - palmas_gpio: palmas_gpio {
> - compatible = "ti,palmas-gpio";
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> - :::::::::::
> - };
> diff --git a/Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml b/Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml
> new file mode 100644
> index 000000000000..46cd30b5541a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/ti,palmas-gpio.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/ti,palmas-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of Power-Management ICs (GPIO)
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@linaro.org>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,palmas-gpio
> + - ti,tps80036-gpio
> + - ti,tps65913-gpio
> + - ti,tps65914-gpio
> +
> + # from gpio.yaml
> + gpio-controller: true
> + "#gpio-cells": true
> +
> +allOf:
> + - $ref: gpio.yaml
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - gpio-controller
> + - "#gpio-cells"
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@58 {
> + compatible = "ti,tps65913", "ti,palmas";
> + reg = <0x58>;
> +
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + palmas_gpio {
> + compatible = "ti,palmas-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> index 7b895784e008..a1f4271b9aa6 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.yaml
> @@ -70,16 +70,24 @@ required:
> examples:
> - |
> #include <dt-bindings/clock/mt8183-clk.h>
> - pmic {
> - compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cels = <0>;
> +
> + pmic@48 {
> + compatible = "ti,palmas";
> + reg = <0x48>;
> +
> adc {
> - compatible = "ti,palmas-gpadc";
> - interrupts = <18 0
> - 16 0
> - 17 0>;
> - #io-channel-cells = <1>;
> - ti,channel0-current-microamp = <5>;
> - ti,channel3-current-microamp = <10>;
> + compatible = "ti,palmas-gpadc";
> + interrupts = <18 0>,
> + <16 0>,
> + <17 0>;
> + #io-channel-cells = <1>;
> + ti,channel0-current-microamp = <5>;
> + ti,channel3-current-microamp = <10>;
> };
> + };
> };
> ...
> diff --git a/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt b/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt
> deleted file mode 100644
> index c829e18e1a05..000000000000
> --- a/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Texas Instruments Palmas family power button module
> -
> -This module is part of the Palmas family of PMICs. For more details
> -about the whole chip see:
> -Documentation/devicetree/bindings/mfd/palmas.txt.
> -
> -This module provides a simple power button event via an Interrupt.
> -
> -Required properties:
> -- compatible: should be one of the following
> - - "ti,palmas-pwrbutton": For Palmas compatible power on button
> -- interrupts: Interrupt number of power button submodule on device.
> -
> -Optional Properties:
> -
> -- ti,palmas-long-press-seconds: Duration in seconds which the power
> - button should be kept pressed for Palmas to power off automatically.
> - NOTE: This depends on OTP support and POWERHOLD signal configuration
> - on platform. Valid values are 6, 8, 10 and 12.
> -- ti,palmas-pwron-debounce-milli-seconds: Duration in milliseconds
> - which the power button should be kept pressed for Palmas to register
> - a press for debouncing purposes. NOTE: This depends on specific
> - Palmas variation capability. Valid values are 15, 100, 500 and 1000.
> -
> -Example:
> -
> -&palmas {
> - palmas_pwr_button: pwrbutton {
> - compatible = "ti,palmas-pwrbutton";
> - interrupt-parent = <&tps659038>;
> - interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> - ti,palmas-long-press-seconds = <12>;
> - ti,palmas-pwron-debounce-milli-seconds = <15>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml b/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml
> new file mode 100644
> index 000000000000..c248ed1d0e67
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/ti,palmas-pwrbutton.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/ti,palmas-pwrbutton.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of Power-Management ICs (power button)
> +
> +maintainers:
> + - Nishanth Menon <nm@ti.com>
> +
> +description: |
> + This module is part of the Palmas family of PMICs. For more details about the whole chip see:
> +
> + Documentation/devicetree/bindings/mfd/palmas.txt
> +
> + This module provides a simple power button event via an interrupt.
> +
> +properties:
> + compatible:
> + const: ti,palmas-pwrbutton
> +
> + interrupts:
> + maxItems: 1
> +
> + wakeup-source:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Enables wake up of host system on power button press.
> +
> + ti,palmas-long-press-seconds:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Duration in seconds which the power button should be kept pressed for Palmas to power off
> + automatically.
> +
> + NOTE: This depends on OTP support and POWERHOLD signal configuration on platform.
> + enum: [ 6, 8, 10, 12 ]
> +
> + ti,palmas-pwron-debounce-milli-seconds:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Duration in milliseconds which the power button should be kept pressed for Palmas to
> + register a press for debouncing purposes. NOTE: This depends on specific Palmas variation
> + capability.
> + enum: [ 15, 100, 500, 1000 ]
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - interrupts
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@48 {
> + compatible = "ti,tps65913", "ti,palmas";
> + reg = <0x48>;
> +
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + pwrbutton {
> + compatible = "ti,palmas-pwrbutton";
> + interrupt-parent = <&tps659038>;
> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> + ti,palmas-long-press-seconds = <12>;
> + ti,palmas-pwron-debounce-milli-seconds = <15>;
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt
> deleted file mode 100644
> index e736ab3012a6..000000000000
> --- a/Documentation/devicetree/bindings/mfd/palmas.txt
> +++ /dev/null
> @@ -1,52 +0,0 @@
> -* palmas device tree bindings
> -
> -The TI palmas family current members :-
> -twl6035 (palmas)
> -twl6037 (palmas)
> -tps65913 (palmas)
> -tps65914 (palmas)
> -tps659038
> -tps65917
> -
> -Required properties:
> -- compatible : Should be from the list
> - ti,twl6035
> - ti,twl6036
> - ti,twl6037
> - ti,tps65913
> - ti,tps65914
> - ti,tps80036
> - ti,tps659038
> - ti,tps65917
> -and also the generic series names
> - ti,palmas
> -- interrupt-controller : palmas has its own internal IRQs
> -- #interrupt-cells : should be set to 2 for IRQ number and flags
> - The first cell is the IRQ number.
> - The second cell is the flags, encoded as the trigger masks from
> - Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> -
> -Optional properties:
> - ti,mux-padX : set the pad register X (1-2) to the correct muxing for the
> - hardware, if not set will use muxing in OTP.
> -
> -Example:
> -
> -palmas {
> - compatible = "ti,twl6035", "ti,palmas";
> - reg = <0x48>
> - interrupt-parent = <&intc>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> -
> - ti,mux-pad1 = <0>;
> - ti,mux-pad2 = <0>;
> -
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - pmic {
> - compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
> - ....
> - };
> -}
> diff --git a/Documentation/devicetree/bindings/mfd/ti,palmas.yaml b/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
> new file mode 100644
> index 000000000000..3d8c823bba13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,palmas.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,palmas.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of Power-Management ICs
> +
> +maintainers:
> + - Lee Jones <lee.jones@linaro.org>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - ti,twl6035
> + - ti,twl6036
> + - ti,twl6037
> + - ti,tps65913
> + - ti,tps65914
> + - ti,tps80036
> + - ti,tps659038
> + - ti,tps65917
> + - const: ti,palmas
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller:
> + description: The Palmas chip has its own internal IRQs.
> +
> + "#interrupt-cells":
> + description: The first cell is the IRQ number and the second cell is the flags, encoded as the
> + trigger mask from ../interrupt-controller/interrupts.txt.
> + const: 2
> +
> + ti,mux-pad1:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Set the pad register 1 to the correct muxing for the hardware. Otherwise the
> + muxing will be obtained from OTP.
> +
> + ti,mux-pad2:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Set the pad register 2 to the correct muxing for the hardware. Otherwise the
> + muxing will be obtained from OTP.
> +
> + ti,power-ctrl:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Specifies the value to program into the POWER_CTRL register.
> +
> + ti,system-power-controller:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Specifies whether or not this PMIC is controlling the system power.
> +
> + pinctrl:
> + $ref: ../pinctrl/ti,palmas-pinctrl.yaml
Don't use relative paths. /schemas/pinctrl/...
> +
> + pwrbutton:
> + $ref: ../input/ti,palmas-pwrbutton.yaml
> +
> + rtc:
> + $ref: ../rtc/ti,palmas-rtc.yaml
> +
> +patternProperties:
> + "^(palmas_)?adc$":
> + $ref: ../iio/adc/ti,palmas-gpadc.yaml
> +
> + "^(palmas_)?(clk32k|clk32kg|clk32kgaudio)$":
> + $ref: ../clock/ti,palmas-clk32k.yaml
> +
> + "^(palmas_)?gpio$":
> + $ref: ../gpio/ti,palmas-gpio.yaml
> +
> + "^(palmas_)?pinmux$":
> + $ref: ../pinctrl/ti,palmas-pinctrl.yaml
> +
> + "^(palmas_)?pmic$":
> + $ref: ../regulator/ti,palmas-pmic.yaml
> +
> + "^(palmas_)?usb$":
> + $ref: ../extcon/ti,palmas-usb-vid.yaml
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-controller
> + - "#interrupt-cells"
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@48 {
> + compatible = "ti,twl6035", "ti,palmas";
> + reg = <0x48>;
> + interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-parent = <&intc>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + ti,mux-pad1 = <0>;
> + ti,mux-pad2 = <0>;
> +
> + pmic {
> + compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
> deleted file mode 100644
> index c28d4eb83b76..000000000000
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-palmas.txt
> +++ /dev/null
> @@ -1,105 +0,0 @@
> -Palmas Pincontrol bindings
> -
> -The pins of Palmas device can be set on different option and provides
> -the configuration for Pull UP/DOWN, open drain etc.
> -
> -Required properties:
> -- compatible: It must be one of following:
> - - "ti,palmas-pinctrl" for Palma series of the pincontrol.
> - - "ti,tps65913-pinctrl" for Palma series device TPS65913.
> - - "ti,tps80036-pinctrl" for Palma series device TPS80036.
> -
> -Please refer to pinctrl-bindings.txt in this directory for details of the
> -common pinctrl bindings used by client devices, including the meaning of the
> -phrase "pin configuration node".
> -
> -Palmas's pin configuration nodes act as a container for an arbitrary number of
> -subnodes. Each of these subnodes represents some desired configuration for a
> -list of pins. This configuration can include the mux function to select on
> -those pin(s), and various pin configuration parameters, such as pull-up,
> -open drain.
> -
> -The name of each subnode is not important; all subnodes should be enumerated
> -and processed purely based on their content.
> -
> -Each subnode only affects those parameters that are explicitly listed. In
> -other words, a subnode that lists a mux function but no pin configuration
> -parameters implies no information about any pin configuration parameters.
> -Similarly, a pin subnode that describes a pullup parameter implies no
> -information about e.g. the mux function.
> -
> -Optional properties:
> -- ti,palmas-enable-dvfs1: Enable DVFS1. Configure pins for DVFS1 mode.
> - Selection primary or secondary function associated to I2C2_SCL_SCE,
> - I2C2_SDA_SDO pin/pad for DVFS1 interface
> -- ti,palmas-enable-dvfs2: Enable DVFS2. Configure pins for DVFS2 mode.
> - Selection primary or secondary function associated to GPADC_START
> - and SYSEN2 pin/pad for DVFS2 interface
> -- ti,palmas-override-powerhold: This is applicable for PMICs for which
> - GPIO7 is configured in POWERHOLD mode which has higher priority
> - over DEV_ON bit and keeps the PMIC supplies on even after the DEV_ON
> - bit is turned off. This property enables driver to over ride the
> - POWERHOLD value to GPIO7 so as to turn off the PMIC in power off
> - scenarios. So for GPIO7 if ti,palmas-override-powerhold is set
> - then the GPIO_7 field should never be muxed to anything else.
> - It should be set to POWERHOLD by default and only in case of
> - power off scenarios the driver will over ride the mux value.
> -
> -This binding uses the following generic properties as defined in
> -pinctrl-bindings.txt:
> -
> -Required: pins
> -Options: function, bias-disable, bias-pull-up, bias-pull-down,
> - drive-open-drain.
> -
> -Note that many of these properties are only valid for certain specific pins.
> -See the Palmas device datasheet for complete details regarding which pins
> -support which functionality.
> -
> -Valid values for pin names are:
> - gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7, gpio8, gpio9,
> - gpio10, gpio11, gpio12, gpio13, gpio14, gpio15, vac, powergood,
> - nreswarm, pwrdown, gpadc_start, reset_in, nsleep, enable1, enable2,
> - int.
> -
> -Valid value of function names are:
> - gpio, led, pwm, regen, sysen, clk32kgaudio, id, vbus_det, chrg_det,
> - vac, vacok, powergood, usb_psel, msecure, pwrhold, int, nreswarm,
> - simrsto, simrsti, low_vbat, wireless_chrg1, rcm, pwrdown, gpadc_start,
> - reset_in, nsleep, enable.
> -
> -There are 4 special functions: opt0, opt1, opt2 and opt3. If any of these
> -functions is selected then directly pins register will be written with 0, 1, 2
> -or 3 respectively if it is valid for that pins or list of pins.
> -
> -Example:
> - palmas: tps65913 {
> - ....
> - pinctrl {
> - compatible = "ti,tps65913-pinctrl";
> - ti,palmas-enable-dvfs1;
> - pinctrl-names = "default";
> - pinctrl-0 = <&palmas_pins_state>;
> -
> - palmas_pins_state: pinmux {
> - gpio0 {
> - pins = "gpio0";
> - function = "id";
> - bias-pull-up;
> - };
> -
> - vac {
> - pins = "vac";
> - function = "vacok";
> - bias-pull-down;
> - };
> -
> - gpio5 {
> - pins = "gpio5";
> - function = "opt0";
> - drive-open-drain = <1>;
> - };
> - };
> - };
> - ....
> - };
> diff --git a/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
> new file mode 100644
> index 000000000000..63f3b858fd62
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/ti,palmas-pinctrl.yaml
> @@ -0,0 +1,154 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/ti,palmas-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of Power-Management ICs (pin control)
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@linaro.org>
> +
> +description: The pins of Palmas device can be set on different option and provides the
> + configuration for Pull UP/DOWN, open drain etc.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,palmas-pinctrl
> + - ti,tps65913-pinctrl
> + - ti,tps80036-pinctrl
> +
> + ti,palmas-enable-dvfs1:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Enable DVFS1. Configure pins for DVFS1 mode. Selection primary or secondary
> + function associated to I2C2_SCL_SCE, I2C2_SDA_SDO pin/pad for DVFS1 interface.
> +
> + ti,palmas-enable-dvfs2:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Enable DVFS2. Configure pins for DVFS2 mode. Selection primary or secondary
> + function associated to GPADC_START and SYSEN2 pin/pad for DVFS2 interface.
> +
> + ti,palmas-override-powerhold:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: This is applicable for PMICs for which GPIO7 is configured in POWERHOLD mode
> + which has higher priority over DEV_ON bit and keeps the PMIC supplies on even after the
> + DEV_ON bit is turned off. This property enables driver to over ride the POWERHOLD value to
> + GPIO7 so as to turn off the PMIC in power off scenarios. So for GPIO7 if
> + ti,palmas-override-powerhold is set then the GPIO_7 field should never be muxed to anything
> + else. It should be set to POWERHOLD by default and only in case of power off scenarios the
> + driver will over ride the mux value.
> +
> +required:
> + - compatible
> +
> +additionalProperties:
> + type: object
> + description: |
> + Please refer to pinctrl-bindings.txt in this directory for details of the common pinctrl
> + bindings used by client devices, including the meaning of the phrase "pin configuration node".
> +
> + Palmas's pin configuration nodes act as a container for an arbitrary number of subnodes. Each
> + of these subnodes represents some desired configuration for a list of pins. This configuration
> + can include the mux function to select on those pin(s), and various pin configuration
> + parameters, such as pull-up, open drain.
> +
> + properties:
> + phandle:
> + $ref: /schemas/types.yaml#/definitions/uint32
Are you sure you still need this? I thought I fixed adding it
automatically everywhere.
> +
> + additionalProperties:
> + type: object
> + description: |
> + The name of each subnode is not important; all subnodes should be enumerated and processed
> + purely based on their content.
> +
> + Each subnode only affects those parameters that are explicitly listed. In other words, a
> + subnode that lists a mux function but no pin configuration parameters implies no information
> + about any pin configuration parameters. Similarly, a pin subnode that describes a pullup
> + parameter implies no information about e.g. the mux function.
> +
> + Note that many of these properties are only valid for certain specific pins. See the Palmas
> + device datasheet for complete details regarding which pins support which functionality.
> +
> + properties:
> + pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + items:
> + enum: [ gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7, gpio8, gpio9, gpio10,
> + gpio11, gpio12, gpio13, gpio14, gpio15, vac, powergood, nreswarm, pwrdown,
> + gpadc_start, reset_in, nsleep, enable1, enable2, int ]
> +
> + function:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: Note that the opt0, opt1, opt2 and opt3 functions are special and if any of
> + these functions is selected then directly pins register will be written with 0, 1, 2 or 3,
> + respectively, if the function is valid for that pin or list of pins.
> + enum: [ gpio, led, pwm, regen, sysen, clk32kgaudio, id, vbus_det, chrg_det, vac, vacok,
> + powergood, usb_psel, msecure, pwrhold, int, nreswarm, simrsto, simrsti, low_vbat,
> + wireless_chrg1, rcm, pwrdown, gpadc_start, reset_in, nsleep, enable, opt0, opt1,
> + opt2, opt3 ]
> +
> + bias-disable:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: disable bias
> +
> + bias-pull-up:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: pull-up bias
> +
> + bias-pull-down:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: pull-down bias
> +
> + drive-open-drain:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: configure for open drain
> + enum: [ 0, 1 ]
> +
> + additionalProperties: false
> +
> + required:
> + - pins
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@58 {
> + compatible = "ti,tps65913", "ti,palmas";
> + reg = <0x58>;
> +
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + pinctrl {
> + compatible = "ti,tps65913-pinctrl";
> + ti,palmas-enable-dvfs1;
> + pinctrl-names = "default";
> + pinctrl-0 = <&palmas_pins_state>;
> +
> + palmas_pins_state: pinmux {
> + gpio0 {
> + pins = "gpio0";
> + function = "id";
> + bias-pull-up;
> + };
> +
> + vac {
> + pins = "vac";
> + function = "vacok";
> + bias-pull-down;
> + };
> +
> + gpio5 {
> + pins = "gpio5";
> + function = "opt0";
> + drive-open-drain = <1>;
> + };
> + };
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> deleted file mode 100644
> index 84bc76a7c39e..000000000000
> --- a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> +++ /dev/null
> @@ -1,89 +0,0 @@
> -* palmas regulator IP block devicetree bindings
> -
> -The tps659038 for the AM57x class have OTP spins that
> -have different part numbers but the same functionality. There
> -is not a need to add the OTP spins to the palmas driver. The
> -spin devices should use the tps659038 as it's compatible value.
> -This is the list of those devices:
> -tps659037
> -
> -Required properties:
> -- compatible : Should be from the list
> - ti,twl6035-pmic
> - ti,twl6036-pmic
> - ti,twl6037-pmic
> - ti,tps65913-pmic
> - ti,tps65914-pmic
> - ti,tps65917-pmic
> - ti,tps659038-pmic
> -and also the generic series names
> - ti,palmas-pmic
> -- interrupts : The interrupt number and the type which can be looked up here:
> - arch/arm/boot/dts/include/dt-bindings/interrupt-controller/irq.h
> -- interrupts-name: The names of the individual interrupts.
> -
> -Optional properties:
> -- ti,ldo6-vibrator : ldo6 is in vibrator mode
> -
> -Optional nodes:
> -- regulators : Must contain a sub-node per regulator from the list below.
> - Each sub-node should contain the constraints and initialization
> - information for that regulator. See regulator.txt for a
> - description of standard properties for these sub-nodes.
> - Additional custom properties are listed below.
> -
> - For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP,
> - smps45, smps457, smps7 depending on variant, smps6, smps[8-9],
> - smps10_out2, smps10_out1, ldo[1-9], ldoln, ldousb.
> -
> - Optional sub-node properties:
> - ti,warm-reset - maintain voltage during warm reset(boolean)
> - ti,roof-floor - This takes as optional argument on platform supporting
> - the rail from desired external control. If there is no argument then
> - it will be assume that it is controlled by NSLEEP pin.
> - The valid value for external pins are:
> - ENABLE1 then 1,
> - ENABLE2 then 2 or
> - NSLEEP then 3.
> - ti,mode-sleep - mode to adopt in pmic sleep 0 - off, 1 - auto,
> - 2 - eco, 3 - forced pwm
> - ti,smps-range - OTP has the wrong range set for the hardware so override
> - 0 - low range, 1 - high range.
> -
> -- ti,system-power-controller: Telling whether or not this pmic is controlling
> - the system power.
> -
> -Example:
> -
> -#include <dt-bindings/interrupt-controller/irq.h>
> -
> -pmic {
> - compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
> - interrupt-parent = <&palmas>;
> - interrupts = <14 IRQ_TYPE_NONE>;
> - interrupts-name = "short-irq";
> -
> - ti,ldo6-vibrator;
> -
> - ti,system-power-controller;
> -
> - regulators {
> - smps12_reg : smps12 {
> - regulator-name = "smps12";
> - regulator-min-microvolt = < 600000>;
> - regulator-max-microvolt = <1500000>;
> - regulator-always-on;
> - regulator-boot-on;
> - ti,warm-reset;
> - ti,roof-floor = <1>; /* ENABLE1 control */
> - ti,mode-sleep = <0>;
> - ti,smps-range = <1>;
> - };
> -
> - ldo1_reg: ldo1 {
> - regulator-name = "ldo1";
> - regulator-min-microvolt = <2800000>;
> - regulator-max-microvolt = <2800000>;
> - };
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml b/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
> new file mode 100644
> index 000000000000..da71e3ebcd32
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,palmas-pmic.yaml
> @@ -0,0 +1,144 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/ti,palmas-pmic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of PMICs regulator IP block
> +
> +maintainers:
> + - Mark Brown <broonie@kernel.org>
> +
> +description: |
> + The TPS659038 for the AM57x class have OTP spins that have different part numbers but the same
> + functionality. There is not a need to add the OTP spins to the Palmas driver. The spin devices
> + should use the TPS659038 as it's compatible value.
> +
> + This is the list of those devices: tps659037
> +
> +definitions:
$defs instead.
> + regulator:
> + type: object
> + properties:
> + ti,warm-reset:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: maintain voltage during warm reset
> +
> + ti,roof-floor:
> + description: This takes as optional argument on platform supporting the rail from
> + desired external control. If there is no argument then it will be assume that it is
> + controlled by NSLEEP pin.
> + oneOf:
> + - $ref: /schemas/types.yaml#/definitions/flag
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + #oneOf:
> + # - description: ENABLE1 pin
> + # const: 1
> + # - description: ENABLE2 pin
> + # const: 2
> + # - description: NSLEEP pin
> + # const: 3
> +
> + ti,mode-sleep:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Mode to adopt in PMIC sleep.
> + #oneOf:
> + # - description: off
> + # const: 0
> + # - description: auto
> + # const: 1
> + # - description: ECO
> + # const: 2
> + # - description: forced PWM
> + # const: 3
> +
> + ti,smps-range:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: OTP has the wrong range set for the hardware so override
> + #oneOf:
> + # - description: low range
> + # const: 0
> + # - description: high range
> + # const: 1
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - ti,twl6035-pmic
> + - ti,twl6036-pmic
> + - ti,twl6037-pmic
> + - ti,tps65913-pmic
> + - ti,tps65914-pmic
> + - ti,tps65917-pmic
> + - ti,tps659038-pmic
> + - const: ti,palmas-pmic
> +
> + interrupts:
> + maxItems: 1
> +
> + ti,ldo6-vibrator:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Specifies whether LDO6 is in vibrator mode or not.
> +
> + regulators:
> + type: object
> + description: |
> + Must contain a sub-node per regulator from the list below. Each sub-node should contain the
> + constraints and initialization information for that regulator. See regulator.txt for a
> + description of standard properties for these sub-nodes. Additional custom properties are
> + listed below.
> +
> + patternProperties:
> + "^smps(12|123|3|34|457|6|7|8|9|10_out1|10_out2)$":
> + $ref: "#/definitions/regulator"
> +
> + "^ldo[1-9]|ldoln|ldousb$":
> + $ref: "#/definitions/regulator"
> +
> +patternProperties:
> + "^smps(([1-9]|10)-in-)|(smps10-out2-)supply$":
> + description: Input supply for the corresponding SMPS regulator.
> +
> + "^ldo([1-9]|ln|usb)-in-supply$":
> + description: Input supply for the corresponding LDO regulator.
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + pmic {
> + compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
> + interrupt-parent = <&palmas>;
> + interrupts = <14 IRQ_TYPE_NONE>;
> + interrupts-name = "short-irq";
> +
> + ti,ldo6-vibrator;
> +
> + ti,system-power-controller;
> +
> + regulators {
> + smps12_reg: smps12 {
> + regulator-name = "smps12";
> + regulator-min-microvolt = < 600000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-always-on;
> + regulator-boot-on;
> + ti,warm-reset;
> + ti,roof-floor = <1>; /* ENABLE1 control */
> + ti,mode-sleep = <0>;
> + ti,smps-range = <1>;
> + };
> +
> + ldo1_reg: ldo1 {
> + regulator-name = "ldo1";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + };
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> deleted file mode 100644
> index c6cf37758a77..000000000000
> --- a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -Palmas RTC controller bindings
> -
> -Required properties:
> -- compatible:
> - - "ti,palmas-rtc" for palma series of the RTC controller
> -- interrupts: Interrupt number of RTC submodule on device.
> -
> -Optional properties:
> -
> -- ti,backup-battery-chargeable: The Palmas series device like TPS65913 or
> - TPS80036 supports the backup battery for powering the RTC when main
> - battery is removed or in very low power state. The backup battery
> - can be chargeable or non-chargeable. This flag will tells whether
> - battery is chargeable or not. If charging battery then driver can
> - enable the charging.
> -- ti,backup-battery-charge-high-current: Enable high current charging in
> - backup battery. Device supports the < 100uA and > 100uA charging.
> - The high current will be > 100uA. Absence of this property will
> - charge battery to lower current i.e. < 100uA.
> -
> -Example:
> - palmas: tps65913@58 {
> - ...
> - palmas_rtc: rtc {
> - compatible = "ti,palmas-rtc";
> - interrupt-parent = <&palmas>;
> - interrupts = <8 0>;
> - ti,backup-battery-chargeable;
> - ti,backup-battery-charge-high-current;
> - };
> - ...
> - };
> diff --git a/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml b/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
> new file mode 100644
> index 000000000000..f236385d5d66
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/ti,palmas-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Palmas family of Power-Management ICs (RTC)
> +
> +maintainers:
> + - Alexandre Belloni <alexandre.belloni@bootlin.com>
> +
> +properties:
> + compatible:
> + const: ti,palmas-rtc
> +
> + interrupts:
> + maxItems: 1
> +
> + ti,backup-battery-chargeable:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: The Palmas series device like TPS65913 or TPS80036 supports the backup battery
> + for powering the RTC when main battery is removed or in very low power state. The backup
> + battery can be chargeable or non-chargeable. This flag will tells whether battery is
> + chargeable or not. If charging battery then driver can enable the charging.
> +
> + ti,backup-battery-charge-high-current:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: Enable high current charging in backup battery. Device supports the < 100uA and >
> + 100uA charging. The high current will be > 100uA. Absence of this property will charge
> + battery to lower current i.e. < 100uA.
> +
> +allOf:
> + - $ref: rtc.yaml
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - interrupts
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + tps65913@58 {
pmic@58
Though I prefer if we just have 1 example in the MFD binding instead of
these partial ones scattered about.
> + compatible = "ti,tps65913", "ti,palmas";
> + reg = <0x58>;
> +
> + #interrupt-cells = <2>;
> + interrupt-controller;
> +
> + rtc {
> + compatible = "ti,palmas-rtc";
> + interrupt-parent = <&palmas>;
> + interrupts = <8 0>;
> + ti,backup-battery-chargeable;
> + ti,backup-battery-charge-high-current;
> + };
> + };
> + };
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-12-21 19:00 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-17 17:05 [PATCH 1/6] dt-bindings: regulator: palmas: Convert to json-schema Thierry Reding
2021-12-17 17:05 ` [PATCH 2/6] dt-bindings: regulator: pwm: " Thierry Reding
2021-12-18 18:08 ` Rob Herring
2021-12-21 18:49 ` Rob Herring
2021-12-17 17:05 ` [PATCH 3/6] dt-bindings: regulator: tps51632: " Thierry Reding
2021-12-21 18:51 ` Rob Herring
2021-12-17 17:05 ` [PATCH 4/6] dt-bindings: regulator: tps62360: " Thierry Reding
2021-12-21 18:52 ` Rob Herring
2021-12-17 17:05 ` [PATCH 5/6] dt-bindings: regulator: tps6586x: " Thierry Reding
2021-12-18 18:08 ` Rob Herring
2021-12-21 18:59 ` Rob Herring
2021-12-17 17:05 ` [PATCH 6/6] dt-bindings: regulator: tps65090: " Thierry Reding
2021-12-21 19:00 ` Rob Herring
2021-12-18 18:08 ` [PATCH 1/6] dt-bindings: regulator: palmas: " Rob Herring
2021-12-21 14:15 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.