[Buildroot] [git commit] package/linux-pam: separate locale and wchar dependencies

[Buildroot] [git commit] package/linux-pam: separate locale and wchar dependencies

[Thomas Petazzoni]

commit: https://git.buildroot.net/buildroot/commit/?id=ac9261edec111836952970e26cf373cc15b9e8ac
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

They are currently expressed as such:

     depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR)

which is not the common practice in Buildroot. We prefer to use:

     depends on BR2_ENABLE_LOCALE
     depends on BR2_USE_WCHAR

This commit ensures linux-pam is consistent with this best practice.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/linux-pam/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/linux-pam/Config.in b/package/linux-pam/Config.in
index 931cfdeccf..27ba55bd61 100644
--- a/package/linux-pam/Config.in
+++ b/package/linux-pam/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LINUX_PAM
 	bool "linux-pam"
-	depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR)
+	depends on BR2_ENABLE_LOCALE
+	depends on BR2_USE_WCHAR
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_FLEX
@@ -12,5 +13,5 @@ config BR2_PACKAGE_LINUX_PAM
 
 comment "linux-pam needs a toolchain w/ wchar, locale, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \
+	depends on !BR2_ENABLE_LOCALE || !BR2_USE_WCHAR \
 		|| BR2_STATIC_LIBS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/linux-pam: separate locale and wchar dependencies

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=ac9261edec111836952970e26cf373cc15b9e8ac
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > They are currently expressed as such:

 >      depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR)

 > which is not the common practice in Buildroot. We prefer to use:

 >      depends on BR2_ENABLE_LOCALE
 >      depends on BR2_USE_WCHAR

 > This commit ensures linux-pam is consistent with this best practice.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2021.02.x and 2021.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot