From: Baoquan He <bhe@redhat.com> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>, akpm@linux-foundation.org, kexec@lists.infradead.org, Tiezhu Yang <yangtiezhu@loongson.cn>, linux-kernel@vger.kernel.org, Amit Daniel Kachhap <amit.kachhap@arm.com>, Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter Date: Mon, 20 Dec 2021 16:10:45 +0800 [thread overview] Message-ID: <20211220081045.GC31681@MiWiFi-R3L-srv> (raw) In-Reply-To: <20211213143927.3069508-2-willy@infradead.org> On 12/13/21 at 02:39pm, Matthew Wilcox (Oracle) wrote: > Instead of passing in a 'buf' and 'userbuf' argument, pass in an iov_iter. > s390 needs more work to pass the iov_iter down further, or refactor, > but I'd be more comfortable if someone who can test on s390 did that work. > > It's more convenient to convert the whole of read_from_oldmem() to > take an iov_iter at the same time, so rename it to read_from_oldmem_iter() > and add a temporary read_from_oldmem() wrapper that creates an iov_iter. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Thanks for making this to do an awesome clean up. This one looks good to me. Acked-by: Baoquan He <bhe@redhat.com> ...... > -/** > - * copy_oldmem_page() - copy one page from old kernel memory > - * @pfn: page frame number to be copied > - * @buf: buffer where the copied page is placed > - * @csize: number of bytes to copy > - * @offset: offset in bytes into the page > - * @userbuf: if set, @buf is int he user address space > - * > - * This function copies one page from old kernel memory into buffer pointed by > - * @buf. If @buf is in userspace, set @userbuf to %1. Returns number of bytes > - * copied or negative error in case of failure. > - */ > -ssize_t copy_oldmem_page(unsigned long pfn, char *buf, > - size_t csize, unsigned long offset, > - int userbuf) > +ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, > + size_t csize, unsigned long offset) ^^^^^^ I am curious why this parameter is called 'csize', but not 'size' directly. This is not related to this patch, it's an old naming. > { > void *vaddr; > > @@ -40,14 +28,7 @@ ssize_t copy_oldmem_page(unsigned long pfn, char *buf, > if (!vaddr) > return -ENOMEM; > > - if (userbuf) { > - if (copy_to_user(buf, vaddr + offset, csize)) { > - iounmap(vaddr); > - return -EFAULT; > - } > - } else { > - memcpy(buf, vaddr + offset, csize); > - } > + csize = copy_to_iter(vaddr + offset, csize, iter); > > iounmap(vaddr); > return csize;
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>, akpm@linux-foundation.org, kexec@lists.infradead.org, Tiezhu Yang <yangtiezhu@loongson.cn>, linux-kernel@vger.kernel.org, Amit Daniel Kachhap <amit.kachhap@arm.com>, Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter Date: Mon, 20 Dec 2021 16:10:45 +0800 [thread overview] Message-ID: <20211220081045.GC31681@MiWiFi-R3L-srv> (raw) In-Reply-To: <20211213143927.3069508-2-willy@infradead.org> On 12/13/21 at 02:39pm, Matthew Wilcox (Oracle) wrote: > Instead of passing in a 'buf' and 'userbuf' argument, pass in an iov_iter. > s390 needs more work to pass the iov_iter down further, or refactor, > but I'd be more comfortable if someone who can test on s390 did that work. > > It's more convenient to convert the whole of read_from_oldmem() to > take an iov_iter at the same time, so rename it to read_from_oldmem_iter() > and add a temporary read_from_oldmem() wrapper that creates an iov_iter. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Thanks for making this to do an awesome clean up. This one looks good to me. Acked-by: Baoquan He <bhe@redhat.com> ...... > -/** > - * copy_oldmem_page() - copy one page from old kernel memory > - * @pfn: page frame number to be copied > - * @buf: buffer where the copied page is placed > - * @csize: number of bytes to copy > - * @offset: offset in bytes into the page > - * @userbuf: if set, @buf is int he user address space > - * > - * This function copies one page from old kernel memory into buffer pointed by > - * @buf. If @buf is in userspace, set @userbuf to %1. Returns number of bytes > - * copied or negative error in case of failure. > - */ > -ssize_t copy_oldmem_page(unsigned long pfn, char *buf, > - size_t csize, unsigned long offset, > - int userbuf) > +ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, > + size_t csize, unsigned long offset) ^^^^^^ I am curious why this parameter is called 'csize', but not 'size' directly. This is not related to this patch, it's an old naming. > { > void *vaddr; > > @@ -40,14 +28,7 @@ ssize_t copy_oldmem_page(unsigned long pfn, char *buf, > if (!vaddr) > return -ENOMEM; > > - if (userbuf) { > - if (copy_to_user(buf, vaddr + offset, csize)) { > - iounmap(vaddr); > - return -EFAULT; > - } > - } else { > - memcpy(buf, vaddr + offset, csize); > - } > + csize = copy_to_iter(vaddr + offset, csize, iter); > > iounmap(vaddr); > return csize; _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-12-20 8:10 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-13 14:39 [PATCH v3 0/3] Convert vmcore to use an iov_iter Matthew Wilcox (Oracle) 2021-12-13 14:39 ` Matthew Wilcox (Oracle) 2021-12-13 14:39 ` [PATCH v3 1/3] vmcore: Convert copy_oldmem_page() to take " Matthew Wilcox (Oracle) 2021-12-13 14:39 ` Matthew Wilcox (Oracle) 2021-12-20 8:10 ` Baoquan He [this message] 2021-12-20 8:10 ` Baoquan He 2021-12-21 8:29 ` Christoph Hellwig 2021-12-21 8:29 ` Christoph Hellwig 2021-12-13 14:39 ` [PATCH v3 2/3] vmcore: Convert __read_vmcore to use " Matthew Wilcox (Oracle) 2021-12-13 14:39 ` Matthew Wilcox (Oracle) 2021-12-21 6:52 ` Baoquan He 2021-12-21 6:52 ` Baoquan He 2021-12-21 8:29 ` Christoph Hellwig 2021-12-21 8:29 ` Christoph Hellwig 2021-12-13 14:39 ` [PATCH v3 3/3] vmcore: Convert read_from_oldmem() to take " Matthew Wilcox (Oracle) 2021-12-13 14:39 ` Matthew Wilcox (Oracle) 2021-12-21 8:30 ` Christoph Hellwig 2021-12-21 8:30 ` Christoph Hellwig 2021-12-16 8:43 ` [PATCH v3 0/3] Convert vmcore to use " Baoquan He 2021-12-16 8:43 ` Baoquan He 2021-12-21 8:06 ` Baoquan He 2021-12-21 8:06 ` Baoquan He 2022-01-01 0:36 ` Al Viro 2022-01-01 0:36 ` Al Viro 2022-01-27 9:44 ` Baoquan He 2022-01-27 9:44 ` Baoquan He 2022-02-25 8:28 ` Baoquan He 2022-02-25 8:28 ` Baoquan He
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211220081045.GC31681@MiWiFi-R3L-srv \ --to=bhe@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=amit.kachhap@arm.com \ --cc=dyoung@redhat.com \ --cc=hch@lst.de \ --cc=kexec@lists.infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vgoyal@redhat.com \ --cc=willy@infradead.org \ --cc=yangtiezhu@loongson.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.