* [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests
@ 2021-12-20 8:10 Thomas Huth
2021-12-20 8:10 ` [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available Thomas Huth
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Thomas Huth @ 2021-12-20 8:10 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier; +Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
Devices might not always be compiled into the QEMU target binaries.
We already have the libqos framework that is good for handling such
situations, but some of the qtests are not a real good fit for the
libqos framework. This patch series adds a new function to check
whether a device is available in the target binary or not, so that
tests can be run or skipped accordingly (also adding some additional
checks for the availability of machines in the target binaries).
Thomas Huth (4):
tests/qtest: Add a function that checks whether a device is available
tests/qtest: Improve endianness-test to work with missing machines and
devices
tests/qtest/cdrom-test: Check whether devices are available before
using them
tests/qtest/boot-order-test: Check whether machines are available
tests/qtest/boot-order-test.c | 5 +++
tests/qtest/cdrom-test.c | 60 +++++++++++++++++++++++------------
tests/qtest/endianness-test.c | 5 ++-
tests/qtest/libqos/libqtest.h | 8 +++++
tests/qtest/libqtest.c | 44 +++++++++++++++++++++++++
5 files changed, 100 insertions(+), 22 deletions(-)
--
2.27.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available
2021-12-20 8:10 [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Thomas Huth
@ 2021-12-20 8:10 ` Thomas Huth
2022-01-11 22:18 ` Philippe Mathieu-Daudé
2021-12-20 8:10 ` [PATCH 2/4] tests/qtest: Improve endianness-test to work with missing machines and devices Thomas Huth
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2021-12-20 8:10 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier; +Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
Devices might not always be compiled into the QEMU target binaries.
We already have the libqos framework that is good for handling such
situations, but some of the qtests are not a real good fit for the
libqos framework. Let's add a qtest_has_device() function for such
tests instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/libqos/libqtest.h | 8 +++++++
tests/qtest/libqtest.c | 44 +++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
diff --git a/tests/qtest/libqos/libqtest.h b/tests/qtest/libqos/libqtest.h
index dff6b31cf0..2df9397519 100644
--- a/tests/qtest/libqos/libqtest.h
+++ b/tests/qtest/libqos/libqtest.h
@@ -718,6 +718,14 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
*/
bool qtest_has_machine(const char *machine);
+/**
+ * qtest_has_device:
+ * @device: The device to look for
+ *
+ * Returns: true if the device is available in the target binary.
+ */
+bool qtest_has_device(const char *device);
+
/**
* qtest_qmp_device_add_qdict:
* @qts: QTestState instance to operate on
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 65ed949685..9e845002a1 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -1418,6 +1418,50 @@ bool qtest_has_machine(const char *machine)
return false;
}
+bool qtest_has_device(const char *device)
+{
+ static QList *list;
+ const QListEntry *p;
+ QObject *qobj;
+ QString *qstr;
+ QDict *devinfo;
+ int idx;
+
+ if (!list) {
+ QDict *resp;
+ QDict *args;
+ QTestState *qts = qtest_init("-machine none");
+
+ args = qdict_new();
+ qdict_put_bool(args, "abstract", false);
+ qdict_put_str(args, "implements", "device");
+
+ resp = qtest_qmp(qts, "{'execute': 'qom-list-types', 'arguments': %p }",
+ args);
+ g_assert(qdict_haskey(resp, "return"));
+ list = qdict_get_qlist(resp, "return");
+ qobject_ref(list);
+ qobject_unref(resp);
+
+ qtest_quit(qts);
+ }
+
+ for (p = qlist_first(list), idx = 0; p; p = qlist_next(p), idx++) {
+ devinfo = qobject_to(QDict, qlist_entry_obj(p));
+ g_assert(devinfo);
+
+ qobj = qdict_get(devinfo, "name");
+ g_assert(qobj);
+ qstr = qobject_to(QString, qobj);
+ g_assert(qstr);
+ if (g_str_equal(qstring_get_str(qstr), device)) {
+ return true;
+ }
+ }
+
+ return false;
+}
+
/*
* Generic hot-plugging test via the device_add QMP commands.
*/
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/4] tests/qtest: Improve endianness-test to work with missing machines and devices
2021-12-20 8:10 [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Thomas Huth
2021-12-20 8:10 ` [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available Thomas Huth
@ 2021-12-20 8:10 ` Thomas Huth
2022-01-11 22:20 ` Philippe Mathieu-Daudé
2021-12-20 8:10 ` [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them Thomas Huth
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2021-12-20 8:10 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier; +Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
The users might have built QEMU with less machines or without the
i82378 superio device. Add some checks to the endianess-test so that
it is able to deal with such stripped down QEMU versions, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/endianness-test.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/endianness-test.c b/tests/qtest/endianness-test.c
index 09ecb531f1..9c03b72dc9 100644
--- a/tests/qtest/endianness-test.c
+++ b/tests/qtest/endianness-test.c
@@ -281,7 +281,10 @@ int main(int argc, char **argv)
for (i = 0; test_cases[i].arch; i++) {
gchar *path;
- if (strcmp(test_cases[i].arch, arch) != 0) {
+
+ if (!g_str_equal(test_cases[i].arch, arch) ||
+ !qtest_has_machine(test_cases[i].machine) ||
+ (test_cases[i].superio && !qtest_has_device(test_cases[i].superio))) {
continue;
}
path = g_strdup_printf("endianness/%s",
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them
2021-12-20 8:10 [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Thomas Huth
2021-12-20 8:10 ` [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available Thomas Huth
2021-12-20 8:10 ` [PATCH 2/4] tests/qtest: Improve endianness-test to work with missing machines and devices Thomas Huth
@ 2021-12-20 8:10 ` Thomas Huth
2022-01-11 19:53 ` John Snow
2022-01-11 22:21 ` Philippe Mathieu-Daudé
2021-12-20 8:10 ` [PATCH 4/4] tests/qtest/boot-order-test: Check whether machines are available Thomas Huth
2022-01-11 22:23 ` [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Philippe Mathieu-Daudé
4 siblings, 2 replies; 10+ messages in thread
From: Thomas Huth @ 2021-12-20 8:10 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier; +Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
Downstream users might want to disable legacy devices in their binaries,
so we should not blindly assume that they are available. Add some proper
checks before using them.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/cdrom-test.c | 60 ++++++++++++++++++++++++++--------------
1 file changed, 39 insertions(+), 21 deletions(-)
diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
index c1fcac5c45..cfca24fa94 100644
--- a/tests/qtest/cdrom-test.c
+++ b/tests/qtest/cdrom-test.c
@@ -142,21 +142,36 @@ static void add_x86_tests(void)
qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
"-drive if=ide,media=cdrom,file=", test_cdboot);
}
- qtest_add_data_func("cdrom/boot/am53c974",
- "-device am53c974 -device scsi-cd,drive=cd1 "
- "-drive if=none,id=cd1,format=raw,file=", test_cdboot);
- qtest_add_data_func("cdrom/boot/dc390",
- "-device dc390 -device scsi-cd,drive=cd1 "
- "-blockdev file,node-name=cd1,filename=", test_cdboot);
- qtest_add_data_func("cdrom/boot/lsi53c895a",
- "-device lsi53c895a -device scsi-cd,drive=cd1 "
- "-blockdev file,node-name=cd1,filename=", test_cdboot);
- qtest_add_data_func("cdrom/boot/megasas", "-M q35 "
- "-device megasas -device scsi-cd,drive=cd1 "
- "-blockdev file,node-name=cd1,filename=", test_cdboot);
- qtest_add_data_func("cdrom/boot/megasas-gen2", "-M q35 "
- "-device megasas-gen2 -device scsi-cd,drive=cd1 "
- "-blockdev file,node-name=cd1,filename=", test_cdboot);
+ if (qtest_has_device("am53c974")) {
+ qtest_add_data_func("cdrom/boot/am53c974",
+ "-device am53c974 -device scsi-cd,drive=cd1 "
+ "-drive if=none,id=cd1,format=raw,file=",
+ test_cdboot);
+ }
+ if (qtest_has_device("dc390")) {
+ qtest_add_data_func("cdrom/boot/dc390",
+ "-device dc390 -device scsi-cd,drive=cd1 "
+ "-blockdev file,node-name=cd1,filename=",
+ test_cdboot);
+ }
+ if (qtest_has_device("lsi53c895a")) {
+ qtest_add_data_func("cdrom/boot/lsi53c895a",
+ "-device lsi53c895a -device scsi-cd,drive=cd1 "
+ "-blockdev file,node-name=cd1,filename=",
+ test_cdboot);
+ }
+ if (qtest_has_device("megasas")) {
+ qtest_add_data_func("cdrom/boot/megasas", "-M q35 "
+ "-device megasas -device scsi-cd,drive=cd1 "
+ "-blockdev file,node-name=cd1,filename=",
+ test_cdboot);
+ }
+ if (qtest_has_device("megasas-gen2")) {
+ qtest_add_data_func("cdrom/boot/megasas-gen2", "-M q35 "
+ "-device megasas-gen2 -device scsi-cd,drive=cd1 "
+ "-blockdev file,node-name=cd1,filename=",
+ test_cdboot);
+ }
}
static void add_s390x_tests(void)
@@ -171,12 +186,15 @@ static void add_s390x_tests(void)
"-drive driver=null-co,read-zeroes=on,if=none,id=d1 "
"-device virtio-blk,drive=d2,bootindex=1 "
"-drive if=none,id=d2,media=cdrom,file=", test_cdboot);
- qtest_add_data_func("cdrom/boot/without-bootindex",
- "-device virtio-scsi -device virtio-serial "
- "-device x-terminal3270 -device virtio-blk,drive=d1 "
- "-drive driver=null-co,read-zeroes=on,if=none,id=d1 "
- "-device virtio-blk,drive=d2 "
- "-drive if=none,id=d2,media=cdrom,file=", test_cdboot);
+ if (qtest_has_device("x-terminal3270")) {
+ qtest_add_data_func("cdrom/boot/without-bootindex",
+ "-device virtio-scsi -device virtio-serial "
+ "-device x-terminal3270 -device virtio-blk,drive=d1 "
+ "-drive driver=null-co,read-zeroes=on,if=none,id=d1 "
+ "-device virtio-blk,drive=d2 "
+ "-drive if=none,id=d2,media=cdrom,file=",
+ test_cdboot);
+ }
}
int main(int argc, char **argv)
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/4] tests/qtest/boot-order-test: Check whether machines are available
2021-12-20 8:10 [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Thomas Huth
` (2 preceding siblings ...)
2021-12-20 8:10 ` [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them Thomas Huth
@ 2021-12-20 8:10 ` Thomas Huth
2022-01-11 22:23 ` [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Philippe Mathieu-Daudé
4 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2021-12-20 8:10 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier; +Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
Machines might not always be compiled into the QEMU binary, so
we should skip the test instead of failing if it is not available.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/boot-order-test.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/qtest/boot-order-test.c b/tests/qtest/boot-order-test.c
index fac580d6c4..f1f59b1261 100644
--- a/tests/qtest/boot-order-test.c
+++ b/tests/qtest/boot-order-test.c
@@ -34,6 +34,11 @@ static void test_a_boot_order(const char *machine,
uint64_t actual;
QTestState *qts;
+ if (machine && !qtest_has_machine(machine)) {
+ g_test_skip("Machine is not available");
+ return;
+ }
+
qts = qtest_initf("-nodefaults%s%s %s", machine ? " -M " : "",
machine ?: "", test_args);
actual = read_boot_order(qts);
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them
2021-12-20 8:10 ` [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them Thomas Huth
@ 2022-01-11 19:53 ` John Snow
2022-01-11 22:21 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 10+ messages in thread
From: John Snow @ 2022-01-11 19:53 UTC (permalink / raw)
To: Thomas Huth; +Cc: Laurent Vivier, Paolo Bonzini, Miroslav Rezanina, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 4897 bytes --]
On Mon, Dec 20, 2021 at 3:11 AM Thomas Huth <thuth@redhat.com> wrote:
> Downstream users might want to disable legacy devices in their binaries,
> so we should not blindly assume that they are available. Add some proper
> checks before using them.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qtest/cdrom-test.c | 60 ++++++++++++++++++++++++++--------------
> 1 file changed, 39 insertions(+), 21 deletions(-)
>
> diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
> index c1fcac5c45..cfca24fa94 100644
> --- a/tests/qtest/cdrom-test.c
> +++ b/tests/qtest/cdrom-test.c
> @@ -142,21 +142,36 @@ static void add_x86_tests(void)
> qtest_add_data_func("cdrom/boot/isapc", "-M isapc "
> "-drive if=ide,media=cdrom,file=",
> test_cdboot);
> }
> - qtest_add_data_func("cdrom/boot/am53c974",
> - "-device am53c974 -device scsi-cd,drive=cd1 "
> - "-drive if=none,id=cd1,format=raw,file=",
> test_cdboot);
> - qtest_add_data_func("cdrom/boot/dc390",
> - "-device dc390 -device scsi-cd,drive=cd1 "
> - "-blockdev file,node-name=cd1,filename=",
> test_cdboot);
> - qtest_add_data_func("cdrom/boot/lsi53c895a",
> - "-device lsi53c895a -device scsi-cd,drive=cd1 "
> - "-blockdev file,node-name=cd1,filename=",
> test_cdboot);
> - qtest_add_data_func("cdrom/boot/megasas", "-M q35 "
> - "-device megasas -device scsi-cd,drive=cd1 "
> - "-blockdev file,node-name=cd1,filename=",
> test_cdboot);
> - qtest_add_data_func("cdrom/boot/megasas-gen2", "-M q35 "
> - "-device megasas-gen2 -device scsi-cd,drive=cd1 "
> - "-blockdev file,node-name=cd1,filename=",
> test_cdboot);
> + if (qtest_has_device("am53c974")) {
> + qtest_add_data_func("cdrom/boot/am53c974",
> + "-device am53c974 -device scsi-cd,drive=cd1 "
> + "-drive if=none,id=cd1,format=raw,file=",
> + test_cdboot);
> + }
> + if (qtest_has_device("dc390")) {
> + qtest_add_data_func("cdrom/boot/dc390",
> + "-device dc390 -device scsi-cd,drive=cd1 "
> + "-blockdev file,node-name=cd1,filename=",
> + test_cdboot);
> + }
> + if (qtest_has_device("lsi53c895a")) {
> + qtest_add_data_func("cdrom/boot/lsi53c895a",
> + "-device lsi53c895a -device scsi-cd,drive=cd1
> "
> + "-blockdev file,node-name=cd1,filename=",
> + test_cdboot);
> + }
> + if (qtest_has_device("megasas")) {
> + qtest_add_data_func("cdrom/boot/megasas", "-M q35 "
> + "-device megasas -device scsi-cd,drive=cd1 "
> + "-blockdev file,node-name=cd1,filename=",
> + test_cdboot);
> + }
> + if (qtest_has_device("megasas-gen2")) {
> + qtest_add_data_func("cdrom/boot/megasas-gen2", "-M q35 "
> + "-device megasas-gen2 -device
> scsi-cd,drive=cd1 "
> + "-blockdev file,node-name=cd1,filename=",
> + test_cdboot);
> + }
> }
>
> static void add_s390x_tests(void)
> @@ -171,12 +186,15 @@ static void add_s390x_tests(void)
> "-drive
> driver=null-co,read-zeroes=on,if=none,id=d1 "
> "-device virtio-blk,drive=d2,bootindex=1 "
> "-drive if=none,id=d2,media=cdrom,file=",
> test_cdboot);
> - qtest_add_data_func("cdrom/boot/without-bootindex",
> - "-device virtio-scsi -device virtio-serial "
> - "-device x-terminal3270 -device
> virtio-blk,drive=d1 "
> - "-drive
> driver=null-co,read-zeroes=on,if=none,id=d1 "
> - "-device virtio-blk,drive=d2 "
> - "-drive if=none,id=d2,media=cdrom,file=",
> test_cdboot);
> + if (qtest_has_device("x-terminal3270")) {
> + qtest_add_data_func("cdrom/boot/without-bootindex",
> + "-device virtio-scsi -device virtio-serial "
> + "-device x-terminal3270 -device
> virtio-blk,drive=d1 "
> + "-drive
> driver=null-co,read-zeroes=on,if=none,id=d1 "
> + "-device virtio-blk,drive=d2 "
> + "-drive if=none,id=d2,media=cdrom,file=",
> + test_cdboot);
> + }
> }
>
> int main(int argc, char **argv)
> --
> 2.27.0
>
>
Acked-by: John Snow <jsnow@redhat.com>
These are really more your tests than mine :)
--js
[-- Attachment #2: Type: text/html, Size: 6834 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available
2021-12-20 8:10 ` [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available Thomas Huth
@ 2022-01-11 22:18 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-11 22:18 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Laurent Vivier
Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
On 20/12/21 09:10, Thomas Huth wrote:
> Devices might not always be compiled into the QEMU target binaries.
> We already have the libqos framework that is good for handling such
> situations, but some of the qtests are not a real good fit for the
> libqos framework. Let's add a qtest_has_device() function for such
> tests instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qtest/libqos/libqtest.h | 8 +++++++
> tests/qtest/libqtest.c | 44 +++++++++++++++++++++++++++++++++++
> 2 files changed, 52 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/4] tests/qtest: Improve endianness-test to work with missing machines and devices
2021-12-20 8:10 ` [PATCH 2/4] tests/qtest: Improve endianness-test to work with missing machines and devices Thomas Huth
@ 2022-01-11 22:20 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-11 22:20 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Laurent Vivier
Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
On 20/12/21 09:10, Thomas Huth wrote:
> The users might have built QEMU with less machines or without the
> i82378 superio device. Add some checks to the endianess-test so that
> it is able to deal with such stripped down QEMU versions, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qtest/endianness-test.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
The i82378 should work regardless the guest endianess...
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them
2021-12-20 8:10 ` [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them Thomas Huth
2022-01-11 19:53 ` John Snow
@ 2022-01-11 22:21 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-11 22:21 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Laurent Vivier
Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
On 20/12/21 09:10, Thomas Huth wrote:
> Downstream users might want to disable legacy devices in their binaries,
> so we should not blindly assume that they are available. Add some proper
> checks before using them.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qtest/cdrom-test.c | 60 ++++++++++++++++++++++++++--------------
> 1 file changed, 39 insertions(+), 21 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests
2021-12-20 8:10 [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Thomas Huth
` (3 preceding siblings ...)
2021-12-20 8:10 ` [PATCH 4/4] tests/qtest/boot-order-test: Check whether machines are available Thomas Huth
@ 2022-01-11 22:23 ` Philippe Mathieu-Daudé
4 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-11 22:23 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Laurent Vivier
Cc: Paolo Bonzini, Miroslav Rezanina, John Snow
On 20/12/21 09:10, Thomas Huth wrote:
> Devices might not always be compiled into the QEMU target binaries.
> We already have the libqos framework that is good for handling such
> situations, but some of the qtests are not a real good fit for the
> libqos framework. This patch series adds a new function to check
> whether a device is available in the target binary or not, so that
> tests can be run or skipped accordingly (also adding some additional
> checks for the availability of machines in the target binaries).
What happens if a device or machine is inadvertently removed from the
build? We won't notice it directly anymore, right?
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-01-11 22:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 8:10 [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Thomas Huth
2021-12-20 8:10 ` [PATCH 1/4] tests/qtest: Add a function that checks whether a device is available Thomas Huth
2022-01-11 22:18 ` Philippe Mathieu-Daudé
2021-12-20 8:10 ` [PATCH 2/4] tests/qtest: Improve endianness-test to work with missing machines and devices Thomas Huth
2022-01-11 22:20 ` Philippe Mathieu-Daudé
2021-12-20 8:10 ` [PATCH 3/4] tests/qtest/cdrom-test: Check whether devices are available before using them Thomas Huth
2022-01-11 19:53 ` John Snow
2022-01-11 22:21 ` Philippe Mathieu-Daudé
2021-12-20 8:10 ` [PATCH 4/4] tests/qtest/boot-order-test: Check whether machines are available Thomas Huth
2022-01-11 22:23 ` [PATCH 0/4] tests/qtest: Check for devices and machines before adding tests Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.