* [Buildroot] [PATCH 1/1] package/connman: add iwd support
@ 2021-12-20 8:46 James Hilliard
2021-12-20 22:34 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: James Hilliard @ 2021-12-20 8:46 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Martin Bark
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/connman/connman.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/connman/connman.mk b/package/connman/connman.mk
index e5e596c973..d3ebb40a1c 100644
--- a/package/connman/connman.mk
+++ b/package/connman/connman.mk
@@ -85,6 +85,13 @@ else
CONNMAN_CONF_OPTS += --disable-wispr
endif
+ifeq ($(BR2_PACKAGE_IWD),y)
+CONNMAN_CONF_OPTS += --enable-iwd
+else
+CONNMAN_CONF_OPTS += --disable-iwd
+endif
+
+
define CONNMAN_INSTALL_INIT_SYSV
$(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
endef
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/connman: add iwd support
2021-12-20 8:46 [Buildroot] [PATCH 1/1] package/connman: add iwd support James Hilliard
@ 2021-12-20 22:34 ` Arnout Vandecappelle
2021-12-21 19:07 ` James Hilliard
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-12-20 22:34 UTC (permalink / raw)
To: James Hilliard, buildroot; +Cc: Martin Bark
On 20/12/2021 09:46, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/connman/connman.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index e5e596c973..d3ebb40a1c 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -85,6 +85,13 @@ else
> CONNMAN_CONF_OPTS += --disable-wispr
> endif
>
> +ifeq ($(BR2_PACKAGE_IWD),y)
> +CONNMAN_CONF_OPTS += --enable-iwd
No need to add iwd to CONNMAN_DEPENDENCIES?
Regards,
Arnout
> +else
> +CONNMAN_CONF_OPTS += --disable-iwd
> +endif
> +
> +
> define CONNMAN_INSTALL_INIT_SYSV
> $(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
> endef
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/connman: add iwd support
2021-12-20 22:34 ` Arnout Vandecappelle
@ 2021-12-21 19:07 ` James Hilliard
2021-12-21 21:47 ` Arnout Vandecappelle
0 siblings, 1 reply; 5+ messages in thread
From: James Hilliard @ 2021-12-21 19:07 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: Martin Bark, buildroot
On Mon, Dec 20, 2021 at 3:34 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 20/12/2021 09:46, James Hilliard wrote:
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/connman/connman.mk | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> > index e5e596c973..d3ebb40a1c 100644
> > --- a/package/connman/connman.mk
> > +++ b/package/connman/connman.mk
> > @@ -85,6 +85,13 @@ else
> > CONNMAN_CONF_OPTS += --disable-wispr
> > endif
> >
> > +ifeq ($(BR2_PACKAGE_IWD),y)
> > +CONNMAN_CONF_OPTS += --enable-iwd
>
> No need to add iwd to CONNMAN_DEPENDENCIES?
From what I can tell iwd is only needed at runtime.
>
> Regards,
> Arnout
>
> > +else
> > +CONNMAN_CONF_OPTS += --disable-iwd
> > +endif
> > +
> > +
> > define CONNMAN_INSTALL_INIT_SYSV
> > $(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
> > endef
> >
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/connman: add iwd support
2021-12-21 19:07 ` James Hilliard
@ 2021-12-21 21:47 ` Arnout Vandecappelle
2021-12-22 0:03 ` James Hilliard
0 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-12-21 21:47 UTC (permalink / raw)
To: James Hilliard; +Cc: Martin Bark, buildroot
On 21/12/2021 20:07, James Hilliard wrote:
> On Mon, Dec 20, 2021 at 3:34 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>
>>
>>
>> On 20/12/2021 09:46, James Hilliard wrote:
>>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>>> ---
>>> package/connman/connman.mk | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
>>> index e5e596c973..d3ebb40a1c 100644
>>> --- a/package/connman/connman.mk
>>> +++ b/package/connman/connman.mk
>>> @@ -85,6 +85,13 @@ else
>>> CONNMAN_CONF_OPTS += --disable-wispr
>>> endif
>>>
>>> +ifeq ($(BR2_PACKAGE_IWD),y)
>>> +CONNMAN_CONF_OPTS += --enable-iwd
>>
>> No need to add iwd to CONNMAN_DEPENDENCIES?
>
> From what I can tell iwd is only needed at runtime.
It helps if you mention that in the commit message :-)
Regards,
Arnout
>
>>
>> Regards,
>> Arnout
>>
>>> +else
>>> +CONNMAN_CONF_OPTS += --disable-iwd
>>> +endif
>>> +
>>> +
>>> define CONNMAN_INSTALL_INIT_SYSV
>>> $(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
>>> endef
>>>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/connman: add iwd support
2021-12-21 21:47 ` Arnout Vandecappelle
@ 2021-12-22 0:03 ` James Hilliard
0 siblings, 0 replies; 5+ messages in thread
From: James Hilliard @ 2021-12-22 0:03 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: Martin Bark, buildroot
On Tue, Dec 21, 2021 at 2:47 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 21/12/2021 20:07, James Hilliard wrote:
> > On Mon, Dec 20, 2021 at 3:34 PM Arnout Vandecappelle <arnout@mind.be> wrote:
> >>
> >>
> >>
> >> On 20/12/2021 09:46, James Hilliard wrote:
> >>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> >>> ---
> >>> package/connman/connman.mk | 7 +++++++
> >>> 1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> >>> index e5e596c973..d3ebb40a1c 100644
> >>> --- a/package/connman/connman.mk
> >>> +++ b/package/connman/connman.mk
> >>> @@ -85,6 +85,13 @@ else
> >>> CONNMAN_CONF_OPTS += --disable-wispr
> >>> endif
> >>>
> >>> +ifeq ($(BR2_PACKAGE_IWD),y)
> >>> +CONNMAN_CONF_OPTS += --enable-iwd
> >>
> >> No need to add iwd to CONNMAN_DEPENDENCIES?
> >
> > From what I can tell iwd is only needed at runtime.
>
> It helps if you mention that in the commit message :-)
Added to commit message in v2:
https://patchwork.ozlabs.org/project/buildroot/patch/20211222000241.1894807-1-james.hilliard1@gmail.com/
>
> Regards,
> Arnout
>
> >
> >>
> >> Regards,
> >> Arnout
> >>
> >>> +else
> >>> +CONNMAN_CONF_OPTS += --disable-iwd
> >>> +endif
> >>> +
> >>> +
> >>> define CONNMAN_INSTALL_INIT_SYSV
> >>> $(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
> >>> endef
> >>>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-22 0:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 8:46 [Buildroot] [PATCH 1/1] package/connman: add iwd support James Hilliard
2021-12-20 22:34 ` Arnout Vandecappelle
2021-12-21 19:07 ` James Hilliard
2021-12-21 21:47 ` Arnout Vandecappelle
2021-12-22 0:03 ` James Hilliard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.