All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: <richard@nod.at>, <miquel.raynal@bootlin.com>, <vigneshr@ti.com>,
	<mcoquelin.stm32@gmail.com>, <kirill.shutemov@linux.intel.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<chengzhihao1@huawei.com>
Subject: [PATCH v5 04/14] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
Date: Mon, 20 Dec 2021 21:59:41 +0800	[thread overview]
Message-ID: <20211220135951.4075801-5-chengzhihao1@huawei.com> (raw)
In-Reply-To: <20211220135951.4075801-1-chengzhihao1@huawei.com>

whiteout inode should be put when do_tmpfile() failed if inode has been
initialized. Otherwise we will get following warning during umount:
  UBIFS error (ubi0:0 pid 1494): ubifs_assert_failed [ubifs]: UBIFS
  assert failed: c->bi.dd_growth == 0, in fs/ubifs/super.c:1930
  VFS: Busy inodes after unmount of ubifs. Self-destruct in 5 seconds.

Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 fs/ubifs/dir.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 2735ad1affed..2cbc5f05f671 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -432,6 +432,8 @@ static int do_tmpfile(struct inode *dir, struct dentry *dentry,
 	make_bad_inode(inode);
 	if (!instantiated)
 		iput(inode);
+	else if (whiteout)
+		iput(*whiteout);
 out_budg:
 	ubifs_release_budget(c, &req);
 	if (!instantiated)
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: <richard@nod.at>, <miquel.raynal@bootlin.com>, <vigneshr@ti.com>,
	<mcoquelin.stm32@gmail.com>, <kirill.shutemov@linux.intel.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<chengzhihao1@huawei.com>
Subject: [PATCH v5 04/14] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
Date: Mon, 20 Dec 2021 21:59:41 +0800	[thread overview]
Message-ID: <20211220135951.4075801-5-chengzhihao1@huawei.com> (raw)
In-Reply-To: <20211220135951.4075801-1-chengzhihao1@huawei.com>

whiteout inode should be put when do_tmpfile() failed if inode has been
initialized. Otherwise we will get following warning during umount:
  UBIFS error (ubi0:0 pid 1494): ubifs_assert_failed [ubifs]: UBIFS
  assert failed: c->bi.dd_growth == 0, in fs/ubifs/super.c:1930
  VFS: Busy inodes after unmount of ubifs. Self-destruct in 5 seconds.

Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 fs/ubifs/dir.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 2735ad1affed..2cbc5f05f671 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -432,6 +432,8 @@ static int do_tmpfile(struct inode *dir, struct dentry *dentry,
 	make_bad_inode(inode);
 	if (!instantiated)
 		iput(inode);
+	else if (whiteout)
+		iput(*whiteout);
 out_budg:
 	ubifs_release_budget(c, &req);
 	if (!instantiated)
-- 
2.31.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2021-12-20 13:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20 13:59 [PATCH v5 00/14] Some bugfixs for ubi/ubifs Zhihao Cheng
2021-12-20 13:59 ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 01/14] ubifs: rename_whiteout: Fix double free for whiteout_ui->data Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 02/14] ubifs: Fix deadlock in concurrent rename whiteout and inode writeback Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 03/14] ubifs: Fix wrong number of inodes locked by ui_mutex in ubifs_inode comment Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` Zhihao Cheng [this message]
2021-12-20 13:59   ` [PATCH v5 04/14] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 05/14] ubifs: Rename whiteout atomically Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 06/14] ubifs: Fix 'ui->dirty' race between do_tmpfile() and writeback work Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 07/14] ubifs: Rectify space amount budget for mkdir/tmpfile operations Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 08/14] ubifs: setflags: Make dirtied_ino_d 8 bytes aligned Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 09/14] ubifs: Fix read out-of-bounds in ubifs_wbuf_write_nolock() Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 10/14] ubifs: Fix to add refcount once page is set private Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 11/14] ubi: fastmap: Return error code if memory allocation fails in add_aeb() Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 12/14] ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 13/14] ubifs: ubifs_writepage: Mark page dirty after writing inode failed Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng
2021-12-20 13:59 ` [PATCH v5 14/14] ubifs: ubifs_releasepage: Remove ubifs_assert(0) to valid this process Zhihao Cheng
2021-12-20 13:59   ` Zhihao Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211220135951.4075801-5-chengzhihao1@huawei.com \
    --to=chengzhihao1@huawei.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.