All of lore.kernel.org
 help / color / mirror / Atom feed
* + dma-revert-make-dma-pool-to-use-kmalloc_node.patch added to -mm tree
@ 2021-12-21 22:04 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2021-12-21 22:04 UTC (permalink / raw)
  To: mm-commits, yinghai.lu, rientjes, greg, clameter,
	christian.koenig, ak, ckoenig.leichtzumerken


The patch titled
     Subject: mm/dmapool.c: revert "make dma pool to use kmalloc_node"
has been added to the -mm tree.  Its filename is
     dma-revert-make-dma-pool-to-use-kmalloc_node.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/dma-revert-make-dma-pool-to-use-kmalloc_node.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/dma-revert-make-dma-pool-to-use-kmalloc_node.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: "=?UTF-8?q?Christian=20K=C3=B6nig?=" <ckoenig.leichtzumerken@gmail.com>
Subject: mm/dmapool.c: revert "make dma pool to use kmalloc_node"

This reverts commit 2618c60b8b5836 ("dma: make dma pool to use
kmalloc_node").

While working myself into the dmapool code I've found this little odd
kmalloc_node().

What basically happens here is that we allocate the housekeeping structure
on the numa node where the device is attached to.  Since the device is
never doing DMA to or from that memory this doesn't seem to make sense at
all.

So while this doesn't seem to cause much harm it's probably cleaner to
revert the change for consistency.

Link: https://lkml.kernel.org/r/20211221110724.97664-1-christian.koenig@amd.com
Signed-off-by: Christian König <christian.koenig@amd.com>
Cc: Yinghai Lu <yinghai.lu@sun.com>
Cc: Andi Kleen <ak@suse.de>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/dmapool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/dmapool.c~dma-revert-make-dma-pool-to-use-kmalloc_node
+++ a/mm/dmapool.c
@@ -152,7 +152,7 @@ struct dma_pool *dma_pool_create(const c
 	else if ((boundary < size) || (boundary & (boundary - 1)))
 		return NULL;
 
-	retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
+	retval = kmalloc(sizeof(*retval), GFP_KERNEL);
 	if (!retval)
 		return retval;
 
_

Patches currently in -mm which might be from ckoenig.leichtzumerken@gmail.com are

dma-revert-make-dma-pool-to-use-kmalloc_node.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-21 22:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 22:04 + dma-revert-make-dma-pool-to-use-kmalloc_node.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.