* [PATCH net-next v1] ice: trivial: fix odd indenting
@ 2021-12-21 23:05 Jesse Brandeburg
2021-12-22 23:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jesse Brandeburg @ 2021-12-21 23:05 UTC (permalink / raw)
To: davem, kuba; +Cc: Jesse Brandeburg, netdev, anthony.l.nguyen
Fix an odd indent where some code was left indented, and causes smatch
to warn:
ice_log_pkg_init() warn: inconsistent indenting
While here, for consistency, add a break after the default case.
This commit has a Fixes: but we caught this while it was only in net-next.
Fixes: 247dd97d713c ("ice: Refactor status flow for DDP load")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 865f2231bb24..661b59456742 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -4123,13 +4123,14 @@ static void ice_log_pkg_init(struct ice_hw *hw, enum ice_ddp_state state)
break;
case ICE_DDP_PKG_LOAD_ERROR:
dev_err(dev, "An error occurred on the device while loading the DDP package. The device will be reset.\n");
- /* poll for reset to complete */
- if (ice_check_reset(hw))
- dev_err(dev, "Error resetting device. Please reload the driver\n");
+ /* poll for reset to complete */
+ if (ice_check_reset(hw))
+ dev_err(dev, "Error resetting device. Please reload the driver\n");
break;
case ICE_DDP_PKG_ERR:
default:
dev_err(dev, "An unknown error occurred when loading the DDP package. Entering Safe Mode.\n");
+ break;
}
}
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v1] ice: trivial: fix odd indenting
2021-12-21 23:05 [PATCH net-next v1] ice: trivial: fix odd indenting Jesse Brandeburg
@ 2021-12-22 23:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-12-22 23:10 UTC (permalink / raw)
To: Jesse Brandeburg; +Cc: davem, kuba, netdev, anthony.l.nguyen
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 21 Dec 2021 15:05:38 -0800 you wrote:
> Fix an odd indent where some code was left indented, and causes smatch
> to warn:
> ice_log_pkg_init() warn: inconsistent indenting
>
> While here, for consistency, add a break after the default case.
>
> This commit has a Fixes: but we caught this while it was only in net-next.
>
> [...]
Here is the summary with links:
- [net-next,v1] ice: trivial: fix odd indenting
https://git.kernel.org/netdev/net-next/c/0092db5fac22
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-22 23:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 23:05 [PATCH net-next v1] ice: trivial: fix odd indenting Jesse Brandeburg
2021-12-22 23:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.