* [PATCH] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2021-12-22 6:24 ` Miaoqian Lin
0 siblings, 0 replies; 12+ messages in thread
From: Miaoqian Lin @ 2021-12-22 6:24 UTC (permalink / raw)
Cc: linmq006, Stanley Chu, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel
The function regulator_get() return error pointer,
use IS_ERR() to check if has error.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 5393b5c9dd9c..86a938075f30 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -557,7 +557,7 @@ static void ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
host->reg_va09 = regulator_get(hba->dev, "va09");
- if (!host->reg_va09)
+ if (IS_ERR(host->reg_va09))
dev_info(hba->dev, "failed to get va09");
else
host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2021-12-22 6:24 ` Miaoqian Lin
0 siblings, 0 replies; 12+ messages in thread
From: Miaoqian Lin @ 2021-12-22 6:24 UTC (permalink / raw)
Cc: linmq006, Stanley Chu, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel
The function regulator_get() return error pointer,
use IS_ERR() to check if has error.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 5393b5c9dd9c..86a938075f30 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -557,7 +557,7 @@ static void ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
host->reg_va09 = regulator_get(hba->dev, "va09");
- if (!host->reg_va09)
+ if (IS_ERR(host->reg_va09))
dev_info(hba->dev, "failed to get va09");
else
host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2021-12-22 6:24 ` Miaoqian Lin
0 siblings, 0 replies; 12+ messages in thread
From: Miaoqian Lin @ 2021-12-22 6:24 UTC (permalink / raw)
Cc: linmq006, Stanley Chu, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel
The function regulator_get() return error pointer,
use IS_ERR() to check if has error.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 5393b5c9dd9c..86a938075f30 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -557,7 +557,7 @@ static void ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
host->reg_va09 = regulator_get(hba->dev, "va09");
- if (!host->reg_va09)
+ if (IS_ERR(host->reg_va09))
dev_info(hba->dev, "failed to get va09");
else
host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
--
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
2021-12-22 6:24 ` Miaoqian Lin
(?)
@ 2021-12-22 6:48 ` Chen-Yu Tsai
-1 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2021-12-22 6:48 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Stanley Chu, Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Matthias Brugger, linux-scsi, linux-mediatek,
linux-kernel, linux-arm-kernel
On Wed, Dec 22, 2021 at 2:25 PM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> The function regulator_get() return error pointer,
> use IS_ERR() to check if has error.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Please add
Fixes: cf137b3ea49a ("scsi: ufs-mediatek: Support VA09 regulator operations")
so that the patch has a chance to get picked into stable.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2021-12-22 6:48 ` Chen-Yu Tsai
0 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2021-12-22 6:48 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Stanley Chu, Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Matthias Brugger, linux-scsi, linux-mediatek,
linux-kernel, linux-arm-kernel
On Wed, Dec 22, 2021 at 2:25 PM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> The function regulator_get() return error pointer,
> use IS_ERR() to check if has error.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Please add
Fixes: cf137b3ea49a ("scsi: ufs-mediatek: Support VA09 regulator operations")
so that the patch has a chance to get picked into stable.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2021-12-22 6:48 ` Chen-Yu Tsai
0 siblings, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2021-12-22 6:48 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Stanley Chu, Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Matthias Brugger, linux-scsi, linux-mediatek,
linux-kernel, linux-arm-kernel
On Wed, Dec 22, 2021 at 2:25 PM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> The function regulator_get() return error pointer,
> use IS_ERR() to check if has error.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Please add
Fixes: cf137b3ea49a ("scsi: ufs-mediatek: Support VA09 regulator operations")
so that the patch has a chance to get picked into stable.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v2] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
2021-12-22 6:48 ` Chen-Yu Tsai
(?)
@ 2021-12-22 7:09 ` Miaoqian Lin
-1 siblings, 0 replies; 12+ messages in thread
From: Miaoqian Lin @ 2021-12-22 7:09 UTC (permalink / raw)
Cc: linmq006, Stanley Chu, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel
The function regulator_get() return error pointer,
use IS_ERR() to check if has error.
Fixes: cf137b3ea49a ("scsi: ufs-mediatek: Support VA09 regulator operations")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 5393b5c9dd9c..86a938075f30 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -557,7 +557,7 @@ static void ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
host->reg_va09 = regulator_get(hba->dev, "va09");
- if (!host->reg_va09)
+ if (IS_ERR(host->reg_va09))
dev_info(hba->dev, "failed to get va09");
else
host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2021-12-22 7:09 ` Miaoqian Lin
0 siblings, 0 replies; 12+ messages in thread
From: Miaoqian Lin @ 2021-12-22 7:09 UTC (permalink / raw)
Cc: linmq006, Stanley Chu, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel
The function regulator_get() return error pointer,
use IS_ERR() to check if has error.
Fixes: cf137b3ea49a ("scsi: ufs-mediatek: Support VA09 regulator operations")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 5393b5c9dd9c..86a938075f30 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -557,7 +557,7 @@ static void ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
host->reg_va09 = regulator_get(hba->dev, "va09");
- if (!host->reg_va09)
+ if (IS_ERR(host->reg_va09))
dev_info(hba->dev, "failed to get va09");
else
host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2021-12-22 7:09 ` Miaoqian Lin
0 siblings, 0 replies; 12+ messages in thread
From: Miaoqian Lin @ 2021-12-22 7:09 UTC (permalink / raw)
Cc: linmq006, Stanley Chu, Alim Akhtar, Avri Altman,
James E.J. Bottomley, Martin K. Petersen, Matthias Brugger,
linux-scsi, linux-mediatek, linux-kernel, linux-arm-kernel
The function regulator_get() return error pointer,
use IS_ERR() to check if has error.
Fixes: cf137b3ea49a ("scsi: ufs-mediatek: Support VA09 regulator operations")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 5393b5c9dd9c..86a938075f30 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -557,7 +557,7 @@ static void ufs_mtk_init_va09_pwr_ctrl(struct ufs_hba *hba)
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
host->reg_va09 = regulator_get(hba->dev, "va09");
- if (!host->reg_va09)
+ if (IS_ERR(host->reg_va09))
dev_info(hba->dev, "failed to get va09");
else
host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;
--
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
2021-12-22 7:09 ` Miaoqian Lin
(?)
@ 2022-01-19 4:06 ` Martin K. Petersen
-1 siblings, 0 replies; 12+ messages in thread
From: Martin K. Petersen @ 2022-01-19 4:06 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Martin K . Petersen, linux-kernel, Matthias Brugger, linux-scsi,
Stanley Chu, James E.J. Bottomley, Avri Altman, Alim Akhtar,
linux-arm-kernel, linux-mediatek
On Wed, 22 Dec 2021 07:09:30 +0000, Miaoqian Lin wrote:
> The function regulator_get() return error pointer,
> use IS_ERR() to check if has error.
>
>
Applied to 5.17/scsi-queue, thanks!
[1/1] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
https://git.kernel.org/mkp/scsi/c/3ba880a12df5
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2022-01-19 4:06 ` Martin K. Petersen
0 siblings, 0 replies; 12+ messages in thread
From: Martin K. Petersen @ 2022-01-19 4:06 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Martin K . Petersen, linux-kernel, Matthias Brugger, linux-scsi,
Stanley Chu, James E.J. Bottomley, Avri Altman, Alim Akhtar,
linux-arm-kernel, linux-mediatek
On Wed, 22 Dec 2021 07:09:30 +0000, Miaoqian Lin wrote:
> The function regulator_get() return error pointer,
> use IS_ERR() to check if has error.
>
>
Applied to 5.17/scsi-queue, thanks!
[1/1] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
https://git.kernel.org/mkp/scsi/c/3ba880a12df5
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
@ 2022-01-19 4:06 ` Martin K. Petersen
0 siblings, 0 replies; 12+ messages in thread
From: Martin K. Petersen @ 2022-01-19 4:06 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Martin K . Petersen, linux-kernel, Matthias Brugger, linux-scsi,
Stanley Chu, James E.J. Bottomley, Avri Altman, Alim Akhtar,
linux-arm-kernel, linux-mediatek
On Wed, 22 Dec 2021 07:09:30 +0000, Miaoqian Lin wrote:
> The function regulator_get() return error pointer,
> use IS_ERR() to check if has error.
>
>
Applied to 5.17/scsi-queue, thanks!
[1/1] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl
https://git.kernel.org/mkp/scsi/c/3ba880a12df5
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-01-19 4:08 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 6:24 [PATCH] scsi: ufs: ufs-mediatek : Fix NULL vs IS_ERR checking in ufs_mtk_init_va09_pwr_ctrl Miaoqian Lin
2021-12-22 6:24 ` Miaoqian Lin
2021-12-22 6:24 ` Miaoqian Lin
2021-12-22 6:48 ` Chen-Yu Tsai
2021-12-22 6:48 ` Chen-Yu Tsai
2021-12-22 6:48 ` Chen-Yu Tsai
2021-12-22 7:09 ` [PATCH v2] " Miaoqian Lin
2021-12-22 7:09 ` Miaoqian Lin
2021-12-22 7:09 ` Miaoqian Lin
2022-01-19 4:06 ` Martin K. Petersen
2022-01-19 4:06 ` Martin K. Petersen
2022-01-19 4:06 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.