* [PATCH] sfc: Check null pointer of rx_queue->page_ring
@ 2021-12-20 13:56 Jiasheng Jiang
2021-12-20 14:16 ` Greg KH
2021-12-22 13:03 ` Martin Habets
0 siblings, 2 replies; 4+ messages in thread
From: Jiasheng Jiang @ 2021-12-20 13:56 UTC (permalink / raw)
To: ecree.xilinx, habetsm.xilinx, davem, kuba, ast, daniel, hawk,
john.fastabend
Cc: netdev, linux-kernel, bpf, Jiasheng Jiang
Because of the possible failure of the kcalloc, it should be better to
set rx_queue->page_ptr_mask to 0 when it happens in order to maintain
the consistency.
Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/net/ethernet/sfc/rx_common.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/rx_common.c b/drivers/net/ethernet/sfc/rx_common.c
index 68fc7d317693..0983abc0cc5f 100644
--- a/drivers/net/ethernet/sfc/rx_common.c
+++ b/drivers/net/ethernet/sfc/rx_common.c
@@ -150,7 +150,10 @@ static void efx_init_rx_recycle_ring(struct efx_rx_queue *rx_queue)
efx->rx_bufs_per_page);
rx_queue->page_ring = kcalloc(page_ring_size,
sizeof(*rx_queue->page_ring), GFP_KERNEL);
- rx_queue->page_ptr_mask = page_ring_size - 1;
+ if (!rx_queue->page_ring)
+ rx_queue->page_ptr_mask = 0;
+ else
+ rx_queue->page_ptr_mask = page_ring_size - 1;
}
static void efx_fini_rx_recycle_ring(struct efx_rx_queue *rx_queue)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sfc: Check null pointer of rx_queue->page_ring
2021-12-20 13:56 [PATCH] sfc: Check null pointer of rx_queue->page_ring Jiasheng Jiang
@ 2021-12-20 14:16 ` Greg KH
2021-12-22 13:03 ` Martin Habets
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-12-20 14:16 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: ecree.xilinx, habetsm.xilinx, davem, kuba, ast, daniel, hawk,
john.fastabend, netdev, linux-kernel, bpf
On Mon, Dec 20, 2021 at 09:56:03PM +0800, Jiasheng Jiang wrote:
> Because of the possible failure of the kcalloc, it should be better to
> set rx_queue->page_ptr_mask to 0 when it happens in order to maintain
> the consistency.
>
> Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/net/ethernet/sfc/rx_common.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/rx_common.c b/drivers/net/ethernet/sfc/rx_common.c
> index 68fc7d317693..0983abc0cc5f 100644
> --- a/drivers/net/ethernet/sfc/rx_common.c
> +++ b/drivers/net/ethernet/sfc/rx_common.c
> @@ -150,7 +150,10 @@ static void efx_init_rx_recycle_ring(struct efx_rx_queue *rx_queue)
> efx->rx_bufs_per_page);
> rx_queue->page_ring = kcalloc(page_ring_size,
> sizeof(*rx_queue->page_ring), GFP_KERNEL);
> - rx_queue->page_ptr_mask = page_ring_size - 1;
> + if (!rx_queue->page_ring)
> + rx_queue->page_ptr_mask = 0;
> + else
> + rx_queue->page_ptr_mask = page_ring_size - 1;
> }
Why not return an error?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sfc: Check null pointer of rx_queue->page_ring
2021-12-20 13:56 [PATCH] sfc: Check null pointer of rx_queue->page_ring Jiasheng Jiang
2021-12-20 14:16 ` Greg KH
@ 2021-12-22 13:03 ` Martin Habets
2021-12-22 20:26 ` Jakub Kicinski
1 sibling, 1 reply; 4+ messages in thread
From: Martin Habets @ 2021-12-22 13:03 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: ecree.xilinx, davem, kuba, ast, daniel, hawk, john.fastabend,
netdev, linux-kernel, bpf
On Mon, Dec 20, 2021 at 09:56:03PM +0800, Jiasheng Jiang wrote:
> Because of the possible failure of the kcalloc, it should be better to
> set rx_queue->page_ptr_mask to 0 when it happens in order to maintain
> the consistency.
>
> Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
> ---
> drivers/net/ethernet/sfc/rx_common.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/rx_common.c b/drivers/net/ethernet/sfc/rx_common.c
> index 68fc7d317693..0983abc0cc5f 100644
> --- a/drivers/net/ethernet/sfc/rx_common.c
> +++ b/drivers/net/ethernet/sfc/rx_common.c
> @@ -150,7 +150,10 @@ static void efx_init_rx_recycle_ring(struct efx_rx_queue *rx_queue)
> efx->rx_bufs_per_page);
> rx_queue->page_ring = kcalloc(page_ring_size,
> sizeof(*rx_queue->page_ring), GFP_KERNEL);
> - rx_queue->page_ptr_mask = page_ring_size - 1;
> + if (!rx_queue->page_ring)
> + rx_queue->page_ptr_mask = 0;
> + else
> + rx_queue->page_ptr_mask = page_ring_size - 1;
> }
>
> static void efx_fini_rx_recycle_ring(struct efx_rx_queue *rx_queue)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sfc: Check null pointer of rx_queue->page_ring
2021-12-22 13:03 ` Martin Habets
@ 2021-12-22 20:26 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2021-12-22 20:26 UTC (permalink / raw)
To: Martin Habets, Jiasheng Jiang
Cc: ecree.xilinx, davem, ast, daniel, hawk, john.fastabend, netdev,
linux-kernel, bpf
On Wed, 22 Dec 2021 13:03:56 +0000 Martin Habets wrote:
> On Mon, Dec 20, 2021 at 09:56:03PM +0800, Jiasheng Jiang wrote:
> > Because of the possible failure of the kcalloc, it should be better to
> > set rx_queue->page_ptr_mask to 0 when it happens in order to maintain
> > the consistency.
> >
> > Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
> > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>
> Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-22 20:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 13:56 [PATCH] sfc: Check null pointer of rx_queue->page_ring Jiasheng Jiang
2021-12-20 14:16 ` Greg KH
2021-12-22 13:03 ` Martin Habets
2021-12-22 20:26 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.