* [PATCH RFC 01/13] mmc: bcm2835: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
` (12 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Florian Fainelli, Ray Jui, Scott Branden, Nicolas Saenz Julienne,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/bcm2835.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 8c2361e66277..985079943be7 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -1413,8 +1413,8 @@ static int bcm2835_probe(struct platform_device *pdev)
host->max_clk = clk_get_rate(clk);
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto err;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 01/13] mmc: bcm2835: fix deferred probing
@ 2021-12-23 17:11 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Florian Fainelli, Ray Jui, Scott Branden, Nicolas Saenz Julienne,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/bcm2835.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 8c2361e66277..985079943be7 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -1413,8 +1413,8 @@ static int bcm2835_probe(struct platform_device *pdev)
host->max_clk = clk_get_rate(clk);
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto err;
}
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 01/13] mmc: bcm2835: fix deferred probing
2021-12-23 17:11 ` Sergey Shtylyov
@ 2021-12-24 22:08 ` Florian Fainelli
-1 siblings, 0 replies; 50+ messages in thread
From: Florian Fainelli @ 2021-12-24 22:08 UTC (permalink / raw)
To: Sergey Shtylyov, Ulf Hansson, linux-mmc
Cc: Ray Jui, Scott Branden, Nicolas Saenz Julienne,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel
On 12/23/2021 9:11 AM, Sergey Shtylyov wrote:
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 01/13] mmc: bcm2835: fix deferred probing
@ 2021-12-24 22:08 ` Florian Fainelli
0 siblings, 0 replies; 50+ messages in thread
From: Florian Fainelli @ 2021-12-24 22:08 UTC (permalink / raw)
To: Sergey Shtylyov, Ulf Hansson, linux-mmc
Cc: Ray Jui, Scott Branden, Nicolas Saenz Julienne,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel
On 12/23/2021 9:11 AM, Sergey Shtylyov wrote:
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
` (11 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-amlogic, linux-arm-kernel
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/meson-gx-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 8f36536cb1b6..c765653ee4d0 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto free_host;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2021-12-23 17:11 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-amlogic, linux-arm-kernel
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/meson-gx-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 8f36536cb1b6..c765653ee4d0 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto free_host;
}
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2021-12-23 17:11 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-amlogic, linux-arm-kernel
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/meson-gx-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 8f36536cb1b6..c765653ee4d0 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto free_host;
}
--
2.26.3
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
2021-12-23 17:11 ` Sergey Shtylyov
(?)
@ 2021-12-24 17:35 ` Martin Blumenstingl
-1 siblings, 0 replies; 50+ messages in thread
From: Martin Blumenstingl @ 2021-12-24 17:35 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, linux-mmc, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-amlogic, linux-arm-kernel
Hi Sergey,
thank you for spotting and fixing this!
On Thu, Dec 23, 2021 at 6:12 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
> ")
I suggest putting the ") on the previous line. Most "Fixes" tag I have
seen don't use any line-break at all, even if the line gets long.
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
with above comment addressed you can add my:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Best regards,
Martin
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2021-12-24 17:35 ` Martin Blumenstingl
0 siblings, 0 replies; 50+ messages in thread
From: Martin Blumenstingl @ 2021-12-24 17:35 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, linux-mmc, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-amlogic, linux-arm-kernel
Hi Sergey,
thank you for spotting and fixing this!
On Thu, Dec 23, 2021 at 6:12 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
> ")
I suggest putting the ") on the previous line. Most "Fixes" tag I have
seen don't use any line-break at all, even if the line gets long.
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
with above comment addressed you can add my:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2021-12-24 17:35 ` Martin Blumenstingl
0 siblings, 0 replies; 50+ messages in thread
From: Martin Blumenstingl @ 2021-12-24 17:35 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, linux-mmc, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-amlogic, linux-arm-kernel
Hi Sergey,
thank you for spotting and fixing this!
On Thu, Dec 23, 2021 at 6:12 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
> ")
I suggest putting the ") on the previous line. Most "Fixes" tag I have
seen don't use any line-break at all, even if the line gets long.
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
with above comment addressed you can add my:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
2021-12-24 17:35 ` Martin Blumenstingl
(?)
@ 2021-12-24 17:37 ` Sergey Shtylyov
-1 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-24 17:37 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Ulf Hansson, linux-mmc, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-amlogic, linux-arm-kernel
On 12/24/21 8:35 PM, Martin Blumenstingl wrote:
>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>> permanently instead of the deferred probing. Switch to propagating the error
>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>> can safely ignore it...
>>
>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>> ")
> I suggest putting the ") on the previous line. Most "Fixes" tag I have
> seen don't use any line-break at all, even if the line gets long.
Sorry, was a cut & paste artifact that I didn't notice... :-/
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> with above comment addressed you can add my:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Thank you!
> Best regards,
> Martin
>
MBR, Sergey
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2021-12-24 17:37 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-24 17:37 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Ulf Hansson, linux-mmc, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-amlogic, linux-arm-kernel
On 12/24/21 8:35 PM, Martin Blumenstingl wrote:
>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>> permanently instead of the deferred probing. Switch to propagating the error
>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>> can safely ignore it...
>>
>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>> ")
> I suggest putting the ") on the previous line. Most "Fixes" tag I have
> seen don't use any line-break at all, even if the line gets long.
Sorry, was a cut & paste artifact that I didn't notice... :-/
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> with above comment addressed you can add my:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Thank you!
> Best regards,
> Martin
>
MBR, Sergey
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2021-12-24 17:37 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-24 17:37 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Ulf Hansson, linux-mmc, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-amlogic, linux-arm-kernel
On 12/24/21 8:35 PM, Martin Blumenstingl wrote:
>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>> permanently instead of the deferred probing. Switch to propagating the error
>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>> can safely ignore it...
>>
>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>> ")
> I suggest putting the ") on the previous line. Most "Fixes" tag I have
> seen don't use any line-break at all, even if the line gets long.
Sorry, was a cut & paste artifact that I didn't notice... :-/
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> with above comment addressed you can add my:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Thank you!
> Best regards,
> Martin
>
MBR, Sergey
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
2021-12-23 17:11 ` Sergey Shtylyov
(?)
@ 2023-04-01 6:38 ` Christian Hewitt
-1 siblings, 0 replies; 50+ messages in thread
From: Christian Hewitt @ 2023-04-01 6:38 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
> On 23 Dec 2021, at 9:11 pm, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
> ")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 8f36536cb1b6..c765653ee4d0 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> }
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0) {
> - ret = -EINVAL;
> + if (host->irq < 0) {
> + ret = host->irq;
> goto free_host;
> }
>
Can I ask if this patch/series [0] has been superseded or forgotten or ??
The series it depended upon [1] appears to have been merged a year ago as I
can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
and its ilk”) in upstream code. I’ve had this patch in my testing kernel for
12+ months now with no observable negative impacts so am wondering if it can
be resent and merged or I should drop the patch from my tree?
Thx. Christian
[0] https://www.spinics.net/lists/linux-mmc/msg68102.html
[1] https://marc.info/?l=linux-kernel&m=163623041902285
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2023-04-01 6:38 ` Christian Hewitt
0 siblings, 0 replies; 50+ messages in thread
From: Christian Hewitt @ 2023-04-01 6:38 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
> On 23 Dec 2021, at 9:11 pm, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
> ")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 8f36536cb1b6..c765653ee4d0 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> }
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0) {
> - ret = -EINVAL;
> + if (host->irq < 0) {
> + ret = host->irq;
> goto free_host;
> }
>
Can I ask if this patch/series [0] has been superseded or forgotten or ??
The series it depended upon [1] appears to have been merged a year ago as I
can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
and its ilk”) in upstream code. I’ve had this patch in my testing kernel for
12+ months now with no observable negative impacts so am wondering if it can
be resent and merged or I should drop the patch from my tree?
Thx. Christian
[0] https://www.spinics.net/lists/linux-mmc/msg68102.html
[1] https://marc.info/?l=linux-kernel&m=163623041902285
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2023-04-01 6:38 ` Christian Hewitt
0 siblings, 0 replies; 50+ messages in thread
From: Christian Hewitt @ 2023-04-01 6:38 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
> On 23 Dec 2021, at 9:11 pm, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
> ")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 8f36536cb1b6..c765653ee4d0 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> }
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0) {
> - ret = -EINVAL;
> + if (host->irq < 0) {
> + ret = host->irq;
> goto free_host;
> }
>
Can I ask if this patch/series [0] has been superseded or forgotten or ??
The series it depended upon [1] appears to have been merged a year ago as I
can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
and its ilk”) in upstream code. I’ve had this patch in my testing kernel for
12+ months now with no observable negative impacts so am wondering if it can
be resent and merged or I should drop the patch from my tree?
Thx. Christian
[0] https://www.spinics.net/lists/linux-mmc/msg68102.html
[1] https://marc.info/?l=linux-kernel&m=163623041902285
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
2023-04-01 6:38 ` Christian Hewitt
(?)
@ 2023-04-02 17:58 ` Sergey Shtylyov
-1 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2023-04-02 17:58 UTC (permalink / raw)
To: Christian Hewitt
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
Hello!
On 4/1/23 9:38 AM, Christian Hewitt wrote:
[...]
>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>> permanently instead of the deferred probing. Switch to propagating the error
>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>> can safely ignore it...
>>
>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>> ")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index 8f36536cb1b6..c765653ee4d0 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
>> }
>>
>> host->irq = platform_get_irq(pdev, 0);
>> - if (host->irq <= 0) {
>> - ret = -EINVAL;
>> + if (host->irq < 0) {
>> + ret = host->irq;
>> goto free_host;
>> }
>
> Can I ask if this patch/series [0] has been superseded or forgotten or ??
I'm sorry, I actually did forget to re-post this series, as asked by Ulf.
Partly because the patch that this series depended on took about 4 months to
hit the kernel and partly because I suspended my platform_get_irq() related
work as I got into PATA development and struggling with a static analyzer's
reports...
Also, the series doesn't seem superseded as all the patches still apply,
sometimes with small offsets...
> The series it depended upon [1]
That was a single patch. :-)
> appears to have been merged a year ago as I
> can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
> and its ilk”) in upstream code.
Not a whole year yet but 11 months surely... :-/
> I’ve had this patch in my testing kernel for
> 12+ months now with no observable negative impacts so am wondering if it can
> be resent and merged or I should drop the patch from my tree?
It? You mean my fix patches, surely? Or you mean you care about patch #2
only? Anyway, I need to find the time to refresh/repost it...
> Thx. Christian
>
> [0] https://www.spinics.net/lists/linux-mmc/msg68102.html
> [1] https://marc.info/?l=linux-kernel&m=163623041902285
MBR, Sergey
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2023-04-02 17:58 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2023-04-02 17:58 UTC (permalink / raw)
To: Christian Hewitt
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
Hello!
On 4/1/23 9:38 AM, Christian Hewitt wrote:
[...]
>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>> permanently instead of the deferred probing. Switch to propagating the error
>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>> can safely ignore it...
>>
>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>> ")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index 8f36536cb1b6..c765653ee4d0 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
>> }
>>
>> host->irq = platform_get_irq(pdev, 0);
>> - if (host->irq <= 0) {
>> - ret = -EINVAL;
>> + if (host->irq < 0) {
>> + ret = host->irq;
>> goto free_host;
>> }
>
> Can I ask if this patch/series [0] has been superseded or forgotten or ??
I'm sorry, I actually did forget to re-post this series, as asked by Ulf.
Partly because the patch that this series depended on took about 4 months to
hit the kernel and partly because I suspended my platform_get_irq() related
work as I got into PATA development and struggling with a static analyzer's
reports...
Also, the series doesn't seem superseded as all the patches still apply,
sometimes with small offsets...
> The series it depended upon [1]
That was a single patch. :-)
> appears to have been merged a year ago as I
> can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
> and its ilk”) in upstream code.
Not a whole year yet but 11 months surely... :-/
> I’ve had this patch in my testing kernel for
> 12+ months now with no observable negative impacts so am wondering if it can
> be resent and merged or I should drop the patch from my tree?
It? You mean my fix patches, surely? Or you mean you care about patch #2
only? Anyway, I need to find the time to refresh/repost it...
> Thx. Christian
>
> [0] https://www.spinics.net/lists/linux-mmc/msg68102.html
> [1] https://marc.info/?l=linux-kernel&m=163623041902285
MBR, Sergey
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2023-04-02 17:58 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2023-04-02 17:58 UTC (permalink / raw)
To: Christian Hewitt
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
Hello!
On 4/1/23 9:38 AM, Christian Hewitt wrote:
[...]
>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>> permanently instead of the deferred probing. Switch to propagating the error
>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>> can safely ignore it...
>>
>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>> ")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> ---
>> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index 8f36536cb1b6..c765653ee4d0 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
>> }
>>
>> host->irq = platform_get_irq(pdev, 0);
>> - if (host->irq <= 0) {
>> - ret = -EINVAL;
>> + if (host->irq < 0) {
>> + ret = host->irq;
>> goto free_host;
>> }
>
> Can I ask if this patch/series [0] has been superseded or forgotten or ??
I'm sorry, I actually did forget to re-post this series, as asked by Ulf.
Partly because the patch that this series depended on took about 4 months to
hit the kernel and partly because I suspended my platform_get_irq() related
work as I got into PATA development and struggling with a static analyzer's
reports...
Also, the series doesn't seem superseded as all the patches still apply,
sometimes with small offsets...
> The series it depended upon [1]
That was a single patch. :-)
> appears to have been merged a year ago as I
> can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
> and its ilk”) in upstream code.
Not a whole year yet but 11 months surely... :-/
> I’ve had this patch in my testing kernel for
> 12+ months now with no observable negative impacts so am wondering if it can
> be resent and merged or I should drop the patch from my tree?
It? You mean my fix patches, surely? Or you mean you care about patch #2
only? Anyway, I need to find the time to refresh/repost it...
> Thx. Christian
>
> [0] https://www.spinics.net/lists/linux-mmc/msg68102.html
> [1] https://marc.info/?l=linux-kernel&m=163623041902285
MBR, Sergey
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
2023-04-02 17:58 ` Sergey Shtylyov
(?)
@ 2023-06-08 20:07 ` Sergey Shtylyov
-1 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2023-06-08 20:07 UTC (permalink / raw)
To: Christian Hewitt
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
Hello!
On 4/2/23 8:58 PM, Sergey Shtylyov wrote:
[...]
>>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>>> permanently instead of the deferred probing. Switch to propagating the error
>>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>>> can safely ignore it...
>>>
>>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>>> ")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>> ---
>>> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>>> index 8f36536cb1b6..c765653ee4d0 100644
>>> --- a/drivers/mmc/host/meson-gx-mmc.c
>>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>>> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
>>> }
>>>
>>> host->irq = platform_get_irq(pdev, 0);
>>> - if (host->irq <= 0) {
>>> - ret = -EINVAL;
>>> + if (host->irq < 0) {
>>> + ret = host->irq;
>>> goto free_host;
>>> }
>>
>> Can I ask if this patch/series [0] has been superseded or forgotten or ??
>
> I'm sorry, I actually did forget to re-post this series, as asked by Ulf.
> Partly because the patch that this series depended on took about 4 months to
> hit the kernel and partly because I suspended my platform_get_irq() related
> work as I got into PATA development and struggling with a static analyzer's
> reports...
> Also, the series doesn't seem superseded as all the patches still apply,
> sometimes with small offsets...
>
>> The series it depended upon [1]
>
> That was a single patch. :-)
>
>> appears to have been merged a year ago as I
>> can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
>> and its ilk”) in upstream code.
>
> Not a whole year yet but 11 months surely... :-/
>
>> I’ve had this patch in my testing kernel for
>> 12+ months now with no observable negative impacts so am wondering if it can
>> be resent and merged or I should drop the patch from my tree?
>
> It? You mean my fix patches, surely? Or you mean you care about patch #2
> only? Anyway, I need to find the time to refresh/repost it...
Now that I'm on vacation, I have found the time -- see the v2 series here:
https://lore.kernel.org/all/20230608194519.10665-1-s.shtylyov@omp.ru/
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2023-06-08 20:07 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2023-06-08 20:07 UTC (permalink / raw)
To: Christian Hewitt
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
Hello!
On 4/2/23 8:58 PM, Sergey Shtylyov wrote:
[...]
>>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>>> permanently instead of the deferred probing. Switch to propagating the error
>>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>>> can safely ignore it...
>>>
>>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>>> ")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>> ---
>>> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>>> index 8f36536cb1b6..c765653ee4d0 100644
>>> --- a/drivers/mmc/host/meson-gx-mmc.c
>>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>>> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
>>> }
>>>
>>> host->irq = platform_get_irq(pdev, 0);
>>> - if (host->irq <= 0) {
>>> - ret = -EINVAL;
>>> + if (host->irq < 0) {
>>> + ret = host->irq;
>>> goto free_host;
>>> }
>>
>> Can I ask if this patch/series [0] has been superseded or forgotten or ??
>
> I'm sorry, I actually did forget to re-post this series, as asked by Ulf.
> Partly because the patch that this series depended on took about 4 months to
> hit the kernel and partly because I suspended my platform_get_irq() related
> work as I got into PATA development and struggling with a static analyzer's
> reports...
> Also, the series doesn't seem superseded as all the patches still apply,
> sometimes with small offsets...
>
>> The series it depended upon [1]
>
> That was a single patch. :-)
>
>> appears to have been merged a year ago as I
>> can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
>> and its ilk”) in upstream code.
>
> Not a whole year yet but 11 months surely... :-/
>
>> I’ve had this patch in my testing kernel for
>> 12+ months now with no observable negative impacts so am wondering if it can
>> be resent and merged or I should drop the patch from my tree?
>
> It? You mean my fix patches, surely? Or you mean you care about patch #2
> only? Anyway, I need to find the time to refresh/repost it...
Now that I'm on vacation, I have found the time -- see the v2 series here:
https://lore.kernel.org/all/20230608194519.10665-1-s.shtylyov@omp.ru/
[...]
MBR, Sergey
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 02/13] mmc: meson-gx: fix deferred probing
@ 2023-06-08 20:07 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2023-06-08 20:07 UTC (permalink / raw)
To: Christian Hewitt
Cc: Ulf Hansson, MMC, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, AML, linux-arm-kernel
Hello!
On 4/2/23 8:58 PM, Sergey Shtylyov wrote:
[...]
>>> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
>>> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
>>> permanently instead of the deferred probing. Switch to propagating the error
>>> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
>>> can safely ignore it...
>>>
>>> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking
>>> ")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>> ---
>>> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>>> index 8f36536cb1b6..c765653ee4d0 100644
>>> --- a/drivers/mmc/host/meson-gx-mmc.c
>>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>>> @@ -1182,8 +1182,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
>>> }
>>>
>>> host->irq = platform_get_irq(pdev, 0);
>>> - if (host->irq <= 0) {
>>> - ret = -EINVAL;
>>> + if (host->irq < 0) {
>>> + ret = host->irq;
>>> goto free_host;
>>> }
>>
>> Can I ask if this patch/series [0] has been superseded or forgotten or ??
>
> I'm sorry, I actually did forget to re-post this series, as asked by Ulf.
> Partly because the patch that this series depended on took about 4 months to
> hit the kernel and partly because I suspended my platform_get_irq() related
> work as I got into PATA development and struggling with a static analyzer's
> reports...
> Also, the series doesn't seem superseded as all the patches still apply,
> sometimes with small offsets...
>
>> The series it depended upon [1]
>
> That was a single patch. :-)
>
>> appears to have been merged a year ago as I
>> can see ce753ad1549c ("platform: finally disallow IRQ0 in platform_get_irq()
>> and its ilk”) in upstream code.
>
> Not a whole year yet but 11 months surely... :-/
>
>> I’ve had this patch in my testing kernel for
>> 12+ months now with no observable negative impacts so am wondering if it can
>> be resent and merged or I should drop the patch from my tree?
>
> It? You mean my fix patches, surely? Or you mean you care about patch #2
> only? Anyway, I need to find the time to refresh/repost it...
Now that I'm on vacation, I have found the time -- see the v2 series here:
https://lore.kernel.org/all/20230608194519.10665-1-s.shtylyov@omp.ru/
[...]
MBR, Sergey
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH RFC 03/13] mmc: mtk-sd: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
` (11 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Chaotian Jing, Matthias Brugger, linux-arm-kernel, linux-mediatek
The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 632775217d35..4bd070a458e9 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2590,7 +2590,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
host->irq = platform_get_irq(pdev, 0);
if (host->irq < 0) {
- ret = -EINVAL;
+ ret = host->irq;
goto host_free;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 03/13] mmc: mtk-sd: fix deferred probing
@ 2021-12-23 17:11 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Chaotian Jing, Matthias Brugger, linux-arm-kernel, linux-mediatek
The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 632775217d35..4bd070a458e9 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2590,7 +2590,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
host->irq = platform_get_irq(pdev, 0);
if (host->irq < 0) {
- ret = -EINVAL;
+ ret = host->irq;
goto host_free;
}
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 03/13] mmc: mtk-sd: fix deferred probing
@ 2021-12-23 17:11 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Chaotian Jing, Matthias Brugger, linux-arm-kernel, linux-mediatek
The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 632775217d35..4bd070a458e9 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2590,7 +2590,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
host->irq = platform_get_irq(pdev, 0);
if (host->irq < 0) {
- ret = -EINVAL;
+ ret = host->irq;
goto host_free;
}
--
2.26.3
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 03/13] mmc: mtk-sd: fix deferred probing
2021-12-23 17:11 ` Sergey Shtylyov
(?)
@ 2022-01-04 11:00 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 50+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-01-04 11:00 UTC (permalink / raw)
To: Sergey Shtylyov, Ulf Hansson, linux-mmc
Cc: Chaotian Jing, Matthias Brugger, linux-arm-kernel, linux-mediatek
Il 23/12/21 18:11, Sergey Shtylyov ha scritto:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 632775217d35..4bd070a458e9 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2590,7 +2590,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>
> host->irq = platform_get_irq(pdev, 0);
> if (host->irq < 0) {
> - ret = -EINVAL;
> + ret = host->irq;
> goto host_free;
> }
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 03/13] mmc: mtk-sd: fix deferred probing
@ 2022-01-04 11:00 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 50+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-01-04 11:00 UTC (permalink / raw)
To: Sergey Shtylyov, Ulf Hansson, linux-mmc
Cc: Chaotian Jing, Matthias Brugger, linux-arm-kernel, linux-mediatek
Il 23/12/21 18:11, Sergey Shtylyov ha scritto:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 632775217d35..4bd070a458e9 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2590,7 +2590,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>
> host->irq = platform_get_irq(pdev, 0);
> if (host->irq < 0) {
> - ret = -EINVAL;
> + ret = host->irq;
> goto host_free;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 03/13] mmc: mtk-sd: fix deferred probing
@ 2022-01-04 11:00 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 50+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-01-04 11:00 UTC (permalink / raw)
To: Sergey Shtylyov, Ulf Hansson, linux-mmc
Cc: Chaotian Jing, Matthias Brugger, linux-arm-kernel, linux-mediatek
Il 23/12/21 18:11, Sergey Shtylyov ha scritto:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: 208489032bdd ("mmc: mediatek: Add Mediatek MMC driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 632775217d35..4bd070a458e9 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2590,7 +2590,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
>
> host->irq = platform_get_irq(pdev, 0);
> if (host->irq < 0) {
> - ret = -EINVAL;
> + ret = host->irq;
> goto host_free;
> }
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH RFC 04/13] mmc: mvsdio: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (2 preceding siblings ...)
2021-12-23 17:11 ` Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 18:48 ` Nicolas Pitre
2021-12-23 17:11 ` [PATCH RFC 05/13] mmc: omap: " Sergey Shtylyov
` (9 subsequent siblings)
13 siblings, 1 reply; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Nicolas Pitre
The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/mvsdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
index 629efbe639c4..b4f6a0a2fcb5 100644
--- a/drivers/mmc/host/mvsdio.c
+++ b/drivers/mmc/host/mvsdio.c
@@ -704,7 +704,7 @@ static int mvsd_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return -ENXIO;
+ return irq;
mmc = mmc_alloc_host(sizeof(struct mvsd_host), &pdev->dev);
if (!mmc) {
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 04/13] mmc: mvsdio: fix deferred probing
2021-12-23 17:11 ` [PATCH RFC 04/13] mmc: mvsdio: " Sergey Shtylyov
@ 2021-12-23 18:48 ` Nicolas Pitre
0 siblings, 0 replies; 50+ messages in thread
From: Nicolas Pitre @ 2021-12-23 18:48 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: Ulf Hansson, linux-mmc
On Thu, 23 Dec 2021, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: Nicolas Pitre <nico@fluxnic.net>
> ---
> drivers/mmc/host/mvsdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index 629efbe639c4..b4f6a0a2fcb5 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -704,7 +704,7 @@ static int mvsd_probe(struct platform_device *pdev)
> }
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return -ENXIO;
> + return irq;
>
> mmc = mmc_alloc_host(sizeof(struct mvsd_host), &pdev->dev);
> if (!mmc) {
> --
> 2.26.3
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH RFC 05/13] mmc: omap: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (3 preceding siblings ...)
2021-12-23 17:11 ` [PATCH RFC 04/13] mmc: mvsdio: " Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 17:11 ` [PATCH RFC 06/13] mmc: omap_hsmmc: " Sergey Shtylyov
` (8 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Aaro Koskinen, linux-omap
The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 5e5af34090f1..ecf2a68d0e84 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1343,7 +1343,7 @@ static int mmc_omap_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return -ENXIO;
+ return irq;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host->virt_base = devm_ioremap_resource(&pdev->dev, res);
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 06/13] mmc: omap_hsmmc: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (4 preceding siblings ...)
2021-12-23 17:11 ` [PATCH RFC 05/13] mmc: omap: " Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
` (7 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: linux-omap
The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/omap_hsmmc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 9dafcbf969d9..6d7dd75b7664 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1827,9 +1827,11 @@ static int omap_hsmmc_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- irq = platform_get_irq(pdev, 0);
- if (res == NULL || irq < 0)
+ if (!res)
return -ENXIO;
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;
base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(base))
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 07/13] mmc: owl: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
` (12 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Andreas Färber, Manivannan Sadhasivam, linux-actions,
linux-arm-kernel
The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: ff65ffe46d28 ("mmc: Add Actions Semi Owl SoCs SD/MMC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/owl-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
index 3dc143b03939..679b8b0b310e 100644
--- a/drivers/mmc/host/owl-mmc.c
+++ b/drivers/mmc/host/owl-mmc.c
@@ -638,7 +638,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
owl_host->irq = platform_get_irq(pdev, 0);
if (owl_host->irq < 0) {
- ret = -EINVAL;
+ ret = owl_host->irq;
goto err_release_channel;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 07/13] mmc: owl: fix deferred probing
@ 2021-12-23 17:11 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Andreas Färber, Manivannan Sadhasivam, linux-actions,
linux-arm-kernel
The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: ff65ffe46d28 ("mmc: Add Actions Semi Owl SoCs SD/MMC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/owl-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
index 3dc143b03939..679b8b0b310e 100644
--- a/drivers/mmc/host/owl-mmc.c
+++ b/drivers/mmc/host/owl-mmc.c
@@ -638,7 +638,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
owl_host->irq = platform_get_irq(pdev, 0);
if (owl_host->irq < 0) {
- ret = -EINVAL;
+ ret = owl_host->irq;
goto err_release_channel;
}
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 07/13] mmc: owl: fix deferred probing
2021-12-23 17:11 ` Sergey Shtylyov
@ 2021-12-23 17:32 ` Manivannan Sadhasivam
-1 siblings, 0 replies; 50+ messages in thread
From: Manivannan Sadhasivam @ 2021-12-23 17:32 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, linux-mmc, Andreas Färber, linux-actions,
linux-arm-kernel
On Thu, Dec 23, 2021 at 08:11:56PM +0300, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: ff65ffe46d28 ("mmc: Add Actions Semi Owl SoCs SD/MMC driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/mmc/host/owl-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 3dc143b03939..679b8b0b310e 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -638,7 +638,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
>
> owl_host->irq = platform_get_irq(pdev, 0);
> if (owl_host->irq < 0) {
> - ret = -EINVAL;
> + ret = owl_host->irq;
> goto err_release_channel;
> }
>
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 07/13] mmc: owl: fix deferred probing
@ 2021-12-23 17:32 ` Manivannan Sadhasivam
0 siblings, 0 replies; 50+ messages in thread
From: Manivannan Sadhasivam @ 2021-12-23 17:32 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, linux-mmc, Andreas Färber, linux-actions,
linux-arm-kernel
On Thu, Dec 23, 2021 at 08:11:56PM +0300, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: ff65ffe46d28 ("mmc: Add Actions Semi Owl SoCs SD/MMC driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/mmc/host/owl-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 3dc143b03939..679b8b0b310e 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -638,7 +638,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
>
> owl_host->irq = platform_get_irq(pdev, 0);
> if (owl_host->irq < 0) {
> - ret = -EINVAL;
> + ret = owl_host->irq;
> goto err_release_channel;
> }
>
> --
> 2.26.3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH RFC 08/13] mmc: s3mci: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
` (12 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Ben Dooks, linux-arm-kernel
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: e584e0750213 ("mmc: host: s3cmci: allow probing from device tree")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/s3cmci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index 8d5929a32d34..719a0b9a2c9e 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1573,8 +1573,8 @@ static int s3cmci_probe(struct platform_device *pdev)
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto probe_iounmap;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 08/13] mmc: s3mci: fix deferred probing
@ 2021-12-23 17:11 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Ben Dooks, linux-arm-kernel
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: e584e0750213 ("mmc: host: s3cmci: allow probing from device tree")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/s3cmci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index 8d5929a32d34..719a0b9a2c9e 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1573,8 +1573,8 @@ static int s3cmci_probe(struct platform_device *pdev)
}
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto probe_iounmap;
}
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH RFC 09/13] mmc: sdhci-acpi: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (7 preceding siblings ...)
2021-12-23 17:11 ` Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2022-01-03 8:25 ` Adrian Hunter
2021-12-23 17:11 ` [PATCH RFC 10/13] mmc: sdhci-spear: " Sergey Shtylyov
` (4 subsequent siblings)
13 siblings, 1 reply; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Adrian Hunter
The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 1b7ba57ecc86 ("mmc: sdhci-acpi: Handle return value of platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/sdhci-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index f1ef0d28b0dd..1fa1d2a7bfc9 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -898,7 +898,7 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
host->ops = &sdhci_acpi_ops_dflt;
host->irq = platform_get_irq(pdev, 0);
if (host->irq < 0) {
- err = -EINVAL;
+ err = host->irq;
goto err_free;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 09/13] mmc: sdhci-acpi: fix deferred probing
2021-12-23 17:11 ` [PATCH RFC 09/13] mmc: sdhci-acpi: " Sergey Shtylyov
@ 2022-01-03 8:25 ` Adrian Hunter
0 siblings, 0 replies; 50+ messages in thread
From: Adrian Hunter @ 2022-01-03 8:25 UTC (permalink / raw)
To: Sergey Shtylyov, Ulf Hansson, linux-mmc
On 23/12/2021 19:11, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: 1b7ba57ecc86 ("mmc: sdhci-acpi: Handle return value of platform_get_irq")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index f1ef0d28b0dd..1fa1d2a7bfc9 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -898,7 +898,7 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
> host->ops = &sdhci_acpi_ops_dflt;
> host->irq = platform_get_irq(pdev, 0);
> if (host->irq < 0) {
> - err = -EINVAL;
> + err = host->irq;
> goto err_free;
> }
>
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH RFC 10/13] mmc: sdhci-spear: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (8 preceding siblings ...)
2021-12-23 17:11 ` [PATCH RFC 09/13] mmc: sdhci-acpi: " Sergey Shtylyov
@ 2021-12-23 17:11 ` Sergey Shtylyov
2021-12-27 4:16 ` Viresh Kumar
2022-01-03 8:30 ` Adrian Hunter
2021-12-23 17:12 ` [PATCH RFC 11/13] mmc: sh_mmcif: " Sergey Shtylyov
` (3 subsequent siblings)
13 siblings, 2 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:11 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Adrian Hunter, Viresh Kumar
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: 682798a596a6 ("mmc: sdhci-spear: Handle return value of platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/sdhci-spear.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index d463e2fd5b1a..c79035727b20 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -65,8 +65,8 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = &sdhci_pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto err_host;
}
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 10/13] mmc: sdhci-spear: fix deferred probing
2021-12-23 17:11 ` [PATCH RFC 10/13] mmc: sdhci-spear: " Sergey Shtylyov
@ 2021-12-27 4:16 ` Viresh Kumar
2022-01-03 8:30 ` Adrian Hunter
1 sibling, 0 replies; 50+ messages in thread
From: Viresh Kumar @ 2021-12-27 4:16 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: Ulf Hansson, linux-mmc, Adrian Hunter, Viresh Kumar
On 23-12-21, 20:11, Sergey Shtylyov wrote:
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: 682798a596a6 ("mmc: sdhci-spear: Handle return value of platform_get_irq")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> drivers/mmc/host/sdhci-spear.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
> index d463e2fd5b1a..c79035727b20 100644
> --- a/drivers/mmc/host/sdhci-spear.c
> +++ b/drivers/mmc/host/sdhci-spear.c
> @@ -65,8 +65,8 @@ static int sdhci_probe(struct platform_device *pdev)
> host->hw_name = "sdhci";
> host->ops = &sdhci_pltfm_ops;
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0) {
> - ret = -EINVAL;
> + if (host->irq < 0) {
> + ret = host->irq;
> goto err_host;
> }
> host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 50+ messages in thread* Re: [PATCH RFC 10/13] mmc: sdhci-spear: fix deferred probing
2021-12-23 17:11 ` [PATCH RFC 10/13] mmc: sdhci-spear: " Sergey Shtylyov
2021-12-27 4:16 ` Viresh Kumar
@ 2022-01-03 8:30 ` Adrian Hunter
1 sibling, 0 replies; 50+ messages in thread
From: Adrian Hunter @ 2022-01-03 8:30 UTC (permalink / raw)
To: Sergey Shtylyov, Ulf Hansson, linux-mmc; +Cc: Viresh Kumar
On 23/12/2021 19:11, Sergey Shtylyov wrote:
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: 682798a596a6 ("mmc: sdhci-spear: Handle return value of platform_get_irq")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-spear.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
> index d463e2fd5b1a..c79035727b20 100644
> --- a/drivers/mmc/host/sdhci-spear.c
> +++ b/drivers/mmc/host/sdhci-spear.c
> @@ -65,8 +65,8 @@ static int sdhci_probe(struct platform_device *pdev)
> host->hw_name = "sdhci";
> host->ops = &sdhci_pltfm_ops;
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0) {
> - ret = -EINVAL;
> + if (host->irq < 0) {
> + ret = host->irq;
> goto err_host;
> }
> host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
>
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH RFC 11/13] mmc: sh_mmcif: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (9 preceding siblings ...)
2021-12-23 17:11 ` [PATCH RFC 10/13] mmc: sdhci-spear: " Sergey Shtylyov
@ 2021-12-23 17:12 ` Sergey Shtylyov
2021-12-23 17:12 ` Sergey Shtylyov
` (2 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:12 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/sh_mmcif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index bcc595c70a9f..e12fe29b275c 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -1398,7 +1398,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
irq[0] = platform_get_irq(pdev, 0);
irq[1] = platform_get_irq_optional(pdev, 1);
if (irq[0] < 0)
- return -ENXIO;
+ return irq[0];
reg = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(reg))
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 12/13] mmc: sunxi: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
@ 2021-12-23 17:12 ` Sergey Shtylyov
2021-12-23 17:11 ` Sergey Shtylyov
` (12 subsequent siblings)
13 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:12 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel,
linux-sunxi
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: 2408a08583d ("mmc: sunxi-mmc: Handle return value of platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/sunxi-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 2702736a1c57..b3256708756b 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1340,8 +1340,8 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
return ret;
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto error_disable_mmc;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* [PATCH RFC 12/13] mmc: sunxi: fix deferred probing
@ 2021-12-23 17:12 ` Sergey Shtylyov
0 siblings, 0 replies; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:12 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel,
linux-sunxi
The driver overrides the error codes and IRQ0 returned by platform_get_irq()
to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the error
codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
can safely ignore it...
Fixes: 2408a08583d ("mmc: sunxi-mmc: Handle return value of platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/sunxi-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 2702736a1c57..b3256708756b 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1340,8 +1340,8 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
return ret;
host->irq = platform_get_irq(pdev, 0);
- if (host->irq <= 0) {
- ret = -EINVAL;
+ if (host->irq < 0) {
+ ret = host->irq;
goto error_disable_mmc;
}
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH RFC 13/13] mmc: usdhi60rol0: fix deferred probing
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (11 preceding siblings ...)
2021-12-23 17:12 ` Sergey Shtylyov
@ 2021-12-23 17:12 ` Sergey Shtylyov
2021-12-27 10:45 ` Jesper Nilsson
2021-12-28 16:40 ` [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Ulf Hansson
13 siblings, 1 reply; 50+ messages in thread
From: Sergey Shtylyov @ 2021-12-23 17:12 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc; +Cc: Jesper Nilsson, Lars Persson, linux-arm-kernel
The driver overrides the error codes returned by platform_get_irq() to
-ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error codes upstream.
Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/mmc/host/usdhi6rol0.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
index 99515be6e5e5..2032e4e1ee68 100644
--- a/drivers/mmc/host/usdhi6rol0.c
+++ b/drivers/mmc/host/usdhi6rol0.c
@@ -1757,8 +1757,10 @@ static int usdhi6_probe(struct platform_device *pdev)
irq_cd = platform_get_irq_byname(pdev, "card detect");
irq_sd = platform_get_irq_byname(pdev, "data");
irq_sdio = platform_get_irq_byname(pdev, "SDIO");
- if (irq_sd < 0 || irq_sdio < 0)
- return -ENODEV;
+ if (irq_sd < 0)
+ return irq_sd;
+ if (irq_sdio < 0)
+ return irq_sdio;
mmc = mmc_alloc_host(sizeof(struct usdhi6_host), dev);
if (!mmc)
--
2.26.3
^ permalink raw reply related [flat|nested] 50+ messages in thread* Re: [PATCH RFC 13/13] mmc: usdhi60rol0: fix deferred probing
2021-12-23 17:12 ` [PATCH RFC 13/13] mmc: usdhi60rol0: " Sergey Shtylyov
@ 2021-12-27 10:45 ` Jesper Nilsson
0 siblings, 0 replies; 50+ messages in thread
From: Jesper Nilsson @ 2021-12-27 10:45 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: Ulf Hansson, linux-mmc, Jesper Nilsson, Lars Persson, linux-arm-kernel
On Thu, Dec 23, 2021 at 06:12:02PM +0100, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
>
> Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Looks good to me.
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
` (12 preceding siblings ...)
2021-12-23 17:12 ` [PATCH RFC 13/13] mmc: usdhi60rol0: " Sergey Shtylyov
@ 2021-12-28 16:40 ` Ulf Hansson
13 siblings, 0 replies; 50+ messages in thread
From: Ulf Hansson @ 2021-12-28 16:40 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: linux-mmc
On Thu, 23 Dec 2021 at 18:12, Sergey Shtylyov <s.shtylyov@omp.ru> wrote:
>
> Here are 13 patches against the 'fixes' branch of Ulf Hansson's 'usb.git' repo.
> The affected MMC/SD drivers call platform_get_irq() but override its result
> in case of error which prevents the deferred probing from working. Some of
> these patches logically depend on the previously posted (and yet unmerged)
> patch:
>
> https://marc.info/?l=linux-kernel&m=163623041902285
Alright, so until we get some more progress on the above patch, I will
simply defer this until later.
Please re-submit the series, when it's ready to be picked up for me.
Kind regards
Uffe
>
> Because of that dependency the patches are marked as RFC.
>
> Sergey Shtylyov (13):
> mmc: bcm2835: fix deferred probing
> mmc: meson-gx: fix deferred probing
> mmc: mtk-sd: fix deferred probing
> mmc: mvsdio: fix deferred probing
> mmc: omap: fix deferred probing
> mmc: omap_hsmmc: fix deferred probing
> mmc: owl: fix deferred probing
> mmc: s3mci: fix deferred probing
> mmc: sdhci-acpi: fix deferred probing
> mmc: sdhci-spear: fix deferred probing
> mmc: sh_mmcif: fix deferred probing
> mmc: sunxi: fix deferred probing
> mmc: usdhi60rol0: fix deferred probing
>
> drivers/mmc/host/bcm2835.c | 4 ++--
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> drivers/mmc/host/mtk-sd.c | 2 +-
> drivers/mmc/host/mvsdio.c | 2 +-
> drivers/mmc/host/omap.c | 2 +-
> drivers/mmc/host/omap_hsmmc.c | 6 ++++--
> drivers/mmc/host/owl-mmc.c | 2 +-
> drivers/mmc/host/s3cmci.c | 4 ++--
> drivers/mmc/host/sdhci-acpi.c | 2 +-
> drivers/mmc/host/sdhci-spear.c | 4 ++--
> drivers/mmc/host/sh_mmcif.c | 2 +-
> drivers/mmc/host/sunxi-mmc.c | 4 ++--
> drivers/mmc/host/usdhi6rol0.c | 6 ++++--
> 13 files changed, 24 insertions(+), 20 deletions(-)
>
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 50+ messages in thread