* [PATCH] drivers: net: smc911x: Fix wrong check for irq
@ 2021-12-24 5:12 Jiasheng Jiang
2021-12-24 23:04 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2021-12-24 5:12 UTC (permalink / raw)
To: davem, kuba, colin.king; +Cc: netdev, linux-kernel, Jiasheng Jiang
Because ndev->irq is unsigned, the check is useless.
Therefore, we need to correct the check by using error variable.
Fixes: cb93b3e11d40 ("drivers: net: smc911x: Check for error irq")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/net/ethernet/smsc/smc911x.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c
index dd6f69ced4ee..3118c8b7a8c3 100644
--- a/drivers/net/ethernet/smsc/smc911x.c
+++ b/drivers/net/ethernet/smsc/smc911x.c
@@ -2071,11 +2071,11 @@ static int smc911x_drv_probe(struct platform_device *pdev)
SET_NETDEV_DEV(ndev, &pdev->dev);
ndev->dma = (unsigned char)-1;
- ndev->irq = platform_get_irq(pdev, 0);
- if (ndev->irq < 0) {
- ret = ndev->irq;
+
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
goto release_both;
- }
+ ndev->irq = ret;
lp = netdev_priv(ndev);
lp->netdev = ndev;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: net: smc911x: Fix wrong check for irq
2021-12-24 5:12 [PATCH] drivers: net: smc911x: Fix wrong check for irq Jiasheng Jiang
@ 2021-12-24 23:04 ` Jakub Kicinski
2021-12-25 15:11 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2021-12-24 23:04 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: davem, colin.king, netdev
On Fri, 24 Dec 2021 13:12:54 +0800 Jiasheng Jiang wrote:
> Because ndev->irq is unsigned
It's not..
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: net: smc911x: Fix wrong check for irq
2021-12-24 23:04 ` Jakub Kicinski
@ 2021-12-25 15:11 ` Andrew Lunn
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-12-25 15:11 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: Jiasheng Jiang, davem, colin.king, netdev
On Fri, Dec 24, 2021 at 03:04:25PM -0800, Jakub Kicinski wrote:
> On Fri, 24 Dec 2021 13:12:54 +0800 Jiasheng Jiang wrote:
> > Because ndev->irq is unsigned
>
> It's not..
https://elixir.bootlin.com/linux/v5.16-rc6/source/include/linux/netdevice.h#L2065
Definitely an int.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-25 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-24 5:12 [PATCH] drivers: net: smc911x: Fix wrong check for irq Jiasheng Jiang
2021-12-24 23:04 ` Jakub Kicinski
2021-12-25 15:11 ` Andrew Lunn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.