[PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

[PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

[Shunzhou.Jiang]

Add the bindings for the Amlogic Secure power domains, controlling the
secure power domains.

The bindings targets the Amlogic s4, in which the power domain registers
are in secure world.

Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@amlogic.com>
---
 .../power/amlogic,meson-sec-pwrc.yaml         |  3 ++-
 include/dt-bindings/power/meson-s4-power.h    | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 include/dt-bindings/power/meson-s4-power.h

diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
index 5dae04d2936c..7657721a4e96 100644
--- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
+++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
@@ -12,13 +12,14 @@ maintainers:
   - Jianxin Pan <jianxin.pan@amlogic.com>
 
 description: |+
-  Secure Power Domains used in Meson A1/C1 SoCs, and should be the child node
+  Secure Power Domains used in Meson A1/C1/S4 SoCs, and should be the child node
   of secure-monitor.
 
 properties:
   compatible:
     enum:
       - amlogic,meson-a1-pwrc
+      - amlogic,meson-s4-pwrc
 
   "#power-domain-cells":
     const: 1
diff --git a/include/dt-bindings/power/meson-s4-power.h b/include/dt-bindings/power/meson-s4-power.h
new file mode 100644
index 000000000000..462dd2cb938b
--- /dev/null
+++ b/include/dt-bindings/power/meson-s4-power.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */
+/*
+ * Copyright (c) 2021 Amlogic, Inc.
+ * Author: Shunzhou Jiang <shunzhou.jiang@amlogic.com>
+ */
+
+#ifndef _DT_BINDINGS_MESON_S4_POWER_H
+#define _DT_BINDINGS_MESON_S4_POWER_H
+
+#define PWRC_S4_DOS_HEVC_ID	0
+#define PWRC_S4_DOS_VDEC_ID	1
+#define PWRC_S4_VPU_HDMI_ID	2
+#define PWRC_S4_USB_COMB_ID	3
+#define PWRC_S4_GE2D_ID		4
+#define PWRC_S4_ETH_ID		5
+#define PWRC_S4_DEMOD_ID	6
+#define PWRC_S4_AUDIO_ID	7
+
+#endif
-- 
2.34.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

[Shunzhou.Jiang]

Add the bindings for the Amlogic Secure power domains, controlling the
secure power domains.

The bindings targets the Amlogic s4, in which the power domain registers
are in secure world.

Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@amlogic.com>
---
 .../power/amlogic,meson-sec-pwrc.yaml         |  3 ++-
 include/dt-bindings/power/meson-s4-power.h    | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 include/dt-bindings/power/meson-s4-power.h

diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
index 5dae04d2936c..7657721a4e96 100644
--- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
+++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
@@ -12,13 +12,14 @@ maintainers:
   - Jianxin Pan <jianxin.pan@amlogic.com>
 
 description: |+
-  Secure Power Domains used in Meson A1/C1 SoCs, and should be the child node
+  Secure Power Domains used in Meson A1/C1/S4 SoCs, and should be the child node
   of secure-monitor.
 
 properties:
   compatible:
     enum:
       - amlogic,meson-a1-pwrc
+      - amlogic,meson-s4-pwrc
 
   "#power-domain-cells":
     const: 1
diff --git a/include/dt-bindings/power/meson-s4-power.h b/include/dt-bindings/power/meson-s4-power.h
new file mode 100644
index 000000000000..462dd2cb938b
--- /dev/null
+++ b/include/dt-bindings/power/meson-s4-power.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */
+/*
+ * Copyright (c) 2021 Amlogic, Inc.
+ * Author: Shunzhou Jiang <shunzhou.jiang@amlogic.com>
+ */
+
+#ifndef _DT_BINDINGS_MESON_S4_POWER_H
+#define _DT_BINDINGS_MESON_S4_POWER_H
+
+#define PWRC_S4_DOS_HEVC_ID	0
+#define PWRC_S4_DOS_VDEC_ID	1
+#define PWRC_S4_VPU_HDMI_ID	2
+#define PWRC_S4_USB_COMB_ID	3
+#define PWRC_S4_GE2D_ID		4
+#define PWRC_S4_ETH_ID		5
+#define PWRC_S4_DEMOD_ID	6
+#define PWRC_S4_AUDIO_ID	7
+
+#endif
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

[Martin Blumenstingl]

Hello,

first of all: thanks for working on this!

On Fri, Dec 24, 2021 at 8:17 AM Shunzhou.Jiang
<shunzhou.jiang@amlogic.com> wrote:
>
> Add the bindings for the Amlogic Secure power domains, controlling the
> secure power domains.
Here the spelling of "domains" is correct but in the subject line it's
not (the subject has: doamins)

> The bindings targets the Amlogic s4, in which the power domain registers
> are in secure world.
>
> Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@amlogic.com>
I found your name in an Android kernel maintainers file with a space
(instead of a dot): Shunzhou Jiang
In Germany a space between the names would be correct - but I can't
tell what's right or wrong for your case.

PS: as a small side-note: when using multiple patches we typically
send a cover-letter.
You can use the following patch-set/series as an example: [0]
It's not critical but it certainly helps identify which patches belong together.


Best regards,
Martin


[0] https://lore.kernel.org/linux-amlogic/20211214022100.14841-1-qianggui.song@amlogic.com/T/

Re: [PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

[Martin Blumenstingl]

Hello,

first of all: thanks for working on this!

On Fri, Dec 24, 2021 at 8:17 AM Shunzhou.Jiang
<shunzhou.jiang@amlogic.com> wrote:
>
> Add the bindings for the Amlogic Secure power domains, controlling the
> secure power domains.
Here the spelling of "domains" is correct but in the subject line it's
not (the subject has: doamins)

> The bindings targets the Amlogic s4, in which the power domain registers
> are in secure world.
>
> Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@amlogic.com>
I found your name in an Android kernel maintainers file with a space
(instead of a dot): Shunzhou Jiang
In Germany a space between the names would be correct - but I can't
tell what's right or wrong for your case.

PS: as a small side-note: when using multiple patches we typically
send a cover-letter.
You can use the following patch-set/series as an example: [0]
It's not critical but it certainly helps identify which patches belong together.


Best regards,
Martin


[0] https://lore.kernel.org/linux-amlogic/20211214022100.14841-1-qianggui.song@amlogic.com/T/

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

[Martin Blumenstingl]

Hello,

first of all: thanks for working on this!

On Fri, Dec 24, 2021 at 8:17 AM Shunzhou.Jiang
<shunzhou.jiang@amlogic.com> wrote:
>
> Add the bindings for the Amlogic Secure power domains, controlling the
> secure power domains.
Here the spelling of "domains" is correct but in the subject line it's
not (the subject has: doamins)

> The bindings targets the Amlogic s4, in which the power domain registers
> are in secure world.
>
> Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@amlogic.com>
I found your name in an Android kernel maintainers file with a space
(instead of a dot): Shunzhou Jiang
In Germany a space between the names would be correct - but I can't
tell what's right or wrong for your case.

PS: as a small side-note: when using multiple patches we typically
send a cover-letter.
You can use the following patch-set/series as an example: [0]
It's not critical but it certainly helps identify which patches belong together.


Best regards,
Martin


[0] https://lore.kernel.org/linux-amlogic/20211214022100.14841-1-qianggui.song@amlogic.com/T/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel