All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] freescale: imx8mm_evk: Use IS_ENABLED instead of #ifdef
@ 2021-12-26 17:23 Tommaso Merciai
  2022-02-19 13:08 ` sbabic
  0 siblings, 1 reply; 3+ messages in thread
From: Tommaso Merciai @ 2021-12-26 17:23 UTC (permalink / raw)
  Cc: tomm.merciai, linuxfancy, Peng Fan, Stefano Babic, Fabio Estevam,
	NXP i.MX U-Boot Team, u-boot

Use IS_ENABLED(CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG) to make the code
more readable and fix checkpatch.pl warning

Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
 board/freescale/imx8mm_evk/imx8mm_evk.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/board/freescale/imx8mm_evk/imx8mm_evk.c b/board/freescale/imx8mm_evk/imx8mm_evk.c
index ab55135a97..e0975fcda7 100644
--- a/board/freescale/imx8mm_evk/imx8mm_evk.c
+++ b/board/freescale/imx8mm_evk/imx8mm_evk.c
@@ -60,9 +60,10 @@ int board_mmc_get_env_dev(int devno)
 
 int board_late_init(void)
 {
-#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
-	env_set("board_name", "EVK");
-	env_set("board_rev", "iMX8MM");
-#endif
+	if (IS_ENABLED(CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG)) {
+		env_set("board_name", "EVK");
+		env_set("board_rev", "iMX8MM");
+	}
+
 	return 0;
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] freescale: imx8mm_evk: Use IS_ENABLED instead of #ifdef
  2021-12-26 17:23 [PATCH] freescale: imx8mm_evk: Use IS_ENABLED instead of #ifdef Tommaso Merciai
@ 2022-02-19 13:08 ` sbabic
  2022-02-24  9:29   ` Tommaso Merciai
  0 siblings, 1 reply; 3+ messages in thread
From: sbabic @ 2022-02-19 13:08 UTC (permalink / raw)
  To: Tommaso Merciai, u-boot

> Use IS_ENABLED(CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG) to make the code
> more readable and fix checkpatch.pl warning
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] freescale: imx8mm_evk: Use IS_ENABLED instead of #ifdef
  2022-02-19 13:08 ` sbabic
@ 2022-02-24  9:29   ` Tommaso Merciai
  0 siblings, 0 replies; 3+ messages in thread
From: Tommaso Merciai @ 2022-02-24  9:29 UTC (permalink / raw)
  To: sbabic; +Cc: Tommaso Merciai, u-boot

On Sat, Feb 19, 2022 at 02:08:09PM +0100, sbabic@denx.de wrote:
> > Use IS_ENABLED(CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG) to make the code
> > more readable and fix checkpatch.pl warning
> > Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> Applied to u-boot-imx, master, thanks !

Hi Stefano,
Thanks for the update.

Tommaso
> 
> Best regards,
> Stefano Babic
> 
> -- 
> =====================================================================
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> =====================================================================

-- 
Tommaso Merciai
Embedded Linux Developer
tommaso.merciai@amarulasolutions.com
__________________________________

Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-24  9:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-26 17:23 [PATCH] freescale: imx8mm_evk: Use IS_ENABLED instead of #ifdef Tommaso Merciai
2022-02-19 13:08 ` sbabic
2022-02-24  9:29   ` Tommaso Merciai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.