* [PATCH kernel-next] kernel: remove redundant result variable
@ 2021-12-15 5:59 ` cgel.zte
0 siblings, 0 replies; 3+ messages in thread
From: cgel.zte @ 2021-12-15 5:59 UTC (permalink / raw)
To: ebiederm; +Cc: kexec, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value from kimage_add_entry() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
kernel/kexec_core.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 5a5d192a89ac..574391de1f83 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -561,23 +561,17 @@ static int kimage_add_entry(struct kimage *image, kimage_entry_t entry)
static int kimage_set_destination(struct kimage *image,
unsigned long destination)
{
- int result;
-
destination &= PAGE_MASK;
- result = kimage_add_entry(image, destination | IND_DESTINATION);
- return result;
+ return kimage_add_entry(image, destination | IND_DESTINATION);
}
static int kimage_add_page(struct kimage *image, unsigned long page)
{
- int result;
-
page &= PAGE_MASK;
- result = kimage_add_entry(image, page | IND_SOURCE);
- return result;
+ return kimage_add_entry(image, page | IND_SOURCE);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH kernel-next] kernel: remove redundant result variable
@ 2021-12-15 5:59 ` cgel.zte
0 siblings, 0 replies; 3+ messages in thread
From: cgel.zte @ 2021-12-15 5:59 UTC (permalink / raw)
To: ebiederm; +Cc: kexec, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value from kimage_add_entry() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
kernel/kexec_core.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 5a5d192a89ac..574391de1f83 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -561,23 +561,17 @@ static int kimage_add_entry(struct kimage *image, kimage_entry_t entry)
static int kimage_set_destination(struct kimage *image,
unsigned long destination)
{
- int result;
-
destination &= PAGE_MASK;
- result = kimage_add_entry(image, destination | IND_DESTINATION);
- return result;
+ return kimage_add_entry(image, destination | IND_DESTINATION);
}
static int kimage_add_page(struct kimage *image, unsigned long page)
{
- int result;
-
page &= PAGE_MASK;
- result = kimage_add_entry(image, page | IND_SOURCE);
- return result;
+ return kimage_add_entry(image, page | IND_SOURCE);
}
--
2.25.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH kernel-next] kernel: remove redundant result variable
2021-12-15 5:59 ` cgel.zte
(?)
@ 2021-12-27 7:19 ` Baoquan He
-1 siblings, 0 replies; 3+ messages in thread
From: Baoquan He @ 2021-12-27 7:19 UTC (permalink / raw)
To: cgel.zte; +Cc: ebiederm, kexec, Minghao Chi, Zeal Robot
On 12/15/21 at 05:59am, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from kimage_add_entry() directly instead
> of taking this in another redundant variable.
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Nice clean up, looks good to me. Thx.
Acked-by: Baoquan He <bhe@redhat.com>
>
> ---
> kernel/kexec_core.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 5a5d192a89ac..574391de1f83 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -561,23 +561,17 @@ static int kimage_add_entry(struct kimage *image, kimage_entry_t entry)
> static int kimage_set_destination(struct kimage *image,
> unsigned long destination)
> {
> - int result;
> -
> destination &= PAGE_MASK;
> - result = kimage_add_entry(image, destination | IND_DESTINATION);
>
> - return result;
> + return kimage_add_entry(image, destination | IND_DESTINATION);
> }
>
>
> static int kimage_add_page(struct kimage *image, unsigned long page)
> {
> - int result;
> -
> page &= PAGE_MASK;
> - result = kimage_add_entry(image, page | IND_SOURCE);
>
> - return result;
> + return kimage_add_entry(image, page | IND_SOURCE);
> }
>
>
> --
> 2.25.1
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-27 7:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 5:59 [PATCH kernel-next] kernel: remove redundant result variable cgel.zte
2021-12-15 5:59 ` cgel.zte
2021-12-27 7:19 ` Baoquan He
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.