From: Jeffle Xu <jefflexu@linux.alibaba.com> To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org Cc: linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org Subject: [PATCH v1 02/23] cachefiles: add mode command to distinguish modes Date: Mon, 27 Dec 2021 20:54:23 +0800 [thread overview] Message-ID: <20211227125444.21187-3-jefflexu@linux.alibaba.com> (raw) In-Reply-To: <20211227125444.21187-1-jefflexu@linux.alibaba.com> Add one flag bit to distinguish the new introduced demand-read mode from the original mode. User daemon could set the specified mode with 'mode' command. If user daemon doesn't ever explicitly set the mode, then the behaviour is the same with that prior this patch, i.e. cachefiles serves as the local cache for remote fs by default. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> --- fs/cachefiles/daemon.c | 32 ++++++++++++++++++++++++++++++++ fs/cachefiles/internal.h | 1 + 2 files changed, 33 insertions(+) diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c index 871f1e0f423d..892a9bdba53f 100644 --- a/fs/cachefiles/daemon.c +++ b/fs/cachefiles/daemon.c @@ -41,6 +41,7 @@ static int cachefiles_daemon_dir(struct cachefiles_cache *, char *); static int cachefiles_daemon_inuse(struct cachefiles_cache *, char *); static int cachefiles_daemon_secctx(struct cachefiles_cache *, char *); static int cachefiles_daemon_tag(struct cachefiles_cache *, char *); +static int cachefiles_daemon_mode(struct cachefiles_cache *, char *); static int cachefiles_daemon_bind(struct cachefiles_cache *, char *); static void cachefiles_daemon_unbind(struct cachefiles_cache *); @@ -83,6 +84,7 @@ static const struct cachefiles_daemon_cmd cachefiles_daemon_cmds[] = { { "inuse", cachefiles_daemon_inuse }, { "secctx", cachefiles_daemon_secctx }, { "tag", cachefiles_daemon_tag }, + { "mode", cachefiles_daemon_mode }, { "", NULL } }; @@ -671,6 +673,36 @@ static int cachefiles_daemon_inuse(struct cachefiles_cache *cache, char *args) return -EINVAL; } +/* + * Set the cache mode + * - command: "mode cache|demand" + */ +static int cachefiles_daemon_mode(struct cachefiles_cache *cache, char *args) +{ + _enter(",%s", args); + + if (test_bit(CACHEFILES_READY, &cache->flags)) { + pr_err("Cache already started\n"); + return -EINVAL; + } + + if (!*args) { + pr_err("Empty mode specified\n"); + return -EINVAL; + } + + if (!strncmp(args, "cache", strlen("cache"))) { + clear_bit(CACHEFILES_DEMAND_MODE, &cache->flags); + } else if (!strncmp(args, "demand", strlen("demand"))) { + set_bit(CACHEFILES_DEMAND_MODE, &cache->flags); + } else { + pr_err("Invalid mode specified\n"); + return -EINVAL; + } + + return 0; +} + /* * Bind a directory as a cache */ diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h index e0ed811d628d..a8e6500889d7 100644 --- a/fs/cachefiles/internal.h +++ b/fs/cachefiles/internal.h @@ -98,6 +98,7 @@ struct cachefiles_cache { #define CACHEFILES_DEAD 1 /* T if cache dead */ #define CACHEFILES_CULLING 2 /* T if cull engaged */ #define CACHEFILES_STATE_CHANGED 3 /* T if state changed (poll trigger) */ +#define CACHEFILES_DEMAND_MODE 4 /* T if works in demand read mode for read-only fs */ char *rootdirname; /* name of cache root directory */ char *secctx; /* LSM security context */ char *tag; /* cache binding tag */ -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Jeffle Xu <jefflexu@linux.alibaba.com> To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org Cc: tao.peng@linux.alibaba.com, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, linux-fsdevel@vger.kernel.org, eguan@linux.alibaba.com, gerry@linux.alibaba.com Subject: [PATCH v1 02/23] cachefiles: add mode command to distinguish modes Date: Mon, 27 Dec 2021 20:54:23 +0800 [thread overview] Message-ID: <20211227125444.21187-3-jefflexu@linux.alibaba.com> (raw) In-Reply-To: <20211227125444.21187-1-jefflexu@linux.alibaba.com> Add one flag bit to distinguish the new introduced demand-read mode from the original mode. User daemon could set the specified mode with 'mode' command. If user daemon doesn't ever explicitly set the mode, then the behaviour is the same with that prior this patch, i.e. cachefiles serves as the local cache for remote fs by default. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> --- fs/cachefiles/daemon.c | 32 ++++++++++++++++++++++++++++++++ fs/cachefiles/internal.h | 1 + 2 files changed, 33 insertions(+) diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c index 871f1e0f423d..892a9bdba53f 100644 --- a/fs/cachefiles/daemon.c +++ b/fs/cachefiles/daemon.c @@ -41,6 +41,7 @@ static int cachefiles_daemon_dir(struct cachefiles_cache *, char *); static int cachefiles_daemon_inuse(struct cachefiles_cache *, char *); static int cachefiles_daemon_secctx(struct cachefiles_cache *, char *); static int cachefiles_daemon_tag(struct cachefiles_cache *, char *); +static int cachefiles_daemon_mode(struct cachefiles_cache *, char *); static int cachefiles_daemon_bind(struct cachefiles_cache *, char *); static void cachefiles_daemon_unbind(struct cachefiles_cache *); @@ -83,6 +84,7 @@ static const struct cachefiles_daemon_cmd cachefiles_daemon_cmds[] = { { "inuse", cachefiles_daemon_inuse }, { "secctx", cachefiles_daemon_secctx }, { "tag", cachefiles_daemon_tag }, + { "mode", cachefiles_daemon_mode }, { "", NULL } }; @@ -671,6 +673,36 @@ static int cachefiles_daemon_inuse(struct cachefiles_cache *cache, char *args) return -EINVAL; } +/* + * Set the cache mode + * - command: "mode cache|demand" + */ +static int cachefiles_daemon_mode(struct cachefiles_cache *cache, char *args) +{ + _enter(",%s", args); + + if (test_bit(CACHEFILES_READY, &cache->flags)) { + pr_err("Cache already started\n"); + return -EINVAL; + } + + if (!*args) { + pr_err("Empty mode specified\n"); + return -EINVAL; + } + + if (!strncmp(args, "cache", strlen("cache"))) { + clear_bit(CACHEFILES_DEMAND_MODE, &cache->flags); + } else if (!strncmp(args, "demand", strlen("demand"))) { + set_bit(CACHEFILES_DEMAND_MODE, &cache->flags); + } else { + pr_err("Invalid mode specified\n"); + return -EINVAL; + } + + return 0; +} + /* * Bind a directory as a cache */ diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h index e0ed811d628d..a8e6500889d7 100644 --- a/fs/cachefiles/internal.h +++ b/fs/cachefiles/internal.h @@ -98,6 +98,7 @@ struct cachefiles_cache { #define CACHEFILES_DEAD 1 /* T if cache dead */ #define CACHEFILES_CULLING 2 /* T if cull engaged */ #define CACHEFILES_STATE_CHANGED 3 /* T if state changed (poll trigger) */ +#define CACHEFILES_DEMAND_MODE 4 /* T if works in demand read mode for read-only fs */ char *rootdirname; /* name of cache root directory */ char *secctx; /* LSM security context */ char *tag; /* cache binding tag */ -- 2.27.0
next prev parent reply other threads:[~2021-12-27 12:54 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-27 12:54 [PATCH v1 00/23] fscache,erofs: fscache-based demand-read semantics Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 01/23] cachefiles: add cachefiles_demand devnode Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-28 2:47 ` Joseph Qi 2021-12-28 2:47 ` Joseph Qi 2021-12-28 12:34 ` JeffleXu 2021-12-28 12:34 ` JeffleXu 2021-12-27 12:54 ` Jeffle Xu [this message] 2021-12-27 12:54 ` [PATCH v1 02/23] cachefiles: add mode command to distinguish modes Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 03/23] cachefiles: detect backing file size in demand-read mode Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 04/23] netfs: make ops->init_rreq() optional Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 05/23] netfs: add inode parameter to netfs_alloc_read_request() Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2022-01-04 14:00 ` Gao Xiang 2022-01-04 14:00 ` Gao Xiang 2022-01-13 3:10 ` [Linux-cachefs] " JeffleXu 2022-01-13 3:10 ` JeffleXu 2022-01-13 12:09 ` Gao Xiang 2022-01-13 12:09 ` Gao Xiang 2021-12-27 12:54 ` [PATCH v1 06/23] erofs: export erofs_map_blocks() Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 07/23] erofs: add nodev mode Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2022-01-04 14:33 ` Gao Xiang 2022-01-04 14:33 ` Gao Xiang 2022-01-04 14:58 ` Gao Xiang 2022-01-04 14:58 ` Gao Xiang 2022-01-05 9:04 ` JeffleXu 2021-12-27 12:54 ` [PATCH v1 08/23] erofs: register global fscache volume Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 09/23] erofs: add cookie context helper functions Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 10/23] erofs: add anonymous inode managing page cache of blob file Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 11/23] erofs: register cookie context for bootstrap Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 12/23] erofs: implement fscache-based metadata read Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 17:07 ` kernel test robot 2021-12-27 17:07 ` kernel test robot 2021-12-27 17:07 ` kernel test robot 2021-12-27 17:17 ` kernel test robot 2021-12-27 17:17 ` kernel test robot 2021-12-27 17:17 ` kernel test robot 2021-12-27 12:54 ` [PATCH v1 13/23] erofs: implement fscache-based data read Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2022-01-03 6:32 ` JeffleXu 2022-01-03 6:32 ` JeffleXu 2022-01-04 14:40 ` Gao Xiang 2022-01-04 14:40 ` Gao Xiang 2022-01-05 2:29 ` JeffleXu 2021-12-27 12:54 ` [PATCH v1 14/23] erofs: register cookie context for data blobs Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 15/23] erofs: implement fscache-based data read " Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 16/23] erofs: add 'uuid' mount option Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 17/23] netfs: support on demand read Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 18/23] cachefiles: use idr tree managing pending " Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 19/23] cachefiles: implement .demand_read() for " Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 15:32 ` kernel test robot 2021-12-27 15:32 ` kernel test robot 2021-12-27 15:32 ` kernel test robot 2021-12-27 15:36 ` Matthew Wilcox 2021-12-27 15:36 ` Matthew Wilcox 2021-12-28 12:33 ` JeffleXu 2021-12-28 12:33 ` JeffleXu 2022-01-12 9:02 ` JeffleXu 2022-01-12 9:02 ` JeffleXu 2022-01-19 13:20 ` Matthew Wilcox 2022-01-19 13:20 ` Matthew Wilcox 2022-01-20 12:43 ` JeffleXu 2022-01-20 12:43 ` JeffleXu 2021-12-27 15:55 ` kernel test robot 2021-12-27 15:55 ` kernel test robot 2021-12-27 15:55 ` kernel test robot 2021-12-27 12:54 ` [PATCH v1 20/23] cachefiles: implement .poll() " Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 21/23] cachefiles: implement .read() " Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 22/23] cachefiles: add done command " Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu 2021-12-27 12:54 ` [PATCH v1 23/23] erofs: support on " Jeffle Xu 2021-12-27 12:54 ` Jeffle Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211227125444.21187-3-jefflexu@linux.alibaba.com \ --to=jefflexu@linux.alibaba.com \ --cc=bo.liu@linux.alibaba.com \ --cc=chao@kernel.org \ --cc=dhowells@redhat.com \ --cc=eguan@linux.alibaba.com \ --cc=gerry@linux.alibaba.com \ --cc=joseph.qi@linux.alibaba.com \ --cc=linux-cachefs@redhat.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tao.peng@linux.alibaba.com \ --cc=xiang@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.