All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Hector Martin <marcan@marcan.st>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [PATCH 25/34] brcmfmac: cfg80211: Add support for PMKID_V3 operations
Date: Mon, 27 Dec 2021 23:01:53 +0800	[thread overview]
Message-ID: <202112272226.cnd1yX00-lkp@intel.com> (raw)
In-Reply-To: <20211226153624.162281-26-marcan@marcan.st>

Hi Hector,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvalo-wireless-drivers-next/master]
[also build test WARNING on kvalo-wireless-drivers/master rafael-pm/linux-next net-next/master net/master robh/for-next linus/master v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hector-Martin/brcmfmac-Support-Apple-T2-and-M1-platforms/20211226-234246
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arm-randconfig-r023-20211227 (https://download.01.org/0day-ci/archive/20211227/202112272226.cnd1yX00-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 511726c64d3b6cca66f7c54d457d586aa3129f67)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/4077393e01c6f0a14a1ba9afa8d2c56dabd4f1fc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hector-Martin/brcmfmac-Support-Apple-T2-and-M1-platforms/20211226-234246
        git checkout 4077393e01c6f0a14a1ba9afa8d2c56dabd4f1fc
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/net/wireless/broadcom/brcm80211/brcmfmac/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:4195:1: warning: stack frame size (1824) exceeds limit (1024) in 'brcmf_cfg80211_flush_pmksa' [-Wframe-larger-than]
   brcmf_cfg80211_flush_pmksa(struct wiphy *wiphy, struct net_device *ndev)
   ^
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:4054:1: warning: stack frame size (1832) exceeds limit (1024) in 'brcmf_pmksa_v3_op' [-Wframe-larger-than]
   brcmf_pmksa_v3_op(struct brcmf_if *ifp, struct cfg80211_pmksa *pmksa,
   ^
   2 warnings generated.


vim +/brcmf_cfg80211_flush_pmksa +4195 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4052  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4053  static s32
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27 @4054  brcmf_pmksa_v3_op(struct brcmf_if *ifp, struct cfg80211_pmksa *pmksa,
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4055  		  bool alive)
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4056  {
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4057  	struct brcmf_pmk_op_v3_le pmk_op;
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4058  	int length = offsetof(struct brcmf_pmk_op_v3_le, pmk);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4059  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4060  	memset(&pmk_op, 0, sizeof(pmk_op));
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4061  	pmk_op.version = cpu_to_le16(BRCMF_PMKSA_VER_3);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4062  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4063  	if (!pmksa) {
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4064  		/* Flush operation, operate on entire list */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4065  		pmk_op.count = cpu_to_le16(0);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4066  	} else {
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4067  		/* Single PMK operation */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4068  		pmk_op.count = cpu_to_le16(1);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4069  		length += sizeof(struct brcmf_pmksa_v3);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4070  		memcpy(pmk_op.pmk[0].bssid, pmksa->bssid, ETH_ALEN);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4071  		memcpy(pmk_op.pmk[0].pmkid, pmksa->pmkid, WLAN_PMKID_LEN);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4072  		pmk_op.pmk[0].pmkid_len = WLAN_PMKID_LEN;
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4073  		pmk_op.pmk[0].time_left = alive ? BRCMF_PMKSA_NO_EXPIRY : 0;
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4074  	}
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4075  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4076  	pmk_op.length = cpu_to_le16(length);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4077  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4078  	return brcmf_fil_iovar_data_set(ifp, "pmkid_info", &pmk_op, sizeof(pmk_op));
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4079  }
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4080  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4081  static __used s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4082  brcmf_update_pmklist(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4083  {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4084  	struct brcmf_pmk_list_le *pmk_list;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4085  	int i;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4086  	u32 npmk;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4087  	s32 err;
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4088  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4089  	pmk_list = &cfg->pmk_list;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4090  	npmk = le32_to_cpu(pmk_list->npmk);
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4091  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4092  	brcmf_dbg(CONN, "No of elements %d\n", npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4093  	for (i = 0; i < npmk; i++)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4094  		brcmf_dbg(CONN, "PMK[%d]: %pM\n", i, &pmk_list->pmk[i].bssid);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4095  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4096  	err = brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4097  				       sizeof(*pmk_list));
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4098  
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4099  	return err;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4100  }
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4101  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4102  static s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4103  brcmf_cfg80211_set_pmksa(struct wiphy *wiphy, struct net_device *ndev,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4104  			 struct cfg80211_pmksa *pmksa)
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4105  {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4106  	struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
c1179033228504 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-10-22  4107  	struct brcmf_if *ifp = netdev_priv(ndev);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4108  	struct brcmf_pmksa *pmk = &cfg->pmk_list.pmk[0];
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4109  	struct brcmf_pub *drvr = cfg->pub;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4110  	s32 err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4111  	u32 npmk, i;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4112  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4113  	brcmf_dbg(TRACE, "Enter\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4114  	if (!check_vif_up(ifp->vif))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4115  		return -EIO;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4116  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4117  	brcmf_dbg(CONN, "set_pmksa - PMK bssid: %pM =\n", pmksa->bssid);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4118  	brcmf_dbg(CONN, "%*ph\n", WLAN_PMKID_LEN, pmksa->pmkid);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4119  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4120  	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_PMKID_V3))
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4121  		return brcmf_pmksa_v3_op(ifp, pmksa, true);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4122  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4123  	/* TODO: implement PMKID_V2 */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4124  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4125  	npmk = le32_to_cpu(cfg->pmk_list.npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4126  	for (i = 0; i < npmk; i++)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4127  		if (!memcmp(pmksa->bssid, pmk[i].bssid, ETH_ALEN))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4128  			break;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4129  	if (i < BRCMF_MAXPMKID) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4130  		memcpy(pmk[i].bssid, pmksa->bssid, ETH_ALEN);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4131  		memcpy(pmk[i].pmkid, pmksa->pmkid, WLAN_PMKID_LEN);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4132  		if (i == npmk) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4133  			npmk++;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4134  			cfg->pmk_list.npmk = cpu_to_le32(npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4135  		}
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4136  	} else {
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4137  		bphy_err(drvr, "Too many PMKSA entries cached %d\n", npmk);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4138  		return -EINVAL;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4139  	}
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4140  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4141  	err = brcmf_update_pmklist(cfg, ifp);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4142  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4143  	brcmf_dbg(TRACE, "Exit\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4144  	return err;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4145  }
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4146  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4147  static s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4148  brcmf_cfg80211_del_pmksa(struct wiphy *wiphy, struct net_device *ndev,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4149  			 struct cfg80211_pmksa *pmksa)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4150  {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4151  	struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4152  	struct brcmf_if *ifp = netdev_priv(ndev);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4153  	struct brcmf_pmksa *pmk = &cfg->pmk_list.pmk[0];
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4154  	struct brcmf_pub *drvr = cfg->pub;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4155  	s32 err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4156  	u32 npmk, i;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4157  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4158  	brcmf_dbg(TRACE, "Enter\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4159  	if (!check_vif_up(ifp->vif))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4160  		return -EIO;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4161  
7703773ef1d85b drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Nicolas Iooss    2016-08-23  4162  	brcmf_dbg(CONN, "del_pmksa - PMK bssid = %pM\n", pmksa->bssid);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4163  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4164  	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_PMKID_V3))
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4165  		return brcmf_pmksa_v3_op(ifp, pmksa, false);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4166  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4167  	/* TODO: implement PMKID_V2 */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4168  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4169  	npmk = le32_to_cpu(cfg->pmk_list.npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4170  	for (i = 0; i < npmk; i++)
7703773ef1d85b drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Nicolas Iooss    2016-08-23  4171  		if (!memcmp(pmksa->bssid, pmk[i].bssid, ETH_ALEN))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4172  			break;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4173  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4174  	if ((npmk > 0) && (i < npmk)) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4175  		for (; i < (npmk - 1); i++) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4176  			memcpy(&pmk[i].bssid, &pmk[i + 1].bssid, ETH_ALEN);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4177  			memcpy(&pmk[i].pmkid, &pmk[i + 1].pmkid,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4178  			       WLAN_PMKID_LEN);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4179  		}
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4180  		memset(&pmk[i], 0, sizeof(*pmk));
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4181  		cfg->pmk_list.npmk = cpu_to_le32(npmk - 1);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4182  	} else {
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4183  		bphy_err(drvr, "Cache entry not found\n");
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4184  		return -EINVAL;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4185  	}
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4186  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4187  	err = brcmf_update_pmklist(cfg, ifp);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4188  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4189  	brcmf_dbg(TRACE, "Exit\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4190  	return err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4191  
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4192  }
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4193  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4194  static s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05 @4195  brcmf_cfg80211_flush_pmksa(struct wiphy *wiphy, struct net_device *ndev)
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4196  {
27a68fe391231b drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-27  4197  	struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4198  	struct brcmf_if *ifp = netdev_priv(ndev);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4199  	s32 err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4200  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4201  	brcmf_dbg(TRACE, "Enter\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4202  	if (!check_vif_up(ifp->vif))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4203  		return -EIO;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4204  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4205  	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_PMKID_V3))
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4206  		return brcmf_pmksa_v3_op(ifp, NULL, false);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4207  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4208  	/* TODO: implement PMKID_V2 */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4209  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4210  	memset(&cfg->pmk_list, 0, sizeof(cfg->pmk_list));
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4211  	err = brcmf_update_pmklist(cfg, ifp);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4212  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4213  	brcmf_dbg(TRACE, "Exit\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4214  	return err;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4215  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 25/34] brcmfmac: cfg80211: Add support for PMKID_V3 operations
Date: Mon, 27 Dec 2021 23:01:53 +0800	[thread overview]
Message-ID: <202112272226.cnd1yX00-lkp@intel.com> (raw)
In-Reply-To: <20211226153624.162281-26-marcan@marcan.st>

[-- Attachment #1: Type: text/plain, Size: 25161 bytes --]

Hi Hector,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvalo-wireless-drivers-next/master]
[also build test WARNING on kvalo-wireless-drivers/master rafael-pm/linux-next net-next/master net/master robh/for-next linus/master v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hector-Martin/brcmfmac-Support-Apple-T2-and-M1-platforms/20211226-234246
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arm-randconfig-r023-20211227 (https://download.01.org/0day-ci/archive/20211227/202112272226.cnd1yX00-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 511726c64d3b6cca66f7c54d457d586aa3129f67)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/4077393e01c6f0a14a1ba9afa8d2c56dabd4f1fc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hector-Martin/brcmfmac-Support-Apple-T2-and-M1-platforms/20211226-234246
        git checkout 4077393e01c6f0a14a1ba9afa8d2c56dabd4f1fc
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/net/wireless/broadcom/brcm80211/brcmfmac/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:4195:1: warning: stack frame size (1824) exceeds limit (1024) in 'brcmf_cfg80211_flush_pmksa' [-Wframe-larger-than]
   brcmf_cfg80211_flush_pmksa(struct wiphy *wiphy, struct net_device *ndev)
   ^
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:4054:1: warning: stack frame size (1832) exceeds limit (1024) in 'brcmf_pmksa_v3_op' [-Wframe-larger-than]
   brcmf_pmksa_v3_op(struct brcmf_if *ifp, struct cfg80211_pmksa *pmksa,
   ^
   2 warnings generated.


vim +/brcmf_cfg80211_flush_pmksa +4195 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4052  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4053  static s32
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27 @4054  brcmf_pmksa_v3_op(struct brcmf_if *ifp, struct cfg80211_pmksa *pmksa,
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4055  		  bool alive)
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4056  {
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4057  	struct brcmf_pmk_op_v3_le pmk_op;
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4058  	int length = offsetof(struct brcmf_pmk_op_v3_le, pmk);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4059  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4060  	memset(&pmk_op, 0, sizeof(pmk_op));
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4061  	pmk_op.version = cpu_to_le16(BRCMF_PMKSA_VER_3);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4062  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4063  	if (!pmksa) {
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4064  		/* Flush operation, operate on entire list */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4065  		pmk_op.count = cpu_to_le16(0);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4066  	} else {
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4067  		/* Single PMK operation */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4068  		pmk_op.count = cpu_to_le16(1);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4069  		length += sizeof(struct brcmf_pmksa_v3);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4070  		memcpy(pmk_op.pmk[0].bssid, pmksa->bssid, ETH_ALEN);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4071  		memcpy(pmk_op.pmk[0].pmkid, pmksa->pmkid, WLAN_PMKID_LEN);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4072  		pmk_op.pmk[0].pmkid_len = WLAN_PMKID_LEN;
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4073  		pmk_op.pmk[0].time_left = alive ? BRCMF_PMKSA_NO_EXPIRY : 0;
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4074  	}
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4075  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4076  	pmk_op.length = cpu_to_le16(length);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4077  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4078  	return brcmf_fil_iovar_data_set(ifp, "pmkid_info", &pmk_op, sizeof(pmk_op));
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4079  }
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4080  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4081  static __used s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4082  brcmf_update_pmklist(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4083  {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4084  	struct brcmf_pmk_list_le *pmk_list;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4085  	int i;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4086  	u32 npmk;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4087  	s32 err;
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4088  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4089  	pmk_list = &cfg->pmk_list;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4090  	npmk = le32_to_cpu(pmk_list->npmk);
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4091  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4092  	brcmf_dbg(CONN, "No of elements %d\n", npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4093  	for (i = 0; i < npmk; i++)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4094  		brcmf_dbg(CONN, "PMK[%d]: %pM\n", i, &pmk_list->pmk[i].bssid);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4095  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4096  	err = brcmf_fil_iovar_data_set(ifp, "pmkid_info", pmk_list,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4097  				       sizeof(*pmk_list));
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4098  
48ed16e86b2823 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-02  4099  	return err;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4100  }
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4101  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4102  static s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4103  brcmf_cfg80211_set_pmksa(struct wiphy *wiphy, struct net_device *ndev,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4104  			 struct cfg80211_pmksa *pmksa)
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4105  {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4106  	struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
c1179033228504 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-10-22  4107  	struct brcmf_if *ifp = netdev_priv(ndev);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4108  	struct brcmf_pmksa *pmk = &cfg->pmk_list.pmk[0];
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4109  	struct brcmf_pub *drvr = cfg->pub;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4110  	s32 err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4111  	u32 npmk, i;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4112  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4113  	brcmf_dbg(TRACE, "Enter\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4114  	if (!check_vif_up(ifp->vif))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4115  		return -EIO;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4116  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4117  	brcmf_dbg(CONN, "set_pmksa - PMK bssid: %pM =\n", pmksa->bssid);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4118  	brcmf_dbg(CONN, "%*ph\n", WLAN_PMKID_LEN, pmksa->pmkid);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4119  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4120  	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_PMKID_V3))
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4121  		return brcmf_pmksa_v3_op(ifp, pmksa, true);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4122  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4123  	/* TODO: implement PMKID_V2 */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4124  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4125  	npmk = le32_to_cpu(cfg->pmk_list.npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4126  	for (i = 0; i < npmk; i++)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4127  		if (!memcmp(pmksa->bssid, pmk[i].bssid, ETH_ALEN))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4128  			break;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4129  	if (i < BRCMF_MAXPMKID) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4130  		memcpy(pmk[i].bssid, pmksa->bssid, ETH_ALEN);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4131  		memcpy(pmk[i].pmkid, pmksa->pmkid, WLAN_PMKID_LEN);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4132  		if (i == npmk) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4133  			npmk++;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4134  			cfg->pmk_list.npmk = cpu_to_le32(npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4135  		}
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4136  	} else {
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4137  		bphy_err(drvr, "Too many PMKSA entries cached %d\n", npmk);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4138  		return -EINVAL;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4139  	}
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4140  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4141  	err = brcmf_update_pmklist(cfg, ifp);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4142  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4143  	brcmf_dbg(TRACE, "Exit\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4144  	return err;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4145  }
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4146  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4147  static s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4148  brcmf_cfg80211_del_pmksa(struct wiphy *wiphy, struct net_device *ndev,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4149  			 struct cfg80211_pmksa *pmksa)
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4150  {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4151  	struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4152  	struct brcmf_if *ifp = netdev_priv(ndev);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4153  	struct brcmf_pmksa *pmk = &cfg->pmk_list.pmk[0];
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4154  	struct brcmf_pub *drvr = cfg->pub;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4155  	s32 err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4156  	u32 npmk, i;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4157  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4158  	brcmf_dbg(TRACE, "Enter\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4159  	if (!check_vif_up(ifp->vif))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4160  		return -EIO;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4161  
7703773ef1d85b drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Nicolas Iooss    2016-08-23  4162  	brcmf_dbg(CONN, "del_pmksa - PMK bssid = %pM\n", pmksa->bssid);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4163  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4164  	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_PMKID_V3))
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4165  		return brcmf_pmksa_v3_op(ifp, pmksa, false);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4166  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4167  	/* TODO: implement PMKID_V2 */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4168  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4169  	npmk = le32_to_cpu(cfg->pmk_list.npmk);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4170  	for (i = 0; i < npmk; i++)
7703773ef1d85b drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Nicolas Iooss    2016-08-23  4171  		if (!memcmp(pmksa->bssid, pmk[i].bssid, ETH_ALEN))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4172  			break;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4173  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4174  	if ((npmk > 0) && (i < npmk)) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4175  		for (; i < (npmk - 1); i++) {
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4176  			memcpy(&pmk[i].bssid, &pmk[i + 1].bssid, ETH_ALEN);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4177  			memcpy(&pmk[i].pmkid, &pmk[i + 1].pmkid,
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4178  			       WLAN_PMKID_LEN);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4179  		}
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4180  		memset(&pmk[i], 0, sizeof(*pmk));
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4181  		cfg->pmk_list.npmk = cpu_to_le32(npmk - 1);
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4182  	} else {
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki    2019-02-15  4183  		bphy_err(drvr, "Cache entry not found\n");
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4184  		return -EINVAL;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4185  	}
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4186  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4187  	err = brcmf_update_pmklist(cfg, ifp);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4188  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4189  	brcmf_dbg(TRACE, "Exit\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4190  	return err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4191  
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4192  }
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4193  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4194  static s32
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05 @4195  brcmf_cfg80211_flush_pmksa(struct wiphy *wiphy, struct net_device *ndev)
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4196  {
27a68fe391231b drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-27  4197  	struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4198  	struct brcmf_if *ifp = netdev_priv(ndev);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4199  	s32 err;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4200  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4201  	brcmf_dbg(TRACE, "Enter\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4202  	if (!check_vif_up(ifp->vif))
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4203  		return -EIO;
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4204  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4205  	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_PMKID_V3))
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4206  		return brcmf_pmksa_v3_op(ifp, NULL, false);
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4207  
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4208  	/* TODO: implement PMKID_V2 */
4077393e01c6f0 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hector Martin    2021-12-27  4209  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4210  	memset(&cfg->pmk_list, 0, sizeof(cfg->pmk_list));
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4211  	err = brcmf_update_pmklist(cfg, ifp);
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4212  
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4213  	brcmf_dbg(TRACE, "Exit\n");
5419f7f17d5b70 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Hante Meuleman   2016-01-05  4214  	return err;
e58060723c91a2 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c       Arend van Spriel 2012-09-19  4215  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

  reply	other threads:[~2021-12-27 15:02 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-26 15:35 [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms Hector Martin
2021-12-26 15:35 ` [PATCH 01/34] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Hector Martin
2021-12-26 21:02   ` Linus Walleij
2021-12-26 23:34   ` Rob Herring
2021-12-27 16:36   ` Rob Herring
2021-12-27 17:23     ` Hector Martin
2021-12-29 16:38       ` Mark Kettenis
2022-01-02 14:12         ` Hector Martin
2021-12-29 16:42   ` Mark Kettenis
2022-01-04  5:47     ` Hector Martin
2021-12-26 15:35 ` [PATCH 02/34] brcmfmac: pcie: Declare missing firmware files in pcie.c Hector Martin
2021-12-26 21:04   ` Linus Walleij
2021-12-26 15:35 ` [PATCH 03/34] brcmfmac: firmware: Support having multiple alt paths Hector Martin
2022-01-02  5:31   ` Linus Walleij
2022-01-02  7:10     ` Dmitry Osipenko
2022-01-02  6:38   ` Dmitry Osipenko
2022-01-02  6:45   ` Dmitry Osipenko
2022-01-02 14:18     ` Hector Martin
2022-01-02 20:11       ` Dmitry Osipenko
2022-01-03  0:41         ` Hector Martin
2022-01-03  1:26           ` Dmitry Osipenko
2022-01-03  6:17             ` Hector Martin
2022-01-02  6:55   ` Dmitry Osipenko
2022-01-03  6:18     ` Hector Martin
2022-01-02  7:08   ` Dmitry Osipenko
2022-01-02  7:20     ` Dmitry Osipenko
2022-01-02 14:25     ` Hector Martin
2022-01-02 20:12       ` Dmitry Osipenko
2021-12-26 15:35 ` [PATCH 04/34] brcmfmac: firmware: Handle per-board clm_blob files Hector Martin
2022-01-02  6:21   ` Linus Walleij
2021-12-26 15:35 ` [PATCH 05/34] brcmfmac: pcie/sdio/usb: Get CLM blob via standard firmware mechanism Hector Martin
2022-01-02  6:22   ` Linus Walleij
2021-12-26 15:35 ` [PATCH 06/34] brcmfmac: firmware: Support passing in multiple board_types Hector Martin
2022-01-02  5:34   ` Linus Walleij
2021-12-26 15:35 ` [PATCH 07/34] brcmfmac: pcie: Read Apple OTP information Hector Martin
2022-01-02  5:38   ` Linus Walleij
2022-01-03  5:51     ` Hector Martin
2022-01-03 11:13       ` Linus Walleij
2021-12-26 15:35 ` [PATCH 08/34] brcmfmac: of: Fetch Apple properties Hector Martin
2022-01-02  5:40   ` Linus Walleij
2021-12-26 15:35 ` [PATCH 09/34] brcmfmac: pcie: Perform firmware selection for Apple platforms Hector Martin
2022-01-02  5:44   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 10/34] brcmfmac: firmware: Allow platform to override macaddr Hector Martin
2022-01-02  5:50   ` Linus Walleij
2022-01-03  5:42     ` Hector Martin
2021-12-26 15:36 ` [PATCH 11/34] brcmfmac: msgbuf: Increase RX ring sizes to 1024 Hector Martin
2022-01-02  5:50   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 12/34] brcmfmac: pcie: Fix crashes due to early IRQs Hector Martin
2022-01-02  5:51   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 13/34] brcmfmac: pcie: Support PCIe core revisions >= 64 Hector Martin
2022-01-02  5:53   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 14/34] brcmfmac: pcie: Add IDs/properties for BCM4378 Hector Martin
2022-01-02  5:53   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 15/34] ACPI / property: Support strings in Apple _DSM props Hector Martin
2021-12-26 18:20   ` Lukas Wunner
2022-01-02  6:20   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 16/34] brcmfmac: acpi: Add support for fetching Apple ACPI properties Hector Martin
2022-01-02  5:58   ` Linus Walleij
2022-01-03  6:03     ` Hector Martin
2022-01-03 11:14       ` Linus Walleij
     [not found]   ` <CAHp75VcZcJ+zCDL-J+w8gEeKXGYdJajjLoa1JTj_kkJixrV12Q@mail.gmail.com>
2022-01-03 17:22     ` Hector Martin
     [not found]       ` <CAHp75Vedgs_zTH2O120jtUuQiuseA0VN62TJiJ7kAi1f5nDQ6Q@mail.gmail.com>
2022-01-04  5:22         ` Hector Martin
2022-01-10  9:59     ` Kalle Valo
2021-12-26 15:36 ` [PATCH 17/34] brcmfmac: pcie: Provide a buffer of random bytes to the device Hector Martin
2022-01-02  5:59   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 18/34] brcmfmac: pcie: Add IDs/properties for BCM4355 Hector Martin
2022-01-02  6:00   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 19/34] brcmfmac: pcie: Add IDs/properties for BCM4377 Hector Martin
2022-01-02  6:01   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 20/34] brcmfmac: pcie: Perform correct BCM4364 firmware selection Hector Martin
2022-01-02  6:02   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 21/34] brcmfmac: chip: Only disable D11 cores; handle an arbitrary number Hector Martin
2022-01-02  6:03   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 22/34] brcmfmac: chip: Handle 1024-unit sizes for TCM blocks Hector Martin
2022-01-02  6:09   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 23/34] brcmfmac: cfg80211: Add support for scan params v2 Hector Martin
2022-01-02  6:23   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 24/34] brcmfmac: feature: Add support for setting feats based on WLC version Hector Martin
2022-01-02  6:11   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 25/34] brcmfmac: cfg80211: Add support for PMKID_V3 operations Hector Martin
2021-12-27 15:01   ` kernel test robot [this message]
2021-12-27 15:01     ` kernel test robot
2022-01-02  6:12   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 26/34] brcmfmac: cfg80211: Pass the PMK in binary instead of hex Hector Martin
2022-01-02  6:13   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 27/34] brcmfmac: pcie: Add IDs/properties for BCM4387 Hector Martin
2022-01-02  6:13   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 28/34] brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio Hector Martin
2022-01-02  6:15   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 29/34] brcmfmac: pcie: Read the console on init and shutdown Hector Martin
2022-01-02  6:16   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 30/34] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path Hector Martin
2022-01-02  6:16   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 31/34] brcmfmac: fwil: Constify iovar name arguments Hector Martin
2022-01-02  6:17   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 32/34] brcmfmac: common: Add support for downloading TxCap blobs Hector Martin
2022-01-02  6:18   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 33/34] brcmfmac: pcie: Load and provide " Hector Martin
2022-01-02  6:19   ` Linus Walleij
2021-12-26 15:36 ` [PATCH 34/34] brcmfmac: common: Add support for external calibration blobs Hector Martin
2022-01-02  6:19   ` Linus Walleij
2021-12-26 19:17 ` [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms Lukas Wunner
2021-12-26 21:42   ` Hans de Goede
2021-12-27 11:53     ` Hector Martin
2022-01-02  6:25 ` Linus Walleij
2022-01-03  6:27   ` Hector Martin
2022-01-03 10:20     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202112272226.cnd1yX00-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=llvm@lists.linux.dev \
    --cc=marcan@marcan.st \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.