All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: conleylee@foxmail.com
Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] sun4i-emac.c: add dma support
Date: Tue, 28 Dec 2021 16:48:17 -0800	[thread overview]
Message-ID: <20211228164817.1297c1c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <tencent_A7052D6C7B1E2AEFA505D7A52E5B974D8508@qq.com>

On Tue, 28 Dec 2021 19:42:04 +0800 conleylee@foxmail.com wrote:
> +static void free_emac_dma_req(struct emac_dma_req *req)

emac_free_dma_req

> +prepare_err:
> +	dma_unmap_single(db->dev, rxbuf, count, DMA_FROM_DEVICE);
> +    return ret;

incorrect whitespace here

> @@ -599,12 +721,25 @@ static void emac_rx(struct net_device *dev)
>  			if (!skb)
>  				continue;
>  			skb_reserve(skb, 2);
> -			rdptr = skb_put(skb, rxlen - 4);
>  
>  			/* Read received packet from RX SRAM */
>  			if (netif_msg_rx_status(db))
>  				dev_dbg(db->dev, "RxLen %x\n", rxlen);
>  
> +			rdptr = skb_put(skb, rxlen - 4);

no reason to move this line

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: conleylee@foxmail.com
Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] sun4i-emac.c: add dma support
Date: Tue, 28 Dec 2021 16:48:17 -0800	[thread overview]
Message-ID: <20211228164817.1297c1c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <tencent_A7052D6C7B1E2AEFA505D7A52E5B974D8508@qq.com>

On Tue, 28 Dec 2021 19:42:04 +0800 conleylee@foxmail.com wrote:
> +static void free_emac_dma_req(struct emac_dma_req *req)

emac_free_dma_req

> +prepare_err:
> +	dma_unmap_single(db->dev, rxbuf, count, DMA_FROM_DEVICE);
> +    return ret;

incorrect whitespace here

> @@ -599,12 +721,25 @@ static void emac_rx(struct net_device *dev)
>  			if (!skb)
>  				continue;
>  			skb_reserve(skb, 2);
> -			rdptr = skb_put(skb, rxlen - 4);
>  
>  			/* Read received packet from RX SRAM */
>  			if (netif_msg_rx_status(db))
>  				dev_dbg(db->dev, "RxLen %x\n", rxlen);
>  
> +			rdptr = skb_put(skb, rxlen - 4);

no reason to move this line

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-29  0:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-24 14:44 [PATCH v4] sun4i-emac.c: add dma support conleylee
2021-12-28  2:35 ` Jakub Kicinski
2021-12-28 11:42 ` [PATCH v5] " conleylee
2021-12-29  0:48   ` Jakub Kicinski [this message]
2021-12-29  0:48     ` Jakub Kicinski
2021-12-29  1:43     ` [PATCH v6] " conleylee
2021-12-29  1:43       ` conleylee
2021-12-30  2:00       ` patchwork-bot+netdevbpf
2021-12-30  2:00         ` patchwork-bot+netdevbpf
2022-05-30  4:51         ` Corentin Labbe
2022-05-30  4:51           ` Corentin Labbe
2022-05-30 18:48           ` Jakub Kicinski
2022-05-30 18:48             ` Jakub Kicinski
2022-05-30 18:55             ` Corentin Labbe
2022-05-30 18:55               ` Corentin Labbe
2021-12-31 10:43       ` Corentin Labbe
2021-12-31 10:43         ` Corentin Labbe
     [not found]         ` <tencent_57960DDC83F43DA3E0A2F47DEBAD69A4A005@qq.com>
2022-01-02 17:38           ` Corentin Labbe
2022-01-02 17:38             ` Corentin Labbe
     [not found]             ` <tencent_67023336008FE777A58293D2D32DEFA69107@qq.com>
2022-01-03 11:42               ` Corentin Labbe
2022-01-03 11:42                 ` Corentin Labbe
2022-01-03 12:21                 ` Conley Lee
2022-01-03 12:21                   ` Conley Lee
2022-01-09  9:17                 ` [PATCH v1] sun4i-emac.c: enable emac tx dma conleylee
2022-01-09  9:17                   ` conleylee
2022-01-09 20:45                   ` Corentin Labbe
2022-01-09 20:45                     ` Corentin Labbe
2022-01-10  7:47                     ` Conley Lee
2022-01-10  7:47                       ` Conley Lee
2022-01-07 23:34       ` [PATCH v6] sun4i-emac.c: add dma support Kees Cook
2022-01-07 23:34         ` Kees Cook
2022-01-08  2:34         ` Jakub Kicinski
2022-01-08  2:34           ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211228164817.1297c1c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
    --to=kuba@kernel.org \
    --cc=conleylee@foxmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.